Activity
From 09/21/2021 to 10/20/2021
10/20/2021
- 04:46 PM bug #9819 (Resolved): Rename "Nameeditor" to "Taxon Editor" in menus
- Searched for all "Namenseditor" and "name editor" strings and replaced it by "taxon editor"/"Taxon Editor"
- 04:44 PM Revision 25302047 (taxeditor): ref #9819: rename name editor to taxon editor in menues
- 04:40 PM bug #9817: AggregationWizard: Changing the maxRank results in empty minRank
- This should be fixed, please review.
- 04:30 PM bug #9817 (Resolved): AggregationWizard: Changing the maxRank results in empty minRank
- Applied in changeset commit:taxeditor|9f84c59541baaae91592b1870fd11d5c802d68a8.
- 04:29 PM Revision 9f84c595 (taxeditor): fix #9817: remember selected rank when update rank combo
- 03:28 PM bug #9821 (Resolved): Description sources shown for description elements should not be editable
- This should be fixed. Please review.
- 12:49 PM bug #9821 (Closed): Description sources shown for description elements should not be editable
- Since #7774 sources for descriptions are shown in the details view for description elements.
However, they should no... - 03:09 PM Revision 4351685c (taxeditor): ref #9821: sources of description should not be editable
- 01:18 PM feature request #9771: Implement Cdm2Cdm for vocabularies
- Note: in TaxEditor there is a first version for handling a second CdmServer at CdmServerInfo.getDevServerRemoteSource()
- 01:11 PM task #9822 (New): Improve performance for DDS aggregation
- e.g. by faster loading of data and by not reloading the full dataset after aggregation (there might be a ticket for t...
- 11:32 AM bug #9811 (Resolved): regression through removal of `TaxonRelationshipBeanProcessor` ?
- solved, see http://test.e-taxonomy.eu/dataportal/preview/euromed/cdm_dataportal/search/results/taxon?ws=portal%2Ftaxo...
- 11:22 AM Revision cb2b26b5 (cdm-dataportal): ref #9811 switching in search results to portal/taxon/{uuid}/taxonRelationshipsDTO and adapting code
- 11:21 AM Revision 3d73cbc2 (cdmlib): ref #9811 adding classification uuids to TaxonRelationshipsDTO
- 11:21 AM Revision fd07b3aa (cdmlib): avoiding NPEs in loadTreeBranch methods
10/19/2021
- 03:23 PM bug #9818 (Resolved): Sources not visible for disabled DescriptionElements
- This should be fixed.
- 03:21 PM bug #9814: Advanced search webservice for area throws NPE (mexico portal)
- I checked advance search on test servers and it works again: http://test.e-taxonomy.eu/dataportal/preview/euromed/cdm...
- 03:19 PM bug #9806 (In Progress): Clones should not be editable in factual data view and elsewhere
- Now cloned descriptions are disabled like computed descriptions.
- 03:18 PM Revision b9b4a1ec (taxeditor): ref #9806: disable cloned descriptions
- 02:58 PM Revision 22466e2e (taxeditor): ref #9818: avoid NPE
- 02:49 PM bug #9281 (Resolved): Set basionym not available for heterotypic synonyms after drag & drop
- This should be fixed, please review.
- 02:47 PM Revision eba0b772 (taxeditor): ref #9281: setBasionym should be available after d&d - continue
- 02:34 PM Revision 342be9a6 (taxeditor): ref #9281: setBasionym should be available after d&d
- 02:04 PM Revision 5af7ab6e (taxeditor): ref #9818: keep collapsable elements expandable when details are disabled
- 11:18 AM bug #9820 (New): OptionalDataException when saving character matrix
- After moving all used elements to Dtos the character matrix still needs a lot of time to start and sometimes an optio...
- 10:39 AM bug #8783: Massive Heap consumption in server instance opening the Description-Matrix editor
- Katja Luther wrote:
> Actually maybe this was the wrong ticket because the exception coming up again was not an OutO...
10/18/2021
- 06:39 PM Revision 22c38d41 (taxeditor): cleanup (cont.)
- 06:21 PM Revision 611fddf9 (taxeditor): cleanup
- 05:09 PM bug #8936: Improve default distribution formatting
- there was a problem with the release in the master branch, some commits have been lost. this is fixed and it is now t...
- 04:37 PM Revision 73bd997a (cdm-dataportal): Merge tag '5.27.1' into develop
- tagging hotfix
- 04:37 PM Revision e3b0407b (cdm-dataportal): Merge branch 'hotfix/5.27.1'
- 04:37 PM Revision ec495134 (cdm-dataportal): fix #9808 option to disable ssl cert validation
- 04:18 PM Revision 32ae53fa (cdmlib): cleanup
- 03:59 PM bug #9814: Advanced search webservice for area throws NPE (mexico portal)
- this method is only used in the TaxEditor:
~~~
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor... - 02:09 PM bug #9814 (Feedback): Advanced search webservice for area throws NPE (mexico portal)
- I fixed the NPE so it does not throw an exception anymore. However, we need to discuss how the TermDTO should behave....
- 12:02 PM bug #9814: Advanced search webservice for area throws NPE (mexico portal)
- This is strange, the actual method getVocRepresentation_L10n_abbreviatedLabel() is never called in cdmlib so I don't ...
- 11:58 AM bug #9814 (Closed): Advanced search webservice for area throws NPE (mexico portal)
- ... Die Area-Terme in der Suche fehlen gerade komplett, das der Webservice nichts zurückliefert: https://132.248.13.8...
- 03:07 PM bug #9819 (Closed): Rename "Nameeditor" to "Taxon Editor" in menus
- follow up for #9744
Currently the "open in" context menu still uses Nameeditor.
Please also check for other occ... - 02:23 PM bug #9818 (Closed): Sources not visible for disabled DescriptionElements
- The sources of disabled description elements are not expandable but should.
- 02:09 PM Revision a4eb66ae (cdmlib): ref #9798 add also Spanish translation for country (label of vocabulary)
- 02:06 PM Revision 19252634 (cdmlib): cleanup
- 02:06 PM Revision d4542f66 (cdmlib): ref #9814 fix NPE in TermDto.getVocRepresentation_L10n (+..._abbreviatedLabel)
- 02:02 PM bug #8783 (Closed): Massive Heap consumption in server instance opening the Description-Matrix editor
- Actually maybe this was the wrong ticket because the exception coming up again was not an OutOfMemoryException but an...
- 01:51 PM bug #8783 (Feedback): Massive Heap consumption in server instance opening the Description-Matrix editor
- Was comment 16 ("changed from Closed to In Progress") a mistake, it completely misses any explanation?
I am assumin... - 12:54 PM bug #8783: Massive Heap consumption in server instance opening the Description-Matrix editor
- If we reopen then we should adapt the milestone. But maybe it is better to keep this closed and create a new ticket a...
- 12:44 PM bug #8783 (In Progress): Massive Heap consumption in server instance opening the Description-Matrix editor
- 01:37 PM bug #9817: AggregationWizard: Changing the maxRank results in empty minRank
- This is a regression therefore setting to 5.28
- 01:12 PM bug #9817 (Closed): AggregationWizard: Changing the maxRank results in empty minRank
- mail AM:
wenn ich den max-Rank beim DDS Aggregationsdialog ändere wird immer der min-Rang auch gelöscht. Auch in F... - 01:10 PM bug #9816 (Closed): Implement correct handling of more than one element for a character
- Implement correct handling in the character matrix, if two or more elements exist for one character. If one of the el...
- 12:35 PM bug #9815 (Closed): When removing all elements of a description, the description disappears from factual data view, but still exist
- mail AM:
wenn ich mehrere Descriptions in eine merge im Facts View und somit eine volle und eine komplett leere üb... - 11:18 AM bug #398 (Worksforme): DIPTERA: Typestatus entered as Notes for NameTypes
- Ich glaube dieses Ticket können wir schließen.
Keinerlei Hinweise darauf, was gemacht wurde, daher WORKSFORME - 10:38 AM bug #9813 (New): Details view should be available for literature (and default) descriptions in character matrix
- this is a subticket #9799 but with highest priority as adding sources to literature descriptions is essential functi...
10/15/2021
- 07:27 PM feature request #6387 (Closed): [Rule] Rank rule for CultivarPlantNames
- Added a level 2 rule that checks if cultivar (ICNCP) names have a cultivar rank.
Of course there could be much mor... - 07:25 PM Revision 64254a55 (cdmlib): ref 6387 add some first rules for rank<->code test (cont.)
- 07:10 PM Revision a01d2bd1 (cdmlib): ref 6387 add some first rules for rank<->code test
- 07:06 PM Revision 7828c44e (cdmlib): cleanup
- 05:55 PM bug #9785 (In Progress): Update script for missing measurment unit_ids (matrix)
- The above update should run with error recovery to avoid a break in update if the SQL fails (especially for non-MySQL)
- 05:53 PM bug #9785: Update script for missing measurment unit_ids (matrix)
- Some search SQL:
~~~sql
SELECT deb.id, fe.id, fe.titleCache -- , COUNT(*) AS n
FROM DescriptionElementBase deb... - 05:52 PM bug #9785: Update script for missing measurment unit_ids (matrix)
- An Update for MySQL:
~~~
UPDATE DescriptionElementBase deb LEFT OUTER JOIN DefinedTermBase fe ON fe.id = deb.feat... - 04:14 PM bug #9477 (Closed): New ordered terms do not have correct order index
- 04:10 PM feature request #8979 (Closed): Prevent misuse of field initial for personal names
- 12:05 PM feature request #8979: Prevent misuse of field initial for personal names
- In Vaadin perfectly implemented there 100%, but did not check the TaxEditor if it is there relevant.
- 04:09 PM task #9308 (Closed): Supress "designated by" reference in portal in registration ListView and RegistrationWorkingSetEditor
- 11:33 AM task #9308: Supress "designated by" reference in portal in registration ListView and RegistrationWorkingSetEditor
- Task is perfectly implemented, ticket can be closed.
- 04:06 PM bug #8936: Improve default distribution formatting
- It looks item suffix is currently not yet handled correctly in Drupal Code.
Example from mexico flora: https://13... - 12:17 PM bug #9812 (Closed): Display of scientific name in the list-view of Vaadin
- As of 15 Oct 2021 scientific names (Vaadin release system) are displayed mainly without blanks between genus, species...
- 11:59 AM feature request #7640 (Closed): Update ISO country names where necessary
- 11:49 AM feature request #7640: Update ISO country names where necessary
- I am happy with the implementation, short names and it is clear which country is meant. Tested it in Vaadin, release ...
10/13/2021
- 03:22 PM bug #9797 (Closed): LazyInitializationException (LIE) on portal/taxon/{uuid} with misapplied names
- new ticket for the open issue #9811
- 03:22 PM bug #9811 (Closed): regression through removal of `TaxonRelationshipBeanProcessor` ?
- It seems as if the removal of the `TaxonRelationshipBeanProcessor` has caused this new problem
: Fix BigDecimal algebra in aggregation algorithms
- Moved polytomous key handling to new ticket #9810
- 05:35 PM task #9810 (New): Test if BigDecimal algebra is correct in PolytomousKey algorithms
- copied from #9123 and #8978
Aggregation is checked and fixed in the meanwhile (#9123) - 05:31 PM feature request #9798 (Closed): Import Spanish representations for countries
- 04:02 PM bug #9797: LazyInitializationException (LIE) on portal/taxon/{uuid} with misapplied names
- It seems as if the removal of the `TaxonRelationshipBeanProcessor` has caused this new problem
 on portal/taxon/{uuid} with misapplied names
- There are still problems with loading MAN, e.g. https://europlusmed.org/cdm_dataportal/search/results/taxon?ws=portal...
- 02:52 PM Revision 29d0b0f6 (cdmlib-apps): some upgrade for BgbmInstancesUpdater
- 02:37 PM bug #9808 (Closed): option to disable ssl/tsl certificate validation of the cdm webserver
- 02:30 PM bug #9808 (Resolved): option to disable ssl/tsl certificate validation of the cdm webserver
- Applied in changeset commit:cdm-dataportal|91313ab4c0d34ddd9d9c745e268b16c4eefe234b.
- 02:29 PM bug #9808 (Closed): option to disable ssl/tsl certificate validation of the cdm webserver
- in situations when a self signed certificate is being used with the cdmserver it is needed to disable certificate val...
- 02:37 PM feature request #9786 (Closed): Implement tags CY and fix PY handling for RIS import
- This should work as tests exist. If there are open issues we should add them to #9809
- 02:35 PM feature request #6636: First version of RIS reference import (e.g. for Endnote import)
- Generally this works. However, there are a couple of open issues handled in #9809.
- 02:34 PM feature request #9809: Implement further tags for RIS reference import
- NaK:
Nur bei Book Chapters funktioniert der Import nur teilweise, dafür muss man ja das Buch separat anlegen und d... - 02:31 PM feature request #9809 (New): Implement further tags for RIS reference import
- in #6636 and #9786 the most important tags for RIS import have been implemented. However, there are a couple of more ...
- 02:31 PM Revision 17ed1083 (cdm-dataportal): Merge tag '5.27.1' into develop
- tagging hfx release
- 02:31 PM Revision 827c80d5 (cdm-dataportal): Merge branch 'hotfix/5.27.1'
- 02:31 PM Revision 2415b2e3 (cdm-dataportal): fix #9808 option to disable ssl cert validation
- 02:30 PM Revision 91313ab4 (cdm-dataportal): fix #9808 option to disable ssl cert validation
- 10:27 AM Revision 6b34400c (cdmlib): minor and cleanup
10/11/2021
- 09:55 PM feature request #6818: Default Image Viewer: setting to enable display of 'Media Representations'
- According to commit this was fixed in 4.9
- 09:49 PM bug #7979: Registration date and time, display
- Can we adapt milestone or remove it?
- 09:46 PM bug #4721 (Feedback): RestServices for list methods return error when index is out of range
- Is this still an open issue? The above link seems to return a correct empty list now.
- 09:10 PM bug #3635: Protologue media should also be displayed when mime type is missing
- is this still an open issue?
- 09:08 PM bug #3511: errors are not cleared after reloading the configuration
- is this still an open issue?
- 08:52 PM bug #2592 (Worksforme): InvalidDataAccessApiUsageException when saving description scope
- I could save a scope for a description now so I guess this issue is solved in the meanwhile.
- 08:15 PM bug #5484 (Worksforme): Connecting to local H2 via local Mgd throws NPE in CdmServiceCacher
- I cannot reproduce therefore close as worksforme
- 08:14 PM bug #5485 (Duplicate): h2 database connection fails if datasource view is open
- This is either fixed already or will be fixed once #9742 is fixed. I tested with a workaround using AUTO_SERVER=TRUE
- 08:01 PM feature request #9771 (In Progress): Implement Cdm2Cdm for vocabularies
- 05:05 PM bug #9807: Matrix should not collapse after aggregation
- AM 2021-10-1:
... Wir müssten also entweder doch herausfinden, woran es liegt, dass diese zusätzlichen Knoten ents... - 04:57 PM bug #9807 (Closed): Matrix should not collapse after aggregation
- As the refresh after aggregation lead to row duplications (of taxa and maybe others) it was temporarily implemented i...
- 04:37 PM feature request #8706 (Closed): taxeditor error report with timestamps
- I guess we can close this ticket. Timestamping generally works. Open new ticket if there are open issues left.
- 04:34 PM feature request #8467 (Closed): Save a "snapshot" of the SpecimenDescriptions used for aggregation
- This for me seems to be fixed. Open issue on visibility of clones moved to new ticket #9806
- 04:32 PM bug #9806: Clones should not be editable in factual data view and elsewhere
- AM: (2021-10-7)
Descriptions Clones, die an Specimens oder auch Taxa hängen sind derzeit noch normal bearbeitbar.
... - 04:31 PM bug #9806 (Closed): Clones should not be editable in factual data view and elsewhere
- copied from #8467:
Currently only aggregated data are not editable (depending on configuration). Also cloned data ... - 04:04 PM feature request #7981 (Closed): Add configuration UI for matrix description aggregation
- I created a ticket for old and new open issues: #9805
- 04:03 PM feature request #9805 (New): Open issues for DDS aggregation dialogue
- copied from #7981
- ~~aggregating full dataset does not work~~ (#9803)
- ~~matrix should not collapse after aggre... - 03:30 PM feature request #7980 (Closed): Enhance matrix description aggregation
- 03:27 PM feature request #7980: Enhance matrix description aggregation
- open issues moved to #9804
- 03:27 PM feature request #9804 (New): Further enhance description aggregation
- copied from #7980
- consider default values during aggregation
- deal with outliers etc.
- improve error and ... - 02:37 PM Revision 4fdc7952 (cdm-server): Merge branch 'release/5.27.0' into develop
- 02:37 PM Revision ee86969f (cdm-server): jenkins merging release branch into master (strategy: theirs)
- 02:36 PM Revision 0be21ca1 (cdm-server): updating poms for branch'release/5.27.0' with non-snapshot versions
- 02:36 PM Revision cc117ebd (cdm-webapp): Merge branch 'release/5.27.0' into develop
- 02:36 PM Revision 4611dabe (cdm-webapp): jenkins merging release branch into master (strategy: theirs)
- 02:35 PM Revision 1c9fea82 (cdm-webapp): updating poms for branch'release/5.27.0' with non-snapshot versions
- 02:35 PM Revision 2971458c (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.27.0
- 02:33 PM feature request #9795 (Closed): Add literature descriptions to matrix aggregation
- 02:32 PM bug #9803: Aggregating full dataset does not work
- Related to this I found that there is redundancy in the code. This lead to a failing fix for the rank handling as it ...
- 12:53 PM bug #9803 (Closed): Aggregating full dataset does not work
- Choosing "Aggregate all taxa of the descriptive datase" currently does not work.
This is because the dataset varia... - 02:10 PM Revision 17e0ac1e (cdm-vaadin): jenkins merging release branch into master (strategy: theirs)
- 02:09 PM Revision 7bd11533 (taxeditor): Merge branch 'release/5.27.0' into develop
- 02:09 PM Revision c89621ab (taxeditor): Merge branch 'release/5.27.0'
- 02:07 PM Revision 9a47de32 (cdm-dataportal): Merge branch 'release/5.27.0' into develop
- 02:07 PM Revision 1032dd43 (cdm-dataportal): updating poms for branch'release/5.27.0' with non-snapshot versions
- 02:06 PM Revision 0780d58d (cdm-vaadin): updating poms for branch'release/5.27.0' with non-snapshot versions
- 02:06 PM Revision 44c4fa25 (cdm-dataportal): release-preparation: production level css
- 02:06 PM Revision e8da55e7 (cdm-vaadin): jenkins bumping cdmlib.version to 5.27.0
- 02:06 PM Revision 0e3b1877 (cdmlib): Updating develop poms back to pre merge state
- 02:06 PM Revision 295c852f (cdmlib): Merge branch 'master' into develop
- 02:06 PM Revision afb06063 (cdmlib): updating develop poms to master versions to avoid merge conflicts
- 02:06 PM Revision dab26056 (cdmlib): Merge branch 'release/5.27.0'
- 01:47 PM Revision 51bd4576 (cdmlib): updating poms for branch'release/5.27.0' with non-snapshot versions
- 01:41 PM Revision 575a6bd5 (cdmlib-apps): ref #9778 adapt redlist import to new existing ranks lusus and subproles
- 01:40 PM Revision dab55660 (cdmlib-apps): ref #9780 fix grex handling in some scripts
- 01:38 PM Revision ae1ae34c (cdmlib-apps): remove JvmLimitsException handling form EuroMedDistributionAggregationActivator
- 01:03 PM Revision 48009893 (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.27.0-SNAPSHOT
- 01:03 PM Revision a95975ed (cdm-webapp): updating poms for 5.28.0-SNAPSHOT development
- 01:03 PM Revision 9af719d8 (cdm-webapp): updating poms for 5.27.0 branch with snapshot versions
- 01:03 PM Revision 01d670ed (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.28.0-SNAPSHOT
- 01:01 PM Revision 70a62925 (cdm-vaadin): jenkins bumping cdmlib.version to 5.27.0-SNAPSHOT
- 01:01 PM Revision 7cf401e1 (taxeditor): Updated version in pom / project files to taxeditor version : 5.28.0-SNAPSHOT and cdmlib version : 5.28.0-SNAPSHOT
- 01:01 PM Revision 47020ac1 (cdm-vaadin): updating poms for 5.28.0-SNAPSHOT development
- 01:01 PM Revision 104bacb0 (cdm-vaadin): updating poms for 5.27.0 branch with snapshot versions
- 01:01 PM Revision 2be1f4fa (taxeditor): Updated version in pom / project files to taxeditor version : 5.27.0 and cdmlib version : 5.27.0
- 01:01 PM Revision 09f6d172 (cdm-vaadin): jenkins bumping cdmlib.version to 5.28.0-SNAPSHOT
- 01:01 PM Revision 9bc9587a (cdm-server): updating poms for 5.28.0-SNAPSHOT development
- 01:00 PM Revision f2fca10a (cdm-dataportal): updating poms for 5.28.0-SNAPSHOT development
- 12:57 PM Revision 206c20c1 (cdmlib): updating poms for 5.28.0-SNAPSHOT development
- 12:55 PM Revision bbcd0abb (taxeditor): ref #9803 better handling of redundant minMaxRank and geoFilter handling in aggregation wizard
- 11:24 AM bug #9802 (New): Label for min=max does not unify values in Matrix QuantitativeData label provider
- e.g. I get [987-987] instead.
Also the unit is missing.
In general we should try to unify the matrix label with...
10/08/2021
- 09:43 PM Revision f717518e (cdmlib): remove deprecated method
- 09:39 PM Revision 3c420001 (cdmlib): ref #9801, ref #7980, ref #8871 remove aggregated source descriptions from aggregation and fix persistence issues
- 09:18 PM bug #9801 (New): Orphan removal does not work correctly for CdmLinkSource
- as part of OriginalSourceBase. As it is 1:1 the mapping should be done the other way round to make orphan removal wor...
- 05:57 PM Revision c50ece59 (cdmlib): cleanup
- 04:05 PM Revision 1ac9cae7 (taxeditor): ref #7981: avoid NPE
- 03:56 PM Revision a9b7ea5d (cdmlib): ref #9772 add deproxy to collector title computation
- 01:40 PM Revision 80bbeb1b (cdmlib): change line number for debugging
- 01:31 PM Revision 541ae6bc (cdmlib): ref #7980 fix concurrent modification exception
- 01:15 PM Revision e7e11b99 (taxeditor): set default for unpublished taxa to true
- 01:06 PM Revision f11b2271 (taxeditor): set default sel in wizard to values in configurator
- 01:04 PM Revision 843fbe64 (cdmlib): cleanup
- 01:04 PM Revision 7fee6b88 (cdmlib): ref #7980 fix NoSuchElement exception (cont.)
- 11:48 AM Revision 2374e385 (taxeditor): ref #7981: select configuration default values
- 11:07 AM Revision 4ca90889 (cdmlib): ref #9772: adapt collectorstring, use collectorTitleCache
- 10:42 AM Revision 305b0475 (taxeditor): statistical value details view should be disabled for computed desc
- 10:30 AM Revision ef1a6397 (cdmlib): ref #7980 fix NoSuchElement exception
- 12:02 AM Revision edfed83c (taxeditor): cleanup
10/07/2021
- 11:57 PM Revision c978affc (taxeditor): cleanup
- 11:45 PM Revision a1417825 (taxeditor): cleanup
- 10:18 PM Revision 3194d52a (cdmlib): update Datasource script
- 08:44 PM Revision c0228744 (taxeditor): ref #7981 adapt label for aggregated taxa/subtrees
- 07:42 PM Revision 1a96d01d (cdmlib): ref #7980, ref #8871 improve error handling and verification in aggregations
- 06:32 PM Revision 293b1494 (cdmlib): cleanup, javadoc and minor
- 06:31 PM Revision bdd1b0c7 (cdmlib): ref #7980 fix aggregation for titleCache of reused descriptions
- 06:29 PM Revision 6ce5c551 (cdmlib): ref #7980 fix aggregation for measurement units (still open are not equal units)
- 06:26 PM Revision 74ccd9f4 (cdmlib): adapt dummy measurement unit to meter in test dataset
- 05:18 PM Revision cdcad85a (taxeditor): ref #7981: read aggSourceMode from configurator in aggregation wizard (cont. II)
- 04:20 PM Revision 6b6b71cf (cdmlib): ref #7980 fix tests for aggregation source mode
- 03:58 PM Revision 469b4d69 (taxeditor): ref #7981: read aggSourceMode from configurator in aggregation wizard (cont.)
- 03:56 PM Revision f677247f (cdmlib): ref #7981, ref #7980, ref #8871 explicitly defined source modes for aggregation configurators
- 03:55 PM Revision d98a1622 (cdmlib): javadoc
- 03:25 PM Revision a76ae357 (taxeditor): ref #7981: read aggSourceMode from configurator in aggregation wizard
- 03:24 PM Revision 583471b3 (taxeditor): cleanup
- 01:07 PM Revision b7ad4bb2 (cdmlib): some renaming
- 01:02 PM Revision 6163ee20 (cdmlib): ref #8871, ref #7980 handle aggregation source mode TAXON for toParent
- 11:04 AM Revision 82b18118 (cdmlib): ref #8871, ref #7980 handle aggregation source modes for SDD aggregation
- 10:26 AM Revision 472080b4 (taxeditor): ref #9772: fix doubled menu items
- 10:04 AM Revision 7e1619ea (cdmlib): ref #8871, ref #7980 adapt available source modes for DDS aggregation
- 09:47 AM Revision 67c1a4e3 (taxeditor): sort taxon nodes in taxon filter of DDS editor
- 02:10 AM Revision a4001175 (cdmlib): ref #8871 try to fix failing aggregation tests (cont.)
- 01:50 AM feature request #9795 (Resolved): Add literature descriptions to matrix aggregation
- this is probably fully resolved
- 01:49 AM task #8871 (In Progress): Remaining issues to unify description aggregation methods
- 01:47 AM Revision bfbf1c9c (cdmlib): cleanup
- 01:46 AM Revision 67c26aa8 (cdmlib): ref #8871 try to fix failing aggregation tests
- 01:40 AM Revision 4b70788c (cdmlib): ref #8871, ref #9331 fix DescriptionElementSource.clone , e.g. for DistributionAggregation
- 01:33 AM Revision f600798d (cdmlib): cleanup
10/06/2021
- 10:13 PM Revision 98623528 (cdmlib): cleanup and minor
- 06:28 PM Revision 5f20c74a (cdmlib): ref #7980 delete not needed descriptions after aggregation
- 06:25 PM Revision 569f15d4 (cdmlib): fix problem with strange DefinedTermBase_InverseRepresentation_AUD1 metadata
- 06:24 PM Revision 0e0fe1fb (cdmlib): cleanup and minor
- 06:21 PM Revision fe503ae0 (cdmlib): remove handling for not thrown exception JvmLimitsExceed
- 02:58 PM Revision 505cd4db (taxeditor): show all description elements in factual data view of taxa
- 02:31 PM Revision ac67f386 (cdmlib): ref #7980 minor changes to aggregation tests
- 02:31 PM Revision 37cdc012 (cdmlib): ref #7980 reduce minFreeHeap for aggregation (cont.)
- 02:30 PM Revision c1c6c66e (cdmlib): cleanup
- 02:16 PM Revision 4296d7cb (cdmlib): ref #7980 reduce minFreeHeap for aggregation
- 01:40 PM Revision 120c4ab8 (taxeditor): default for availableForTaxa and availableForSpecimen set to true
- 01:34 PM Revision c549e4d6 (taxeditor): add available for parts to character details
- 12:08 PM Revision e8edefb2 (cdmlib): cleanup
- 12:08 PM Revision 5d1ef7fc (cdmlib): ref #9510 adapt specimens holding description label (cont. II)
- 11:31 AM bug #9510 (In Progress): Improve label for descriptions created via DDS matrix
- 11:29 AM Revision 7f25cd4e (cdmlib): ref #9510 adapt specimens holding description label (cont.)
- 11:28 AM Revision 24190230 (cdmlib): cleanup
- 11:26 AM feature request #9511 (Resolved): Move specimens/individual associations for matrix into same description
- This seems to be fixed in the meanwhile. Can you please double check and if true close the ticket?
If you find the... - 11:06 AM Revision a5c8139e (cdmlib): cleanup and explicit title for IndividualsAssociation taxon descriptions
- 10:30 AM Revision a1a25627 (cdmlib): minor
- 09:26 AM bug #6523: Correct display of misspellings in synonymy
- another example case from the carypophyllales portal:
----
ich habe eben gesehen, dass die misspellings im Po...
10/05/2021
- 11:54 PM Revision 310956ec (cdmlib): fix compile error and cleanup (cont.)
- 11:50 PM Revision b78fe281 (cdmlib): fix compile error and cleanup
- 11:36 PM Revision 12da0940 (cdmlib): cleanup
- 11:30 PM Revision 09b7d505 (cdmlib): ref #7980, ref #8871, ref #9795 fix source handling in StructuredDescriptionAggregation
- 03:09 PM Revision 9b4330d1 (cdmlib): revert add supresswarning annotation
- 02:39 PM Revision 06367522 (cdmlib): cleanup
- 02:39 PM Revision 8d87730d (cdmlib): fix compile error
- 02:01 PM Revision 44900eab (cdmlib): remove cloneNotSupportedException from DescriptionElementBase and some cleanup
- 01:55 PM Revision 802b31bc (cdm-dataportal): avoiding usage of deprecated property determinedNames
- 01:46 PM Revision eb1d334b (cdmlib): code cleaning - continue
- 01:35 PM bug #9772: Improve DTO usage for character matrix
- Andreas Müller wrote:
> Can you please also leave a note which model objects have been replaced by this ticket?
>
... - 01:21 PM bug #9772 (Resolved): Improve DTO usage for character matrix
- Code cleaning done for TaxonNodeService/Dao and DescriptiveDatasetService.
- 10:54 AM bug #9772: Improve DTO usage for character matrix
- Andreas Müller wrote:
> Please check also if code is clean. E.g. I found DescriptiveDatasetService.getDescriptiveDat... - 08:45 AM bug #9772: Improve DTO usage for character matrix
- Andreas Müller wrote:
> Same in TaxonNodeServiceImpl.getTaxonNodeDtos().
>
> By the way I wonder if all these HQL... - 01:28 PM Revision c6890f7a (cdmlib): code cleaning - continue
- 01:17 PM Revision b3c135e2 (cdmlib): code cleaning
- 01:15 PM Revision 128317f4 (cdmlib): code cleaning
- 10:53 AM Revision 3ed10837 (cdmlib): ref #9772: code cleaning - move hql code to persistence
- 09:57 AM Revision c61c9db0 (cdmlib): code cleaning, move hql queries to dao
- 09:40 AM bug #9800 (In Progress): Open issues for character matrix
- * implement the details view again to be able to edit some more advanced data like the modifiers. This worked in earl...
- 09:40 AM bug #9799 (New): Details view should be available for character matrix
- Implement the details view again to be able to edit some more advanced data like the modifiers. This worked in earlie...
- 09:30 AM bug #9073 (Worksforme): Configuring the matrix view throws HTTP invoker exception
- could not reproduce this anymore, so close this ticket.
- 09:20 AM bug #8243: Cdm Cache uses a lot of disk space
- We should have a look on this with the new implementation because the matrix worked with descriptions and descriptive...
- 08:56 AM bug #9074: Specimen missing a collector + n° and missing a collection identifier (Barcode, Accession number) not identifiable in descriptive Matrix
- With the actual implementation the "collector & nr" field is always filled, if a field unit with collector and collec...
10/04/2021
- 04:34 PM bug #9772: Improve DTO usage for character matrix
- Same in TaxonNodeServiceImpl.getTaxonNodeDtos().
By the way I wonder if all these HQL statements are necessary. Ha... - 04:23 PM bug #9772: Improve DTO usage for character matrix
- Please check also if code is clean. E.g. I found DescriptiveDatasetService.getDescriptiveDataSetDtoByUuid() which inc...
- 04:01 PM bug #9772: Improve DTO usage for character matrix
- Can you also check for other open matrix tickets and add the new tag "matrix" to them so we can check for all open ma...
- 03:52 PM bug #9772: Improve DTO usage for character matrix
- Generally we can close this ticket.
- 03:52 PM bug #9772: Improve DTO usage for character matrix
- Can you please also leave a note which model objects have been replaced by this ticket?
And can you check the (new... - 03:50 PM bug #9772: Improve DTO usage for character matrix
- This generally seems to work now as expected.
I guess we need to create a couple of follow-up tickets. I could thi... - 02:24 PM bug #9772: Improve DTO usage for character matrix
- Some more tests (with Lactucinae):
found two issues, both are already fixed:
* avoid NPE for quantitative data ... - 11:33 AM bug #9772: Improve DTO usage for character matrix
- Andreas Müller wrote:
> Adding a new literature to a taxon does show the taxon row 2x if a specimen description for ... - 11:30 AM bug #9772 (Feedback): Improve DTO usage for character matrix
- Adding a new literature to a taxon does show the taxon row 2x if a specimen description for this taxon existed before...
- 04:25 PM Revision 4deab588 (cdmlib): cleanup
- 03:35 PM bug #9796 (Closed): LazyInitializationException (LIE) on portal/taxon/{uuid} with misapplied names
- the changes seem to solve the initialization problems without noticeable side-effects.
- 02:53 PM Revision cbd2db51 (taxeditor): ref #7981: fix enable/disable in aggregation wizard
- 02:44 PM Revision d10e83d5 (cdmlib): ref #9772 cleanup SpecimenOrObservationBaseDTO (cont.)
- 02:39 PM Revision 20baf421 (cdmlib): cleanup SpecimenOrObservationBaseDTO
- 02:12 PM Revision 0b54e3e1 (cdmlib): ref #7980, ref #8871 reuse description items for DDS aggregation
- 02:09 PM Revision 22f2a9b8 (cdmlib): cleanup
- 02:08 PM Revision 44ddcdb3 (taxeditor): ref #9772: check for changes before start aggregation
- 02:06 PM Revision 11baea18 (cdmlib): ref #7980 remove multiple description items for same feature from reused description
- 01:52 PM bug #9797 (Resolved): LazyInitializationException (LIE) on portal/taxon/{uuid} with misapplied names
- 01:52 PM Revision c7378b10 (cdmlib): ref #9797 introducing TaxonAutoInitializer to init taxonNodes and adapting init strategies
- 01:52 PM Revision 6f10f4a4 (cdmlib): ref #9797 comment on UNUSED TaxonNodeAutoInitializer
- 01:52 PM Revision 19732d4e (cdmlib): ref #9797 disabling and deprecating TaxonRelationshipBeanProcessor
- 01:50 PM Revision 4bb63f91 (cdmlib): ref #9797 better trace logging for bean initialization
- 01:50 PM Revision 7eb8206e (cdmlib): ref #9797 Taxon.isMisapplicationOnly() as transient method
- 12:54 PM Revision 64e5bc9f (cdmlib): ref #9772: add collectors string with collector and collectorsnumber
- 12:25 PM Revision 337fab7d (taxeditor): ref #9772: fix collector and number
- 12:23 PM Revision e0bfdfcc (cdmlib): ref #9772: add collectors string with collector and collectorsnumber
- 09:28 AM Revision bf9c6f71 (cdmlib): ref #7981: fix taxonnodeDto taxon titlecache
10/02/2021
- 02:13 AM Revision dd94a952 (cdmlib): add CDMLINK to ClearDB_with_Terms_DataSet.xml
- 12:18 AM Revision 0f720e98 (cdmlib): minor and cleanup
10/01/2021
- 09:46 PM Revision 476ec51f (cdmlib): include taxon name in taxon node referencing objects formatter
- 07:26 PM Revision 2d5e8696 (cdmlib): fix compile error
- 07:15 PM Revision 36ccd41f (cdmlib): cleanup
- 06:15 PM Revision 405677c2 (taxeditor): ref #7981: indent added
- 06:10 PM Revision b52812b1 (cdmlib): ref #7981: fix taxonnodeDto taxon titlecache
- 05:51 PM Revision 52002b9b (taxeditor): ref #7981: improve aggregation ui
- 05:41 PM Revision 6991db68 (taxeditor): disable 'use default descr' in aggreg config wizard
- 04:24 PM Revision 405ec428 (taxeditor): ref #7981 update labels for aggregation filter selection
- 01:22 PM Revision 114b2aae (cdmlib): fix wrong parameters in taxonnodeDto in DDS Dto
- 01:15 PM Revision e83d7600 (taxeditor): ref #7981 fix literature description default value handling
- 01:01 PM Revision f4bb39c6 (taxeditor): cleanup
- 01:01 PM Revision 8f7bd0a1 (taxeditor): ref #7981 improve publish, literature and default description handling in StructuredDescriptionAggregationConfigurationWizardPage (cont.)
- 01:01 PM Revision 6c5aa726 (taxeditor): ref #7981 move "Aggregate all taxa in descriptive dataset" to top
- 01:01 PM Revision e1834f73 (taxeditor): ref #7981 improve publish, literature and default description handling in StructuredDescriptionAggregationConfigurationWizardPage
- 01:00 PM Revision e0142947 (taxeditor): cleanup
- 12:04 PM Revision 1f7cd5bd (taxeditor): set default values in aggregation conf wizard for the new attributes
- 10:56 AM Revision f7186f68 (cdmlib): Simplify stateData comparator
- 10:44 AM Revision f33239f5 (cdmlib): fulfill compare contract for stateData comparator
- 10:32 AM Revision 7398f69e (taxeditor): avoid NPEs
- 10:32 AM feature request #9798: Import Spanish representations for countries
- Import is prepared but still needs to run after the next release
- 10:07 AM feature request #9798 (Resolved): Import Spanish representations for countries
- Applied in changeset commit:cdmlib-apps|9920661b646173b407c80a48fba951c648f011fc.
- 09:32 AM feature request #9798 (Closed): Import Spanish representations for countries
- We can use the same code as for the German/Latin ranks written for edaphobase.
- 10:17 AM Revision 317f174d (cdmlib): minor
- 10:17 AM Revision 1e12fcd5 (cdmlib): ref #9798 add Spanish country labels to term csv files
- 10:07 AM Revision 9920661b (cdmlib-apps): fix #9798 add activator for Spanish country representations
- 10:05 AM Revision 6efca48a (cdmlib-apps): cleanup
- 10:05 AM Revision c1a05f5d (cdmlib-apps): Adapt E+M aggregation activators to new AggregationMode.byXXX signatures
- 09:51 AM Revision 114b1bfe (cdmlib): avoid NPE in state comparat
- 09:39 AM Revision 61a16467 (taxeditor): add additional attributes to aggregation wizard
- 09:34 AM Revision 526223e5 (cdmlib): cleanup
- 09:34 AM Revision 5cea4919 (cdmlib): ref #9798 make Spanish uuid public
- 09:24 AM Revision 2abccc58 (taxeditor): ref #7981 enable source modes for checked aggregation modes and some code cleaning
- 09:11 AM Revision 94dfa139 (cdmlib): sort states in aggregated descriptions on count - continue
- 08:56 AM bug #9797 (Closed): LazyInitializationException (LIE) on portal/taxon/{uuid} with misapplied names
- eg:
http://localhost:8080/portal/taxon/b384de9c-0a70-48e9-8fcc-1f772a331544.json
http://int.e-taxonomy.eu/cd... - 08:48 AM Revision e2171f2a (cdmlib): sort states in aggregated descriptions on count
- 08:42 AM Revision 8cb33c6c (taxeditor): javadoc
09/30/2021
- 06:35 PM Revision 838c7344 (cdmlib): Merge branch 'develop' of ssh://dev.e-taxonomy.eu/var/git/cdmlib into develop
- 06:32 PM Revision 45140a15 (cdmlib): ref #9772: do not create empty elements in taxon descriptions
- 05:49 PM Revision c9369579 (cdmlib): ref #9795 include literature aggregation by default
- 05:49 PM Revision ecaf2cf6 (cdmlib): cleanup
- 05:46 PM Revision 3b6350d6 (cdmlib): ref #7980 fix NPE for StateData having no state
- 05:46 PM Revision 1d1c2ae7 (cdmlib): ref #8871 remove isAggregateToHigherRanks from StructuredDescriptionAggregationConfiguration
- 02:03 PM bug #9630: Make the handling of computed description configurable
- Added check whether a d&d target is a computed description.
- 02:02 PM Revision 1df9cf60 (taxeditor): ref #9630: d&d should not allowed to a computed description if
- 01:49 PM Revision 1475999b (taxeditor): ref #9772: revert some changes in l10n
- 12:51 PM Revision 0e123335 (taxeditor): Merge branch 'develop' of ssh://dev.e-taxonomy.eu/var/git/taxeditor into develop
- 12:50 PM Revision 4512ae1c (taxeditor): ref #9772: code cleaning
- 12:44 PM bug #9772 (Resolved): Improve DTO usage for character matrix
- There are still two UI issues, the color of the field where a default description exists, changes (of the color) are ...
- 09:56 AM bug #9772 (In Progress): Improve DTO usage for character matrix
- 09:56 AM bug #9772: Improve DTO usage for character matrix
- Andreas Müller wrote:
> Katja Luther wrote:
> > need to be tested:
>
> what does this mean? Did you test it or i... - 09:35 AM bug #9772: Improve DTO usage for character matrix
- Katja Luther wrote:
> need to be tested:
what does this mean? Did you test it or is it still to be done?
- 09:17 AM bug #9772: Improve DTO usage for character matrix
- need to be tested:
* add new specimen, add character data -> save , add more character data -> save -> check for d... - 12:04 PM Revision e3c9d137 (taxeditor): ref #7981 include unpublished to taxon filter (explicit checkbox is still missing)
- 12:04 PM Revision ff7bfebe (taxeditor): ref #7981 fill DDS aggregation dialogue with correct values for aggregation mode
- 12:04 PM Revision a89350b0 (taxeditor): fix potential NPE in AggregationConfigurationWizardPage
- 12:04 PM Revision 3e4d8bf8 (taxeditor): Cleanup aggregation handler
- 12:04 PM Revision 5a83898e (taxeditor): cleanup
- 10:51 AM Revision bb03a041 (taxeditor): ref #9772: redraw after literature desc creation and code cleaning
- 10:40 AM Revision 926b7eda (cdmlib): ref #9772: continue solving problems with rowWrapper
- 10:05 AM Revision bd94706c (cdmlib): ref #9772: fix problems with doubled states in literature descriptions
- 08:01 AM Revision d70979a4 (taxeditor): Merge branch 'develop' of ssh://dev.e-taxonomy.eu/var/git/taxeditor into develop
- 07:58 AM Revision a0914872 (taxeditor): ref #9772: fix problems with rowWrapper
- 07:54 AM Revision 205624c1 (cdmlib): Merge branch 'develop' of ssh://dev.e-taxonomy.eu/var/git/cdmlib into develop
- 07:53 AM Revision a0f0c203 (cdmlib): ref #9772: fix problems with rowWrapper
09/29/2021
- 04:11 PM bug #9796 (Resolved): LazyInitializationException (LIE) on portal/taxon/{uuid} with misapplied names
- 03:51 PM bug #9796: LazyInitializationException (LIE) on portal/taxon/{uuid} with misapplied names
- this is related to the changes made for #9433 ( commit:40708c6 )
- 03:13 PM bug #9796 (Closed): LazyInitializationException (LIE) on portal/taxon/{uuid} with misapplied names
- eg:
http://test.e-taxonomy.eu/cdmserver/euromed/portal/taxon/e1688082-958a-4787-9afa-f46297920eee.json
htt... - 04:03 PM Revision a1012824 (cdmlib): ref #9796, ref #9433 extending init strategy for related taxa
- 03:56 PM Revision c13b2469 (taxeditor): fix compile errors and cleanup
- 03:46 PM feature request #8713 (Closed): Improve structured descriptive data aggregation
- remaining issues handled in #7980
- 03:38 PM Revision 8a6770d6 (cdmlib): ref #9795 evaluate includeLiterature
- 03:08 PM Revision 9341b749 (cdmlib): rename static AggregationMode methods
- 02:51 PM Revision 9c09a16e (cdmlib): minor
- 02:40 PM task #9123: Fix BigDecimal algebra in aggregation algorithms
- Rounding in aggregation is now done using MathContext.DECIMAL32 and stripTrailingZeros(). This avoids rounding errors...
- 11:49 AM task #9123 (In Progress): Fix BigDecimal algebra in aggregation algorithms
- There is a problem with average computing in aggregation. RoundingMode is missing.
Once this is fixed we need to che... - 02:32 PM Revision 003ae517 (cdmlib): minor
- 02:31 PM Revision b7cfb9fb (cdmlib): ref #9123 improve precision handling for average computing in DDS aggregation
- 11:52 AM Revision b55fc921 (cdmlib): ref #9123 add rounding to average computing in DDS aggregation (not yet complete)
- 10:02 AM Revision e55c87fd (cdmlib): ref #7980 add exception message to unhandled exception handling
- 10:00 AM Revision e176d33f (cdmlib): put failing test preliminary to ignore
- 10:00 AM Revision 058e1e67 (cdmlib): cleanup
- 09:54 AM Revision 02f22141 (taxeditor): ref #7981 try to handle exceptions in structured aggregation handler
- 09:52 AM Revision 9bd56314 (taxeditor): cleanup
- 09:04 AM Revision ef827ced (cdmlib): add stacktrace handling for StructuredDescriptionAggregationTest (cont.)
- 09:03 AM Revision c356f10f (cdmlib): cleanup UpdateResult
- 08:44 AM Revision db3f7e5d (cdmlib): add stacktrace handling for StructuredDescriptionAggregationTest
09/28/2021
- 11:21 PM feature request #9795 (In Progress): Add literature descriptions to matrix aggregation
- 11:19 PM feature request #9795 (Closed): Add literature descriptions to matrix aggregation
- copied from #7980
- 11:21 PM Revision 7043c4ee (cdmlib): ref #9795 add literature descriptions to matrix aggregation
- 11:14 PM Revision 83efeb94 (cdmlib): minor issues for StructuredDescriptionAggregationTest
- 01:31 PM bug #9794 (Closed): external-links: World Flora Online link template improved
- done!
- 01:19 PM bug #9794 (Closed): external-links: World Flora Online link template improved
- the external link to World Flora Online results in a too unspecific search and returns far too many results.
Eckha... - 01:31 PM Revision 1272ab60 (cdm-dataportal): ref #9794 wfo link improved - update script
- 01:21 PM Revision eeb2bfe0 (cdm-dataportal): ref #9794 wfo link improved
- 11:36 AM discussion #9793 (New): webservice versioning strategy
- see
https://dzone.com/articles/rest-api-versioning-strategies-1 - 11:17 AM Revision 310a5f85 (taxeditor): id column in specimen selection dialog smaller and moved
- 11:14 AM task #9792 (Closed): remove ePic from ext-links
- 10:52 AM task #9792 (Closed): remove ePic from ext-links
- ePIC is gone:
"The requested resource
/searchepic/summaryquery.do
is no longer available on this server and th... - 11:13 AM Revision 2c63e9ba (cdm-dataportal): ref #9792 update script to remove epic from stored settings
- 10:54 AM Revision cf1b2853 (cdm-dataportal): ref #9792 removing ePIC from ext-links
- 10:50 AM bug #8936 (Closed): Improve default distribution formatting
- done
- 10:50 AM Revision a8b43555 (cdm-dataportal): ref #8936 new default for level-0 item_glue
- 09:50 AM bug #9791 (New): Handle differing media meta data and informations in DB
- If media data of a media differs from the data in DB, we need a refresh button and a warning that the informations ar...
- 09:28 AM feature request #9054: Allow adding taxon descriptions to matrix for taxa which have no specimen descriptions attached yet
- As we are currently working on the matrix/additivity issues and as the Borsch workshop is coming closer we should try...
- 09:27 AM bug #9790 (Closed): Remove source mode "highest Status" from DDS Aggregation
- I tested in TaxEditor and it works as expected.
09/27/2021
- 05:27 PM bug #8936: Improve default distribution formatting
- Andreas Kohlbecker wrote:
> please can you clarify what exactly the conclusion is that results from the discussion i... - 04:41 PM bug #8936: Improve default distribution formatting
- please can you clarify what exactly the conclusion is that results from the discussion in comment #8936#note-19?
- 03:59 PM bug #9781: Merge of QuantitativeData or CategoricalData from Character Matrix should not create new records
- KL:
Das passiert im RowWrapper (setDataValueForQuantitativeData()) - 03:38 PM bug #9790 (Resolved): Remove source mode "highest Status" from DDS Aggregation
- Applied in changeset commit:cdmlib|ef92e1f650be6328f4e3d5b466169ce0f32c1d9d.
- 03:37 PM bug #9790 (Closed): Remove source mode "highest Status" from DDS Aggregation
- only highest status (or "OnlySameValue") should for now not be available for Descriptive Dataset aggregation.
We n... - 03:38 PM Revision ef92e1f6 (cdmlib): fix #9790 remove highest status only for DDS source aggregation
- 10:07 AM bug #9789 (New): Missing configurator when deleting a classification
- Similar to the deletion of nodes we need a configuration wizard for classifications.
- 09:51 AM Revision 7c78e6e0 (taxeditor): change color for overridden values
09/24/2021
- 07:28 PM feature request #7275 (In Progress): [DISCUSS] Require email address for Users
- 07:26 PM feature request #7276 (In Progress): Make User.email a unique field.
- AM:
Eigentlich dachte ich ja wir können sie als rejected schließen. Aber das Thema uniquenes ist natürlich schon k... - 05:58 PM feature request #9788 (New): Add full stop at the end of bibliographic reference citations in dataportal
- AM:
zum Punkt hinter den Quellen: ich kann mich hier nicht mehr genau an die Entwicklung erinnern, aber ich glaube... - 05:54 PM bug #8936: Improve default distribution formatting
- Andreas Kohlbecker wrote:
> Andreas Müller wrote:
> > The issue in #note-19 is still open. The suggestion is to rem... - 01:46 PM bug #8936: Improve default distribution formatting
- Andreas Müller wrote:
> The issue in #note-19 is still open. The suggestion is to remove Space and use Komma+Space i... - 01:38 PM bug #8936 (Feedback): Improve default distribution formatting
- The issue in #note-19 is still open. The suggestion is to remove Space and use Komma+Space instead for Level-0 item g...
- 01:31 PM bug #8936 (Resolved): Improve default distribution formatting
- 1. I adapted the setting of the cuba test portal, so that it conforms to the production portal, the setting are now ...
- 02:49 PM Revision ae115efe (cdmlib): code cleaning
- 01:53 PM feature request #9787 (New): option to show external kml layers in the taxon/specimen page
- Hello Andreas and Raúl,
[Raúl: I intercalated some questions below]
I had asked Raúl your question about the ma... - 01:30 PM bug #9762 (Closed): Handle cultivars correctly in TaxEditor
- This seems to be fully fixed now.
- 11:57 AM bug #9762 (Feedback): Handle cultivars correctly in TaxEditor
- Katja Luther wrote:
> Andreas Müller wrote:
> > There is a single issue left. When switching back from ICNCP to ICN... - 12:05 PM Revision 4451d6c9 (taxeditor): ref #9762: adapt l18n strings
- 11:47 AM bug #9772 (Resolved): Improve DTO usage for character matrix
- All open issues are fixed. Only new issue is the NPE when opening the aggregation. I will check this once the editor ...
- 08:21 AM bug #9772: Improve DTO usage for character matrix
- Andreas Müller wrote:
> Currently it looks like quantitative data characters which support >1 measurment units can n... - 11:39 AM Revision 41fe4def (taxeditor): ref #9772: avoid NPE in aggregation handler - continue
- 11:12 AM Revision 2c37ed60 (taxeditor): ref #9772: avoid NPE in aggregation handler
- 09:56 AM Revision e719e550 (cdmlib): ref #9772: fix problems with more than one description for one taxon
09/23/2021
- 05:52 PM feature request #6640: Integrate RIS Import in taxEditor
- KL 2017-05-12 (not sure if still an open issue):
der Ris Import funktioniert jetzt bei mir lokal im Editor.
Den ... - 05:42 PM bug #9762 (Resolved): Handle cultivars correctly in TaxEditor
- Andreas Müller wrote:
> There is a single issue left. When switching back from ICNCP to ICNAFP there comes a warning... - 01:29 PM bug #9762: Handle cultivars correctly in TaxEditor
- There is a single issue left. When switching back from ICNCP to ICNAFP there comes a warning like:
![](picture728-... - 01:17 PM bug #9762: Handle cultivars correctly in TaxEditor
- Katja Luther wrote:
> Andreas Müller wrote:
> > When selecting a rank in the combobox the rank shown below in the l... - 01:15 PM bug #9762: Handle cultivars correctly in TaxEditor
- Andreas Müller wrote:
> Ok, I found it. Fields that update the nameCache need an annotation @CacheUpdate("nameCache"... - 09:03 AM bug #9762: Handle cultivars correctly in TaxEditor
- Katja Luther wrote:
> Andreas Müller wrote:
> > Andreas Müller wrote:
> > > Andreas Müller wrote:
> > > > Works c... - 08:43 AM bug #9762: Handle cultivars correctly in TaxEditor
- Andreas Müller wrote:
> When selecting a rank in the combobox the rank shown below in the list is selected and shown... - 08:36 AM bug #9762: Handle cultivars correctly in TaxEditor
- Andreas Müller wrote:
> Andreas Müller wrote:
> > Andreas Müller wrote:
> > > Works correctly now except for 1 ope... - 05:32 PM bug #8936 (Feedback): Improve default distribution formatting
- 01:04 PM bug #8936: Improve default distribution formatting
- In general I did not yet test other databases with status being shown. A reason was that I did not find the place whe...
- 01:03 PM bug #8936: Improve default distribution formatting
- Andreas Kohlbecker wrote:
> I changed the code a bit so that the item suffix is only added when there are not child-... - 11:37 AM bug #8936: Improve default distribution formatting
- AM:
wir arbeiten in diesem Release an der Optimierung des Verbreitungsstrings bezüglich Separatoren und Fußnoten. ... - 11:16 AM bug #8936 (Resolved): Improve default distribution formatting
- I changed the code a bit so that the item suffix is only added when there are not child-nodes.
Additionally, I als... - 05:31 PM feature request #9780 (Closed): Split rank grex into grex (ICNCP) and grex (infraspec)
- Reordering for existing terms will be done in #9784
- 05:28 PM feature request #6636: First version of RIS reference import (e.g. for Endnote import)
- CY (full, place published) and PY (fix merge with DA, year) fixed in #9786
- 05:26 PM feature request #9786 (Resolved): Implement tags CY and fix PY handling for RIS import
- Applied in changeset commit:cdmlib|d457f5b7c2f642f4c600124e9905ea01255645b4.
- 03:26 PM feature request #9786 (Closed): Implement tags CY and fix PY handling for RIS import
- follow up for #6636
CY (Place published) is not yet handled.
PY handling has a bug and is not yet used therefor... - 05:26 PM Revision d457f5b7 (cdmlib): fix #9786 implement CY and fix PY for RIS import (and fix Source handling for in-references)
- 05:16 PM Revision bb25976f (taxeditor): ref #9772: fix handling when more than 1 unit is choosable - continue
- 04:22 PM Revision 49fee2fb (cdmlib): ref #9772: avoid another NPE
- 03:21 PM Revision 638120c2 (taxeditor): ref 9762: adapt message when cultivar epithets are removed.
- 02:56 PM Revision 9740c8f1 (cdmlib): Cleanup RIS and Endnote tests
- 02:43 PM bug #9772: Improve DTO usage for character matrix
- Currently it looks like quantitative data characters which support >1 measurment units can not be opened in the popup...
- 01:51 PM bug #9772: Improve DTO usage for character matrix
- Andreas Müller wrote:
> We will need an update script to try to update existing data (in greece-bupleurum there are ... - 01:43 PM bug #9772: Improve DTO usage for character matrix
- Katja Luther wrote:
> Andreas Müller wrote:
> > Values are not persisted when entered into a taxon description (lit... - 11:15 AM bug #9772: Improve DTO usage for character matrix
- Andreas Müller wrote:
> Values are not persisted when entered into a taxon description (literatur description or def... - 01:56 PM Revision 8b7732ac (taxeditor): ref #9772: fix handling when more than 1 unit is choosable - continue
- 01:50 PM Revision 6bcb1685 (cdmlib): ref #9772: avoid NPE
- 01:49 PM bug #9785 (Closed): Update script for missing measurment unit_ids (matrix)
- for details see #9772#note-24
The problem existed already befor so there are lots of data with missing unit_id (e.... - 01:48 PM Revision 446189d9 (taxeditor): ref #9772: fix handling when more than 1 unit is choosable
- 01:08 PM feature request #9778 (Closed): Add new rank terms lusus, subgrex and subproles
- 01:06 PM Revision f263ddd1 (cdmlib): ref #6387 add code validation for cultivar group epi
- 11:03 AM Revision cbefe788 (cdm-dataportal): ref #8936 item-suffix only when child-nodes exist
- 11:03 AM Revision c4f29439 (cdmlib): ref #9772: fix getting taxonRowWrapper - continue
- 10:32 AM Revision e1fef636 (cdmlib): ref #9772: fix getting taxonRowWrapper
- 10:29 AM bug #9477 (Resolved): New ordered terms do not have correct order index
- before closing check on production if it worked correctly. I already tested locally.
~~~
SELECT id, dtb.orderInde... - 10:26 AM bug #9784 (New): Update script for term order of ordered CDM terms
- copied from #9477
Termloader is fixed now but we still need to update order for already existing term which were l... - 10:22 AM Revision 749a2e19 (cdmlib): ref #9477 fix term loading for ordered new terms
- 09:45 AM Revision 0a5a166c (cdmlib): fix incorrect previousUpdater info in 5.27.0_5.27.1
- 09:23 AM Revision ab600885 (taxeditor): ref #9762: fix problems with rank combo and switch nomenclatural code
- 09:02 AM Revision 0ea0fdd3 (cdmlib): ref #9762, ref #9755 Add nameCache annotation to cultivar fields
09/22/2021
- 08:02 PM bug #8936 (Feedback): Improve default distribution formatting
- For a portal showing also the status in the distribution string this does not look so well yet
: ref #9778, ref #9782 fix parsing for (sub)proles
- 06:44 PM bug #9772: Improve DTO usage for character matrix
- Values are not persisted when entered into a taxon description (literatur description or default description). Or may...
- 06:27 PM bug #9772 (Feedback): Improve DTO usage for character matrix
- 06:26 PM bug #9772: Improve DTO usage for character matrix
- If the unit is changed via the quantitative data editing dialog and persisted this change does not appear in the data...
- 06:22 PM bug #9772: Improve DTO usage for character matrix
- We will need an update script to try to update existing data (in greece-bupleurum there are 787 quantitative data wit...
- 11:29 AM bug #9772 (Resolved): Improve DTO usage for character matrix
- Save should not create new states or statistical values, but I think this is a new ticket because it is no regression...
- 09:03 AM bug #9772: Improve DTO usage for character matrix
- Andreas Müller wrote:
> The smv.type_id IS NULL issue seems to be solved now. But there is another critical issue: t... - 06:35 PM bug #9783 (New): When a new value is added to a quantitative data it should appear at the end
- currently it appears at the beginning. But this is only the case for the current editing. When a other value is added...
- 06:15 PM task #9782 (Closed): Adapt abbreviation and idInVoc for rank "proles"
- Checked result in updated database.
- 02:44 PM task #9782 (Resolved): Adapt abbreviation and idInVoc for rank "proles"
- 02:43 PM task #9782 (Closed): Adapt abbreviation and idInVoc for rank "proles"
- AM:
wie ist denn die übliche Formatierung bei proles /subproles. Bislang haben wir das als „prol.“, also abgekürzt... - 06:13 PM bug #9734 (Closed): Correct handling for secundum references when moving taxon to new parent
- Works as expected now
- 11:29 AM bug #9734 (Resolved): Correct handling for secundum references when moving taxon to new parent
- I will test again with nightly when the test server is available again
- 11:20 AM bug #9734: Correct handling for secundum references when moving taxon to new parent
- Tested locally (test server is unavailable):
pref: keepOrWarn
* if the secs the same -> ok
* if secs different -... - 05:57 PM Revision 2f1d896d (cdmlib): ref #9757 add test for parsing into existing name
- 05:56 PM Revision de0abe03 (cdmlib): ref #9754 fix tests
- 05:32 PM Revision 1c0ec33b (cdmlib): ref #9754 fix appended phrase handling in cultivar formatter (cont.)
- 05:26 PM Revision b58adaec (cdmlib): ref #9754 fix appended phrase handling in cultivar formatter
- 04:58 PM bug #9762: Handle cultivars correctly in TaxEditor
- Andreas Müller wrote:
> Andreas Müller wrote:
> > Works correctly now except for 1 open issue: if cultivar epithet ... - 04:56 PM bug #9762: Handle cultivars correctly in TaxEditor
- When changing back from ICNCP to ICNAFP the rank list is not updated.
Also the currently selected rank is not remove... - 04:52 PM bug #9762: Handle cultivars correctly in TaxEditor
- When selecting a rank in the combobox the rank shown below in the list is selected and shown afterwards. The selectio...
- 04:35 PM bug #9762 (Feedback): Handle cultivars correctly in TaxEditor
- There was also another NPE that I fixed (careful with name.getRank().doSomething() !!)
- 03:10 PM bug #9762 (Resolved): Handle cultivars correctly in TaxEditor
- Andreas Müller wrote:
> >If ICNafp is selected do not show cultivar ranks
>
> I suggest to implement it like this... - 03:08 PM bug #9762: Handle cultivars correctly in TaxEditor
- Andreas Müller wrote:
> >If ICNafp is selected do not show cultivar ranks
>
> I suggest to implement it like this... - 03:08 PM bug #9762: Handle cultivars correctly in TaxEditor
- Andreas Müller wrote:
> This is decided now:
>
> * if "Grex (ICNCP)" is selected show "Cultivar Group"
this is... - 12:43 PM bug #9762: Handle cultivars correctly in TaxEditor
- >If ICNafp is selected do not show cultivar ranks
I suggest to implement it like this for now - 12:40 PM bug #9762: Handle cultivars correctly in TaxEditor
- This is decided now:
* if "Grex (ICNCP)" is selected show "Cultivar Group" - 12:38 PM bug #9762: Handle cultivars correctly in TaxEditor
- New requirement:
* Rename Cultivar Name to Cultivar Epithet and Cultivar Group to Cultivar Group Epi. (to make it ... - 09:58 AM bug #9762: Handle cultivars correctly in TaxEditor
- Andreas Müller wrote:
> There is the general issue that the details view does not update correctly when the nomencla... - 04:48 PM Revision d0deb3b0 (cdmlib): ref #9755 add DENOMINATIONCLASS to isCultivar()
- 04:26 PM Revision d29fd8e4 (taxeditor): ref #9762 fix NPE in cultivar handling
- 03:09 PM Revision 7a2e68e9 (taxeditor): ref #9762: smaller changes for cultivar names
- 02:58 PM Revision df18f369 (cdmlib): ref #9782 adapt abbreviation for proles - adapt tests
- 02:44 PM Revision 35146960 (cdmlib): ref #9782 adapt abbreviation for proles
- 02:37 PM feature request #9755: Open issues for cultivar handling
- AM
Denomination class:
Verstehe ich es richtig, dass das in der Regel Taxa vom Rang „Genus“ sind, und in seltenen... - 02:33 PM feature request #9755: Open issues for cultivar handling
- AM:
Verwendung von nom. Author and nom. Ref. (und evtl. andere Zusätze):
Article 28.2 verstehe ich so, dass ein A... - 02:22 PM feature request #9755 (In Progress): Open issues for cultivar handling
- The important issues have been fixed with 5.27 mostly using separate tickets.
- 02:35 PM feature request #9757: Make cultivars, cultivar groups and grexes parsable
- AM:
Arti. 21.18 nennt die erlaubten Zeichen für Kultivar-Epithete. Gelten diese Zeichen auch für Gruppen bzw. für ... - 02:30 PM feature request #6387 (Resolved): [Rule] Rank rule for CultivarPlantNames
- 01:24 PM feature request #6387: [Rule] Rank rule for CultivarPlantNames
- We will not handle convar. as cultivar rank.
WGB:
ja, ich würde convar. pragmatisch in die Liste der „alten bot... - 02:29 PM Revision f112ee1f (cdmlib): fix CdmUpdater to correct version
- 02:14 PM Revision dacb2825 (cdmlib): ref #9755 update script for grex infraspec. representation
- 02:05 PM Revision af10946c (cdmlib): ref #6387 test that convar is not a cultivar
- 02:04 PM Revision 9752a045 (cdmlib): ref #9771Additional ignore on seupClass, just in case
- 01:44 PM bug #9781 (New): Merge of QuantitativeData or CategoricalData from Character Matrix should not create new records
- Actually every merge of already existing but updated character data creates new states/statistical values and removes...
- 01:19 PM Revision 24d1dcbf (taxeditor): ref #9762: remove cultivar ranks for non cultivar codes and use isCultivar()
- 01:18 PM Revision 6a5d2783 (taxeditor): ref #9734: add missing brackets to condition
- 12:47 PM feature request #9754 (Closed): Adapt cache strategy to support cultivar names
- 12:45 PM Revision bd349938 (cdmlib): ref #9771 first incomplete version of Cdm2CdmVocabularyImport (cont.)
- 12:26 PM feature request #9780 (Resolved): Split rank grex into grex (ICNCP) and grex (infraspec)
- 12:25 PM feature request #9780 (Closed): Split rank grex into grex (ICNCP) and grex (infraspec)
- AM:
wir haben in letzter Zeit versucht das Handling (Parsen, Formattieren, Handling im TaxEditor) von Kultivaren e... - 12:20 PM Revision 6825968d (cdmlib): cleanup
- 12:19 PM Revision 8876144e (cdmlib): ref #9771 first incomplete version of Cdm2CdmVocabularyImport
- 12:13 PM feature request #9778 (Resolved): Add new rank terms lusus, subgrex and subproles
- 10:43 AM feature request #9778 (Closed): Add new rank terms lusus, subgrex and subproles
- About lusus:
Rangstufen: Die untenstehenden „Ränge“ fehlen in der normalen Tabelle („sublusus“ haben wir z.B.)... - 12:04 PM Revision 9585c46e (cdmlib): ref #9778, ref #9755, ref #9754, ref # 9757 split grex and add new ranks lusus, subproles and subgrex
- 11:25 AM bug #9779 (New): Exception when override db preference
- copied from #9739:
When trying to override preference common name language via local settings I get:
~~~
org.e... - 11:22 AM bug #9739 (Closed): Add common name languages preference to DB preferences
- create new ticket with the exception of comment 13
- 10:34 AM Revision f73004b4 (taxeditor): ref #9734: adapt message
- 10:29 AM task #8392 (Worksforme): Types in PhycoBank
- 08:32 AM task #8392 (Resolved): Types in PhycoBank
- The displayed data are as expected. All issues are solved. The ticket can be closed.
- 09:11 AM Revision 7a8c920c (cdmlib): ref #9772: fix missing unit
09/21/2021
- 11:14 PM bug #9772: Improve DTO usage for character matrix
- The smv.type_id IS NULL issue seems to be solved now. But there is another critical issue: the unit_id is often null ...
- 03:56 PM bug #9772: Improve DTO usage for character matrix
- Andreas Müller wrote:
> There seems to be another issue: when I change only 1 record 8 new records are added in the ... - 11:10 PM task #3346 (Resolved): Team.addListenerForTeamMember(Person member) adds idle listener
- 10:48 PM bug #9762: Handle cultivars correctly in TaxEditor
- There is the general issue that the details view does not update correctly when the nomenclatural code or ranks are c...
- 10:42 PM bug #9762: Handle cultivars correctly in TaxEditor
- Andreas Müller wrote:
> Works correctly now except for 1 open issue: if cultivar epithet or cultivar group are chang... - 10:40 PM bug #9762: Handle cultivars correctly in TaxEditor
- Works correctly now except for 1 open issue: if cultivar epithet or cultivar group are changed the name Cache and the...
- 10:44 PM Revision d5fbdca7 (cdmlib): ref #9754 handle infraspecific epithets better
- 10:20 PM feature request #9754: Adapt cache strategy to support cultivar names
- Only open issue is the correct handling of rank grex
- 01:57 PM feature request #9754 (Resolved): Adapt cache strategy to support cultivar names
- Not yet fully resolved but set to resolved to not forget
- 10:18 PM feature request #9757 (Closed): Make cultivars, cultivar groups and grexes parsable
- This should be fixed. Only correct usage of rank grex needs discussion but is handled in generell cultivar ticket #9755
- 01:56 PM feature request #9757 (Resolved): Make cultivars, cultivar groups and grexes parsable
- Not yet fully resolved but set to resolved to not forget
- 10:10 PM Revision 9d8aa1aa (cdmlib): ref #9754 handle null values for cultivar epis better
- 09:52 PM Revision fe699834 (cdmlib): cleanup
- 08:59 PM Revision 12ffe453 (cdmlib): ref #9757 fix emptying name before parsing
- 08:41 PM Revision 11fb1cef (taxeditor): ref #9762 fix NPE in cultivar handling
- 08:05 PM Revision c03313e2 (cdmlib): ref #9757 fix cultivar parser test
- 07:56 PM Revision ad3aa7ba (cdmlib): ref #9754 support author and nom. ref. handling for cultivar formatting
- 07:33 PM Revision 446e5712 (cdmlib): ref #9757 improve cultivar parser
- * parse with referencedName()
* include author parsing
* include nom. ref. parsing - 07:33 PM Revision 26a096a2 (cdmlib): cleanup
- 04:02 PM Revision 2966c278 (cdmlib): ref #9772: smaller changes
- 03:42 PM Revision 83db01f8 (cdmlib): ref #9772: deproxy the term in getTermByClassAndUUID
- 03:25 PM bug #825 (Closed): DefinedTermDaoImpl - missleading method names
- fully solved
- 03:18 PM bug #7904: DerivedUnitFacadeFieldUnitCacheStrategy.getCollectorAndFieldNumber() creates temporary Team objects which can not be garbage collected.
- ahh this was solved for Release 5.25
- 03:18 PM bug #7904 (Closed): DerivedUnitFacadeFieldUnitCacheStrategy.getCollectorAndFieldNumber() creates temporary Team objects which can not be garbage collected.
- code looks good. I also tested with yourkit, ticket can be closed.
- 02:49 PM task #8392: Types in PhycoBank
- Hi Hennig It ink this is all solved now and we can close this ticket as "worksforme"
- 02:32 PM bug #9777 (New): TypeError: Argument 1 passed to cdm_tagged_text_add_options() in registration-search
- http://edit.test/d7/phycobank/cdm_dataportal/registration-search/filter?identifier=&taxon_name=Mi&reference_citation=...
- 02:16 PM feature request #9758 (Closed): EmailService implemented
- implemented, covered by integration tests and not causing problem in existing apps -> can be closed
- 02:05 PM task #8379 (Closed): Review strange specimen implementations
- 02:05 PM task #8379: Review strange specimen implementations
- final check successful, can be closed, moving to the milestone for which this has been fixed: Release 5.18
- 01:58 PM task #7099 (Closed): Make CdmAuthority a persistable class
- two more lines of doc and closing this ticket
- 01:07 PM task #7099 (Resolved): Make CdmAuthority a persistable class
- I added some javadoc. Please extend if you remember more details.
I implemented a first toString() method. Can be ... - 11:34 AM task #7099 (Feedback): Make CdmAuthority a persistable class
- the implementation looks good, I only got three opens points:
* Documentation is missing, I think only linking to ... - 01:57 PM Revision a15be025 (cdmlib): ref #7099 documentation on the intendet purpose of CdmAuthority
- 01:56 PM feature request #9755 (Resolved): Open issues for cultivar handling
- Not yet fully resolved but set to resolved to not forget
- 01:35 PM bug #9740 (Worksforme): Adapt Motive(Motif) to Subject in data portal
- Ahh, sorry, this was a mistake from my side. It does not exist in the dataportals.
- 10:44 AM bug #9740 (Feedback): Adapt Motive(Motif) to Subject in data portal
- There is no such term in the dataportal code.
Please can you give an example for a dataportal page where this label ... - 01:04 PM Revision b4a56647 (cdmlib): ref #7099 javadoc added to CdmAuthority
- 12:44 PM Revision 73e39cab (cdmlib): ref #7099 implement toString and isEqual for CdmAuthority
- 12:30 PM Revision 55d06011 (cdmlib): cleanup
- 11:41 AM bug #8429 (Closed): Rename DeterminationEvent_Reference.setOfReferences_id
- there are no indications of this problem in the log, so the issue is fixed for sure.
- 11:38 AM Revision 68935150 (taxeditor): add specimen id to specimen selection dialog of character matrix
- 11:15 AM Revision c58ab5d6 (taxeditor): ref #9762: avoid NPE
- 10:08 AM bug #8936 (Closed): Improve default distribution formatting
- As far as I remember the level-0 item glue ", " was needed in some cases where only one hierarchy level of area has ...
- 09:51 AM Revision fd550079 (taxeditor): ref #9084 fix German translation for description delete config label
- 09:42 AM Revision 44490676 (taxeditor): ref #9732 change Motif to Subject in TaxEditor
- 09:32 AM feature request #3630: Taxeditor should add mimetype of mediaRepresentations automatically
- As this is already partly implemented we probably only need to adapt the existing algorithm.
@Andreas K., as you h... - 09:25 AM task #2452 (Duplicate): Media entities and Webpages
- I think this is kind of a duplicate discussion of #9067. We decided there to keep the current data model and store me...
- 09:20 AM Revision a1fd4a9b (taxeditor): ref #9762: cultivar group for cultivar and cultivar group and rank handling
- 08:57 AM Revision 3487252c (taxeditor): add correct handling for keepOrWarn when moving taxa
Also available in: Atom