Project

General

Profile

Activity

From 07/16/2024 to 08/14/2024

08/12/2024

06:14 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
~~~
String pattern = "#.###";
DecimalFormatSymbols otherSymbols = new DecimalFormatSymbols();
...
Andreas Müller

08/11/2024

12:32 AM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
Minor note: tests are easier to read if in something like
~~~
matchResults = nameMatchingService.findMatchingName...
Andreas Müller
12:28 AM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
Your tests ofen do something like
~~~
assertEquals("0.969", formmattedDouble);
~~~
This is difficult to revi...
Andreas Müller
12:25 AM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
In the tests you do something like
~~~
matchResults = nameMatchingService.findMatchingNames(inputName, true, true...
Andreas Müller
12:21 AM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
The NameMatchingResult has exactResult and bestResults. This is confusing as bestResult is actually not the best (exa... Andreas Müller
12:16 AM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
Andreas Müller wrote in #note-25:
> You do not seem to compare exBasionymAuthors
I have to correct myself. Now I ...
Andreas Müller
12:15 AM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
You generally seem to compare all authors together. E.g. in
~~~
String combinedAuthorCacheDB = exCombinationAutho...
Andreas Müller
12:07 AM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
You do not seem to compare exBasionymAuthors Andreas Müller
12:03 AM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
You handle the case
~~~
if (excludeBasionymAuthors == false && excludeExAuthors == false) {
~~~
I guess this...
Andreas Müller

08/10/2024

11:52 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
in code like
~~~
if (excludeExAuthors) {
for (int i = 0 ; i < results.size(); i++) {
...
Andreas Müller
11:45 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
Why is there a step result shaping in code "findMatchingNamesUnshaped()"? This sounds contradictory. Andreas Müller
11:43 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
In findMatchingNamesUnshaped() you repeat the same code
~~~
// 7. Result shaping
Collect...
Andreas Müller
11:37 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
Why is there a comparison
~~~
if (distanceAuthorComparison <= 0) {
~~~
Is it really possible that the distan...
Andreas Müller
10:46 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
modifiedDamerauLevenshteinDistance() starts with
~~~
if (str1 == str2) {
~~~
I guess you mean
~~~
if (str1.equals...
Andreas Müller
10:28 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
In authorMatch you use
~~~
distanceAuthorComparison/3
~~~
3 seems to be a hardcoded weight for the final dis...
Andreas Müller
10:24 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
In authorMatch() better use
~~~
for (SingleNameMatchingResult singleResult : results){
...
}
~~~
or
~~~
result...
Andreas Müller
06:58 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search

In postfilterEpithet() I do not understand why a list is returned. It looks like the laist can be filled only 1x so...
Andreas Müller
06:45 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
Minor issue:
Instead of using string comparison with null, e.g.
~~~
} else if (specificEpithetQuery != null &...
Andreas Müller
06:38 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
In compareGenus why do you pass the empty parameter postFilteredGenusOrUninominalWithDis? It seems to be a simple ret... Andreas Müller
06:16 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
Minor issue: please remove all documentation that has no content like:
~~~
/**
* @param config
* @para...
Andreas Müller
06:13 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
In NameMatchingService there is often code like
~~~
try {
combinationAuthor = name.getCombin...
Andreas Müller
06:08 PM feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
It is inconsistent that the input parameter maxDistance is integer and by default >1 while the resulting distance is ... Andreas Müller
06:07 PM feature request #10525 (In Progress): Implementation of name matching search and remaining issues for fuzzy search
Why is the title of this ticket "Implementation of name matching search and remaining issues for fuzzy search"? What ... Andreas Müller
06:05 PM feature request #10178 (Closed): Implement fuzzy name matching
Andreas Müller
02:57 PM Revision 42e06f73 (cdmlib-apps): minor
Andreas Müller
02:56 PM Revision 4cfb1c4e (cdmlib-apps): ref #10235 add cdmlight command line export for E+M
Andreas Müller
02:50 PM Revision c378088c (cdmlib): cleanup and minor issues
Andreas Müller

08/08/2024

08:14 PM bug #10579 (Resolved): Protected titleCaches for empty teams not handled correctly in TaxonNameFormatter
Please review. Andreas Müller
05:14 PM bug #10579 (Resolved): Protected titleCaches for empty teams not handled correctly in TaxonNameFormatter
... (or TaxonNameDefaultCacheStrategy). This is relevant in taxonPageDto as this is created from cacheStrategy only, ... Andreas Müller
07:59 PM Revision 938b250a (cdmlib): ref #10579 handle protected titleCache in Team formatter correctly
Andreas Müller

08/07/2024

10:42 AM Revision af1c59c9 (cdmlib-apps): ref #10235 add EuroMedWfoIdentifierActivator
Andreas Müller
10:36 AM Revision 892eebc1 (cdmlib-apps): cleanup
Andreas Müller

08/06/2024

01:17 PM bug #10578: Type specimen source comparator in cdmlight throws NPE
please review Andreas Müller
01:16 PM bug #10578 (Resolved): Type specimen source comparator in cdmlight throws NPE
Applied in changeset commit:cdmlib|1dbdf638883e99441b5de1927d41c07efa428632. Andreas Müller
11:51 AM bug #10578 (Resolved): Type specimen source comparator in cdmlight throws NPE
... if both citations or both date published are null. Andreas Müller
01:16 PM Revision 1dbdf638 (cdmlib): fix #10578 fix NPE in source comparator and extract to model.compare
Andreas Müller

08/02/2024

03:37 PM bug #10563 (Closed): Specimen selection dialog should show a short description column
Code looks good and the result as well. So we can close the ticket. Katja Luther
02:19 PM bug #10563 (Feedback): Specimen selection dialog should show a short description column
CollectorNumber still seems to missing at least if the field number is meant by collector number. There seems to be s... Andreas Müller
11:29 AM bug #10563 (Resolved): Specimen selection dialog should show a short description column
Now for concatenation CdmUtils.concat() is used and the country is added, please review. Katja Luther
02:38 PM bug #10466: Open issues in logfiles
Currently there are again a lot of LIE (many of them in TypeDesignationBaseBeanProcessor), the full stacktrace is:
~...
Katja Luther
02:25 PM bug #10577 (Rejected): Unexpected names in ColDP export
As this is a pure data issue and we decided not to clean it up as it is not critical if the duplicates are also avail... Andreas Müller
02:18 PM Revision ebed5d56 (cdmlib): ref #10563 cleanup null handling
Andreas Müller
02:11 PM Revision b93e887f (cdmlib): cleanup
Andreas Müller
02:11 PM Revision 94b9240b (cdmlib): ref #10563 replace collectorsNumber by fieldNumber
Andreas Müller
02:00 PM Revision ca2aa96b (cdmlib): cleanup
Andreas Müller
01:57 PM Revision c09eba68 (cdm-dataportal): code cleaning to avoid warnings
Katja Luther
01:56 PM Revision e23c9649 (cdm-dataportal): code cleaning to avoid warnings
Katja Luther
01:25 PM Revision b2de164f (cdmlib): cleanup
Andreas Müller
12:36 PM Revision dfc9bd65 (taxeditor): replace Umlaute for colDP file name
Katja
11:22 AM Revision fbc61bee (cdmlib): ref #10563: add country and code cleaning
Katja Luther
10:26 AM bug #9979 (Resolved): Flora Greece shows large images
This is fixed for the profile image as well, already installed a hotfix branch on production. Katja Luther
10:14 AM Revision b06b6e7c (taxeditor): Merge branch 'hotfix/5.45.1'
root
09:26 AM Revision 9937bc88 (taxeditor): fix NPE in ColDP export Wizard
Katja
09:21 AM Revision 358bcbe4 (taxeditor): Updated version in pom / project files to taxeditor version : 5.45.1 and cdmlib version : 5.45.0
jenkins
09:12 AM Revision 8de85588 (cdmlib): ref #10568: iterate over all repr and parts of image
Katja Luther
09:11 AM Revision 3b23264c (taxeditor): fix NPE in ColDP export Wizard
Katja

08/01/2024

10:02 PM bug #10562 (Closed): CdmLight and ColDP must not contain names not included in the synonymy and not linked directly
The ColDP issue is different (#10577) so we can close this ticket. Andreas Müller
04:26 PM bug #10562: CdmLight and ColDP must not contain names not included in the synonymy and not linked directly
related issue moved to #10574 Andreas Müller
09:25 PM bug #10577: Unexpected names in ColDP export
SQL to find basionym relationships that link to unpublished names
~~~ sql
SELECT syn.titleCache syn, sn.titleCache s...
Andreas Müller
09:06 PM bug #10577: Unexpected names in ColDP export
So this seems to be a data issue, not an export issue. We need to find out how to fix these data issues. Andreas Müller
09:06 PM bug #10577 (Resolved): Unexpected names in ColDP export
>Der gleiche Fall scheint auch bei Allium rotundum L., Allium rupestre Steven und A. saxatile M.Bieb. vorzuliegen.
...
Andreas Müller
08:50 PM bug #10577: Unexpected names in ColDP export
In the given case there exists a "heterotypic" synonym Allium paniculatum subsp. pallens (L.) K. Richt. which has the... Andreas Müller
07:54 PM bug #10577: Unexpected names in ColDP export
This has not been fixed by #10562 Andreas Müller
07:53 PM bug #10577 (Rejected): Unexpected names in ColDP export
WGB:
ich bin auf folgendes gestoßen:
Allium pallens L. wird mir im COLDP Export als Duplikat ausgegeben:
|Name...
Andreas Müller
08:05 PM Revision 1e95310c (cdmlib): cleanup
Andreas Müller
06:47 PM feature request #10552 (Closed): Change default anntotation type for Vaadin submitters to internal (PhycoBank)
Andreas Müller
06:38 PM feature request #10552: Change default anntotation type for Vaadin submitters to internal (PhycoBank)
Review: checked with production: Submitter submits a note, when curator takes over the text is "internal". That is ex... Wolf-Henning Kusber
06:13 PM Revision fe5b2280 (cdm-dataportal): ref #9979: handle representation for profile image correctly
Katja Luther
06:11 PM Revision 0ffead0e (cdm-dataportal): ref #9979: handle representation for profile image correctly
Katja Luther
05:19 PM bug #10357 (Closed): CDMLight fix handling for names used as synonym and accepted taxa
I exported the data with the latest version and Oncostema africanum appears only once. So I guess this an be closed. Andreas Müller
04:21 PM bug #10557 (Closed): Avoid creating empty annotations in phycobank
I removed all the above mentioned empty records so we can close this ticket. Andreas Müller
03:58 PM bug #10543: ChildNodesOf webservice does not show taxa without secundum, rank or name
The above issues are to be handled in #10507 Andreas Müller
12:12 PM bug #10543: ChildNodesOf webservice does not show taxa without secundum, rank or name
Andreas Müller wrote in #note-7:
> https://api.cybertaxonomy.org/cichorieae/portal/classification/534e190f-3339-49ba...
Andreas Müller
11:58 AM bug #10543: ChildNodesOf webservice does not show taxa without secundum, rank or name
https://api.cybertaxonomy.org/cichorieae/portal/classification/534e190f-3339-49ba-95d9-fa27d5493e3e/childNodesAt/ac47... Andreas Müller
03:36 PM bug #9979: Flora Greece shows large images
KL:
jetzt werden die Thumbnails geladen, man erkennt das nicht, indem man mit der Maus über das Bild geht, sondern...
Andreas Müller
02:05 PM bug #9979: Flora Greece shows large images
Andreas Müller wrote in #note-27:
> Katja Luther wrote in #note-26:
> > But the search shows thumbnails:
>
> Yes...
Katja Luther
12:44 PM bug #9979: Flora Greece shows large images
Katja Luther wrote in #note-26:
> But the search shows thumbnails:
Yes, but this ticket is not about the search b...
Andreas Müller
12:41 PM bug #9979: Flora Greece shows large images
Andreas Müller wrote in #note-25:
> Katja Luther wrote in #note-24:
> > Andreas Müller wrote in #note-23:
> > > Ka...
Katja Luther
12:31 PM bug #9979: Flora Greece shows large images
Katja Luther wrote in #note-24:
> Andreas Müller wrote in #note-23:
> > Katja Luther wrote in #note-22:
> > > Most...
Andreas Müller
12:24 PM bug #9979: Flora Greece shows large images
Andreas Müller wrote in #note-23:
> Katja Luther wrote in #note-22:
> > Most images in flora greece don't have differ...
Katja Luther
11:50 AM bug #9979: Flora Greece shows large images
Katja Luther wrote in #note-22:
> Most images in flora greece don't have different representations, so we should cre...
Andreas Müller
11:46 AM bug #9979: Flora Greece shows large images
Most images in flora greece don't have different representations, so we should create a transformation rule for these... Katja Luther
11:32 AM bug #9979 (In Progress): Flora Greece shows large images
The thumbnails in the image gallery are still using the large sized images. Andreas Müller
11:12 AM bug #9979 (Resolved): Flora Greece shows large images
This seems to be solved by the adaptions of last release, the image of the taxon page is now the medium representatio... Katja Luther
02:34 PM Revision ce86188f (cdm-dataportal): ref #9979: handle representation in simple gallery correctly
Katja Luther
01:22 PM Revision d831f56c (cdm-dataportal): ref #9979: handle representation in simple gallery correctly
Katja Luther
11:13 AM bug #10181 (Closed): Search images do not show thumbnails
Andreas Müller wrote in #note-16:
> Ahh, correct. So we take this as final test after release.
The example from n...
Katja Luther

07/31/2024

06:32 PM Revision 4bf15812 (cdm-webapp): cleanup
Andreas Müller
06:25 PM Revision 5a9f914f (taxeditor): cleanup
Andreas Müller
06:24 PM Revision 1c7009a3 (cdm-dataportal): cleanup
Andreas Müller
06:22 PM Revision da52b902 (cdm-server): Merge branch 'release/5.45.0' into develop
jenkins
06:22 PM Revision 0e9fc7cc (cdm-server): jenkins merging release branch into master (strategy: theirs)
jenkins
06:21 PM Revision 91babf96 (cdm-server): updating poms for branch'release/5.45.0' with non-snapshot versions
jenkins
06:20 PM Revision e3c8f6bf (cdm-webapp): Merge branch 'release/5.45.0' into develop
jenkins
06:20 PM Revision af7cfdee (cdm-webapp): jenkins merging release branch into master (strategy: theirs)
jenkins
06:20 PM Revision d2efc88b (cdm-webapp): updating poms for branch'release/5.45.0' with non-snapshot versions
jenkins
06:20 PM Revision 413cd34a (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.45.0
jenkins
06:20 PM Revision f7123058 (cdm-vaadin): Merge branch 'release/5.45.0' into develop
jenkins
06:20 PM Revision 03d786f1 (cdm-vaadin): jenkins merging release branch into master (strategy: theirs)
jenkins
06:19 PM Revision fbd326fa (taxeditor): Merge branch 'release/5.45.0' into develop
jenkins
06:19 PM Revision dd23ed5d (taxeditor): Merge branch 'release/5.45.0'
jenkins
06:17 PM Revision fbec489e (cdm-dataportal): Merge branch 'release/5.45.0' into develop
jenkins
06:17 PM Revision 426ee54e (cdm-vaadin): updating poms for branch'release/5.45.0' with non-snapshot versions
jenkins
06:17 PM Revision ebe01426 (cdm-dataportal): updating poms for branch'release/5.45.0' with non-snapshot versions
jenkins
06:16 PM Revision b10d5a8d (cdm-dataportal): release-preparation: production level css
jenkins
06:16 PM Revision 4056f14b (cdm-vaadin): jenkins bumping cdmlib.version to 5.45.0
jenkins
06:16 PM Revision 0960c6ad (cdmlib): Updating develop poms back to pre merge state
jenkins
06:16 PM Revision a455abd9 (cdmlib): Merge branch 'master' into develop
jenkins
06:16 PM Revision 27a005dd (cdmlib): updating develop poms to master versions to avoid merge conflicts
jenkins
06:16 PM Revision 28cf4989 (cdmlib): Merge branch 'release/5.45.0'
jenkins
05:52 PM Revision 6acd909f (cdmlib): updating poms for branch'release/5.45.0' with non-snapshot versions
jenkins
05:50 PM Revision b1ca1906 (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.45.0-SNAPSHOT
jenkins
05:50 PM Revision b8a40663 (cdm-webapp): updating poms for 5.46.0-SNAPSHOT development
jenkins
05:50 PM Revision efe9f6de (cdm-webapp): updating poms for 5.45.0 branch with snapshot versions
jenkins
05:50 PM Revision 1e2a3d2e (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.46.0-SNAPSHOT
jenkins
05:49 PM Revision a7df5af2 (taxeditor): Updated version in pom / project files to taxeditor version : 5.46.0-SNAPSHOT and cdmlib version : 5.46.0-SNAPSHOT
jenkins
05:49 PM Revision 9113dabd (taxeditor): Updated version in pom / project files to taxeditor version : 5.45.0 and cdmlib version : 5.45.0
jenkins
05:48 PM Revision f929bb23 (cdm-vaadin): jenkins bumping cdmlib.version to 5.45.0-SNAPSHOT
jenkins
05:48 PM Revision 9124f068 (cdm-vaadin): updating poms for 5.46.0-SNAPSHOT development
jenkins
05:48 PM Revision d82199c6 (cdm-vaadin): updating poms for 5.45.0 branch with snapshot versions
jenkins
05:48 PM Revision 102eb141 (cdm-vaadin): jenkins bumping cdmlib.version to 5.46.0-SNAPSHOT
jenkins
05:47 PM Revision da7112a5 (cdm-server): updating poms for 5.46.0-SNAPSHOT development
jenkins
05:47 PM Revision abf4d036 (cdm-dataportal): updating poms for 5.46.0-SNAPSHOT development
jenkins
05:45 PM bug #10181: Search images do not show thumbnails
Ahh, correct. So we take this as final test after release. Andreas Müller
05:40 PM bug #10181 (Resolved): Search images do not show thumbnails
The link of note-9 is from production. Katja Luther
04:59 PM bug #10181 (Feedback): Search images do not show thumbnails
The link from note-9 still shows a too-large image
![](clipboard-202407311659-em1u3.png)
Andreas Müller
09:56 AM bug #10181 (Resolved): Search images do not show thumbnails
Cichorieae images are rotated now and all thumbnails are correctly shown. For Cyprus the rotation of the images will ... Katja Luther
05:44 PM Revision c627a65a (cdmlib): updating poms for 5.46.0-SNAPSHOT development
jenkins
05:09 PM bug #10563: Specimen selection dialog should show a short description column
For concatenation I suggest to use CdmUtils.concat(CharSequence separator, String... strings). This makes the code mu... Andreas Müller
04:25 PM bug #10563: Specimen selection dialog should show a short description column
Andreas Müller wrote in #note-5:
> Separators should appear only when necessary
>
> ![](clipboard-202407311607-6p...
Katja Luther
04:07 PM bug #10563 (Feedback): Specimen selection dialog should show a short description column
Separators should appear only when necessary
![](clipboard-202407311607-6p4qw.png)
Andreas Müller
02:13 PM bug #10563 (Resolved): Specimen selection dialog should show a short description column
Now also the collectorTitleCache is available in the short label column. I set this to resolved for review, after the... Katja Luther
10:15 AM bug #10563: Specimen selection dialog should show a short description column
Open issues:
* Country + Collector
Andreas Müller
05:02 PM bug #10557: Avoid creating empty annotations in phycobank
Before closing the ticket the empty annotations should be removed in the DB. Andreas Müller
02:31 PM bug #10557 (Resolved): Avoid creating empty annotations in phycobank
Fixed and tested for name annotations, reference annotations, name type annotations and specimen type annotaions Andreas Müller
04:54 PM bug #10568 (Closed): Manifest files should not be shown in dataportal
Katja Luther wrote in #note-15:
> Currently the abcd entry does not contain the mimetype, but we could set it during...
Andreas Müller
04:30 PM bug #10568 (Resolved): Manifest files should not be shown in dataportal
Katja Luther
04:21 PM bug #10568: Manifest files should not be shown in dataportal
Andreas Müller wrote in #note-11:
> Katja Luther wrote in #note-10:
> > There is a media specimen with a manifest fil...
Katja Luther
04:18 PM bug #10568: Manifest files should not be shown in dataportal
Andreas Müller wrote in #note-12:
> Katja Luther wrote in #note-8:
> > Andreas Müller wrote in #note-5:
> > > The ...
Katja Luther
03:28 PM bug #10568 (Feedback): Manifest files should not be shown in dataportal
Andreas Müller
03:28 PM bug #10568: Manifest files should not be shown in dataportal
Katja Luther wrote in #note-8:
> Andreas Müller wrote in #note-5:
> > The code seems to be ok on first glance. But ...
Andreas Müller
03:26 PM bug #10568: Manifest files should not be shown in dataportal
Katja Luther wrote in #note-10:
> There is a media specimen with a manifest file:
>
> The Image is shown, but not...
Andreas Müller
02:58 PM bug #10568: Manifest files should not be shown in dataportal
There is a media specimen with a manifest file:
![](Screenshot 2024-07-31 145549.png)
The Image is shown, but n...
Katja Luther
02:53 PM bug #10568: Manifest files should not be shown in dataportal
Katja Luther wrote in #note-6:
> Andreas Müller wrote in #note-4:
> > Katja Luther wrote in #note-2:
> > > This sh...
Andreas Müller
01:13 PM bug #10568: Manifest files should not be shown in dataportal
Andreas Müller wrote in #note-5:
> The code seems to be ok on first glance. But there seems to be a lot of duplicati...
Katja Luther
10:58 AM bug #10568 (Resolved): Manifest files should not be shown in dataportal
Andreas Müller wrote in #note-4:
> Katja Luther wrote in #note-2:
> > This should be fixed, please review. I will a...
Katja Luther
04:32 PM bug #10576 (New): Set mimetype for json files (manifest) in ABCD import
Follow up for #10568:
Currently the mimentype is not set for manifest.json files coming from ABCD import. We shoul...
Katja Luther
04:25 PM bug #10418 (Closed): Thumbnail loading takes very long in taxon search
Thumbnail loading is much faster now in search. Andreas Müller
10:39 AM bug #10418 (Resolved): Thumbnail loading takes very long in taxon search
Now the thumbnail representation is used for the search display and only one call to get the media, so the loading is... Katja Luther
04:17 PM Revision 6c0483d6 (cdmlib): ref #10568: code deduplication
Katja Luther
03:56 PM bug #9880 (Closed): Add active flag to user bulkeditor
Fixed Andreas Müller
02:25 PM bug #9880 (Resolved): Add active flag to user bulkeditor
This is fixed, please review. Katja Luther
02:28 PM Revision 794b4e09 (cdmlib): ref #10557 add checkEmpty to Annotation
Andreas Müller
02:28 PM Revision b81b8fc9 (cdmlib): cleanup
Andreas Müller
02:25 PM Revision 2891f570 (taxeditor): ref #9880: add active flag to user bulkeditor
Katja
02:24 PM Revision 48327f4e (cdm-vaadin): ref #10557 remove empty annotations during save
Andreas Müller
02:12 PM Revision 9b7b2cd9 (cdmlib): ref #10563: add collector
Katja Luther
02:10 PM Revision d6b40aa5 (cdm-vaadin): cleanup
Andreas Müller
01:17 PM Revision ae85fef3 (cdmlib): ref #10563: set specimen identifier at the end of the string
Katja Luther
01:12 PM Revision d93b0b39 (cdmlib): ref #10568: code cleaning
Katja Luther
11:48 AM feature request #10552: Change default anntotation type for Vaadin submitters to internal (PhycoBank)
Please review. Andreas Müller
11:45 AM feature request #10552 (Resolved): Change default anntotation type for Vaadin submitters to internal (PhycoBank)
Andreas Müller
11:36 AM feature request #10552: Change default anntotation type for Vaadin submitters to internal (PhycoBank)
Wolf-Henning Kusber wrote in #note-6:
> For Vaadin curator the featurer request is perfectly solved.
>
> There is...
Andreas Müller
11:38 AM Revision e5fcc239 (cdm-vaadin): ref #10552 change default editable annotation type for submitters to internal
Andreas Müller
11:04 AM bug #10572 (Closed): Specimens are added to a taxon of not selected classification
New ticket created (#10575), so I close this ticket. Katja Luther
11:04 AM bug #10575 (New): Remaining issues on ABCD import
copied from #10572
* When switching of "Reuse existing taxa" the taxon still seems to be mapped.
* For new taxa ...
Katja Luther
09:59 AM Revision 41975e03 (cdmlib): cleanup
Andreas Müller
09:59 AM Revision 75298784 (cdmlib): fix potential NPE in CondensedDistributionComposer
Andreas Müller

07/30/2024

10:03 PM feature request #10552 (Feedback): Change default anntotation type for Vaadin submitters to internal (PhycoBank)
Andreas Müller
09:54 PM bug #10572: Specimens are added to a taxon of not selected classification
Please create new tickets for open issues that can not be fixed immediately.
The main functionality is as expected...
Andreas Müller
09:53 PM bug #10572 (Feedback): Specimens are added to a taxon of not selected classification
If not choosing any classification for the import but having "Reuse existing taxa when possible" checked but "Create ... Andreas Müller
09:43 PM bug #10572: Specimens are added to a taxon of not selected classification
The "Reuse existing taxa when possible" config param is not remembered for next import while other config params are ... Andreas Müller
09:38 PM bug #10572: Specimens are added to a taxon of not selected classification
The label "Newly created taxa" is misleading as often taxa are not created anew. We should rename to either simply "T... Andreas Müller
09:35 PM bug #10572: Specimens are added to a taxon of not selected classification
For new taxa the sec. reference is not taken from the parent. As this is usually the expected behavior it should at l... Andreas Müller
09:29 PM bug #10572: Specimens are added to a taxon of not selected classification
![](clipboard-202407302129-xxugq.png)
Andreas Müller
09:28 PM bug #10572: Specimens are added to a taxon of not selected classification
When switching of "Reuse existing taxa" the taxon still seems to be mapped.
Andreas Müller
08:40 PM bug #10555: Sorting for doubtful taxa is not correct
Works as expected. Andreas Müller
08:40 PM bug #10555 (Closed): Sorting for doubtful taxa is not correct
Andreas Müller
07:13 PM bug #10559 (Closed): html formatting for sub names
I did not test with an export but the code (especially the test) looks fine. So I guess this is fixed.
@WGB: pleas...
Andreas Müller
07:05 PM feature request #8339: Completely remove the potentially redundant 'acceptedFor' parameter from synonym page
This is related to #10505 so maybe it can be handled together. If not please move to the next milestone. Andreas Müller
07:02 PM bug #10505: Rename synonymy parameter highlite -> highlight
There is a related ticket #8339 which suggests to simply remove the acceptedFor part of the URL eg in https://test.e-... Andreas Müller
06:36 PM feature request #10574 (New): Refine name relationship filter in cdmlight (and maybe other imports)
copied from #10562
A related issue might be that some names related only via a name relation should not be export...
Andreas Müller
06:30 PM bug #10568: Manifest files should not be shown in dataportal
The code seems to be ok on first glance. But there seems to be a lot of duplication of same functionality (checking f... Andreas Müller
06:20 PM bug #10568 (Feedback): Manifest files should not be shown in dataportal
Katja Luther wrote in #note-2:
> This should be fixed, please review. I will add an example to the integration refer...
Andreas Müller
04:03 PM bug #10181 (In Progress): Search images do not show thumbnails
Now thumbnails are now loaded for Althenia filiformis, but the second image is not correctly rotated. Dominik will ha... Katja Luther
01:26 PM Revision 2f1ae2ae (cdm-dataportal): ref #10418: don't get the media a second time
Katja Luther
12:40 PM Revision e9faf99e (cdmlib): ref #10418: add new uri only if all parts match
Katja Luther

07/26/2024

01:55 PM Revision 81a6844a (cdmlib): ref #10563: code cleaning and fix hashcode
Katja Luther
12:08 PM Revision 86ed0d1d (cdmlib): ref #10559: remove whitespace
Katja Luther
11:53 AM bug #10563 (In Progress): Specimen selection dialog should show a short description column
As a first implementation a new column containing collectorsNumber + " - " + collectionCode + " - " + specimenIdenti... Katja Luther
11:53 AM Revision 5fe19a0e (taxeditor): ref #10563: add column with short label
Katja
11:52 AM Revision fc35a521 (cdmlib): ref #10563: add short label for specimen
Katja Luther
11:39 AM Revision b404c372 (cdmlib): ref #10559: adapt test
Katja Luther
11:13 AM Revision 9b7995ff (cdmlib): ref #10559: subname should be without author
Katja Luther
10:19 AM Revision 8a71ea58 (cdmlib): minor
Katja Luther
09:54 AM Revision b32d6e76 (cdmlib): ref #10559: adapt test to html tags for subname
Katja Luther

07/25/2024

02:16 PM bug #10559 (Resolved): html formatting for sub names
This should be fixed. Katja Luther
02:16 PM Revision 30165ca8 (cdmlib): ref #10559: add html tags to subname
Katja Luther
02:10 PM bug #10572 (Resolved): Specimens are added to a taxon of not selected classification
I tested with C. macedonica and C. graeca and all specimen are moved to the taxa already in centaurea classification ... Katja Luther
11:33 AM bug #10572 (In Progress): Specimens are added to a taxon of not selected classification
Need some more time to test all configuration possibilities Katja Luther
10:40 AM bug #10572: Specimens are added to a taxon of not selected classification
Konstantina Koutroumpa wrote in #note-2:
> What about Centaurea macedonica? All 15 specimens are determined as C. mac...
Katja Luther
09:48 AM bug #10572: Specimens are added to a taxon of not selected classification
What about Centaurea macedonica? All 15 specimens are determined as C. macedonica but they were all imported in the F... Konstantina Koutroumpa
09:05 AM bug #10572 (Resolved): Specimens are added to a taxon of not selected classification
The problem appeared if the determination of the specimen was a infraspecific taxon and the parent a taxon contained ... Katja Luther
02:00 PM Revision 703362e4 (cdmlib): ref #10572: some more adaptions, fix creation of new nodes - continue
Katja Luther
01:20 PM bug #10573: type [icon] from the literature cited without multimedia item (PhycoBank, Portal)
Yes, it ist is related to bug #10426. For PhycoBank this is a new bug, because the display was correct. Wolf-Henning Kusber
01:16 PM bug #10573: type [icon] from the literature cited without multimedia item (PhycoBank, Portal)
maybe this is a duplicate for #10426 Katja Luther
12:10 PM bug #10573: type [icon] from the literature cited without multimedia item (PhycoBank, Portal)
The error occurs (25 July 2024 12:10) on the name-page for Mallomonopsis elliptica Matv.
URL: https://www.phycobank....
Wolf-Henning Kusber
11:56 AM bug #10573 (New): type [icon] from the literature cited without multimedia item (PhycoBank, Portal)
Example: http://phycobank.org/104821
If icons/figures are cited as types, PhycoBank (currently >99%) cites the image...
Wolf-Henning Kusber
11:16 AM Revision b6c5b93b (cdmlib): ref #10572: some more adaptions
Katja Luther
09:03 AM Revision a1adb4c6 (cdmlib): ref #10572: fix handling of infraspecific taxa in abcd import
Katja Luther

07/24/2024

12:34 PM Revision 4b796078 (cdmlib): ref #10418: fix ws if parameters missing
Katja Luther
12:32 PM bug #10418: Thumbnail loading takes very long in taxon search
Andreas Müller wrote in #note-17:
> > Here the problem was, that the images weren't available anymore. I adapted the...
Katja Luther
09:45 AM Revision 0689d9ab (cdm-dataportal): fix not shown image thumbnails
Katja Luther

07/23/2024

09:39 AM Revision f81e36c3 (cdm-dataportal): revert index change
Katja Luther
09:10 AM Revision 8679af95 (cdm-dataportal): adapt tests to adapted images
Katja Luther

07/22/2024

05:07 PM bug #10572 (Closed): Specimens are added to a taxon of not selected classification
An via ABCD imported specimen sometimes added to a taxon belonging to another classification than the selected one.
...
Katja Luther
04:59 PM Revision c3e1c70d (cdmlib): ref #10568: fix NPE
Katja Luther
04:15 PM bug #10549 (Discussed): Move exsiccatum to field unit
AM:
in one of the last user meeting we discussed that the exsiccatum information in type designation formatting sho...
Andreas Müller
02:27 PM discussion #10403: Should syn. sec. be part of the homotypical group instead of single synonym?
WGB + NaK:
Hallo,
ich hatte mir folgendes überlegt, zu schreiben, Fragen zu Deinem Ausgabevorschlag unten in rot:
=...
Andreas Müller
01:58 PM bug #10568 (Resolved): Manifest files should not be shown in dataportal
This should be fixed, please review. I will add an example to the integration reference DB, the example is Centaurea ... Katja Luther
01:57 PM Revision 822b4438 (cdmlib): ref #10568: filter for mimetype
Katja Luther
01:54 PM Revision 3bf7d4f4 (cdmlib): ref #10568: add mimetype for json files
Katja Luther
01:22 PM Revision 713bc024 (cdmlib): ref #10568: filter media with json at the end of uri (manifest files)
Katja Luther

07/21/2024

04:16 PM feature request #3369 (Rejected): Lucene search factory or builder implemented
There is no such field in eu.etaxonomy.cdm.config.Configuration anymore and also not elsewhere in the code. Also it d... Andreas Müller
04:07 PM feature request #10069 (In Progress): Upgrade hibernate search and lucene to hs6+ and lucene 8+
Andreas Müller

07/19/2024

11:01 AM bug #10567: Fix copyright sign for all copyright informations
It looks good to me too. Konstantina Koutroumpa
10:35 AM bug #10567 (Closed): Fix copyright sign for all copyright informations
To me it looks correct now. Konstantina, maybe you also want to have a look? The link to the adapted image(s) is here... Andreas Müller
08:45 AM bug #10567: Fix copyright sign for all copyright informations
Andreas Müller wrote in #note-4:
> Do you have an example image for reviewing?
On test cichorieae I added for the...
Katja Luther
10:29 AM Revision 94cc88ce (cdm-vaadin): ref #10505 adapt highlite->highlight in vaadin (cont.)
Andreas Müller
10:28 AM bug #10505 (Closed): Rename synonymy parameter highlite -> highlight
Upps, sorry, for some reason my workspace was not fully up-to-date.
But at least, this way I found some more appeara...
Andreas Müller
10:23 AM bug #10505: Rename synonymy parameter highlite -> highlight
Andreas Müller wrote in #note-14:
> Katja Luther wrote in #note-13:
> > Andreas Müller wrote in #note-12:
> > > In...
Katja Luther

07/18/2024

07:52 PM Revision 743e7691 (cdmlib): cleanup
Andreas Müller
06:38 PM bug #10567: Fix copyright sign for all copyright informations
Do you have an example image for reviewing? Andreas Müller
04:37 PM bug #10567 (Resolved): Fix copyright sign for all copyright informations
This should be fixed. Katja Luther
04:34 PM Revision 4bdb8102 (cdmlib): ref #10567: fix copyright handling
Katja Luther
02:47 PM Revision 89d2b1ab (cdmlib): cleanup
Andreas Müller
02:46 PM Revision bd2ee0c9 (cdmlib): fix typo (standart->standard)
Andreas Müller
12:40 PM bug #10571 (New): Improve character data in details page
Currently the details page for specimen shows the character data in a table which looks ok as long as the labels and ... Katja Luther
12:30 PM bug #10570 (New): Fix deduplication of authors in ABCD import
After importing specimen via ABCD import, the database is flooded with duplicated authors. The ABCD import need to de... Katja Luther
12:30 PM bug #10505: Rename synonymy parameter highlite -> highlight
Katja Luther wrote in #note-13:
> Andreas Müller wrote in #note-12:
> > In Cichorieae_NamePageTest the word highlit...
Andreas Müller
11:18 AM bug #10505: Rename synonymy parameter highlite -> highlight
Andreas Müller wrote in #note-12:
> In Cichorieae_NamePageTest the word highlite is still used 2x as it is used as p...
Katja Luther
10:53 AM bug #10505: Rename synonymy parameter highlite -> highlight
In Cichorieae_NamePageTest the word highlite is still used 2x as it is used as php-class name. Can you please adapt t... Andreas Müller
12:28 PM bug #10569 (New): Improvements for point maps
There are two requirements for point maps:
1. Different symbols or colors of the symbol for co-ordinates that do n...
Katja Luther
11:31 AM bug #10418: Thumbnail loading takes very long in taxon search
Andreas Müller wrote in #note-18:
> Katja Luther wrote in #note-15:
> > The algorithm to get the best matching repres...
Katja Luther
10:38 AM bug #10418: Thumbnail loading takes very long in taxon search
Katja Luther wrote in #note-15:
> The algorithm to get the best matching representation of a file seems to be not de...
Andreas Müller
10:37 AM bug #10418: Thumbnail loading takes very long in taxon search
> Here the problem was, that the images weren't available anymore. I adapted the uris and now the search is much fast... Andreas Müller
10:47 AM Revision c0da2e91 (cdm-vaadin): ref #10505 adapt highlite->highlight in vaadin
Andreas Müller
10:46 AM Revision cbb14b09 (cdmlib): cleanup
Andreas Müller
10:46 AM Revision 3da79d69 (cdmlib): ref #10505 adapt highlite->highlight in WfoBackboneExport
Andreas Müller

07/17/2024

11:06 PM Revision dc4d5024 (cdmlib): cleanup
Andreas Müller
10:29 PM bug #10566: Implement a webservice for checking new scans for existing specimen
Why should this be a webservice Andreas Müller
05:28 PM Revision cba43f73 (cdm-dataportal): fix link handling
Katja Luther
05:20 PM Revision 63a0093f (cdmlib): ref #10525: Normalized output score
Belen Escobari
03:26 PM bug #10559: html formatting for sub names
I guess sub names are nameUsedInSource for sec references Andreas Müller
12:13 AM Revision 896535f3 (cdmlib): cleanup
Andreas Müller

07/16/2024

06:21 PM Revision 42606af6 (cdmlib): reenable OaiPmhViewTest
Andreas Müller
03:42 PM bug #10568 (Closed): Manifest files should not be shown in dataportal
The manifest files coming with the import of specimen, but should not be shown in dataportal.
We decided that it m...
Katja Luther
02:34 PM bug #10567 (Closed): Fix copyright sign for all copyright informations
The copyright sign is only shown, if the copyright information comes from the cdm db, but should be shown also for th... Katja Luther
02:17 PM bug #10566 (New): Implement a webservice for checking new scans for existing specimen
If already imported specimens get new herbarium scans we need funtionality to call a webservice getting the informati... Katja Luther
02:13 PM bug #10565 (New): Refresh after deleting media
After deleting a media from a taxon, the media view is not updated and the deleted media is still shown also after save. Katja Luther
02:12 PM bug #10564 (New): Move media to another taxon
Currently the move operation is available only for factual data but not for media. We need this functionality also fo... Katja Luther
02:07 PM bug #10563 (Closed): Specimen selection dialog should show a short description column
In the specimen selection dialog of the matrix currently the titlecache is used as identification column, but sometim... Katja Luther
10:09 AM Revision 12f33203 (cdmlib): ref #10525: corrected decimal format in tests
Belen Escobari
 

Also available in: Atom