Project

General

Profile

Actions

bug #825

closed

DefinedTermDaoImpl - missleading method names

Added by Andreas Kohlbecker over 13 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
New
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
major
Found in Version:
Tags:

Description

DefinedTermDaoImpl implements

findByTitle(String queryString);
findByTitle(String queryString, CdmBase sessionObject);

which is declared in ITitledDao. The name suggests a search by title the implementation however does a search by label. All other findByTitle methods are implemented correctly.

Actions #1

Updated by Andreas Kohlbecker over 13 years ago

  • Severity changed from normal to major
Actions #2

Updated by Andreas Müller almost 13 years ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Andreas K., could you please check if this has been fixed by Ben's latest work on CdmLibraryConventions?

Actions #3

Updated by Andreas Kohlbecker almost 13 years ago

  • Target version changed from CDM lib Release 2.0 to CDM lib Release 2.3
Actions #4

Updated by Andreas Müller about 1 year ago

  • Description updated (diff)
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • Target version changed from cdmlib - Old Next Major Release to Release 5.35

This is still an open issue.

Actions #5

Updated by Andreas Müller about 1 year ago

  • Tags set to fast
Actions #6

Updated by Andreas Kohlbecker about 1 year ago

  • Private changed from Yes to No
Actions #7

Updated by Andreas Müller about 1 year ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #8

Updated by Andreas Müller about 1 year ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

This is fixed. Please review.

As the old method findByTitle which did override the same labeled parent method seems to be only called by test methods there seems to be no danger that this change created a regression as it is not API but dao.

Actions #9

Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 5.35 to Release 5.27
Actions #10

Updated by Andreas Kohlbecker about 1 year ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 50 to 100

fully solved

Actions

Also available in: Atom PDF