Project

General

Profile

bug #9821

Description sources shown for description elements should not be editable

Added by Andreas Müller about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
10/20/2021
Due date:
% Done:

100%

Severity:
normal
Found in Version:
Tags:

Description

Since #7774 sources for descriptions are shown in the details view for description elements.
However, they should not be editable there to avoid misunderstandings. But currently they are.
We should disable them.


Related issues

Related to Edit - feature request #7774: Show description source for description elements Closed 09/20/2018

Associated revisions

Revision 4351685c (diff)
Added by Katja Luther about 1 month ago

ref #9821: sources of description should not be editable

Revision a9cd0534 (diff)
Added by Katja Luther about 1 month ago

ref #9821: all sources of description should be disabled

Revision df3a895a (diff)
Added by Katja Luther about 1 month ago

ref #9821: renderContent needs to overrite

Revision d146cd8f (diff)
Added by Katja Luther about 1 month ago

ref #9821: no references yet should be shown only once

Revision d0198e95 (diff)
Added by Katja Luther 28 days ago

ref #9821: disable sources for computed and cloned descriptions

Revision 6d9a00e0 (diff)
Added by Katja Luther 28 days ago

ref #9821: disable sources for computed and cloned descriptions - continue

History

#1 Updated by Andreas Müller about 1 month ago

#2 Updated by Katja Luther about 1 month ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This should be fixed. Please review.

#3 Updated by Andreas Müller about 1 month ago

  • Assignee changed from Andreas Müller to Katja Luther

#4 Updated by Katja Luther about 1 month ago

  • Assignee changed from Katja Luther to Andreas Müller

Tested with Descripta prima Dall. in Descriptive DS test.

Categorical as well as quantitative data worked as expected.

#5 Updated by Andreas Müller about 1 month ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 30

It works for sources loaded during the session but not yet for sources created during the session.

I created a new sources for a description and then went to the description element and could edit the source there. After reopening the taxon it worked as expected.

#6 Updated by Katja Luther about 1 month ago

  • Status changed from Feedback to Resolved

Andreas Müller wrote:

It works for sources loaded during the session but not yet for sources created during the session.

I created a new sources for a description and then went to the description element and could edit the source there. After reopening the taxon it worked as expected.

This was not a problem of a new source, but of more than one source, this problem is fixed.
Tested with nightly:
* Open Descripta secunda Gall. add a new source to the description "Distributions for Descripta secunda Gall." add a new source and switch to one of the distributions
* the source is shown and disabled.
* but still a problem if the section is collapsed before.

#7 Updated by Andreas Müller about 1 month ago

  • Target version changed from Release 5.29 to Release 5.28

#8 Updated by Katja Luther about 1 month ago

  • Status changed from Resolved to In Progress

#9 Updated by Katja Luther about 1 month ago

Katja Luther wrote:

Andreas Müller wrote:

It works for sources loaded during the session but not yet for sources created during the session.

I created a new sources for a description and then went to the description element and could edit the source there. After reopening the taxon it worked as expected.

This was not a problem of a new source, but of more than one source, this problem is fixed.
Tested with nightly:
* Open Descripta secunda Gall. add a new source to the description "Distributions for Descripta secunda Gall." add a new source and switch to one of the distributions
* the source is shown and disabled.
* but still a problem if the section is collapsed before.

this should be fixed, now

#10 Updated by Katja Luther about 1 month ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • Target version changed from Release 5.28 to Release 5.29

Katja Luther wrote:

Katja Luther wrote:

Andreas Müller wrote:

It works for sources loaded during the session but not yet for sources created during the session.

I created a new sources for a description and then went to the description element and could edit the source there. After reopening the taxon it worked as expected.

This was not a problem of a new source, but of more than one source, this problem is fixed.
Tested with nightly:
* Open Descripta secunda Gall. add a new source to the description "Distributions for Descripta secunda Gall." add a new source and switch to one of the distributions
* the source is shown and disabled.
* but still a problem if the section is collapsed before.

this should be fixed, now

tested with nightly and is fixed. please review.

#11 Updated by Andreas Müller about 1 month ago

  • Target version changed from Release 5.29 to Release 5.28

I guess the change of milestone was accidentally

#12 Updated by Andreas Müller about 1 month ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 30 to 100

Works as expected.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)