Project

General

Profile

Actions

bug #9630

closed

Make the handling of computed description configurable

Added by Katja Luther over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

80%

Estimated time:
Severity:
normal
Found in Version:
Tags:

Description

from #8471:

This ticket is not meant to completely make the computed descriptions invisible. By default they should only be disabled for editing. But ofcourse it might be even better if this can be made configurable (e.g. 3 states: editable, disabled for editing, invisible) with default to disabled for editing.


Related issues

Related to EDIT - feature request #8471: Computed descriptions should be disabled in TaxEditorClosedKatja Luther

Actions
Actions #1

Updated by Katja Luther over 1 year ago

Actions #2

Updated by Katja Luther over 1 year ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

this is fixed, please review.

Actions #3

Updated by Katja Luther over 1 year ago

  • Status changed from Resolved to In Progress
  • Assignee changed from Andreas Müller to Katja Luther
Actions #4

Updated by Katja Luther over 1 year ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I think now it works, please review

Actions #5

Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 50

When selection is "Enabled" the supplemental data and the sources are still disabled. Tested with rem_conf_am/->Species "Testaggregation species"->Germany
Enablement works ok for area and status and timescope

Actions #6

Updated by Andreas Müller over 1 year ago

When "disabled" is selected, timescope is still editable (I have only checked distributions no other descriptions)

Actions #7

Updated by Andreas Müller over 1 year ago

"Invisible" works as expected

Actions #8

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

When "disabled" is selected, timescope is still editable (I have only checked distributions no other descriptions)

this is fixed with the last commit

Actions #9

Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.25 to Release 5.24
Actions #10

Updated by Andreas Müller over 1 year ago

The detail fields in timescope are still editable with "disabled"

Actions #11

Updated by Andreas Müller over 1 year ago

And supplemental data of not-computed dara are not editable with "disabled"

Actions #12

Updated by Andreas Müller over 1 year ago

Andreas Müller wrote:

And supplemental data of not-computed dara are not editable with "disabled"

... but only if a "computed" description was selected before

Actions #13

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

Andreas Müller wrote:

And supplemental data of not-computed dara are not editable with "disabled"

... but only if a "computed" description was selected before

this is fixed.

Actions #14

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

The detail fields in timescope are still editable with "disabled"

In my local installation the fields are not greyed, but they are not editable, have to check it with nightly.

Actions #15

Updated by Andreas Müller over 1 year ago

Katja Luther wrote:

Andreas Müller wrote:

The detail fields in timescope are still editable with "disabled"

In my local installation the fields are not greyed, but they are not editable, have to check it with nightly.

Have you tested with an empty field? Be aware that the fields have a maximum number of digits that can be entered.

Actions #16

Updated by Andreas Müller over 1 year ago

  • Tags set to additivity
  • Status changed from Feedback to Resolved
  • % Done changed from 50 to 80

Works now as expected for distributions but needs to be tested for structured descriptions (open new ticket if necessary).

Code still needs to be cleanup (lot of commented code)

Actions #17

Updated by Katja Luther over 1 year ago

  • Status changed from Resolved to Closed

Code is cleaned up. I check the structured descriptions and create a new ticket if necessary.

Actions #18

Updated by Katja Luther about 1 year ago

Added check whether a d&d target is a computed description.

Actions

Also available in: Atom PDF