Project

General

Profile

bug #9630

Make the handling of computed description configurable

Added by Katja Luther 5 months ago. Updated 27 days ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
05/19/2021
Due date:
% Done:

80%

Severity:
normal
Found in Version:
Tags:

Description

from #8471:

This ticket is not meant to completely make the computed descriptions invisible. By default they should only be disabled for editing. But ofcourse it might be even better if this can be made configurable (e.g. 3 states: editable, disabled for editing, invisible) with default to disabled for editing.


Related issues

Related to Edit - feature request #8471: Computed descriptions should be disabled in TaxEditor Closed 12/18/2018

Associated revisions

Revision 3012f271 (diff)
Added by Katja Luther 5 months ago

ref #9630: add PreferencePredicate for computed Descriptions

Revision 0ab60230 (diff)
Added by Katja Luther 5 months ago

ref #9630: make computed descriptions handling configurable

Revision 12521139 (diff)
Added by Katja Luther 5 months ago

ref #9630: make computed descriptions handling configurable - adapt handler

Revision 7fcccab7 (diff)
Added by Katja Luther 5 months ago

ref #9630: make computed descriptions handling configurable - adapt content and label provider

Revision bc2df6ea (diff)
Added by Katja Luther 5 months ago

ref #9630: make computed descriptions handling configurable - avoid IAE

Revision 49fc34f0 (diff)
Added by Katja Luther 5 months ago

ref #9630: override toString()

Revision 85f3df99 (diff)
Added by Katja Luther 5 months ago

ref #9630: avoid IAE continue

Revision 13555b11 (diff)
Added by Katja Luther 5 months ago

ref #9630: fix time period disabling and supplemental data enabling

Revision 33f8af3e (diff)
Added by Katja Luther 5 months ago

ref #9630: default value for enable description element source is true

Revision 093e7cd5 (diff)
Added by Katja Luther 5 months ago

ref #8776, #9630: d&d from voc to tree and disable time period if fact is disabled

Revision 2daf0f0b (diff)
Added by Katja Luther 5 months ago

ref #9630: setEnabled to source section

Revision 1df9cf60 (diff)
Added by Katja Luther 27 days ago

ref #9630: d&d should not allowed to a computed description if

History

#1 Updated by Katja Luther 5 months ago

#2 Updated by Katja Luther 5 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

this is fixed, please review.

#3 Updated by Katja Luther 5 months ago

  • Status changed from Resolved to In Progress
  • Assignee changed from Andreas Müller to Katja Luther

#4 Updated by Katja Luther 5 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I think now it works, please review

#5 Updated by Andreas Müller 5 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 50

When selection is "Enabled" the supplemental data and the sources are still disabled. Tested with rem_conf_am/->Species "Testaggregation species"->Germany
Enablement works ok for area and status and timescope

#6 Updated by Andreas Müller 5 months ago

When "disabled" is selected, timescope is still editable (I have only checked distributions no other descriptions)

#7 Updated by Andreas Müller 5 months ago

"Invisible" works as expected

#8 Updated by Katja Luther 5 months ago

Andreas Müller wrote:

When "disabled" is selected, timescope is still editable (I have only checked distributions no other descriptions)

this is fixed with the last commit

#9 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.24

#10 Updated by Andreas Müller 5 months ago

The detail fields in timescope are still editable with "disabled"

#11 Updated by Andreas Müller 5 months ago

And supplemental data of not-computed dara are not editable with "disabled"

#12 Updated by Andreas Müller 5 months ago

Andreas Müller wrote:

And supplemental data of not-computed dara are not editable with "disabled"

... but only if a "computed" description was selected before

#13 Updated by Katja Luther 5 months ago

Andreas Müller wrote:

Andreas Müller wrote:

And supplemental data of not-computed dara are not editable with "disabled"

... but only if a "computed" description was selected before

this is fixed.

#14 Updated by Katja Luther 5 months ago

Andreas Müller wrote:

The detail fields in timescope are still editable with "disabled"

In my local installation the fields are not greyed, but they are not editable, have to check it with nightly.

#15 Updated by Andreas Müller 5 months ago

Katja Luther wrote:

Andreas Müller wrote:

The detail fields in timescope are still editable with "disabled"

In my local installation the fields are not greyed, but they are not editable, have to check it with nightly.

Have you tested with an empty field? Be aware that the fields have a maximum number of digits that can be entered.

#16 Updated by Andreas Müller 5 months ago

  • Tags set to additivity
  • Status changed from Feedback to Resolved
  • % Done changed from 50 to 80

Works now as expected for distributions but needs to be tested for structured descriptions (open new ticket if necessary).

Code still needs to be cleanup (lot of commented code)

#17 Updated by Katja Luther 5 months ago

  • Status changed from Resolved to Closed

Code is cleaned up. I check the structured descriptions and create a new ticket if necessary.

#18 Updated by Katja Luther 27 days ago

Added check whether a d&d target is a computed description.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)