Project

General

Profile

bug #9819

Rename "Nameeditor" to "Taxon Editor" in menus

Added by Andreas Müller about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Severity:
normal
Found in Version:
Tags:

Description

follow up for #9744

Currently the "open in" context menu still uses Nameeditor.

Please also check for other occurrences of the old label.


Related issues

Follows Edit - task #9744: Find suitable name for the Freetext- or Name-Editor Closed 09/03/2021
Copied to Edit - task #9827: Rename taxeditor code from name editor to taxon editor New 10/26/2021

Associated revisions

Revision 25302047 (diff)
Added by Katja Luther about 1 month ago

ref #9819: rename name editor to taxon editor in menues

Revision 7a683d4e (diff)
Added by Katja Luther about 1 month ago

ref #9819: one file was missing

Revision 7d4a750b (diff)
Added by Katja Luther about 1 month ago

ref #9819: still some occurences of Namens-Editor, move to taxon editor

Revision d7f7dcb0 (diff)
Added by Katja Luther about 1 month ago

remove unused labels

History

#1 Updated by Andreas Müller about 1 month ago

  • Due date set to 09/06/2021
  • Start date changed from 10/18/2021 to 09/06/2021
  • Follows task #9744: Find suitable name for the Freetext- or Name-Editor added

#2 Updated by Andreas Müller about 1 month ago

  • Due date deleted (09/06/2021)
  • Start date deleted (09/06/2021)

#3 Updated by Andreas Müller about 1 month ago

  • Tags set to fast

#4 Updated by Katja Luther about 1 month ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Searched for all "Namenseditor" and "name editor" strings and replaced it by "taxon editor"/"Taxon Editor"

#5 Updated by Andreas Müller about 1 month ago

  • Assignee changed from Andreas Müller to Katja Luther

#6 Updated by Katja Luther about 1 month ago

  • Assignee changed from Katja Luther to Andreas Müller

Tested in taxon navigator and bulk editor and open in ... shows "taxon editor"

#7 Updated by Andreas Müller about 1 month ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 30

Please check that always both translations are adapted. E.g. there is a change in eu.etaxonomy.taxeditor.bulkeditor/OSGI-INF/l10n/bundle.properties but not in bundle_de.properties. This is highly unexpected. More such cases exist.

Did you check all the changes that they are really about labeling the former name editor? I just ask but didn't check myself.

#8 Updated by Katja Luther about 1 month ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

Please check that always both translations are adapted. E.g. there is a change in eu.etaxonomy.taxeditor.bulkeditor/OSGI-INF/l10n/bundle.properties but not in bundle_de.properties. This is highly unexpected. More such cases exist.

Did you check all the changes that they are really about labeling the former name editor? I just ask but didn't check myself.

Yes I checked that the changes only about the former name editor, found some occurences of "Namens-Editor", changed this also to "Taxon Editor"

#9 Updated by Andreas Müller about 1 month ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 30 to 40

Have you checked partdescriptor.label.2 in eu.etaxonomy.taxeditor.editor/OSGI-INF/l10n/plugin_de.properties ? And colorDefinition.label.14 in eu.etaxonomy.taxeditor.store/OSGI-INF/l10n/bundle.properties ?

Once this is done we can close the ticket. However, we should think about a new ticket to adapt also code to the new labels. E.g. command.name.OPEN_NAME_EDITOR_FOR_TAXON_NODE should better be called command.name.OPEN_TAXON_EDITOR_FOR_TAXON_NODE or in eu.etaxonomy.taxeditor.perspective.Default the variable NAME_EDITOR should be renamed and for sure there are many other such possible renamings. Preferable we should have a strict distinction for using "taxon_editor" like code attribute names for all code related to the old "name editor" and "taxon_bulk_editor" like names for all taxon bulk editor like names.

#10 Updated by Katja Luther about 1 month ago

Andreas Müller wrote:

Have you checked partdescriptor.label.2 in eu.etaxonomy.taxeditor.editor/OSGI-INF/l10n/plugin_de.properties ? And colorDefinition.label.14 in eu.etaxonomy.taxeditor.store/OSGI-INF/l10n/bundle.properties ?

all colorDefinitions are not used anymore, I remove it.
the partdescriptor label was missing.

Once this is done we can close the ticket. However, we should think about a new ticket to adapt also code to the new labels. E.g. command.name.OPEN_NAME_EDITOR_FOR_TAXON_NODE should better be called command.name.OPEN_TAXON_EDITOR_FOR_TAXON_NODE or in eu.etaxonomy.taxeditor.perspective.Default the variable NAME_EDITOR should be renamed and for sure there are many other such possible renamings. Preferable we should have a strict distinction for using "taxon_editor" like code attribute names for all code related to the old "name editor" and "taxon_bulk_editor" like names for all taxon bulk editor like names.

#11 Updated by Andreas Müller about 1 month ago

  • Copied to task #9827: Rename taxeditor code from name editor to taxon editor added

#12 Updated by Andreas Müller about 1 month ago

Andreas Müller wrote:

Once this is done we can close the ticket. However, we should think about a new ticket to adapt also code to the new labels. E.g. command.name.OPEN_NAME_EDITOR_FOR_TAXON_NODE should better be called command.name.OPEN_TAXON_EDITOR_FOR_TAXON_NODE or in eu.etaxonomy.taxeditor.perspective.Default the variable NAME_EDITOR should be renamed and for sure there are many other such possible renamings. Preferable we should have a strict distinction for using "taxon_editor" like code attribute names for all code related to the old "name editor" and "taxon_bulk_editor" like names for all taxon bulk editor like names.

I put this to a new ticket #9827

#13 Updated by Andreas Müller about 1 month ago

  • Status changed from Feedback to Closed
  • Target version changed from Release 5.29 to Release 5.28
  • % Done changed from 40 to 100

I guess we can close this ticket now.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)