Project

General

Profile

bug #9807

Matrix should not collapse after aggregation

Added by Andreas Müller about 2 months ago. Updated 27 days ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
10/11/2021
Due date:
% Done:

10%

Severity:
normal
Found in Version:

Description

As the refresh after aggregation lead to row duplications (of taxa and maybe others) it was temporarily implemented in 5.27 to fully reload the dataset after aggregation.

This results in a collapsed tree and in bad performance as the full dataset is reloaded.

We need to find out what caused the row duplication and try to fix it.


Related issues

Related to Edit - feature request #9805: Open issues for DDS aggregation dialogue New 10/11/2021
Related to Edit - bug #9015: Comparator for Character Matrix creates strange result Resolved 05/14/2020
Related to Edit - bug #9843: When adding new descriptions it should not be necessary to load the complete matrix Resolved 11/03/2021

Associated revisions

Revision 727c9cd2 (diff)
Added by Katja Luther about 1 month ago

expand matrix after aggregation

History

#1 Updated by Andreas Müller about 2 months ago

#2 Updated by Andreas Müller about 2 months ago

AM 2021-10-1:

... Wir müssten also entweder doch herausfinden, woran es liegt, dass diese zusätzlichen Knoten entstehen. Kann man das debuggen?
Oder herausfinden, wie man den Expansionstate wieder herstellt und die Spalten Reihenfolge + Ausblendung, wenn wir bei der jetzigen völligen Neuberechnung bleiben.

Übrigens ist das bisher als asynchrone longrunnig task implementiert, oder? Man kann also weiter editieren während die Aggregation läuft. Das klingt gefährlich, wenn danach die Daten komplett geupdated werden aus der DB. Ich denke zumindest die Matrix müsste während der Aggregation disabled werden um Problem zu verhindern.

#3 Updated by Katja Luther about 1 month ago

  • Status changed from New to Resolved
  • Target version changed from Release 5.29 to Release 5.28

this is fixed.

#4 Updated by Katja Luther about 1 month ago

  • Assignee changed from Katja Luther to Andreas Müller

please review

#5 Updated by Andreas Müller 29 days ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 10

The current solution solves that the matrix is completely collapsed which is helpful. However the aim is to keep it expanded in the same state as it was before and to not reload the full matrix as this takes time. We only need to load the aggregation records and to add/update them where necessary.

#6 Updated by Andreas Müller 28 days ago

  • Related to bug #9015: Comparator for Character Matrix creates strange result added

#7 Updated by Andreas Müller 28 days ago

Andreas Müller wrote:

The current solution solves that the matrix is completely collapsed which is helpful. However the aim is to keep it expanded in the same state as it was before and to not reload the full matrix as this takes time. We only need to load the aggregation records and to add/update them where necessary.

Maybe the original problem was already described in #9015. So it might be only a comparator issue. Could you check this?

#8 Updated by Katja Luther 27 days ago

  • Related to bug #9843: When adding new descriptions it should not be necessary to load the complete matrix added

#9 Updated by Katja Luther 27 days ago

Create a new ticket, because the original problem is solved but a nicer solution should be implemented.(#9843)

#10 Updated by Katja Luther 27 days ago

  • Status changed from Feedback to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)