Project

General

Profile

Actions

task #8379

closed

Review strange specimen implementations

Added by Andreas Kohlbecker about 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
major
Tags:

Description

Please

I am repeating according comments from the original tickets here:


#8370

Important for the review is to understand why the bug was introduced with cdm-dataportal|e89c1115 this was for sure in the attempt to fix another problem.


#8368

After fixing the problems in this code i noticed that this code is not generating any output at all.

I attempted to base the code on existing functions and wrote the following lines:

        if(isset($specimen_or_observation->specimenTypeDesignations) && count($specimen_or_observation->specimenTypeDesignations) > 0){
          // $specimen_or_observation->specimenTypeDesignations are DTOs
          $specimen_type_designation_map = array();
          foreach($specimen_or_observation->specimenTypeDesignations as $stdDTO){
            if(!isset($specimen_type_designation_map[$stdDTO->typeStatus])){
              $specimen_type_designation_map[$stdDTO->typeStatus] = array();
            }
            $specimen_type_designation_map[$stdDTO->typeStatus][] = $stdDTO;
          }
          $items['data'] = compose_specimen_type_designations($specimen_type_designation_map);
        }

I removed them again and left the original code as it is. This code was introduced in cdm-dataportal|b3ac03bf

TODO: check if it is feasible to simplify and unify the code by using compose_specimen_type_designations(). (low priority)


Related issues

Related to EDIT - task #8419: Harmonization of the different specimen representationsIn ProgressAndreas Kohlbecker

Actions
Copied from EDIT - bug #8368: problems in compose_cdm_specimen_or_observation_tree_entry()ClosedAndreas Kohlbecker

Actions
Copied from EDIT - bug #8370: feature blocks created by compose_description_element_individuals_association() are brokenClosedAndreas Kohlbecker

Actions
Actions #1

Updated by Andreas Kohlbecker about 3 years ago

  • Copied from bug #8368: problems in compose_cdm_specimen_or_observation_tree_entry() added
Actions #2

Updated by Andreas Kohlbecker about 3 years ago

  • Copied from bug #8370: feature blocks created by compose_description_element_individuals_association() are broken added
Actions #3

Updated by Katja Luther about 3 years ago

  • Target version changed from Release 5.10 to Release 5.11
Actions #4

Updated by Katja Luther almost 3 years ago

  • Target version changed from Release 5.11 to Release 5.12
Actions #5

Updated by Katja Luther over 2 years ago

  • Target version changed from Release 5.12 to Release 5.13
Actions #6

Updated by Katja Luther over 2 years ago

  • Target version changed from Release 5.13 to Release 5.14
Actions #7

Updated by Katja Luther over 2 years ago

  • Target version changed from Release 5.14 to Release 5.15
Actions #8

Updated by Andreas Müller over 2 years ago

  • Assignee changed from Katja Luther to Andreas Kohlbecker

I think we decided to move this issue to AK. Please correct me if wrong.

Please also decide which milestone it should go to, but definetely it should not be postponed to much as a good specimen is a more and more important requirement.

Actions #9

Updated by Andreas Kohlbecker over 2 years ago

  • Description updated (diff)

Andreas Müller wrote:

I think we decided to move this issue to AK. Please correct me if wrong.

Yes, exactly. But I will definitely need Katja to help shed more light on the original requirements and expectations.

Please also decide which milestone it should go to, but definetely it should not be postponed to much as a good specimen is a more and more important requirement.

Milestone 5.15 seems like realistic perspective to me

Actions #10

Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.15 to Release 5.18
Actions #11

Updated by Andreas Kohlbecker about 2 years ago

  • Related to task #8419: Harmonization of the different specimen representations added
Actions #12

Updated by Andreas Kohlbecker almost 2 years ago

  • Description updated (diff)
Actions #13

Updated by Andreas Kohlbecker almost 2 years ago

  • Target version changed from Release 5.18 to Release 5.19

TODO: final check

Actions #14

Updated by Andreas Kohlbecker over 1 year ago

  • Target version changed from Release 5.19 to Release 5.21
Actions #15

Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.21 to Release 5.22
Actions #16

Updated by Andreas Kohlbecker over 1 year ago

  • Target version changed from Release 5.22 to Release 5.25
Actions #17

Updated by Andreas Müller about 1 year ago

  • Tags set to specimen
  • Tracker changed from report to task
  • Status changed from New to Resolved

According to note 13 this only needs a final check. So I put it on resolved in case it is fixed and only needs review.

Actions #18

Updated by Andreas Kohlbecker about 1 year ago

  • Target version changed from Release 5.25 to Release 5.35

moving to next milestone to speed up review phase of 5.25.0

Actions #19

Updated by Andreas Kohlbecker about 1 year ago

  • Target version changed from Release 5.35 to Release 5.18

final check successful, can be closed, moving to the milestone for which this has been fixed: Release 5.18

Actions #20

Updated by Andreas Kohlbecker about 1 year ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF