Project

General

Profile

feature request #5050

revise the subAreaPreference rule for filtering Distributions

Added by Andreas Kohlbecker over 4 years ago. Updated about 1 month ago.

Status:
In Progress
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
06/30/2015
Due date:
% Done:

40%

Estimated time:
16.00 h
Severity:
critical
Tags:

Description

The subAreaPreference rule for filtering Distributions is implemented in the DescriptionUtility.filterDistributions()

Sub area preference rule

The rule as currently implemented:

"If there is an area with a direct sub area and both areas have the same computed status only the information on the sub area should be reported, whereas the super area should be ignored."

This rule has a restriction which is no longer valid:

"NOTE: this rule only applies to non computed areas, since the second rule is applied first!. TODO this is no longer valid since the second rule has been removed_" the so called second rule was: "In computed distributions, distributions in sub areas are preferred over those for parent areas if they have the same status"

Questions and Facts

  • The subAreaPreference rule must only affect the maps and never must remove any Area from textual distribution information. It is originally only implemented in attachment:"#3904:FillHelsinkiOccurrence.bas" which had sole purpose of preparing the table to be sent to Helsinki for creating the maps. TODO: make subAreaPreference rule independent from other filters and execute it exclusively for maps. DONE [r24597|r24598]

  • The subAreaPreference rule must be applied to all Distributions, to computed and edited. This can bee clearly seen in attachment:"#3904:FillHelsinkiOccurrence.bas" - UPDATE: the subAreaPreference was never limited to only computed Distributions, this was only confused in the documentation and comments. TODO: disentangle documentation and clean up old code fragments DONE r24597

Originally requested in

  • 1. #2625 Data aggregation functionalities for E+M (TransmissionEngine))*

in Ticket description:

When generating maps from the accumulated distribution information some special cases have to be handled: .... If there is an area with a sub area and both areas have the same calculated status only the subarea status should be shown in the map, whereas the super area should be ignored.

and secondly in a follow up ticket:

  • 2. #3904 EuroMed: Implement filtering rules for Distributions**

[#3904#note-2]:

  • Cz Former Czechoslovakia soll nur dann ausgegeben werden, wenn es für keines der Teilareale (Cs Czech Republic oder Sk Slovakia) eine Angabe gibt;
  • Ju Former Jugoslavia soll nur dann ausgegeben werden, wenn es für keines der Teilareale (BH, Cg, Ct, Mk, Sl, Sr) eine Angabe gibt ;
  • IJ Israel-Jordan soll nur dann ausgegeben werden, wenn es für keines der Teilareale (Ir, Jo) eine Angabe gibt;
  • LS Lebanon-Syria soll nur dann ausgegeben werden, wenn es für keines der Teilareale (Le, Sy) eine Angabe gibt;

UPDATE: At least above requirement for Ju conflicts with the other rules, see [#4408#note-6]

Issues that exist with this rule

A couple of issues exist which are related to this rule:

  • [#3907#note-26] the rule causes removal of named areas which should occur in the condensed distribution
  • #4409 (filtering rules for Distributions: some named areas with sub areas are missing in distribution)
  • #4408 (Distribution filter rule 2 not working in all cases)

Related issues

Related to Edit - feature request #6452: Filter for equal and single subareas New 03/01/2017
Related to Edit - bug #8297: Fix condensed distribution string for E+M New 05/23/2019
Related to Edit - task #8671: Distribution in E+M (BM) on different levels In Progress 11/09/2019
Related to Edit - bug #8670: Unwanted distribution aggregation/display on 2 levels Resolved 11/09/2019

History

#1 Updated by Andreas Kohlbecker over 4 years ago

  • Status changed from New to In Progress

#2 Updated by Andreas Kohlbecker over 4 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Kohlbecker to Andreas Müller

fixing all issues mentioned in this ticket:

  • [r24598 applying subAreaPreference rule exclusively for maps|* r24597] subAreaPreference Rule can be run completely separately

#3 Updated by Andreas Müller over 4 years ago

  • Category changed from architecture to cdmlib

#4 Updated by Andreas Müller almost 3 years ago

#6 Updated by Andreas Kohlbecker almost 2 years ago

  • Description updated (diff)

#9 Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to In Progress
  • % Done changed from 0 to 40
  • Estimated time set to 16.00 h

#10 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 3.7 to Release 5.1

#11 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.1 to Release 5.2

#12 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.2 to Release 5.3

#13 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.3 to Release 5.4

#14 Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 5.4 to Release 5.5

#15 Updated by Andreas Müller 10 months ago

  • Target version changed from Release 5.5 to Release 5.6

#16 Updated by Andreas Müller 10 months ago

  • Target version changed from Release 5.6 to Release 5.7

#17 Updated by Andreas Müller 7 months ago

  • Target version changed from Release 5.7 to Release 5.8

#18 Updated by Andreas Müller 7 months ago

  • Related to bug #8297: Fix condensed distribution string for E+M added

#19 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.8 to Release 5.10

#20 Updated by Andreas Müller 3 months ago

  • Target version changed from Release 5.10 to Release 5.11

#21 Updated by Andreas Müller about 1 month ago

  • Private changed from Yes to No

#22 Updated by Andreas Müller about 1 month ago

  • Target version changed from Release 5.11 to Release 5.12

#23 Updated by Andreas Müller 22 days ago

  • Related to task #8671: Distribution in E+M (BM) on different levels added

#24 Updated by Andreas Müller 22 days ago

  • Related to bug #8670: Unwanted distribution aggregation/display on 2 levels added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)