EDIT

Andreas Müller wrote:

Patrick Plitzner wrote:

tested on nightly.

Changing to any *lectotype will show the reference related elements. The reference and the details are saved correctly.

Only issue: When changing from *lectotype which already has a reference to any non-lectotype, saving and then changing back to *lectotype the reference is still connected to this type designation. This may be a feature and not a bug.

No, I don't think this is a feature. We should handle these type changes consistently. Changing nomenclatural code might be a template. There, if you change the code, and an existing information is deleted this way you get a warning and you have to agree explicitly. The same should happen here.

By the way, changing the rank does not give the same warning, e.g. change species to genus the specific epithet is still stored. This to me does not seem to be correct.

But maybe this should be handled in the library? When updating a typedesignation check whether it has a reference but is not of type lectotype? At the moment maybe it is easier to implement it in the editor but in general I would think it is better to check this while saving.

Katja Luther wrote:

But maybe this should be handled in the library? When updating a typedesignation check whether it has a reference but is not of type lectotype? At the moment maybe it is easier to implement it in the editor but in general I would think it is better to check this while saving.

The warning needs to be implemented in UI I think. Or do you think about throwing an exception. Additionally we could add a validation rule. Hardcoding to delete the reference if it is not a "lectotype" reference to me feels a bit to strict, but not sure about it.

Andreas Müller wrote:

Katja Luther wrote:

But maybe this should be handled in the library? When updating a typedesignation check whether it has a reference but is not of type lectotype? At the moment maybe it is easier to implement it in the editor but in general I would think it is better to check this while saving.

The warning needs to be implemented in UI I think. Or do you think about throwing an exception. Additionally we could add a validation rule. Hardcoding to delete the reference if it is not a "lectotype" reference to me feels a bit to strict, but not sure about it.

I would think this should be handled by a validation rule. But for this release the editor removes the reference.

Validation already exists by the way #8139 but needs validation framework in place to be available

When having 2 type designations and the second one is not yet saved and deleting the second one both type designations are deleted but the first shouldn't.

Don't know if this is related to this ticket. If not please open a new one or attache to another ticket.

Andreas Müller wrote:

When having 2 type designations and the second one is not yet saved and deleting the second one both type designations are deleted but the first shouldn't.

Don't know if this is related to this ticket. If not please open a new one or attache to another ticket.

This is not related to this ticket, I think. I create a new ticket. (#8225)

Andreas Müller wrote:

If Status is completely deleted the reference is not deleted but should (similar to choosing e.g. holotype) I guess.

Also "Not designated" should be moved elsewhere to keep status and it's reference close together. Mabe we can move it down after Reference Detail as it is not used often. (Note: we also need to check if "Not Designated" excludes other fields from being filled than we should show fields only if "not designated" is false. But this needs further investigation)

It would be nice to have a more specific label for reference and reference detail to make clear that it is ONLY for lectotypification. But as it is not only for "lecto" but also for e.g. "neo" I am not sure what label to use. Maybe "Status Reference"? Any other ideas.

this is fixed.

Andreas Müller wrote:

After choosing a specimen for the type designation it is sometimes impossible to select the type designation to show the supplemental data for the type designation. One needs to set the focus to something else (e.g. the taxon in name editor) and try to select the type designation again. Also the later does not always work but difficult to reproduce.

Does someone else have the same experience? If yes, it should be fixed because otherwise it is difficult and not intuitive to add the new sources to a type designation.

This is a little bit strange. The area where to select the typedesignation for the supplemental data view is different. when I have two typedesination one I can click near the label of the specimen and for the other I need to click behind the type status combo (this always works!)

This is because the entitySelectionElement has a selectionListener as well and when this entitySelectionElement contains an element this element is selected and shown in the supplemental data view.

Clicking somewhere behind the type combo or the 'Not deisgnated' checkbox activates the selection of the type designation. I think we have to describe this in the manual because I don't know how to change this behaviour.
But maybe someone else has a better idea?

??

Andreas Müller wrote:

??

this was a question for Patrick. See the description in node#33

Katja Luther wrote:

Andreas Müller wrote:

If Status is completely deleted the reference is not deleted but should (similar to choosing e.g. holotype) I guess.

Also "Not designated" should be moved elsewhere to keep status and it's reference close together. Mabe we can move it down after Reference Detail as it is not used often. (Note: we also need to check if "Not Designated" excludes other fields from being filled than we should show fields only if "not designated" is false. But this needs further investigation)

It would be nice to have a more specific label for reference and reference detail to make clear that it is ONLY for lectotypification. But as it is not only for "lecto" but also for e.g. "neo" I am not sure what label to use. Maybe "Status Reference"? Any other ideas.

this is fixed.

Have you forgotten to push? For me it still looks like before.

Patrick Plitzner wrote:

Clicking somewhere behind the type combo or the 'Not deisgnated' checkbox activates the selection of the type designation. I think we have to describe this in the manual because I don't know how to change this behaviour.

Changing this behaviour would require adjusting the layout of all entity selection elements and may be difficult and also may add unwanted white space.

Why do you think so? Do you know what the reason for the behavior is? If yes please leave a note what it is. I find it strange because it often works as expected and only sometimes it doesn't. So I don't understand why it necessarily requires complete refactoring/adjusting

This functionality in general is not very intuitive. In this case it is even easier because you have this large area below the right outer Delete icon (see cursor in image). I find it even harder to select a name in the taxon details view.

For me this is not true, name selection always works, clicking behind (and ONLY behind) the record is less intuitive. And also: often it WORKS as expected, only sometimes (and currently still non-deterministic) it changes the behavior and selects the specimen instead of the complete type designation.

So not very nice (as selection is crucial for entering sources, but it is true that it always works in the area below the delete button) we may close this ticket and create a high priority bugfix ticket once also note-28 is really fixed.

I just realized that the same problem exists e.g. for original sources. So it seems to be a general issue for lists, not only related specifically to type designations. So we maybe should open a new ticket for this general issue and close this ticket as it works as expected except for the general bug.

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

If Status is completely deleted the reference is not deleted but should (similar to choosing e.g. holotype) I guess.

Also "Not designated" should be moved elsewhere to keep status and it's reference close together. Mabe we can move it down after Reference Detail as it is not used often. (Note: we also need to check if "Not Designated" excludes other fields from being filled than we should show fields only if "not designated" is false. But this needs further investigation)

It would be nice to have a more specific label for reference and reference detail to make clear that it is ONLY for lectotypification. But as it is not only for "lecto" but also for e.g. "neo" I am not sure what label to use. Maybe "Status Reference"? Any other ideas.

this is fixed.

Have you forgotten to push? For me it still looks like before.

sorry, yes now, it is pushed.

Maybe we shorten the "Status Reference Detail" to "Status Ref Detail" or back to "Reference Detail" (maybe with a small identation to show that it belongs to the above reference ) or simply to Detail with a larger identation which makes it clear that it belongs to above reference.

Or we find a better technical solution.