feature request #7658
closeduse new taxon relationship DTO webservice in portal
100%
Description
for details see #6682
Example taxa:
- Chichorieae: Pilosella acutifolia coll.
- Cihochorieae: Hieracium dermophyllum
New test data copied from
Nepenthes abalata in the integrationtest reference database
Still to discuss: how to handle misapplied name deduplication (1 line per same name/rel.sec. but for different sensu/appended phrases, the later need to be concatenated with "," as separator. This can either be handled on server or client side (discussion).
Files
Related issues
Updated by Andreas Kohlbecker about 6 years ago
- Copied from feature request #6682: Formatter and DTO for taxon relationships (e.g. misapplied names) added
Updated by Andreas Kohlbecker about 6 years ago
- Tags changed from euro+med to euro+med, caryophyllales
Updated by Andreas Müller about 6 years ago
- Related to bug #6652: [Discuss] misapplied names: hide protologue icon added
Updated by Andreas Müller about 6 years ago
- Related to bug #5676: Sensu does not show up if no author exists for secundum reference added
Updated by Andreas Kohlbecker about 6 years ago
- Target version changed from Release 5.2 to Release 5.3
Updated by Andreas Müller about 6 years ago
- Related to feature request #7666: Remaining issues for "Formatter and DTO for taxon relationships (e.g. misapplied names)" added
Updated by Andreas Müller about 6 years ago
- Copied from deleted (feature request #6682: Formatter and DTO for taxon relationships (e.g. misapplied names))
Updated by Andreas Müller about 6 years ago
- Due date set to 06/01/2017
- Start date changed from 05/31/2017 to 06/01/2017
- Follows feature request #6682: Formatter and DTO for taxon relationships (e.g. misapplied names) added
Updated by Andreas Kohlbecker almost 6 years ago
- Copied to feature request #7720: use new taxonRelationshipsDTO webservice for all taxon relations added
Updated by Andreas Kohlbecker almost 6 years ago
- Status changed from In Progress to Resolved
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- % Done changed from 0 to 60
implementation complete, please review
Updated by Andreas Müller almost 6 years ago
- Related to feature request #5232: use TaxonBase.getTaggedTitle to get the sec reference in theme_cdm_taxonRelationships() added
Updated by Andreas Müller almost 6 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Andreas Kohlbecker
Does not yet work for pro parte and partial MANs.
Updated by Andreas Müller almost 6 years ago
- File picture970-1.png picture970-1.png added
- File picture970-2.png picture970-2.png added
Exception for second MAN of Achillea santolinoides Lag.
for this data on test.cyprus
Updated by Andreas Müller almost 6 years ago
But it works when adding an explicit sensu reference. But explicit sensu is not a requirement.
Updated by Andreas Müller almost 6 years ago
- File picture38-1.png picture38-1.png added
Strange, with this entry:
the webservice even does not return a second entry though it exists. Need to check why.
Updated by Andreas Müller almost 6 years ago
Andreas Müller wrote:
Strange, with this entry:
the webservice even does not return a second entry though it exists. Need to check why.
ohh, sorry, it was on unpublish (so unpublish works !! ;-)
Updated by Andreas Müller almost 6 years ago
Deduplication must NOT take place if the rel. sec. differs (e.g. only one of the MANs has a rel. sec.). This is not yet correctly implemented.
Also everything else needs to be equal except for MAN.sec and MAN.secDetail. E.g. if the doubtful flag differs either for the MAN taxon or for relation also no deduplication should take place (as it is no duplicate).
Also the relationship type needs to be equal (once pro parte and partial works).
Updated by Andreas Müller almost 6 years ago
- File picture944-1.png picture944-1.png added
& handling does not yet work correctly in teams. Probably a formatter issue #7666.
Updated by Andreas Müller almost 6 years ago
Andreas Müller wrote:
& handling does not yet work correctly in teams. Probably a formatter issue #7666.
This was a formatter problem (#7666) which was fixed by cdmlib|c331fa7e
Updated by Andreas Müller almost 6 years ago
- Related to feature request #5647: Aggregate misapplied names with multiple sensu references added
Updated by Andreas Kohlbecker almost 6 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- % Done changed from 60 to 70
finally fully solved, please review
Updated by Andreas Müller almost 6 years ago
- Related to feature request #6681: Correct formatting for misapplied names in name editor added
Updated by Andreas Müller almost 6 years ago
- Related to feature request #7753: use TaxonRelationshipFormatter for MAN and pro parte synonyms in name editor added
Updated by Andreas Müller almost 6 years ago
- File picture400-1.png picture400-1.png added
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Andreas Kohlbecker
Deduplication still does not work if everything is similar except for sensu and sensu detail. In the following screeshot the 2nd and 3rd entry should be deduplicated:
Updated by Andreas Müller almost 6 years ago
I tested the above behavior. The reason is that secDetail differs (or misses in one case). secDetail is part of the secSource and may be different.
Updated by Andreas Müller almost 6 years ago
The MANs are still unsorted. In the above example you can see that Achillea santolina sensu Chrtek ... is before Achillea santolina sensu Baumel but shouldn't.
As far as I know Katja implemented a Comparator for same issue in TaxEditor. If possible we should try to reuse it. But may be this is not possible because of the deduplications that do not exist in TaxEditor.
Updated by Andreas Müller almost 6 years ago
Andreas Müller wrote:
Exception for second MAN of Achillea santolinoides Lag.
for this data on test.cyprus
This is not yet fixed. The exception still exists. #7658#note-17
Updated by Andreas Müller almost 6 years ago
Deduplication should include appendedPhrase part I think (this is also not yet implemented in the server side misapplication deduplication and also has not yet been discussed in our last discussion on deduplication).
E.g. - "Achillea santolina" auctrs. afr.; Meikle 1988 should be deduplicated and not 2 entries.
This is because the appendedPhrase for MANs is usually used as kind of freetext for the sensu reference like in the above example.
Updated by Andreas Müller almost 6 years ago
Andreas Müller wrote:
Does not yet work for pro parte and partial MANs.
This is also still an open issue.
Updated by Andreas Müller almost 6 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Andreas Kohlbecker to Andreas Müller
Updated by Andreas Kohlbecker almost 6 years ago
Fehler wie bei Achillea santolinoides beseitigt, aber die Fußnoten bei den nicht MANs fehlen noch - kommt in 3.4!
Updated by Andreas Kohlbecker almost 6 years ago
Andreas Kohlbecker wrote:
Fehler wie bei Achillea santolinoides beseitigt, aber die Fußnoten bei den nicht MANs fehlen noch - kommt in 3.4!
jetzt müsste es perfekt sein!
der Review lohnt sich nun.
Updated by Andreas Müller almost 6 years ago
"auct." (appended phrase) does not show up, e.g.
- "Achillea santolina" , non Test , but should be "Achillea santolina" auct., non Test
The auct. is in the webservice but seems to get lost in the portal code
Updated by Andreas Müller almost 6 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Andreas Kohlbecker
Updated by Andreas Müller almost 6 years ago
Andreas Müller wrote:
"auct." (appended phrase) does not show up, e.g.
- "Achillea santolina" , non Test , but should be "Achillea santolina" auct., non Test
The auct. is in the webservice but seems to get lost in the portal code
This is only the case, if no sensu reference is defined
Updated by Andreas Müller almost 6 years ago
Deduplication takes not yet place when the relationship is of type "pro parte Misaplied Name" or "partial Misapplied Name", but should. But of course only if both types are equal, so don't mix MAN with ppMAN or partialMAN with ppMAN ...
Updated by Andreas Kohlbecker almost 6 years ago
Andreas Müller wrote:
Deduplication takes not yet place when the relationship is of type "pro parte Misaplied Name" or "partial Misapplied Name", but should. But of course only if both types are equal, so don't mix MAN with ppMAN or partialMAN with ppMAN ...
Oops, this is a new requirement.
Updated by Andreas Kohlbecker almost 6 years ago
Andreas Müller wrote:
Andreas Müller wrote:
"auct." (appended phrase) does not show up, e.g.
- "Achillea santolina" , non Test , but should be "Achillea santolina" auct., non Test
The auct. is in the webservice but seems to get lost in the portal code
This is only the case, if no sensu reference is defined
It is actually the "Combination Authors" data which causes the problem.
Updated by Andreas Kohlbecker almost 6 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Andreas Kohlbecker to Andreas Müller
all mentioned bugs fixed!
Updated by Andreas Müller almost 6 years ago
The sort order is still not correct. We should first have pro parte/partial synonyms, then invalid designations, then MANs followed (or including?) pro parte/partial MAN and finally concept relationships.
Currently they come mixed up:
Updated by Andreas Müller almost 6 years ago
- File picture979-1.png picture979-1.png added
Updated by Andreas Müller almost 6 years ago
This problem is not release critical. We can fix it in 5.4. Maybe only moving up ppSyn to top would be nice but if not it is acceptable.
Updated by Andreas Müller almost 6 years ago
Andreas Kohlbecker wrote:
all mentioned bugs fixed!
Tested the 2 issues. Both work.
So the only open issue is the sorting #7658#note-46
We may move this to 5.4 if not easy to fix.
Updated by Andreas Müller almost 6 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Andreas Kohlbecker
Updated by Andreas Müller almost 6 years ago
And ofcourse the footnotes for non-MAN data are still missing. #7658#note-37 or should this be fixed already? If yes, it doesn't seem to work.
Updated by Andreas Kohlbecker almost 6 years ago
- Copied to bug #7766: Remaining issues for using relationship DTO webservice in portal added
Updated by Andreas Müller almost 6 years ago
- Status changed from Feedback to Closed
Close this ticket. Remaining (and new) issues moved to #7766