Project

General

Profile

bug #8385

Open issues in DB preferences

Added by Andreas Müller 2 months ago. Updated 18 days ago.

Status:
Feedback
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
07/18/2019
Due date:
% Done:

90%

Severity:
normal
Found in Version:

Description

  • Values on General page (Export/Import, Checklist perspective, Taxonnode Wizard) are not loaded correctly when reopening the DB pref wizard
  • Commonname areas-popup: finish button does not work this works for me
  • Name details view can not be set to "default" (always chooses enabled after reopening)
  • PublishFlag: if choosing "default" after reopening an IAE is thrown (see #8385#note-6)
  • Distribution-Editor:
    • !!status-combo: default handling not correct, "Use default" is stored in DB instead of deleting preference => no combobox is shown in Dist Editor
    • sorting areas => choose Label, selects ID in Voc after reopening
    • Show rank: use yes and no instead "Show Rank" and "No rank", this is consistent with other such fields.
  • ABCD Import: (see also #8089)
    • Biocase Provider for associated DNA should be moved to "Biocase Provider" **this is not the same because this provider link belongs to the configurator
    • Nomencl.Code dropdown is missing a label
    • io.ABCD.config is stored in DB with value NULL even if nothing has changed, if this is default value, the default should not be stored
    • similar for BiocaseProvider: io.ABCD.providerList is stored with "Keine Provider verfügbar;" which seems to be incorrect as this is only a label for a non existing provider
  • Disable "allow override" where no local preference exists yet (or better implement local preference)
    • ABCD import
    • General (IO menu, Checklist perspective, TaxonNode Wizard)this exist in local preferences, too
    • Common names areas
  • Adapt menu to local prefs menu (use same structure)
  • Check result of "Restore Defaults", with the new implementation it should always set fields to "default" but it doesn't (e.g. Distribution Editor-Show Ranks is set to "Show Rank" instead)
  • show default value in brackets: currently "Use default" is shown but users don't know what the default value is so it is difficult to decide if "Use default" is what is wanted. However, computing the default needs to be done together with "subject" so first all higher subjects need to be asked for there value and finally if no value exists for any subject the default for the predicate should be taken.
  • disable OK if no changes took place, same as "Apply" (necessary?)
  • NameDetailsView: the taxon sec attributes are disabled if NDV is disabled but they are not grey. Only when uncheck NDV display on the page they are also grey as all others
  • handle default with allowOverride=false => #8389

Related issues

Related to Edit - bug #7849: Improve DB Preferences handling and saving in TaxEditor Feedback 10/23/2018
Related to Edit - feature request #8089: improve abcd preference page New 02/09/2019
Related to Edit - bug #8389: Correct handling of default values with allowOverride=false Resolved 07/18/2019
Related to Edit - feature request #8489: Further issues for DB preferences In Progress 08/26/2019
Related to Edit - bug #8494: Better ABCD Preferences Page New 08/28/2019

Associated revisions

Revision cf115b19 (diff)
Added by Patrick Plitzner 2 months ago

ref #8385 Remove publish flag preference when set to default

Revision 793ded33 (diff)
Added by Patrick Plitzner 2 months ago

ref #8385 Fix potential NPE

Revision 25a3ce1e (diff)
Added by Katja Luther about 2 months ago

ref #8385: fixes for preferences

Revision c2a446b0 (diff)
Added by Katja Luther about 2 months ago

ref #8385: fixes in preferences - getDefaults() for all pages

Revision 515bfcff (diff)
Added by Katja Luther about 2 months ago

ref #8385: fix TermOrder Enum

Revision fc3e5e6e (diff)
Added by Katja Luther about 2 months ago

ref #8385: fixes in preferences - continue

Revision fe64715e (diff)
Added by Katja Luther about 1 month ago

ref #8385: add new preference predicates

Revision 9c128421 (diff)
Added by Katja Luther about 1 month ago

ref #8385: adapt local and db preference pages

Revision 905236e8 (diff)
Added by Katja Luther about 1 month ago

ref #8385: adapt strucutre of db prefs to local prefs

Revision af1131f2 (diff)
Added by Katja Luther about 1 month ago

ref #8385: add method to get voc by uuid

Revision f9840e06 (diff)
Added by Katja Luther about 1 month ago

ref #8385: correct preference handling for provider list

Revision a60ccec4 (diff)
Added by Katja Luther about 1 month ago

ref #8385: enable apply button when provider added or removed from preference

Revision c1662123 (diff)
Added by Katja Luther about 1 month ago

ref #8385: adapt preference keys to preference predicates

Revision 041937b4 (diff)
Added by Katja Luther 29 days ago

ref #8385: fix problems in preferences

Revision f9af366e (diff)
Added by Katja Luther 29 days ago

ref #8385: smaller changes in preferences

Revision dea4cffc (diff)
Added by Katja Luther 29 days ago

ref #8385: add allowOverride to AbcdProvider PreferencePage

Revision c9bb625e (diff)
Added by Katja Luther 29 days ago

ref #8385: fix nomenclatural code preference page

Revision dc1780ec (diff)
Added by Katja Luther 29 days ago

ref #8385: fix nomenclatural code preference page - continue

Revision f02e08f4 (diff)
Added by Katja Luther 22 days ago

ref #8385: fix general and abcd pages

Revision 3d31b229 (diff)
Added by Katja Luther 22 days ago

ref #8385: fix nomenclatural status page

Revision c793c58b (diff)
Added by Katja Luther 22 days ago

ref #8385: fix namedetails view configuration and rank selection

Revision e649e0cb (diff)
Added by Katja Luther 21 days ago

ref #8385: label issues, search dialog prefs...

Revision d2a55134 (diff)
Added by Katja Luther 21 days ago

ref #8385: label issues

Revision 8fecfdbd (diff)
Added by Katja Luther 21 days ago

ref #8385: fix general prefs and publish flag prefs page

Revision 531b0ee6 (diff)
Added by Katja Luther 21 days ago

ref #8385: fix specimen pref page

Revision de9fe10f (diff)
Added by Katja Luther 20 days ago

ref #8385: smaller label issues

Revision 89683c7f (diff)
Added by Katja Luther 20 days ago

ref #8385: smaller label issues

Revision c4ae573c (diff)
Added by Katja Luther 19 days ago

ref #8385: fix NPE

Revision 44c33856 (diff)
Added by Katja Luther 19 days ago

ref #8385: fix enabling of allow override button

Revision 643f70e0 (diff)
Added by Katja Luther 19 days ago

ref #8385: adapt local default labels to db preference

Revision 53d771bb (diff)
Added by Katja Luther 19 days ago

ref #8385: fix enabling and disabling of distribution editor pref page

Revision 6f5b48f3 (diff)
Added by Katja Luther 19 days ago

ref #8385: setToDefault needs to setApply = true

Revision cb75abfb (diff)
Added by Katja Luther 19 days ago

ref #8385: show db preference for local term preferences if default is selected

Revision 75ca45ac (diff)
Added by Katja Luther 19 days ago

ref #8385: do not show default preference for distributionstatus

Revision 0a635f6d (diff)
Added by Katja Luther 19 days ago

ref #8385: label issues

Revision bcf07bcc (diff)
Added by Katja Luther 8 days ago

ref #8385: minor in preferencesUtil

Revision b6ea6bbc (diff)
Added by Katja Luther 4 days ago

ref #8385: methods for better voc selection pref pages

Revision e7cdc2fb (diff)
Added by Katja Luther 4 days ago

ref #8385: better handling of distr preferences and term related preferences

History

#1 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#2 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#3 Updated by Andreas Müller 2 months ago

  • Assignee changed from Katja Luther to Patrick Plitzner

Patrick, can you have a look?

#4 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#5 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#6 Updated by Andreas Müller 2 months ago

After setting Publish Flag to default and reopening:

login : admin
editor version : 5.8.0.201907180811
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.5.0.0.20190221
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.IllegalArgumentException: No enum constant eu.etaxonomy.cdm.model.metadata.PublishEnum.
    at java.lang.Enum.valueOf(Enum.java:238)
    at eu.etaxonomy.cdm.model.metadata.PublishEnum.valueOf(PublishEnum.java:1)
    at eu.etaxonomy.taxeditor.databaseAdmin.preferencePage.PublishFlagPreference.getValues(PublishFlagPreference.java:75)
    at eu.etaxonomy.taxeditor.preference.PublishFlagLocalPreference.createContents(PublishFlagLocalPreference.java:57)
    at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:241)
    at eu.etaxonomy.taxeditor.preference.menu.CdmPreferencePage.createControl(CdmPreferencePage.java:65)
    at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1430)
    at org.eclipse.jface.preference.PreferenceDialog$9.run(PreferenceDialog.java:1197)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
    at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
    at org.eclipse.jface.preference.PreferenceDialog.showPage(PreferenceDialog.java:1189)
    at org.eclipse.jface.preference.PreferenceDialog$5.lambda$0(PreferenceDialog.java:656)
    at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
    at org.eclipse.jface.preference.PreferenceDialog$5.selectionChanged(PreferenceDialog.java:653)
    at org.eclipse.jface.viewers.StructuredViewer$3.run(StructuredViewer.java:878)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
    at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
    at org.eclipse.jface.viewers.StructuredViewer.firePostSelectionChanged(StructuredViewer.java:875)
    at org.eclipse.jface.viewers.StructuredViewer.setSelection(StructuredViewer.java:1729)
    at org.eclipse.jface.viewers.TreeViewer.setSelection(TreeViewer.java:1077)
    at org.eclipse.jface.preference.PreferenceDialog.selectSavedItem(PreferenceDialog.java:991)
    at org.eclipse.jface.preference.PreferenceDialog.lambda$0(PreferenceDialog.java:346)
    at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
    at org.eclipse.jface.preference.PreferenceDialog.createContents(PreferenceDialog.java:343)
    at org.eclipse.jface.window.Window.create(Window.java:426)
    at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1095)
    at eu.etaxonomy.taxeditor.workbench.handler.OpenAdminPreferencesHandler.execute(OpenAdminPreferencesHandler.java:123)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
    at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:282)
    at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:264)
    at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
    at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
    at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
    at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:488)
    at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
    at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:433)
    at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:454)
    at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem$3.handleEvent(AbstractContributionItem.java:482)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
    at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
    at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
    at eu.etaxonomy.taxeditor.Application.start(Application.java:24)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1519)

#7 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#8 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#9 Updated by Andreas Müller 2 months ago

  • Priority changed from New to Highest

#10 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#11 Updated by Andreas Müller 2 months ago

  • Related to bug #7849: Improve DB Preferences handling and saving in TaxEditor added

#12 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#13 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#14 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#15 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#16 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#17 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#18 Updated by Andreas Müller 2 months ago

#19 Updated by Andreas Müller 2 months ago

io.ABCD.config is stored in DB with value NULL even if nothing has changed, if this is default value, the default should not be stored

CRITICAL: if this value is set the navigator does not show any classifications after restart. We need to check why this is and fix it (it is the first page and this can happen accidentally).

Maybe these stacktraces are related:

java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.preference.PreferencesUtil.getDBAbcdImportConfigurationPreference(PreferencesUtil.java:1447)
    at eu.etaxonomy.taxeditor.preference.PreferencesUtil.resetToDBPreferenceAbcdCOnfigurator(PreferencesUtil.java:1541)
    at eu.etaxonomy.taxeditor.preference.PreferencesUtil.updateAbcdImportConfigurationPreference(PreferencesUtil.java:1535)
    at eu.etaxonomy.taxeditor.preference.PreferencesUtil.updateDBPreferences(PreferencesUtil.java:1711)
    at eu.etaxonomy.taxeditor.databaseAdmin.preferencePage.AbcdImportPreference.performOk(AbcdImportPreference.java:367)
    at org.eclipse.jface.preference.PreferenceDialog$8.run(PreferenceDialog.java:905)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
    at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.ApplicationWorkbenchAdvisor$CdmStatusHandler.handle(ApplicationWorkbenchAdvisor.java:123)
    at org.eclipse.ui.internal.WorkbenchErrorHandlerProxy.handle(WorkbenchErrorHandlerProxy.java:31)
    at org.eclipse.ui.statushandlers.StatusManager.handle(StatusManager.java:204)
    at org.eclipse.ui.statushandlers.StatusManager.handle(StatusManager.java:246)
    at org.eclipse.ui.statushandlers.StatusManager.handle(StatusManager.java:257)

#21 Updated by Patrick Plitzner 2 months ago

  • Description updated (diff)

#22 Updated by Patrick Plitzner 2 months ago

Andreas Müller wrote:

io.ABCD.config is stored in DB with value NULL even if nothing has changed, if this is default value, the default should not be stored

CRITICAL: if this value is set the navigator does not show any classifications after restart. We need to check why this is and fix it (it is the first page and this can happen accidentally).

Maybe these stacktraces are related:

java.lang.NullPointerException
  at eu.etaxonomy.taxeditor.preference.PreferencesUtil.getDBAbcdImportConfigurationPreference(PreferencesUtil.java:1447)
  at eu.etaxonomy.taxeditor.preference.PreferencesUtil.resetToDBPreferenceAbcdCOnfigurator(PreferencesUtil.java:1541)
  at eu.etaxonomy.taxeditor.preference.PreferencesUtil.updateAbcdImportConfigurationPreference(PreferencesUtil.java:1535)
  at eu.etaxonomy.taxeditor.preference.PreferencesUtil.updateDBPreferences(PreferencesUtil.java:1711)
  at eu.etaxonomy.taxeditor.databaseAdmin.preferencePage.AbcdImportPreference.performOk(AbcdImportPreference.java:367)
  at org.eclipse.jface.preference.PreferenceDialog$8.run(PreferenceDialog.java:905)
  at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
  at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
  at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
java.lang.NullPointerException
  at eu.etaxonomy.taxeditor.ApplicationWorkbenchAdvisor$CdmStatusHandler.handle(ApplicationWorkbenchAdvisor.java:123)
  at org.eclipse.ui.internal.WorkbenchErrorHandlerProxy.handle(WorkbenchErrorHandlerProxy.java:31)
  at org.eclipse.ui.statushandlers.StatusManager.handle(StatusManager.java:204)
  at org.eclipse.ui.statushandlers.StatusManager.handle(StatusManager.java:246)
  at org.eclipse.ui.statushandlers.StatusManager.handle(StatusManager.java:257)

This is now fixed. It was an NPE because the ABCD config is stored as null in the DB Prefs. Wouldn't it be better to just delete the preference if the config is null. null means default in this case and default should be the same as deleting the preference.

#23 Updated by Patrick Plitzner 2 months ago

Patrick Plitzner wrote:

Wouldn't it be better to just delete the preference if the config is null. null means default in this case and default should be the same as deleting the preference.

I just saw that this is already mentioned in the ticket description.

#24 Updated by Andreas Müller 2 months ago

the above both fixes seem to work (though the last is only a workaround for a real fix (full delete of the preference))

#25 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#26 Updated by Andreas Müller 2 months ago

  • Related to bug #8389: Correct handling of default values with allowOverride=false added

#27 Updated by Andreas Müller 2 months ago

  • Description updated (diff)

#28 Updated by Andreas Müller about 2 months ago

  • Target version changed from Release 5.8 to Release 5.9

#29 Updated by Patrick Plitzner about 2 months ago

  • Assignee changed from Patrick Plitzner to Katja Luther

Passing the ticket back to Katja. We may have a look on it together, though.

#30 Updated by Katja Luther about 2 months ago

  • Description updated (diff)

#31 Updated by Katja Luther about 2 months ago

  • Description updated (diff)

#32 Updated by Katja Luther about 2 months ago

  • Status changed from New to In Progress

#33 Updated by Katja Luther about 2 months ago

  • Description updated (diff)

#34 Updated by Katja Luther about 2 months ago

  • Description updated (diff)

#35 Updated by Katja Luther about 1 month ago

  • Description updated (diff)

#36 Updated by Katja Luther about 1 month ago

  • Description updated (diff)

#37 Updated by Katja Luther about 1 month ago

  • Description updated (diff)

#38 Updated by Andreas Müller about 1 month ago

  • Status changed from In Progress to Feedback

When opening Peferences - Distribution Editor for the first time the drop downs for some fields were completely empty. Is this because maybe old values were stored that are not supported anymore? Do we need an update script for them? How does the TaxEditor handle such entries. Does it throw exceptions if it uses them or does it use the default value instead?
this is fixed

#39 Updated by Andreas Müller about 1 month ago

  • Description updated (diff)

Name details view can not be set to "default" (always chooses enabled after reopening)

Now it always sets it back to "Use default" after reopening

this is fixed

#40 Updated by Andreas Müller about 1 month ago

Andreas Müller wrote:

When opening Peferences - Distribution Editor for the first time the drop downs for some fields were completely empty. Is this because maybe old values were stored that are not supported anymore? Do we need an update script for them? How does the TaxEditor handle such entries. Does it throw exceptions if it uses them or does it use the default value instead?

This even happend with freshly selected data. In Distribution Editor when selecting "IdInVoc" after reopening the drop down is empty.

this is fixed

#41 Updated by Andreas Müller about 1 month ago

ABCD import is now implemented on both sides, but "allow override" does not yet exist for "ABCD import provider"

this is fixed

#42 Updated by Andreas Müller about 1 month ago

some preferences are not deleted for NameDetailsView => deselect all and reopen preferences => 3 prefs stay selected

this is fixed

#43 Updated by Andreas Müller about 1 month ago

name.nomenclaturalStatus can not be removed by Reset Default
this is fixed.

#44 Updated by Andreas Müller about 1 month ago

Distribution editor status selection: changes are not visible in Preferences view after reopening the preferences view. I have not checked if they were correctly stored in the DB

this is fixed

#45 Updated by Andreas Müller about 1 month ago

Restore button does not yet work for Distribution Editor status and area selection preferences

this is fixed

#46 Updated by Katja Luther 27 days ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review

#47 Updated by Andreas Müller 22 days ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 70

Name Details View: if UseDefaults(Disable) is selected the fields are not disabled in the same way as when selecting "Disable"
this is fixed

#48 Updated by Andreas Müller 22 days ago

Name Details View: when selecting "restore defaults" allow override is not set to default

this is fixed

#49 Updated by Andreas Müller 22 days ago

"Show rank in Distribution Editor" should be relabled -> "Show rank column"

this is fixed

#50 Updated by Andreas Müller 22 days ago

ABCD: Ignore Authorship ... -> Ignore authorship ...

fixed

#51 Updated by Andreas Müller 22 days ago

Biocase Provider for associated DNA should be moved to "Biocase Provider"

this is not the same because this provider link belongs to the configurator

But still it would be nice to not allow to enter all providers may it be ABCD providers or DNA providers once at one place and then offer them where ever they are used as dropdown.

Also I do not understand why the biocase provider itself should not be part of the configurator while the DNA provider is part of it. Both is part of a specific import and therefore should be configurable when starting an import. Or do I misunderstand something here.

Note: to me it also seems like both should be usually a pair. For a given biocase provider I would expect that there is usually 1 DNA bank provider, so they could be selected as a pair.

#52 Updated by Andreas Müller 22 days ago

Why does the nomenclatural code not provide a default? Is this wanted? Does ABCD not need a nomenclatural code? I remember ABCD distinguishes botanical, zoological, ... by itself so maybe this parameter is not needed and only comes from the super class? If so, we should remove it. If not, and if a null value is not explicitly handled without using a default instead we should define the usage of default here, I guess. But I don't know the import so well so maybe there is a reason for the current implementation.

#53 Updated by Andreas Müller 22 days ago

ABCD: Restore defaults does not seem to set allowOverride

#54 Updated by Andreas Müller 22 days ago

io.ABCD.config is stored in DB with value NULL even if nothing has changed, if this is default value, the default should not be stored

This is still not fixed yet

#55 Updated by Andreas Müller 22 days ago

Andreas Müller wrote:

Biocase Provider for associated DNA should be moved to "Biocase Provider"

this is not the same because this provider link belongs to the configurator

But still it would be nice to not allow to enter all providers may it be ABCD providers or DNA providers once at one place and then offer them where ever they are used as dropdown.

Also I do not understand why the biocase provider itself should not be part of the configurator while the DNA provider is part of it. Both is part of a specific import and therefore should be configurable when starting an import. Or do I misunderstand something here.

Note: to me it also seems like both should be usually a pair. For a given biocase provider I would expect that there is usually 1 DNA bank provider, so they could be selected as a pair.

In general we should distinguish clearly between the list of available providers (may it be ABCD providers or DNA providers) and the default or predefined single values for the import configuration which provider to use for ABCD and for DNA. This is currently still mixed up. (But might be a new ticket)

#56 Updated by Andreas Müller 22 days ago

similar for BiocaseProvider: io.ABCD.providerList is stored with "Keine Provider verfügbar;" which seems to be incorrect as this is only a label for a non existing provider

This is fixed but still "Restore default" does not completely remove the preference (and even does not clear the existing list, what I would expect)

#57 Updated by Andreas Müller 22 days ago

General: When choosing "No - allow override" for all 3 entries the values shown in local preferences are "Use Default(Yes)",Default(No)" and "Default(Yes)" but it should be all "Default(No)".

Also when choosing explicit "Yes" in local preferences for all 3 of them this is not stored in local prefs but after reopen it shows "Use Default XXX" again.

This might be the case elsewhere, too. For now I tested only for General page.

this is fixed

#58 Updated by Andreas Müller 22 days ago

Nomenclatural status is not stored. Neither after reopening the pref dialog nor after restarting the TaxEditor the new values are recovered. Also they seem to be not stored in the CdmPreference table.

fixed

#59 Updated by Andreas Müller 22 days ago

Same for ranks. They are not stored.

fixed

#60 Updated by Andreas Müller 22 days ago

Andreas Müller wrote:

Same for ranks. They are not stored.

Hmm, maybe I made a mistake. This seems to work.

#61 Updated by Andreas Müller 22 days ago

Name details view: "Restore Defaults" does not enable "Secundum enabled" and "Secundum Reference Details"

fixed

#62 Updated by Andreas Müller 22 days ago

NDV: "Secundum Reference Details" -> "Secundum reference details"

#63 Updated by Andreas Müller 22 days ago

NDV: NameCache of the name ... -> "Name cache of the name ..."

#64 Updated by Andreas Müller 22 days ago

NDV: "Whole Authorship section" -> "Whole authorship section"

#65 Updated by Andreas Müller 22 days ago

Andreas Müller wrote:

Name details view: "Restore Defaults" does not enable "Secundum enabled" and "Secundum Reference Details"

Same if checkbox for "Taxon of the name" is set to "true"

#66 Updated by Andreas Müller 22 days ago

Publish Flage:

"Not Publish" -> "Don't Publish"
"Use Default (InheritFromParent)" -> kein Camel Case sondern wie bei "Inherit from Parent"

Eventuell überall klein schreiben außer am Anfang, aber vielleicht können wir das auch so lassen. Wie du willst.

fixed

#67 Updated by Andreas Müller 22 days ago

Andreas Müller wrote:

General: When choosing "No - allow override" for all 3 entries the values shown in local preferences are "Use Default(Yes)",Default(No)" and "Default(Yes)" but it should be all "Default(No)".

Also when choosing explicit "Yes" in local preferences for all 3 of them this is not stored in local prefs but after reopen it shows "Use Default XXX" again.

This might be the case elsewhere, too. For now I tested only for General page.

Problem is similar for "Search Dialog". There the correct value is shown in local preferences but it should show "Use Default (%correct value%)". Currently it does not show the "Use default" even if no value was selected before.

fixed

#68 Updated by Andreas Müller 22 days ago

Search dialog: "Search also for titlecache ..." -> "... title cache ..."

fixed

#69 Updated by Andreas Müller 22 days ago

Andreas Müller wrote:

Andreas Müller wrote:

General: When choosing "No - allow override" for all 3 entries the values shown in local preferences are "Use Default(Yes)",Default(No)" and "Default(Yes)" but it should be all "Default(No)".

Also when choosing explicit "Yes" in local preferences for all 3 of them this is not stored in local prefs but after reopen it shows "Use Default XXX" again.

This might be the case elsewhere, too. For now I tested only for General page.

Problem is similar for "Search Dialog". There the correct value is shown in local preferences but it should show "Use Default (%correct value%)". Currently it does not show the "Use default" even if no value was selected before.

Same or similar for "Specimens"

fixed

#70 Updated by Andreas Müller 22 days ago

Saving of "Publish Flag" does not always work. You may try different states including allow override adn "Restore Defaults". Sometime it seems to work, sometimes it does not. Not yet fully sure about the pattern.

fixed

#71 Updated by Andreas Müller 22 days ago

#72 Updated by Andreas Müller 22 days ago

Generally values recovered by "Restore default" often seem not to be persisted but old values are kept.

fixed

#73 Updated by Katja Luther 20 days ago

  • Related to bug #8494: Better ABCD Preferences Page added

#74 Updated by Katja Luther 19 days ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

abcd preferences are moved to a new ticket, please review the rest.

#75 Updated by Andreas Müller 19 days ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 70 to 80

Is there a reason why allow override is always disabled for "Enable Distribution Editor"?

#76 Updated by Katja Luther 19 days ago

Andreas Müller wrote:

Is there a reason why allow override is always disabled for "Enable Distribution Editor"?

I cannot reproduce this. But will have a look.

#77 Updated by Andreas Müller 19 days ago

Andreas Müller wrote:

General: When choosing "No - allow override" for all 3 entries the values shown in local preferences are "Use Default(Yes)",Default(No)" and "Default(Yes)" but it should be all "Default(No)".

This might be the case elsewhere, too. For now I tested only for General page.

This is not yet fixed for all such cases. I tested for Publish Flag and Distribution Editor preferences and the default values were not taken from the DB prefs. It works correct for the "General" page.

Please carefully check ALL pages for this issue.

#78 Updated by Katja Luther 19 days ago

Katja Luther wrote:

Andreas Müller wrote:

Is there a reason why allow override is always disabled for "Enable Distribution Editor"?

I cannot reproduce this. But will have a look.

is fixed

#79 Updated by Andreas Müller 19 days ago

Andreas Müller wrote:

Saving of "Publish Flag" does not always work. You may try different states including allow override adn "Restore Defaults". Sometime it seems to work, sometimes it does not. Not yet fully sure about the pattern.

This is still open. Currently I can't save the state at all. Always "default" is shown after reopening.

#80 Updated by Katja Luther 19 days ago

Andreas Müller wrote:

Andreas Müller wrote:

General: When choosing "No - allow override" for all 3 entries the values shown in local preferences are "Use Default(Yes)",Default(No)" and "Default(Yes)" but it should be all "Default(No)".

This might be the case elsewhere, too. For now I tested only for General page.

This is not yet fixed for all such cases. I tested for Publish Flag and Distribution Editor preferences and the default values were not taken from the DB prefs. It works correct for the "General" page.

Please carefully check ALL pages for this issue.

this should be fixed now

#81 Updated by Katja Luther 19 days ago

Andreas Müller wrote:

Andreas Müller wrote:

Saving of "Publish Flag" does not always work. You may try different states including allow override adn "Restore Defaults". Sometime it seems to work, sometimes it does not. Not yet fully sure about the pattern.

This is still open. Currently I can't save the state at all. Always "default" is shown after reopening.

this is fixed with the last commit as well.

#82 Updated by Andreas Müller 19 days ago

Andreas Müller wrote:

Generally values recovered by "Restore default" often seem not to be persisted but old values are kept.

Still does not work for Name details view. Only if pressing "Apply" it works. OK does not delete the record.
I have not tested other pages.
Please check all pages if it works.

#83 Updated by Katja Luther 19 days ago

Andreas Müller wrote:

Andreas Müller wrote:

Generally values recovered by "Restore default" often seem not to be persisted but old values are kept.

Still does not work for Name details view. Only if pressing "Apply" it works. OK does not delete the record.
I have not tested other pages. Please check all pages if it works.

sorry, I missed to call setApply(true), this is fixed.

#84 Updated by Andreas Müller 19 days ago

Names.NomenclaturalStatus restores default only after clicking 2x "Restore Default". Or more exact, clicking the first time seem to restore only the state before opening the preferences while the second time the value is really set to the default value.

#85 Updated by Andreas Müller 19 days ago

Distribution editor status and area selection: restore default deletes the values correctly but when opening the selection dialogs still the old values are shown.

#86 Updated by Katja Luther 19 days ago

Andreas Müller wrote:

Distribution editor status and area selection: restore default deletes the values correctly but when opening the selection dialogs still the old values are shown.

you need to click on apply or ok

#87 Updated by Andreas Müller 19 days ago

Distribution editor: Restore default removes the entry "distribution.status.term" from the above table (and completely removes all values from DB).

When reopening the entry in the table is shown again. This is inconsistent.

The main problem is that the table does not show the actual value, but only subject and predicate. So I can't see what value was restored.

Also it is not clear why this first line always seems to appear even if no preference was set yet.

#88 Updated by Andreas Müller 19 days ago

Katja Luther wrote:

Andreas Müller wrote:

Distribution editor status and area selection: restore default deletes the values correctly but when opening the selection dialogs still the old values are shown.

you need to click on apply or ok

why? This is not what I would expect.
Hmm, now I see that the dialog values are also stored if I click on Cancel. This is also not what I would expect. But it is consistent with the above issue.
Generally we need to change this. But I guess it is more difficult so we probably better open a new ticket.

#89 Updated by Katja Luther 19 days ago

Andreas Müller wrote:

Distribution editor: Restore default removes the entry "distribution.status.term" from the above table (and completely removes all values from DB).

When reopening the entry in the table is shown again. This is inconsistent.

The main problem is that the table does not show the actual value, but only subject and predicate. So I can't see what value was restored.

Also it is not clear why this first line always seems to appear even if no preference was set yet.

now the default preference is not shown in the table anymore

#90 Updated by Andreas Müller 19 days ago

In local preferences Publish Flag for "Use Default" the Camel Case is used, not the current correct label. E.g. (NotPublished) instead of "(Don't publish)"

#91 Updated by Katja Luther 19 days ago

Andreas Müller wrote:

In local preferences Publish Flag for "Use Default" the Camel Case is used, not the current correct label. E.g. (NotPublished) instead of "(Don't publish)"

is fixed, but for the next release.

#92 Updated by Andreas Müller 18 days ago

  • % Done changed from 80 to 90

can you move open issues to #8489?

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)