Project

General

Profile

bug #8389

Correct handling of default values with allowOverride=false

Added by Andreas Müller 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
New
Category:
taxeditor
Target version:
Start date:
07/18/2019
Due date:
% Done:

50%

Severity:
normal
Found in Version:

Description

It looks like currently the preferences are deleted no matter what the allowOverride value is. But if it is "false" simply deleting does not seem to be correct as this will force the user to use the default and not a local preference. Question is what do we use as value then. "Null"?

Or is there a reason for always deleteing the preference if use default is chosen?
Maybe alternatively we may disallow allowOverride=false for default values. If we decide so we need to check that default values that come from a more general subject and have a clearly defined value there can not be overriden locally.


Related issues

Related to Edit - bug #8385: Open issues in DB preferences Feedback 07/18/2019
Related to Edit - feature request #8489: Further issues for DB preferences In Progress 08/26/2019

Associated revisions

Revision e1dfd329 (diff)
Added by Katja Luther 3 months ago

ref #8389: disable allowOverride when 'use default' is selected

Revision 79bd864f (diff)
Added by Katja Luther 3 months ago

ref #8389: revert disabling of allowOverride for default selection

Revision e3fb78b6 (diff)
Added by Katja Luther 2 months ago

ref #8389: fix NPE and smaller issues in preferences

Revision d947e6ad (diff)
Added by Katja Luther 2 months ago

ref #8389: fix NPE and smaller issues in preferences

Revision 45d7ee4e (diff)
Added by Katja Luther 2 months ago

ref #8389: minor

Revision 0be6d8aa (diff)
Added by Katja Luther 2 months ago

ref #8389: minor

Revision 901d433e (diff)
Added by Katja Luther 2 months ago

ref #8389: fix preferred TaxonFeature Tree creation

Revision ad368340 (diff)
Added by Katja Luther 2 months ago

ref #8389: fix preferred TaxonFeature Tree creation

Revision 62ae7823 (diff)
Added by Katja Luther 2 months ago

ref #8389: adapt term preference handling

Revision acd9267c (diff)
Added by Katja Luther 2 months ago

ref #8389: adapt term preference handling for nametypedesignation

Revision d4527e75 (diff)
Added by Katja Luther 2 months ago

ref #8389: adapt term preference handling for nametypedesignation

Revision 03fa610a (diff)
Added by Katja Luther 2 months ago

ref #8389: common name language combo needs termtype

Revision 35910f47 (diff)
Added by Katja Luther 2 months ago

ref #8389: common name language combo needs termtype

Revision 05bfe276 (diff)
Added by Katja Luther 2 months ago

ref #8389: fix problems with search preferences

Revision 1ced89e3 (diff)
Added by Katja Luther 2 months ago

ref #8389: fix problems with search preferences

Revision 8a925e42 (diff)
Added by Katja Luther 2 months ago

ref #8389: adapt term preference handling

History

#1 Updated by Andreas Müller 4 months ago

  • Related to bug #8385: Open issues in DB preferences added

#2 Updated by Andreas Müller 3 months ago

  • Target version changed from Release 5.10 to Release 5.9

Has this been fixed in 5.9 together with #8385. To me it looks like fixed but I did not test systematically.

Please set to resolved if you think it might be completely fixed.

#3 Updated by Andreas Müller 3 months ago

#4 Updated by Katja Luther 3 months ago

The actual implementation is that if the default value is chosen allowOverride is set to true and the checkbox is disabled. If the user does not want allow override he/she has to select a concrete value.

This implementation is still missing for the following preference pages:

  • selection dialogs
  • sources

#5 Updated by Katja Luther 3 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

#6 Updated by Katja Luther 3 months ago

  • % Done changed from 0 to 50

#7 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Katja Luther wrote:

The actual implementation is that if the default value is chosen allowOverride is set to true and the checkbox is disabled. If the user does not want allow override he/she has to select a concrete value.

I don't understand this behavior. This way you can't say that you want that ALWAYS the default (this may also be the default coming from a higher "subject") should be taken, but users may not define there own behavior.
Wyh do we need to handle default different then defined
values?

#8 Updated by Katja Luther 3 months ago

Andreas Müller wrote:

Katja Luther wrote:

The actual implementation is that if the default value is chosen allowOverride is set to true and the checkbox is disabled. If the user does not want allow override he/she has to select a concrete value.

I don't understand this behavior. This way you can't say that you want that ALWAYS the default (this may also be the default coming from a higher "subject") should be taken, but users may not define there own behavior.
Wyh do we need to handle default different then defined
values?

because we decided that we want to delete the preference when the user choose the default value and then it is not possible to define whether allowOverride is set to true or false.

If we want to have the possibility to define "choose default" but do not allow override then we have to save the preference again and think about an entry for the default value.

#9 Updated by Andreas Müller 3 months ago

But this is what this ticket is all about.
I can't remember that we decided to delete if "default" was selected AND allowOverride=false. We decided only that if the complete record has a default value it should be deleted. And the complete record has default if value=default AND allowOverride=true (the later being the default for allowOverride).

#10 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved

now the allow override selection is now handled seperatly and the preference is only removed when default + allow override is selected otherwise the preference is set with null as value.

#11 Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)