bug #8389
openCorrect handling of default values with allowOverride=false
50%
Description
It looks like currently the preferences are deleted no matter what the allowOverride value is. But if it is "false" simply deleting does not seem to be correct as this will force the user to use the default and not a local preference. Question is what do we use as value then. "Null"?
Or is there a reason for always deleteing the preference if use default is chosen?
Maybe alternatively we may disallow allowOverride=false for default values. If we decide so we need to check that default values that come from a more general subject and have a clearly defined value there can not be overriden locally.
Related issues
Updated by Andreas Müller almost 5 years ago
- Related to bug #8385: Open issues in DB preferences added
Updated by Andreas Müller over 4 years ago
- Target version changed from Release 5.10 to Release 5.9
Has this been fixed in 5.9 together with #8385. To me it looks like fixed but I did not test systematically.
Please set to resolved if you think it might be completely fixed.
Updated by Andreas Müller over 4 years ago
- Related to feature request #8489: Further issues for DB preferences added
Updated by Katja Luther over 4 years ago
The actual implementation is that if the default value is chosen allowOverride is set to true and the checkbox is disabled. If the user does not want allow override he/she has to select a concrete value.
This implementation is still missing for the following preference pages:
selection dialogssources
Updated by Katja Luther over 4 years ago
- Status changed from New to Resolved
- Assignee changed from Katja Luther to Andreas Müller
Updated by Andreas Müller over 4 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
Katja Luther wrote:
The actual implementation is that if the default value is chosen allowOverride is set to true and the checkbox is disabled. If the user does not want allow override he/she has to select a concrete value.
I don't understand this behavior. This way you can't say that you want that ALWAYS the default (this may also be the default coming from a higher "subject") should be taken, but users may not define there own behavior.
Wyh do we need to handle default different then defined
values?
Updated by Katja Luther over 4 years ago
Andreas Müller wrote:
Katja Luther wrote:
The actual implementation is that if the default value is chosen allowOverride is set to true and the checkbox is disabled. If the user does not want allow override he/she has to select a concrete value.
I don't understand this behavior. This way you can't say that you want that ALWAYS the default (this may also be the default coming from a higher "subject") should be taken, but users may not define there own behavior.
Wyh do we need to handle default different then defined
values?
because we decided that we want to delete the preference when the user choose the default value and then it is not possible to define whether allowOverride is set to true or false.
If we want to have the possibility to define "choose default" but do not allow override then we have to save the preference again and think about an entry for the default value.
Updated by Andreas Müller over 4 years ago
But this is what this ticket is all about.
I can't remember that we decided to delete if "default" was selected AND allowOverride=false. We decided only that if the complete record has a default value it should be deleted. And the complete record has default if value=default AND allowOverride=true (the later being the default for allowOverride).
Updated by Katja Luther over 4 years ago
- Status changed from Feedback to Resolved
now the allow override selection is now handled seperatly and the preference is only removed when default + allow override is selected otherwise the preference is set with null as value.
Updated by Katja Luther over 4 years ago
- Assignee changed from Katja Luther to Andreas Müller