Project

General

Profile

Actions

bug #8494

open

Better ABCD Preferences Page

Added by Katja Luther over 4 years ago. Updated almost 3 years ago.

Status:
In Progress
Priority:
Priority14
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Severity:
normal
Found in Version:

Description

to be done

see also #8489

also #8385#note-51,

#8385#note-52

Why does the nomenclatural code not provide a default? Is this wanted? Does ABCD not need a nomenclatural code? I remember ABCD distinguishes botanical, zoological, ... by itself so maybe this parameter is not needed and only comes from the super class? If so, we should remove it. If not, and if a null value is not explicitly handled without using a default instead we should define the usage of default here, I guess. But I don't know the import so well so maybe there is a reason for the current implementation.

=> mostly the nomenclatural code comes from the biocase response, but sometimes it is missing and then the import needs the nomenclatural code for namecreation

now the preferred Nomenclatural code of the instance is used as default.

#8385#note-55

In general we should distinguish clearly between the list of available providers (may it be ABCD providers or DNA providers) and the default or predefined single values for the import configuration which provider to use for ABCD and for DNA. This is currently still mixed up. (But might be a new ticket)

#8385#note-56:

This is fixed but still "Restore default" does not completely remove the preference (and even does not clear the existing list, what I would expect)


Related issues

Related to EDIT - bug #8385: Open issues in DB preferencesClosedKatja Luther

Actions
Related to EDIT - feature request #8489: Further issues for DB preferencesResolvedAndreas Müller

Actions
Actions #1

Updated by Katja Luther over 4 years ago

  • Related to bug #8385: Open issues in DB preferences added
Actions #2

Updated by Andreas Müller over 4 years ago

Actions #3

Updated by Andreas Müller over 4 years ago

  • Description updated (diff)
Actions #4

Updated by Andreas Müller over 4 years ago

  • Description updated (diff)
Actions #5

Updated by Andreas Müller over 4 years ago

  • Description updated (diff)
Actions #6

Updated by Katja Luther over 4 years ago

now the Unit ID mapping is a combo box and the dna provider is a combo box containing the providers defined in the preferences as well.

Actions #7

Updated by Katja Luther over 4 years ago

  • Description updated (diff)
Actions #8

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 5.10 to Release 5.11
Actions #9

Updated by Katja Luther over 4 years ago

  • Description updated (diff)
  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

The issues above are solved, so I think we can close this ticket.

Actions #10

Updated by Andreas Müller over 4 years ago

  • Target version changed from Release 5.11 to Release 5.10
Actions #11

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

is #8385#note-51 already fixed? It is part of this ticket description! (copied from)

The field NomenclaturalCode still does not seem to handle "default" same as others

Actions #12

Updated by Andreas Müller over 4 years ago

Trying to create a new provider results in

login : admin
editor version : 5.10.0.201909180750
server : localhost (localhost mgd.)
schema version : 5.8.2.0.20190815
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.IllegalArgumentException: Index out of bounds
    at org.eclipse.swt.SWT.error(SWT.java:4514)
    at org.eclipse.swt.SWT.error(SWT.java:4448)
    at org.eclipse.swt.SWT.error(SWT.java:4419)
    at org.eclipse.swt.widgets.Widget.error(Widget.java:482)
    at org.eclipse.swt.widgets.List.add(List.java:150)
    at eu.etaxonomy.taxeditor.preference.ListComponent$AddListener.mouseUp(ListComponent.java:293)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:221)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
    at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
    at org.eclipse.jface.window.Window.open(Window.java:794)
    at eu.etaxonomy.taxeditor.workbench.handler.OpenAdminPreferencesHandler.execute(OpenAdminPreferencesHandler.java:125)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
    at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:282)
    at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:264)
    at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
    at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
    at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
    at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:488)
    at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
    at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:433)
    at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:454)
    at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem$3.handleEvent(AbstractContributionItem.java:482)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
    at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
    at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
    at eu.etaxonomy.taxeditor.Application.start(Application.java:24)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
Actions #13

Updated by Andreas Müller over 4 years ago

Second time it worked but still there was an empty entry in the provider list

Actions #14

Updated by Andreas Müller over 4 years ago

The "New provider" text field should have a label "New provider" or similar. Also the "Add Provider" button should be placed behind the text field to make clear that the text in the "New provider" textfield will be added to the list.

Actions #15

Updated by Andreas Müller over 4 years ago

  • Description updated (diff)
Actions #16

Updated by Andreas Müller over 4 years ago

This is fixed but still "Restore default" does not completely remove the preference (and even does not clear the existing list, what I would expect)

This to me also does not seem to be fixed yet. Did you push your ABCD preference changes?

Actions #17

Updated by Katja Luther over 4 years ago

Andreas Müller wrote:

This is fixed but still "Restore default" does not completely remove the preference (and even does not clear the existing list, what I would expect)

This to me also does not seem to be fixed yet. Did you push your ABCD preference changes?

maybe jenkins did not build, I started the job now.

Actions #18

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to In Progress

I move this to 5.11 to solve the layout issues.

Actions #19

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 5.10 to Release 5.11
Actions #20

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 5.11 to Release 5.12
Actions #21

Updated by Katja Luther about 4 years ago

  • Target version changed from Release 5.12 to Release 5.13
Actions #22

Updated by Katja Luther about 4 years ago

  • Target version changed from Release 5.13 to Release 5.14

still have a look by myself if everything is fixed.

Actions #23

Updated by Andreas Müller almost 4 years ago

  • Target version changed from Release 5.14 to Release 5.15
Actions #24

Updated by Katja Luther almost 4 years ago

  • Target version changed from Release 5.15 to Release 5.18
Actions #25

Updated by Katja Luther over 3 years ago

  • Target version changed from Release 5.18 to Release 5.19
Actions #26

Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 5.19 to Release 5.21
Actions #27

Updated by Katja Luther about 3 years ago

  • Target version changed from Release 5.21 to Release 5.22
Actions #28

Updated by Katja Luther almost 3 years ago

  • Target version changed from Release 5.22 to Release 5.46
Actions

Also available in: Atom PDF