Project

General

Profile

Actions
Copy link

feature request #8062

closed

Make default preferences deletable serverside

Added by Andreas Müller almost 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Priority14
Assignee:
Andreas Müller
Category:
cdmlib
Target version:
Release 5.8
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:
preferences

Description

Currently when storing a CdmPreference it can not be checked if it holds the default value and therefore can be deleted. This is because CdmPreference holds the predicate as string only and therefore does not hold the default value. Only for those predicates defined server side it is possible to retrieve default value.

There are various possibilities to pass the default value.

  1. Use IPreferencePredicate in CdmPreference.prefKey instead of String
  2. Override set(CdmPreference) in PreferenceService to allow to pass an extra attribute "default value"
  3. Leave it to the client to delete default values (this requires a delete method) => we finally took this solution, see also #8045
  4. tbc

Related issues

Related to EDIT - bug #7849: Improve DB Preferences handling and saving in TaxEditorClosedKatja Luther

Actions
Related to EDIT - feature request #7902: Allow default values for PreferencePredicatesClosedAndreas Müller

Actions
Related to EDIT - feature request #8045: Improve handling of default values and override in local preferencesFeedbackKatja Luther

Actions
Copied to EDIT - task #9826: Move pure TaxEditor predicates back to taxeditor codeNewKatja Luther

Actions
Actions
Copy link
 #1

Updated by Andreas Müller almost 4 years ago

  • Related to bug #7849: Improve DB Preferences handling and saving in TaxEditor added
Actions
Copy link
 #2

Updated by Andreas Müller almost 4 years ago

Actions
Copy link
 #3

Updated by Andreas Müller almost 4 years ago

The first implementation seems to work for all server side preferences using PreferencePredicates. This is only a first step.

Actions
Copy link
 #4

Updated by Andreas Müller almost 4 years ago

  • Status changed from New to In Progress
  • Target version changed from Release 5.5 to Release 5.6
Actions
Copy link
 #5

Updated by Andreas Müller almost 4 years ago

  • Priority changed from New to Highest
Actions
Copy link
 #6

Updated by Andreas Müller almost 4 years ago

  • Target version changed from Release 5.6 to Release 5.7
Actions
Copy link
 #7

Updated by Andreas Müller almost 4 years ago

  • Target version changed from Release 5.7 to Release 5.8
Actions
Copy link
 #8

Updated by Andreas Müller over 1 year ago

  • Status changed from In Progress to Resolved
  • Target version changed from Release 5.8 to Release 5.25
  • % Done changed from 0 to 30

Check, how far this is fixed. Create open issues ticket and move this ticket back to 5.8

Actions
Copy link
 #9

Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.25 to Release 5.37
Actions
Copy link
 #10

Updated by Andreas Müller over 1 year ago

  • Priority changed from Highest to Priority14
Actions
Copy link
 #11

Updated by Andreas Müller over 1 year ago

  • Related to feature request #8045: Improve handling of default values and override in local preferences added
Actions
Copy link
 #12

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

In later discussions (e.g. related to #8045) we decided that it makes sense to distinguish default values (not existing values) from preferences that has the same value as the default value. This has an advantage in case a default value of a preference changes as you can still distinguish between an explicitly chosen value (similar to the default value) and a non-chosen value (a real default value).
Also it makes the handling between serverside preferences and client side preferences easier.

Actions
Copy link
 #13

Updated by Andreas Müller over 1 year ago

  • Copied to task #9826: Move pure TaxEditor predicates back to taxeditor code added
Actions
Copy link
 #14

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
  • Status changed from Resolved to Closed
  • Target version changed from Release 5.37 to Release 5.8
  • % Done changed from 30 to 100

So we finally chose solution 3 (from the ticket description) and had to revert some of the changes made here previously (#8045). The ticket can be closed.
We still may move the pure editor predicates back to TaxEditor code (#9826)

Actions
Copy link
 #15

Updated by Andreas Müller over 1 year ago

  • Tags set to preferences
Actions
Copy link

Also available in: Atom PDF