Project

General

Profile

feature request #8045

Improve handling of default values and override in local preferences

Added by Katja Luther 10 months ago. Updated 5 months ago.

Status:
Feedback
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
01/31/2019
Due date:
% Done:

50%

Severity:
normal

Description

For selection of default, dbPreference or explicit local value the local preference pages should have combo boxes.

Depending on his selection the local preference should be handled:

  • default: save the default value
  • db preference: delete the value in local preferences if exist
  • explicit value: save to preference file

Also check restore behavior (see #7849#note-80


Related issues

Related to Edit - bug #7856: Allow local override for distribution vocabularies Closed 10/23/2018
Related to Edit - bug #7849: Improve DB Preferences handling and saving in TaxEditor Feedback 10/23/2018
Related to Edit - feature request #8092: set default for term and vocabulary selection preferences in selection wizard Closed 02/11/2019
Related to Edit - feature request #8309: Implement preferences with predicate and subject in local preferences New 05/28/2019

Associated revisions

Revision 9fe7e119 (diff)
Added by Katja Luther 7 months ago

ref #8045: show possible entries for preferences in combo boxes and show default value

Revision 755105d4 (diff)
Added by Katja Luther 7 months ago

ref #8045: show possible entries for preferences in combo boxes and show default value - continue

Revision 1000779d (diff)
Added by Katja Luther 7 months ago

ref #8045: add Interface for Preference Enums

Revision cc1302bd (diff)
Added by Katja Luther 7 months ago

ref #8045: check whether all db preferences are deleted from DB if value is default value

Revision 63732a7c (diff)
Added by Katja Luther 7 months ago

ref #8045: further implementation for default/explicit value selection preference pages

Revision 4d025474 (diff)
Added by Katja Luther 7 months ago

ref #8045: add remove to preference service and dao

Revision bfaa6a16 (diff)
Added by Katja Luther 7 months ago

ref #8045: add toString() to the preference enums

History

#1 Updated by Andreas Müller 10 months ago

I don't know if we really need "db preference" as explicit value. It makes it more difficult to understand and there is almost no added value (compared to "default". So we only need "default" and the list of explicit values. If "default" is chosen then the preference is deleted from the local preferences.

#2 Updated by Katja Luther 10 months ago

I would show the value of the db preference in the drop down, but with ("global") or ("db") behind

#3 Updated by Andreas Müller 10 months ago

Katja Luther wrote:

I would show the value of the db preference in the drop down, but with ("global") or ("db") behind

OK, if this is not an explicit entry but if it is only added to the anyway existing entry for this value. Maybe "recommended" is another possible label. A bit long but standard for many such cases.

#4 Updated by Katja Luther 10 months ago

  • Related to bug #7856: Allow local override for distribution vocabularies added

#5 Updated by Andreas Müller 10 months ago

  • Related to bug #7849: Improve DB Preferences handling and saving in TaxEditor added

#6 Updated by Andreas Müller 10 months ago

  • Subject changed from local preferences pages with drop down to Improve handling of default values and override in local preferences

#7 Updated by Andreas Müller 10 months ago

  • Target version changed from Release 5.6 to Reviewed Next Major Release

#8 Updated by Andreas Müller 5 months ago

  • Status changed from New to Feedback
  • Target version changed from Reviewed Next Major Release to Release 5.8

Looks like this has been implemented in 5.8 so I switch milestone.
Are there open issues?

#9 Updated by Andreas Müller 5 months ago

  • % Done changed from 0 to 50

Choosing "default" for local preference "nomenclatural status" has no effect. It uses the explicitly chosen values from the list above. Anyway, if "default" is chosen the list should select only those status which are available according to the default/dbPrefs. Also the list should be disabled I guess.

#10 Updated by Andreas Müller 5 months ago

For nomencl.Code. implementation is still missing or incorrect. Also we may discuss if in DB prefs we should allow "Use default" which is currently not available but by default nom.code is set to ICNAFP

#11 Updated by Andreas Müller 5 months ago

  • Related to feature request #8092: set default for term and vocabulary selection preferences in selection wizard added

#12 Updated by Andreas Müller 5 months ago

  • Description updated (diff)

#13 Updated by Andreas Müller 5 months ago

Andreas Müller wrote:

Choosing "default" for local preference "nomenclatural status" has no effect. It uses the explicitly chosen values from the list above. Anyway, if "default" is chosen the list should select only those status which are available according to the default/dbPrefs. Also the list should be disabled I guess.

For ranks it is the opposite.

#14 Updated by Andreas Müller 5 months ago

  • Description updated (diff)

#15 Updated by Andreas Müller 5 months ago

  • Description updated (diff)

#16 Updated by Andreas Müller 5 months ago

For the above issues see also #8323#note-4

#17 Updated by Andreas Müller 5 months ago

with the new implementation of distribution status with different subjects if allowOverride=false in DB prefs this does not disable the local pref button for this pref. I did not check if the local pref is used in this case.

We need to guarantee that even for disallowOverride the local pref is always disabled. This must be the case even if the DB pref subject is defined more generic. Only if a specific subject allows override while a more generic disallows especially for this subject local prefs should be available.
Anyway, the area specific distribution status still needs to be implemented for local prefs. Currently it only exists for DB prefs.

See also #7920#note-19

#18 Updated by Andreas Müller 5 months ago

  • Related to feature request #8309: Implement preferences with predicate and subject in local preferences added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)