Project

General

Profile

Actions
Copy link

bug #8034

closed

Recently used references shows all references

Added by Andreas Müller over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Katja Luther
Category:
taxeditor
Target version:
Release 5.10
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

... but should show only those of the correct type.

E.g. if you search for the journal of an article you may also get Proceedings (if you have selected them recently). This is not correct and may lead to inconsistent data.

Files

picture417-1.png (49.5 KB) picture417-1.png Patrick Plitzner, 09/18/2019 03:33 PM

Related issues

Related to EDIT - bug #7985: Remove Print Series from InProceedings, use "Proceedings"ClosedKatja Luther

Actions
Related to EDIT - bug #8961: Using the selection dialogue for nomenclatural references removes the recently used listClosedKatja Luther

Actions
Actions
Copy link
 #1

Updated by Andreas Müller over 5 years ago

  • Related to bug #7985: Remove Print Series from InProceedings, use "Proceedings" added
Actions
Copy link
 #2

Updated by Andreas Müller over 5 years ago

  • Subject changed from Recently used references shows all reference to Recently used references shows all references
Actions
Copy link
 #3

Updated by Katja Luther over 5 years ago

  • Priority changed from New to Highest
  • Target version changed from Release 5.6 to Release 5.7
Actions
Copy link
 #4

Updated by Katja Luther about 5 years ago

  • Target version changed from Release 5.7 to Release 5.8
Actions
Copy link
 #5

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 5.8 to Release 5.10
Actions
Copy link
 #6

Updated by Katja Luther almost 5 years ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Patrick Plitzner

this is fixed. please review.

For review you should open a reference selection dialog and choose a journal.
In a second selection you should select any other type of reference

Then go to another reference of type article and open the inreference selection dialog and then only the last selected journal should be diplayed in the preselected list of references.

Actions
Copy link
 #7

Updated by Katja Luther almost 5 years ago

  • % Done changed from 0 to 50
Actions
Copy link
 #8

Updated by Patrick Plitzner almost 5 years ago

I am not sure if I tested this correctly. Here is what I did:

  1. I selected a Generic reference as secundum for one taxon.
  2. Then I hit "Edit" on that reference and it propsed the reference itself when trying to add an inReference (see Screenshot)

Actions
Copy link
 #9

Updated by Katja Luther almost 5 years ago

the reference needs to be an article because therefore an inreference type exist

Actions
Copy link
 #10

Updated by Patrick Plitzner almost 5 years ago

Another thing I tested:

  1. I imported a specimen via ABCD import which had the generic reference "DNA_Bank"
  2. I tried to select an existing book reference (checked in bulk editor before) which did not show in the selection dialog.
  3. I deleted the import reference
  4. Then the book showed up.

This feels very unintuitive. I only realized that deleting could help because I knew of this ticket and supposed that the book is probably filtered because it was not of the type of current reference (generic).

Actions
Copy link
 #11

Updated by Patrick Plitzner almost 5 years ago

ok, I tested the recently selected references with Article and Journal as InReference which works fine. Nevertheless the issue mentioned in #8034#note-10 feels strange. But we may move this to the next milestone

Actions
Copy link
 #12

Updated by Katja Luther almost 5 years ago

Did you selected the book in a selection dialog or only in bulk editor? The recently selected references are only for selection dialogs

Actions
Copy link
 #13

Updated by Katja Luther almost 5 years ago

  • Assignee changed from Katja Luther to Patrick Plitzner
Actions
Copy link
 #14

Updated by Patrick Plitzner almost 5 years ago

  • Assignee changed from Patrick Plitzner to Katja Luther

Katja Luther wrote:

Did you selected the book in a selection dialog or only in bulk editor? The recently selected references are only for selection dialogs

No, sorry, maybe I wrote this too confusing. I just wanted to say that I had a look at all references in the bulk editor to see which are available and should be shown.

I only edited in the details view for the taxon.

Actions
Copy link
 #15

Updated by Patrick Plitzner almost 5 years ago

Hmm, now when I already have a reference for the secundum, the selection dialog only shows some of the last used references but does find any other references when entering '?' or any letter

Actions
Copy link
 #16

Updated by Katja Luther almost 5 years ago

Patrick Plitzner wrote:

Hmm, now when I already have a reference for the secundum, the selection dialog only shows some of the last used references but does find any other references when entering '?' or any letter

this should be fixed.

Actions
Copy link
 #17

Updated by Katja Luther almost 5 years ago

  • Status changed from Feedback to Resolved

fix is committed, please review.

Actions
Copy link
 #18

Updated by Katja Luther almost 5 years ago

  • Assignee changed from Katja Luther to Patrick Plitzner
Actions
Copy link
 #19

Updated by Patrick Plitzner almost 5 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Patrick Plitzner to Katja Luther
  • % Done changed from 50 to 100

works fine

Actions
Copy link
 #20

Updated by Andreas Müller over 4 years ago

  • Related to bug #8961: Using the selection dialogue for nomenclatural references removes the recently used list added
Actions
Copy link

Also available in: Atom PDF