Project

General

Profile

bug #8034

Recently used references shows all references

Added by Andreas Müller 10 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
01/29/2019
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

... but should show only those of the correct type.

E.g. if you search for the journal of an article you may also get Proceedings (if you have selected them recently). This is not correct and may lead to inconsistent data.

picture417-1.png View (49.5 KB) Patrick Plitzner, 09/18/2019 03:33 PM


Related issues

Related to Edit - bug #7985: Remove Print Series from InProceedings, use "Proceedings" Closed 01/14/2019

Associated revisions

Revision 6af26c13 (diff)
Added by Katja Luther about 2 months ago

ref #8034: filter last selected references by inReference type

Revision e126ec3a (diff)
Added by Katja Luther about 2 months ago

ref #8034: filter last selected references by inReference type

Revision 44bee70c (diff)
Added by Katja Luther about 2 months ago

fix #8034: preselected references should have correct type

Revision 3ea88987 (diff)
Added by Katja Luther about 2 months ago

ref #8034: fix handling with recently selected references in s

Revision 25e92728 (diff)
Added by Katja Luther about 2 months ago

ref #8034: fixes for recently selected references

History

#1 Updated by Andreas Müller 10 months ago

  • Related to bug #7985: Remove Print Series from InProceedings, use "Proceedings" added

#2 Updated by Andreas Müller 10 months ago

  • Subject changed from Recently used references shows all reference to Recently used references shows all references

#3 Updated by Katja Luther 9 months ago

  • Priority changed from New to Highest
  • Target version changed from Release 5.6 to Release 5.7

#4 Updated by Katja Luther 7 months ago

  • Target version changed from Release 5.7 to Release 5.8

#5 Updated by Andreas Müller 4 months ago

  • Target version changed from Release 5.8 to Release 5.10

#6 Updated by Katja Luther about 2 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Patrick Plitzner

this is fixed. please review.

For review you should open a reference selection dialog and choose a journal.
In a second selection you should select any other type of reference

Then go to another reference of type article and open the inreference selection dialog and then only the last selected journal should be diplayed in the preselected list of references.

#7 Updated by Katja Luther about 2 months ago

  • % Done changed from 0 to 50

#8 Updated by Patrick Plitzner about 2 months ago

  • File picture417-1.png View added
  • Status changed from Resolved to Feedback
  • Assignee changed from Patrick Plitzner to Katja Luther

I am not sure if I tested this correctly. Here is what I did:

  1. I selected a Generic reference as secundum for one taxon.
  2. Then I hit "Edit" on that reference and it propsed the reference itself when trying to add an inReference (see Screenshot)

#9 Updated by Katja Luther about 2 months ago

the reference needs to be an article because therefore an inreference type exist

#10 Updated by Patrick Plitzner about 2 months ago

Another thing I tested:

  1. I imported a specimen via ABCD import which had the generic reference "DNA_Bank"
  2. I tried to select an existing book reference (checked in bulk editor before) which did not show in the selection dialog.
  3. I deleted the import reference
  4. Then the book showed up.

This feels very unintuitive. I only realized that deleting could help because I knew of this ticket and supposed that the book is probably filtered because it was not of the type of current reference (generic).

#11 Updated by Patrick Plitzner about 2 months ago

ok, I tested the recently selected references with Article and Journal as InReference which works fine. Nevertheless the issue mentioned in #8034#note-10 feels strange. But we may move this to the next milestone

#12 Updated by Katja Luther about 2 months ago

Did you selected the book in a selection dialog or only in bulk editor? The recently selected references are only for selection dialogs

#13 Updated by Katja Luther about 2 months ago

  • Assignee changed from Katja Luther to Patrick Plitzner

#14 Updated by Patrick Plitzner about 2 months ago

  • Assignee changed from Patrick Plitzner to Katja Luther

Katja Luther wrote:

Did you selected the book in a selection dialog or only in bulk editor? The recently selected references are only for selection dialogs

No, sorry, maybe I wrote this too confusing. I just wanted to say that I had a look at all references in the bulk editor to see which are available and should be shown.

I only edited in the details view for the taxon.

#15 Updated by Patrick Plitzner about 2 months ago

Hmm, now when I already have a reference for the secundum, the selection dialog only shows some of the last used references but does find any other references when entering '?' or any letter

#16 Updated by Katja Luther about 2 months ago

Patrick Plitzner wrote:

Hmm, now when I already have a reference for the secundum, the selection dialog only shows some of the last used references but does find any other references when entering '?' or any letter

this should be fixed.

#17 Updated by Katja Luther about 2 months ago

  • Status changed from Feedback to Resolved

fix is committed, please review.

#18 Updated by Katja Luther about 2 months ago

  • Assignee changed from Katja Luther to Patrick Plitzner

#19 Updated by Patrick Plitzner about 2 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Patrick Plitzner to Katja Luther
  • % Done changed from 50 to 100

works fine

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)