Project

General

Profile

Actions

bug #5670

closed

Refresh of Taxon Navigator

Added by Katja Luther over 6 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

80%

Estimated time:
Severity:
normal
Found in Version:

Description

Reimplement the refresh of the navigator.

The refresh itself works now, but now the navigator is completely refreshed if it is not needed and this yields to performance problems.

Refresh removed for:

  • set subtree publish / secundum
  • new taxon node cancel

Refresh parent only for:

  • save Name Editor

Open issues:

  • New Taxon Node / Update Taxon Node
  • Move taxon node
  • Change synonymToAccepted
  • Swap syn-acc
  • bulk editor for name and taxon
  • tbc

Files

picture630-1.png (3.36 KB) picture630-1.png Andreas Müller, 03/05/2021 11:58 AM

Related issues

Related to EDIT - bug #7521: refresh of taxonnavigator sometimes does not work for moving taxonnodesClosedKatja Luther

Actions
Related to EDIT - bug #8582: Taxon Navigator: Classification label not refreshed & new taxa not visibleClosedKatja Luther

Actions
Related to EDIT - feature request #9514: Open issues for taxon navigator refreshNewKatja Luther

Actions
Related to EDIT - bug #8955: After saving a taxon the taxon navigator scrolls the taxon to the bottomNewKatja Luther

Actions
Copied from EDIT - bug #5289: trying to delete an already deleted object leads to not correctly handled exceptionClosedKatja Luther

Actions
Actions #1

Updated by Andreas Müller about 6 years ago

  • Description updated (diff)
  • Assignee changed from Andreas Müller to Katja Luther
Actions #2

Updated by Andreas Kohlbecker about 3 years ago

  • Private changed from Yes to No

I think this ticket needs more details.

Refresh of what? General refresh of all nodes and the classifications?

Actions #3

Updated by Andreas Kohlbecker about 3 years ago

  • Copied from bug #5289: trying to delete an already deleted object leads to not correctly handled exception added
Actions #4

Updated by Andreas Kohlbecker about 3 years ago

  • Related to bug #7521: refresh of taxonnavigator sometimes does not work for moving taxonnodes added
Actions #5

Updated by Andreas Kohlbecker about 3 years ago

  • Related to bug #8582: Taxon Navigator: Classification label not refreshed & new taxa not visible added
Actions #6

Updated by Andreas Kohlbecker about 3 years ago

  • Subject changed from refresh of navigator to refresh of Taxon Navigator
Actions #7

Updated by Katja Luther almost 2 years ago

  • Subject changed from refresh of Taxon Navigator to Refresh of Taxon Navigator
  • Description updated (diff)
  • Status changed from New to In Progress
  • Assignee changed from Katja Luther to Andreas Müller

First issues:

  • add a parameter whether the navigator should be updated or not.
  • do not refresh the navigator if taxon node wizard was closed with cancel.
  • update caches does not need a refresh
  • set secundum and set publish flag does not need a refresh

please review the first steps.

Actions #8

Updated by Katja Luther almost 2 years ago

Refresh only the handled taxonnode for changes in taxa or names.

Actions #9

Updated by Andreas Müller almost 2 years ago

  • Target version changed from Unassigned CDM tickets to Release 5.21
  • % Done changed from 0 to 10

is this fixed/for review? If not can you leave a note on open issues?

Actions #10

Updated by Katja Luther almost 2 years ago

in #note-7 the steps already solved are described, if there are other issues we should create a new ticket or keep this one open.

Actions #11

Updated by Andreas Müller almost 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 10 to 30

I put this to resolved so I have it on the review list.
Before closing the ticket we should create a new ticket for open issues.

Actions #12

Updated by Andreas Müller over 1 year ago

Now, when changing the name in NameEditor the new taxon is not rearranged within the parent taxon yet.
I think you mentioned recently that you had worked on this but it does not work yet.

Actions #13

Updated by Katja Luther over 1 year ago

  • Status changed from Feedback to Resolved
  • % Done changed from 30 to 50
Actions #14

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

Now, when changing the name in NameEditor the new taxon is not rearranged within the parent taxon yet.
I think you mentioned recently that you had worked on this but it does not work yet.

now, it works with updating the parent node.

Actions #15

Updated by Katja Luther over 1 year ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #16

Updated by Andreas Müller over 1 year ago

open issues can be taken from callhierarchy of WorkbenchEventConstant.REFRESH_NAVIGATOR

Actions #17

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Can you please check the lists in the description if they are correct and complete?

(I still have to wait for the build to review the last change)

Actions #18

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

Can you please check the lists in the description if they are correct and complete?

(I still have to wait for the build to review the last change)

New Taxon Node / Update Taxon Node
Move taxon node -> works, but new parent taxon node is still collapsed
Change synonymToAccepted
Swap syn-acc -> works as expected
bulk editor for name and taxon

Actions #19

Updated by Andreas Müller over 1 year ago

  • % Done changed from 50 to 80

I tested NameEditor save and swap and both work well.

Only minor question I have is: can we easily avoid refresh completely if the taxon label does not save at all. Then even the parent refresh is not necessary (performance wise this is probably only a minor issue in most cases compared to taxon save performance, however it could be an improvement and in most cases the name titlecache of the accepted taxon does not change when a name editor is changed).

I think we can close this ticket an move the open issues to a new ticket.

Actions #20

Updated by Katja Luther over 1 year ago

  • Status changed from Feedback to Closed

create open issues ticket #9514

Actions #21

Updated by Katja Luther over 1 year ago

  • % Done changed from 80 to 100
Actions #22

Updated by Katja Luther over 1 year ago

Actions #23

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
Actions #24

Updated by Andreas Müller over 1 year ago

  • Status changed from Closed to Feedback

What is about the other open issues which you did not move to the new ticket yet:

  • New Taxon Node / Update Taxon Node
  • Change synonymToAccepted
  • bulk editor for name and taxon

Are they fixed already or did you forget to move them to the new ticket?

Actions #25

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

What is about the other open issues which you did not move to the new ticket yet:

  • New Taxon Node / Update Taxon Node - new Taxon works, update needs to be moved
  • Change synonymToAccepted - works
  • bulk editor for name and taxon - needs to be moved

Are they fixed already or did you forget to move them to the new ticket?

Actions #26

Updated by Andreas Müller over 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 100 to 80

OK, I will review those which work already.

Actions #27

Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Seems to work.
Only thing I realized, when creating a new taxon via TaxonNode assistant the navigator collapses afterwards at the parent position a reopens the node. Is this necessary? It does not seem to happen when e.g. changing syn to acc though this also creates a new child node to the parent.

Actions #28

Updated by Katja Luther over 1 year ago

  • Status changed from Feedback to Closed

Andreas Müller wrote:

Seems to work.
Only thing I realized, when creating a new taxon via TaxonNode assistant the navigator collapses afterwards at the parent position a reopens the node. Is this necessary? It does not seem to happen when e.g. changing syn to acc though this also creates a new child node to the parent.

I move this to the follow up ticket.

Actions #29

Updated by Andreas Müller over 1 year ago

  • Related to bug #8955: After saving a taxon the taxon navigator scrolls the taxon to the bottom added
Actions

Also available in: Atom PDF