Project

General

Profile

Actions

feature request #9338

closed

Restructure term menus

Added by Andreas Müller almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

We now have the vocabulary menu and the term tree menu. Both look very different but should look similar.

To me it looks like the term tree menu is more promissing as it uses groups instead of submenus. This also allows ordering by importance, not pure alphabet. However ordering might be difficult in an i18n context then if we use still alphabetic ordering within the groups.

This ticket needs discussion before implementation.


Files

picture753-1.png (3.81 KB) picture753-1.png Andreas Müller, 01/22/2021 03:28 PM

Related issues

Related to EDIT - feature request #9337: Open issues for reimplementation of termtree editorsClosedKatja Luther

Actions
Has duplicate EDIT - bug #8660: Generic menu creation for Term treesDuplicateKatja Luther

Actions
Copied from EDIT - bug #8774: Reimplement term tree editors to implement the general save strategyClosedKatja Luther

Actions
Copied to EDIT - feature request #9409: [Decision] Which terms should be editable in term tree editor (and vocabulary editor)NewAndreas Müller

Actions
Actions #1

Updated by Andreas Müller almost 2 years ago

I put milestone to 5.19 as it belongs to #8774 content wise.

Actions #2

Updated by Andreas Müller almost 2 years ago

  • Copied from bug #8774: Reimplement term tree editors to implement the general save strategy added
Actions #3

Updated by Andreas Müller almost 2 years ago

Actions #4

Updated by Andreas Müller almost 2 years ago

Actions #5

Updated by Andreas Müller almost 2 years ago

Actions #6

Updated by Andreas Müller almost 2 years ago

  • Related to bug #8660: Generic menu creation for Term trees added
Actions #7

Updated by Andreas Müller almost 2 years ago

This ticket seems to be somehow contradictory to #8660. However, currently I think a menu not automatically created is preferable as it allows more content wise structuring.

My suggestion for ordering is

Feature
Character
Property
State
Structure
Structure Modifier (Modifier?)


Named Area
Named Area Level
Named Area Type
Distribution Status (use same label for term and tree editor, so not Presence Absence term as currently for vocabularies


Rank (only for tree)
NameRelationshipType (only for tree)
TaxonRelationshipType (only for tree for now, should be editable later)
NameTypeDesignationStatus (only for tree)
NomenclaturalStatusType (only for tree)
SpecimenTypeDesignationStatus (only for tree) - discuss if a common tree for both TypeDesignationStatus variants is needed
TaxonNodeAgentRelationType (should be editable but is not yet)


Language (only for trees for now)


Annotation Type
Identifier Type
Marker Type
Extension Type


Modifier
Kind of Unit
Determination Modifier
Scope

Sex

Stage
DNA Marker

====

Open term types:

DerivationEventType (not in use yet?) => if to use last section
DnaQualityType (fixed vocabulary?) => if to use last sectioni
HybridRelationshipType (currently not in use , should go to taxon sectioni with "rank"
InstitutionType (not in use) => section?
Material and MaterialOrMethod (in use already?) => if to use last section
MeasurementUnit (currently fixed, probably model update needed to open it for general use) => if to use in first section (descriptive data)
Method , same as MaterialOrMethod ?
NaturalLangaugeTerm (still needed?) ?> if to use first section
ReferenceSystem (to discuss) => if to use NamedArea section
Rights Type (in trees only) - not sure if needed => supplemental data section
SynonymType (for now not editable, maybe will be turned to an enum in future) => otherwise go to name section withs rank
TermRelationType (currently not to be used externally)
TextFormat (currently not in use)
unknown (currently not in use)

Actions #8

Updated by Andreas Müller almost 2 years ago

  • Related to deleted (bug #8660: Generic menu creation for Term trees)
Actions #9

Updated by Andreas Müller almost 2 years ago

  • Has duplicate bug #8660: Generic menu creation for Term trees added
Actions #10

Updated by Katja Luther almost 2 years ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Both menues have the same structure and also the handling of opening the editors are synchronized.

Actions #11

Updated by Andreas Müller almost 2 years ago

TaxonNodeAgentRelationType should be also editable for vocabularies (sorry, my comment was maybe not clear)

Language should have a separator below.

Actions #12

Updated by Andreas Müller almost 2 years ago

And a small change to my above description: can we put Modifier and Scope into 1 section followed by another section having Kind of Unit, Determination Modifier, Sex, Stage, DnaMarker.
The later are all Specimen related while the former are general terms.

Actions #13

Updated by Andreas Müller almost 2 years ago

  • % Done changed from 0 to 90

The new menu looks much better now (also mentioned by AK recently). Good we changed this.

Actions #14

Updated by Andreas Müller almost 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
Actions #15

Updated by Andreas Müller almost 2 years ago

  • Copied to feature request #9409: [Decision] Which terms should be editable in term tree editor (and vocabulary editor) added
Actions #16

Updated by Andreas Müller almost 2 years ago

I moved questions on unhandled term types to new ticket #9409

Actions #17

Updated by Katja Luther almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Adapted the menues, please have a look.

Actions #18

Updated by Andreas Müller almost 2 years ago

There is another issue for trees:

Dna Marker is duplicated, the first is wrong. At the same time NameTypeDesignationStatus is missing.

Actions #19

Updated by Andreas Müller almost 2 years ago

Some translations are missing.

Easy: Language, Extension-Type

Maybe also possible: Stage, Nametypedesignation Status, Specimentypedesignation Status, Taxonnode Agent Relation Type

Discussion needed: Character, Property (to avoid ambiguity)

Actions #20

Updated by Katja Luther almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

The german labels are adapted, please have a look whether everything is ok now.

Actions #21

Updated by Andreas Müller almost 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 90 to 70

I found some further issues:

  • Namerelationshiptype tree editor opens taxon relationship trees and the other way round
  • Nametype designation status does not open anything

Please check all trees if they do the correct thing again. I did not check everything.

Actions #22

Updated by Andreas Müller almost 2 years ago

translation works now as expected

Actions #23

Updated by Katja Luther almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

I found some further issues:

  • Namerelationshiptype tree editor opens taxon relationship trees and the other way round
  • Nametype designation status does not open anything

Please check all trees if they do the correct thing again. I did not check everything.

Checked all editors and adapted name/taxon relationship and nameTypeDesignation trees

Actions #24

Updated by Andreas Müller almost 2 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 70 to 100

I did not check again but I guess we can close this ticket.

Actions

Also available in: Atom PDF