Project

General

Profile

feature request #9338

Restructure term menus

Added by Andreas Müller 11 months ago. Updated 9 months ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
12/01/2020
Due date:
% Done:

100%

Severity:
normal

Description

We now have the vocabulary menu and the term tree menu. Both look very different but should look similar.

To me it looks like the term tree menu is more promissing as it uses groups instead of submenus. This also allows ordering by importance, not pure alphabet. However ordering might be difficult in an i18n context then if we use still alphabetic ordering within the groups.

This ticket needs discussion before implementation.

picture753-1.png View (3.81 KB) Andreas Müller, 01/22/2021 03:28 PM


Related issues

Related to Edit - feature request #9337: Open issues for reimplementation of termtree editors Closed 11/30/2020
Duplicated by Edit - bug #8660: Generic menu creation for Term trees Duplicate 11/07/2019
Copied from Edit - bug #8774: Reimplement term tree editors to implement the general save strategy Closed 12/17/2019
Copied to Edit - feature request #9409: [Decision] Which terms should be editable in term tree editor (and vocabulary editor) New 01/21/2021

Associated revisions

Revision 22ac94a9 (diff)
Added by Katja Luther 11 months ago

ref #9338: restructure term menues and adapt handling

Revision 0b1cfd87 (diff)
Added by Katja Luther 9 months ago

ref #9338: some adaptions in menues

Revision d09b9168 (diff)
Added by Katja Luther 9 months ago

ref #9338: adapt term menu

Revision 2c763ca6 (diff)
Added by Katja Luther 9 months ago

ref #9338: adapt translations in term menues

Revision 3c8dd48a (diff)
Added by Katja Luther 9 months ago

ref #9338: adapt translations in term menues - fix typo

Revision 6fd05c62 (diff)
Added by Katja Luther 9 months ago

ref #9338: adapt translations in term menues - Status -> Kategorie

History

#1 Updated by Andreas Müller 11 months ago

I put milestone to 5.19 as it belongs to #8774 content wise.

#2 Updated by Andreas Müller 11 months ago

  • Copied from bug #8774: Reimplement term tree editors to implement the general save strategy added

#3 Updated by Andreas Müller 11 months ago

#4 Updated by Andreas Müller 11 months ago

#5 Updated by Andreas Müller 11 months ago

#6 Updated by Andreas Müller 11 months ago

  • Related to bug #8660: Generic menu creation for Term trees added

#7 Updated by Andreas Müller 11 months ago

This ticket seems to be somehow contradictory to #8660. However, currently I think a menu not automatically created is preferable as it allows more content wise structuring.

My suggestion for ordering is

Feature
Character
Property
State
Structure
Structure Modifier (Modifier?)


Named Area
Named Area Level
Named Area Type
Distribution Status (use same label for term and tree editor, so not Presence Absence term as currently for vocabularies


Rank (only for tree)
NameRelationshipType (only for tree)
TaxonRelationshipType (only for tree for now, should be editable later)
NameTypeDesignationStatus (only for tree)
NomenclaturalStatusType (only for tree)
SpecimenTypeDesignationStatus (only for tree) - discuss if a common tree for both TypeDesignationStatus variants is needed
TaxonNodeAgentRelationType (should be editable but is not yet)


Language (only for trees for now)


Annotation Type
Identifier Type
Marker Type
Extension Type


Modifier
Kind of Unit
Determination Modifier
Scope

Sex

Stage
DNA Marker

====

Open term types:

DerivationEventType (not in use yet?) => if to use last section
DnaQualityType (fixed vocabulary?) => if to use last sectioni
HybridRelationshipType (currently not in use , should go to taxon sectioni with "rank"
InstitutionType (not in use) => section?
Material and MaterialOrMethod (in use already?) => if to use last section
MeasurementUnit (currently fixed, probably model update needed to open it for general use) => if to use in first section (descriptive data)
Method , same as MaterialOrMethod ?
NaturalLangaugeTerm (still needed?) ?> if to use first section
ReferenceSystem (to discuss) => if to use NamedArea section
Rights Type (in trees only) - not sure if needed => supplemental data section
SynonymType (for now not editable, maybe will be turned to an enum in future) => otherwise go to name section withs rank
TermRelationType (currently not to be used externally)
TextFormat (currently not in use)
unknown (currently not in use)

#8 Updated by Andreas Müller 11 months ago

  • Related to deleted (bug #8660: Generic menu creation for Term trees)

#9 Updated by Andreas Müller 11 months ago

  • Duplicated by bug #8660: Generic menu creation for Term trees added

#10 Updated by Katja Luther 11 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Both menues have the same structure and also the handling of opening the editors are synchronized.

#11 Updated by Andreas Müller 9 months ago

TaxonNodeAgentRelationType should be also editable for vocabularies (sorry, my comment was maybe not clear)

Language should have a separator below.

#12 Updated by Andreas Müller 9 months ago

And a small change to my above description: can we put Modifier and Scope into 1 section followed by another section having Kind of Unit, Determination Modifier, Sex, Stage, DnaMarker.
The later are all Specimen related while the former are general terms.

#13 Updated by Andreas Müller 9 months ago

  • % Done changed from 0 to 90

The new menu looks much better now (also mentioned by AK recently). Good we changed this.

#14 Updated by Andreas Müller 9 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

#15 Updated by Andreas Müller 9 months ago

  • Copied to feature request #9409: [Decision] Which terms should be editable in term tree editor (and vocabulary editor) added

#16 Updated by Andreas Müller 9 months ago

I moved questions on unhandled term types to new ticket #9409

#17 Updated by Katja Luther 9 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Adapted the menues, please have a look.

#18 Updated by Andreas Müller 9 months ago

  • File picture753-1.png View added
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

There is another issue for trees:

Dna Marker is duplicated, the first is wrong. At the same time NameTypeDesignationStatus is missing.

#19 Updated by Andreas Müller 9 months ago

Some translations are missing.

Easy: Language, Extension-Type

Maybe also possible: Stage, Nametypedesignation Status, Specimentypedesignation Status, Taxonnode Agent Relation Type

Discussion needed: Character, Property (to avoid ambiguity)

#20 Updated by Katja Luther 9 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

The german labels are adapted, please have a look whether everything is ok now.

#21 Updated by Andreas Müller 9 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 90 to 70

I found some further issues:

  • Namerelationshiptype tree editor opens taxon relationship trees and the other way round
  • Nametype designation status does not open anything

Please check all trees if they do the correct thing again. I did not check everything.

#22 Updated by Andreas Müller 9 months ago

translation works now as expected

#23 Updated by Katja Luther 9 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

I found some further issues:

  • Namerelationshiptype tree editor opens taxon relationship trees and the other way round
  • Nametype designation status does not open anything

Please check all trees if they do the correct thing again. I did not check everything.

Checked all editors and adapted name/taxon relationship and nameTypeDesignation trees

#24 Updated by Andreas Müller 9 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 70 to 100

I did not check again but I guess we can close this ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)