task #8379
closed
Review strange specimen implementations
Added by Andreas Kohlbecker over 4 years ago.
Updated over 2 years ago.
Description
Please
I am repeating according comments from the original tickets here:
Important for the review is to understand why the bug was introduced with cdm-dataportal|e89c1115 this was for sure in the attempt to fix another problem.
After fixing the problems in this code i noticed that this code is not generating any output at all.
I attempted to base the code on existing functions and wrote the following lines:
if(isset($specimen_or_observation->specimenTypeDesignations) && count($specimen_or_observation->specimenTypeDesignations) > 0){
// $specimen_or_observation->specimenTypeDesignations are DTOs
$specimen_type_designation_map = array();
foreach($specimen_or_observation->specimenTypeDesignations as $stdDTO){
if(!isset($specimen_type_designation_map[$stdDTO->typeStatus])){
$specimen_type_designation_map[$stdDTO->typeStatus] = array();
}
$specimen_type_designation_map[$stdDTO->typeStatus][] = $stdDTO;
}
$items['data'] = compose_specimen_type_designations($specimen_type_designation_map);
}
I removed them again and left the original code as it is. This code was introduced in cdm-dataportal|b3ac03bf
TODO: check if it is feasible to simplify and unify the code by using compose_specimen_type_designations()
. (low priority)
- Copied from bug #8368: problems in compose_cdm_specimen_or_observation_tree_entry() added
- Copied from bug #8370: feature blocks created by compose_description_element_individuals_association() are broken added
- Target version changed from Release 5.10 to Release 5.11
- Target version changed from Release 5.11 to Release 5.12
- Target version changed from Release 5.12 to Release 5.13
- Target version changed from Release 5.13 to Release 5.14
- Target version changed from Release 5.14 to Release 5.15
- Assignee changed from Katja Luther to Andreas Kohlbecker
I think we decided to move this issue to AK. Please correct me if wrong.
Please also decide which milestone it should go to, but definetely it should not be postponed to much as a good specimen is a more and more important requirement.
- Description updated (diff)
Andreas Müller wrote:
I think we decided to move this issue to AK. Please correct me if wrong.
Yes, exactly. But I will definitely need Katja to help shed more light on the original requirements and expectations.
Please also decide which milestone it should go to, but definetely it should not be postponed to much as a good specimen is a more and more important requirement.
Milestone 5.15 seems like realistic perspective to me
- Target version changed from Release 5.15 to Release 5.18
- Related to task #8419: Harmonization of the different specimen representations added
- Description updated (diff)
- Target version changed from Release 5.18 to Release 5.19
- Target version changed from Release 5.19 to Release 5.21
- Target version changed from Release 5.21 to Release 5.22
- Target version changed from Release 5.22 to Release 5.25
- Tags set to specimen
- Tracker changed from report to task
- Status changed from New to Resolved
According to note 13 this only needs a final check. So I put it on resolved in case it is fixed and only needs review.
- Target version changed from Release 5.25 to Release 5.45
moving to next milestone to speed up review phase of 5.25.0
- Target version changed from Release 5.45 to Release 5.18
final check successful, can be closed, moving to the milestone for which this has been fixed: Release 5.18
- Status changed from Resolved to Closed
- % Done changed from 0 to 100
Also available in: Atom
PDF