feature request #7957
Add types for taxon description (as EnumSet)
100%
Description
When working on the Character Matrix there are 3 types of taxon descriptions:
- default taxon description
- taxon descriptions from literature
- aggregated taxon descriptions
To be able to differentiate between them we need two more marker types for "literature" and "default".
Currently we use:
MarkerType.COMPUTED()
for "aggregated"MarkerType.IN_BIBLIOGRAPHY()
for "literature"MarkerType.TO_BE_CHECKED()
for "default"
Current usage with hibernate Criterion (see DescriptionDaoImpl
):
private void addDescriptionTypesCriterion(Set<DescriptionType> descriptionTypes, Criteria criteria) {
if(descriptionTypes != null && !descriptionTypes.isEmpty()) {
Set<Criterion> typeCriteria = new HashSet<>();
for (DescriptionType descriptionType : descriptionTypes) {
typeCriteria.add(Restrictions.sqlRestriction("{alias}.types like '%"+descriptionType.getKey()+"%'"));
}
criteria.add(Restrictions.and(typeCriteria.toArray(new Criterion[]{})));
}
}
Related issues
Associated revisions
ref #7957 Change marker to avoid "Uses" details view
fix #7957 add types to DescriptionBase
ref #7957 add not null to update script for DescriptionBase.types
ref #7957 adapt tests to DescriptionBase.types not null
ref #7957 add javadoc to description types
ref #7957 Add (web) service for filtering descriptions by type
History
#1 Updated by Patrick Plitzner about 2 years ago
- Description updated (diff)
#2 Updated by Patrick Plitzner about 2 years ago
- Description updated (diff)
#3 Updated by Patrick Plitzner about 2 years ago
- Description updated (diff)
#4 Updated by Patrick Plitzner over 1 year ago
- Target version changed from Unassigned CDM tickets to CDM UML 5.15
#5 Updated by Patrick Plitzner over 1 year ago
- Status changed from New to In Progress
- Priority changed from New to Highest
#6 Updated by Andreas Müller over 1 year ago
- Target version changed from CDM UML 5.15 to CDM UML 5.8
#7 Updated by Andreas Müller over 1 year ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 50
Applied in changeset cdmlib|1962891319edeb12380aa69994467f674a96ce96.
#8 Updated by Andreas Müller over 1 year ago
- Precedes feature request #8471: Computed descriptions should be disabled in TaxEditor added
#9 Updated by Andreas Müller over 1 year ago
- Subject changed from Add marker types for taxon description to Add types for taxon description (as EnumSet)
- Assignee changed from Andreas Müller to Patrick Plitzner
This has been implemented now as an EnumSet for better performance.
Please review.
#10 Updated by Andreas Müller over 1 year ago
- Precedes feature request #8472: Transmission engine for distribution aggregation needs to be adapted to new DescriptionBase.types added
#11 Updated by Patrick Plitzner over 1 year ago
- Status changed from Resolved to Closed
- Assignee changed from Patrick Plitzner to Andreas Müller
- % Done changed from 50 to 100
Adapted descriptive data set service to use DescriptionType. Tried aggregation and tested display in matrix editor. Also checked DB. Seems to work fine.
#12 Updated by Andreas Müller over 1 year ago
- Related to feature request #8128: Add indicator for feature facts and/or vocabularies which description type they support added
#13 Updated by Patrick Plitzner over 1 year ago
- Description updated (diff)