Project

General

Profile

Actions

feature request #7957

closed

Add types for taxon description (as EnumSet)

Added by Patrick Plitzner about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Highest
Category:
cdm
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

When working on the Character Matrix there are 3 types of taxon descriptions:

  1. default taxon description
  2. taxon descriptions from literature
  3. aggregated taxon descriptions

To be able to differentiate between them we need two more marker types for "literature" and "default".

Currently we use:

  • MarkerType.COMPUTED() for "aggregated"
  • MarkerType.IN_BIBLIOGRAPHY() for "literature"
  • MarkerType.TO_BE_CHECKED() for "default"

Current usage with hibernate Criterion (see DescriptionDaoImpl):

    private void addDescriptionTypesCriterion(Set<DescriptionType> descriptionTypes, Criteria criteria) {
        if(descriptionTypes != null && !descriptionTypes.isEmpty()) {
            Set<Criterion> typeCriteria = new HashSet<>();
            for (DescriptionType descriptionType : descriptionTypes) {
                typeCriteria.add(Restrictions.sqlRestriction("{alias}.types like '%"+descriptionType.getKey()+"%'"));
            }
            criteria.add(Restrictions.and(typeCriteria.toArray(new Criterion[]{})));
        }
    }

Related issues

Related to EDIT - feature request #8128: Add indicator for feature facts and/or vocabularies which description type they supportDuplicateAndreas Müller

Actions
Related to EDIT - task #10109: Investigate best practice for HQL with enumset NewAndreas Müller

Actions
Precedes EDIT - feature request #8471: Computed descriptions should be disabled in TaxEditorClosedKatja Luther

Actions
Precedes EDIT - feature request #8472: Transmission engine for distribution aggregation needs to be adapted to new DescriptionBase.typesClosedAndreas Müller

Actions
Actions #1

Updated by Patrick Plitzner about 5 years ago

  • Description updated (diff)
Actions #2

Updated by Patrick Plitzner about 5 years ago

  • Description updated (diff)
Actions #3

Updated by Patrick Plitzner about 5 years ago

  • Description updated (diff)
Actions #4

Updated by Patrick Plitzner over 4 years ago

  • Target version changed from Unassigned CDM tickets to CDM UML 5.15
Actions #5

Updated by Patrick Plitzner over 4 years ago

  • Status changed from New to In Progress
  • Priority changed from New to Highest
Actions #6

Updated by Andreas Müller over 4 years ago

  • Target version changed from CDM UML 5.15 to CDM UML 5.8
Actions #7

Updated by Andreas Müller over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 50
Actions #8

Updated by Andreas Müller over 4 years ago

Actions #9

Updated by Andreas Müller over 4 years ago

  • Subject changed from Add marker types for taxon description to Add types for taxon description (as EnumSet)
  • Assignee changed from Andreas Müller to Patrick Plitzner

This has been implemented now as an EnumSet for better performance.

Please review.

Actions #10

Updated by Andreas Müller over 4 years ago

  • Precedes feature request #8472: Transmission engine for distribution aggregation needs to be adapted to new DescriptionBase.types added
Actions #11

Updated by Patrick Plitzner over 4 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 50 to 100

Adapted descriptive data set service to use DescriptionType. Tried aggregation and tested display in matrix editor. Also checked DB. Seems to work fine.

Actions #12

Updated by Andreas Müller over 4 years ago

  • Related to feature request #8128: Add indicator for feature facts and/or vocabularies which description type they support added
Actions #13

Updated by Patrick Plitzner over 4 years ago

  • Description updated (diff)
Actions #14

Updated by Andreas Müller over 1 year ago

  • Related to task #10109: Investigate best practice for HQL with enumset added
Actions

Also available in: Atom PDF