Project

General

Profile

feature request #8471

Computed descriptions should be disabled in TaxEditor

Added by Andreas Müller about 2 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
12/18/2018
Due date:
% Done:

60%

Severity:
normal

Description

Taxon descriptions being computed (DescriptionBase.types contains COMPUTED or AGGREGATED) should be disabled for editing in TaxEditor.

This may also count for other DescriptionTypes like "Clone for Source" but not for all (e.g. "Secondary data" or "Default values for Aggregation" might be editable in general - or configurable for the project)

Also the types should be somehow shown in the UI (as part of the shown label, with an icon, or any other solution)


Related issues

Related to Edit - bug #9631: New implementation for disable details/supplemental data views New 05/19/2021
Related to Edit - bug #9630: Make the handling of computed description configurable Closed 05/19/2021
Follows Edit - feature request #7957: Add types for taxon description (as EnumSet) Closed 12/17/2018

Associated revisions

Revision 0858c777 (diff)
Added by Katja Luther 5 months ago

ref #8471: disable computed descriptions

Revision cc21d978 (diff)
Added by Katja Luther 5 months ago

ref #8471: disable computed descriptions - supplemental data

Revision d43e5395 (diff)
Added by Katja Luther 5 months ago

ref #8471: adapt label provider to show icon for computed descriptions and gray font

Revision c6df1ae1 (diff)
Added by Katja Luther 5 months ago

ref #8471: allow delete again and disable description parts

Revision e297472a (diff)
Added by Katja Luther 5 months ago

ref #8471: set details view disabled for computed descriptions and remove unnecessary code

Revision 4cf3f92d (diff)
Added by Katja Luther 5 months ago

ref #8471: disable toggle button in details view

Revision 570e1cf4 (diff)
Added by Katja Luther 5 months ago

ref #8471: always disable type field

History

#1 Updated by Andreas Müller about 2 years ago

  • Due date set to 12/18/2018
  • Start date changed from 08/16/2019 to 12/18/2018
  • Follows feature request #7957: Add types for taxon description (as EnumSet) added

#2 Updated by Andreas Müller about 2 years ago

  • Due date deleted (12/18/2018)

#3 Updated by Andreas Müller about 2 years ago

  • Target version changed from Unassigned CDM tickets to Release 5.10

#4 Updated by Andreas Müller about 2 years ago

  • Description updated (diff)

#5 Updated by Patrick Plitzner about 2 years ago

  • Target version changed from Release 5.10 to Release 5.11

#6 Updated by Patrick Plitzner almost 2 years ago

  • Target version changed from Release 5.11 to Release 5.12

#7 Updated by Andreas Müller almost 2 years ago

  • Tags set to additivity, euro+med, transmission-engine-distribution
  • Assignee changed from Patrick Plitzner to Katja Luther
  • Priority changed from New to Highest

#8 Updated by Andreas Kohlbecker almost 2 years ago

I find it very useful for debugging that computed descriptions can be viewed and modified in the editor. Can't we allow this by introducing a "Developer" mode in which the computed descriptions are not hidden or set to read only?

#9 Updated by Andreas Müller almost 2 years ago

Andreas Kohlbecker wrote:

I find it very useful for debugging that computed descriptions can be viewed and modified in the editor. Can't we allow this by introducing a "Developer" mode in which the computed descriptions are not hidden or set to read only?

This ticket is not meant to completely make the computed descriptions invisible. By default they should only be disabled for editing. But ofcourse it might be even better if this can be made configurable (e.g. 3 states: editable, disabled for editing, invisible) with default to disabled for editing.
I think this should meat your requirments?

#10 Updated by Andreas Kohlbecker almost 2 years ago

Andreas Müller wrote:

Andreas Kohlbecker wrote:

I find it very useful for debugging that computed descriptions can be viewed and modified in the editor. Can't we allow this by introducing a "Developer" mode in which the computed descriptions are not hidden or set to read only?

This ticket is not meant to completely make the computed descriptions invisible. By default they should only be disabled for editing. But ofcourse it might be even better if this can be made configurable (e.g. 3 states: editable, disabled for editing, invisible) with default to disabled for editing.
I think this should meat your requirments?

This would be the perfect solution!

#11 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.12 to Release 5.13

#12 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.13 to Release 5.14

#13 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.14 to Release 5.15

#14 Updated by Katja Luther over 1 year ago

I did some research but it seems to be a little bit more complex because this needs to be implemented by a mouseListener (see for example https://www.eclipse.org/forums/index.php/t/103773/), therefore we keep the ticket in 5.15

#15 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.15 to Release 5.18

#16 Updated by Katja Luther 11 months ago

  • Target version changed from Release 5.18 to Release 5.19

#17 Updated by Andreas Müller 9 months ago

  • Target version changed from Release 5.19 to Release 5.21

#18 Updated by Andreas Müller 7 months ago

  • Target version changed from Release 5.21 to Release 5.22

#19 Updated by Katja Luther 6 months ago

  • Target version changed from Release 5.22 to Release 5.25

#20 Updated by Katja Luther 5 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review.

#21 Updated by Katja Luther 5 months ago

  • Status changed from Resolved to In Progress
  • Assignee changed from Andreas Müller to Katja Luther

#22 Updated by Katja Luther 5 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Missed to check in the label provider, please review now. There is still a missing issue, the details of the description are not disabled. But the facts and the menu are disabled (only create new factual data set is available)

#23 Updated by Andreas Müller 5 months ago

The preferences to make the aggregated data either disabled, invisible or enabled is still missing, correct?

Should we create a new ticket for this?

#24 Updated by Andreas Müller 5 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The description itself is not yet disabled in details view (but it is in suppl data view). This needs to be fixed.

#25 Updated by Andreas Müller 5 months ago

The "Types" field for ordinary descriptions is now enabled but shouldn't because it is read only (should be set only by machines). In 5.22 it was still disabled always.

#26 Updated by Andreas Müller 5 months ago

I think we should reenable the "delete" menu item as it should always be possible to remove computed data again. Maybe in future there are cases where this is not wanted but for the current cases (distribution and description aggregation) I think it should be possible.

#27 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.23

#28 Updated by Katja Luther 5 months ago

Andreas Müller wrote:

The description itself is not yet disabled in details view (but it is in suppl data view). This needs to be fixed.

I mentioned this in #note-22

#29 Updated by Katja Luther 5 months ago

Andreas Müller wrote:

I think we should reenable the "delete" menu item as it should always be possible to remove computed data again. Maybe in future there are cases where this is not wanted but for the current cases (distribution and description aggregation) I think it should be possible.

Delete is enabled again.

#30 Updated by Katja Luther 5 months ago

Andreas Müller wrote:

The "Types" field for ordinary descriptions is now enabled but shouldn't because it is read only (should be set only by machines). In 5.22 it was still disabled always.

this should be fixed again

#31 Updated by Katja Luther 5 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

The description itself is not yet disabled in details view (but it is in suppl data view). This needs to be fixed.

this is fixed as well.

#32 Updated by Andreas Müller 5 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 60

The UUID and ID fields can not be copied anymore. In general it might be a good idea not to fully disable fields but make them write-protected instead, similar to what we do usually in fields like UUID and ID. This allows copying information even if it is write protected which is often helpful.
Another issue is that sections can be opened now. E.g. if there is an annotation I can't see it's content as I can't open the section. This is also better if fields are only write protected.

But this is probably more complicated so we should move it to another ticket.

Also the configurability (see comment 9) should be moved to another ticket if it can't be implemented now.

#33 Updated by Andreas Müller 5 months ago

Another issue is that sections can be opened now. E.g. if there is an annotation I can't see it's content as I can't open the section. This is also better if fields are only write protected.

Generally we may think about another implementation. I think about a solution which passes an "enabled" or "editingStatus" parameter with setInput() to ALL editors. (Alternatively we could also add it to createControl(?) but this in future should only run once per application and form so in future setInput() is the better place I guess).

This way we have a very generic way to disable writing as when ever we set the input to any control we also set the value if it should be write protected or not. This differs from the current code which needs a lot of case distictions etc.
Can you put this also to the new ticket?

#34 Updated by Andreas Müller 5 months ago

This ticket can be closed once the new 2 tickets are created.

#35 Updated by Katja Luther 5 months ago

  • Related to bug #9631: New implementation for disable details/supplemental data views added

#36 Updated by Katja Luther 5 months ago

  • Related to bug #9630: Make the handling of computed description configurable added

#37 Updated by Katja Luther 5 months ago

  • Status changed from Feedback to Closed

New tickets created.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)