Project

General

Profile

feature request #7899

enable orthographic name correction in Vaadin

Added by Wolf-Henning Kusber 9 months ago. Updated 7 months ago.

Status:
Closed
Priority:
New
Category:
cdm-vaadin
Target version:
Start date:
11/09/2018
Due date:
% Done:

100%

Severity:
normal
Tags:

Description

Subject: validly published names are in (up to) 10% not correctly formed according to the rules of the ICN. Such names "are to be corrected", that means, they are wrongly published but in every publication the name has to be changed.
Published: Mastogloia wulffii
To be corrected to: Mastogloia wulffiae
[In print publications names would be used as "Mastogloia wulffii" or "Mastogloia wulffiae" or "Mastogloia 'wulffii'wulffiae"]

PhycoBank could copy most elements of validation for Vaadin.
Insert field with clickbox "with orthographic validation"
Analoguous to the Validation part of the form, a correction part is opened
Instead of "Validation" it is called "Orthographic correction"
Instead of "Validated name" it is called "orthraphical corrected name"
Namefield stays, Reference [to select ICN] stays, Reference detail stays, Rule considered stays.
Main differences:
(i) the corrected name is already valid in contrast to the validated name Ref. & Ref.Detail is the same
(iii) The name relation is not validation, but "has orthograph variant", the corrected name is "original spelling" (orthographic variant) for the first one. Correct name relation according to ICN and CDM to be discussed.

Advantages: Name correction is no formal act, is no registration by its own. If (a) a name was published with an orthographic error AND (b) it was published in PDF or online with http Identifier, it is directly linkted to the record wich includes both names. There is a justification of the name change.

Disadvantages: An additional Field/check box makes the system more complicated, it is not self-explaining.


Further improvements in answer to the problems pointed out in comment 7 and before (#7899#note-7):

  • in the Editor for incorrect names: hide, disable the option "Orthographic correction" - DONE
  • A) when creating a weakly related higher name (genus for incorrect species, genus or species for incorrect subspecies)
    • Editor should not offer the nomenclatural reference field since the nom.-ref of the higher name is unknown
    • a blocking registration must not be created
  • B) start the editor without VALIDATE_AGAINST_HIGHER_NAME_PART mode ==> Preferred solution - DONE
  • All incorrect names with be tagged with a marker of the type "Incorrect name" rejected, see comment #13
  • Exclude all names with marker "Incorrect name" from all comboboxes except the one in the Orthographic correction field rejected, see comment #13
  • Exclude all names which are fromNamein name relations with the type ORTHOGRAPHIC_VARIANT. from all comboboxes except the one in the Orthographic correction field

OrthographicNameCorrection.PNG View (63.8 KB) Wolf-Henning Kusber, 11/09/2018 10:45 AM

picture294-1.png View (44.8 KB) Wolf-Henning Kusber, 12/10/2018 07:05 PM

picture267-1.png View (34.3 KB) Wolf-Henning Kusber, 12/10/2018 07:37 PM

picture267-2.png View (49.1 KB) Wolf-Henning Kusber, 12/10/2018 07:37 PM

picture110-1.png View (42.3 KB) Wolf-Henning Kusber, 12/19/2018 06:44 PM


Related issues

Related to Edit - report #7960: Revision of NameRelationshipTypes New 12/19/2018
Related to Edit - task #7961: Consider removal of the TaxonNamePopupEditorMode ORTHOGRAPHIC_CORRECTION New 12/19/2018

Associated revisions

Revision e5237e50 (diff)
Added by Andreas Kohlbecker 8 months ago

fix #7899 orthographic variant and corrections implemented in taxon name popup editor

Revision ade5a13e (diff)
Added by Andreas Kohlbecker 8 months ago

ref #7899 adding new name as orthographic correction with correct bean instantiator

Revision 4bae0768 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #7899 validator for orthographic correction

Revision aaa63dad (diff)
Added by Andreas Kohlbecker 8 months ago

ref #7899 updating nameRelationField with newly created corrected name

Revision 61b6ce4e (diff)
Added by Andreas Kohlbecker 8 months ago

fix #7899 changing corrected name label to "Incorrect name"

Revision 068197fd (diff)
Added by Andreas Kohlbecker 8 months ago

ref #7899 adding MarkerType 'Incorrect name'

Revision 775c87a6 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #7899 starting 'Incorrect name' editor without mode VALIDATE_AGAINST_HIGHER_NAME_PART and hiding 'Ortographic correction' toggle

Revision 3bf04fa1 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #7899 excluding 'incorrect' names from name comboboxes by fitering by NameRelationshipType

Revision 8d8da57a (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8117 commenting orthographic corrected names filter to prevent from unclear performance probelms, see ref #7899

Revision b599ad36 (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8117 commenting orthographic corrected names filter to prevent from unclear performance probelms, see ref #7899

History

#1 Updated by Wolf-Henning Kusber 9 months ago

Note: The term "orthographic variant" is to broad for our case, because it includes also variants in different publications.

#2 Updated by Wolf-Henning Kusber 9 months ago

Im Vergleich zu meinem Vorschlag habe ich zu Mastogloia wulffii im TaxEditor Mastogloia wulffiae neu angelegt, dieselben Autoren neu ausgewählt, dieselbe Referenz neu ausgewählt, dieselben RefDetails eingegeben, für Mastogloia wulffii Name Relationship= is original spelling for Mastogloia wulffiae angelegt und Rule Considered sowie Reference ausgewählt. Das ist deutlich aufwändiger als der oben genannte Vorschlag.

#3 Updated by Andreas Kohlbecker 9 months ago

  • Description updated (diff)

#4 Updated by Andreas Kohlbecker 8 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#5 Updated by Andreas Kohlbecker 8 months ago

  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber
  • Target version changed from Unassigned CDM tickets to Release 5.5

please review once test server is updated.

#6 Updated by Wolf-Henning Kusber 8 months ago

  • File picture294-1.png View added
  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 70

Forms and functionality implemented as discussed.
Working with orthographic variants reveals an error in the specification:

Label "Corrected name" is not clear because the correct name is not labelled as correct name. To make clear that the "Corrected name" is not itself corrected but was the original spelling to be corrected it should be called "Incorrect name" (see screen shot). That makes sense with regard to the respective article of the ICN.

#7 Updated by Wolf-Henning Kusber 8 months ago

The normal usecase "new epithet incorrectly published" to be corrected according to ICN works well.

But problems accur if a incorrect spelling is given for a listed genus or species name. To put in a erroneously spelled genus, published in the context of an epithet, I have to register a "new" genus name with a reference.

http://test.e-taxonomy.eu/cdmserver/phycobank/app/registration#!workingset/9d80da69-2098-42a7-8cb8-be4fff0ecc59

eu.etaxonomy.vaadin.mvp.PopupEditorException: Error saving popup editor - context [user=w.h.kusber] :Edit registration (TypedEntityReference: Registration#null) > New taxon name (TaxonNameDTO: TaxonName#0)

#8 Updated by Wolf-Henning Kusber 8 months ago

To handle an erroneously spelled genus name, I had to register the uncorrect spelled genus name. A workaround could be to reject this entry?

The rejected name was afterworth available as name, to be used.

#9 Updated by Andreas Kohlbecker 8 months ago

  • % Done changed from 70 to 50

#10 Updated by Wolf-Henning Kusber 8 months ago

incorrect uninominals and epithets should only be searchable in the "incorrect name" section. Example is genus=Meloseira (see screen shots)

#11 Updated by Andreas Kohlbecker 8 months ago

  • Description updated (diff)

We discussed the above problems and came to a solution ... issue description updated accordingly

#12 Updated by Andreas Kohlbecker 8 months ago

  • Description updated (diff)

#13 Updated by Andreas Kohlbecker 8 months ago

  • Description updated (diff)

#14 Updated by Andreas Kohlbecker 8 months ago

  • Description updated (diff)
  • Status changed from Resolved to In Progress

After a discussion with Andreas Müller, the improved concept from 2018-12-11 has been revised and changed again:

  1. Instead of using a marker the incorrect name should only be recognized through the name relation with a specific type in which it is being used.
  2. The appropriate type of the NameReationship is currently being dicussed neither NameRelationshipType.ORTHOGRAPHIC_VARIANT() nor NameRelationshipType.MISSPELLING() seem to semantically 100% suitable.

#15 Updated by Andreas Kohlbecker 8 months ago

  • Description updated (diff)

according to the latest discussion, which is based on research in the ICBN, we came to the conclusion that ORTHOGRAPHIC_VARIANT is the correct type to be used. The from name is always a name to be corrected and is to be considered invalid. There are rare cases where two slightly different notation for the same name exist but these differences are nomenclatural irrelevant and never are subject of a name relationship. These minor orthographic differences are corrected silently. For more details on this subject please refer to #7960

#16 Updated by Andreas Kohlbecker 8 months ago

  • Related to report #7960: Revision of NameRelationshipTypes added

#17 Updated by Andreas Kohlbecker 8 months ago

  • Description updated (diff)

#18 Updated by Andreas Kohlbecker 8 months ago

  • Related to task #7961: Consider removal of the TaxonNamePopupEditorMode ORTHOGRAPHIC_CORRECTION added

#19 Updated by Andreas Kohlbecker 8 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

please review

#20 Updated by Wolf-Henning Kusber 8 months ago

Comment on #15

according to the latest discussion, which is based on research in the ICBN, we came to the conclusion that ORTHOGRAPHIC_VARIANT is the correct type to be used. The from name is always a name to be corrected and is to be considered valid but incorrect.

#21 Updated by Wolf-Henning Kusber 8 months ago

label: what about the following label wording?

header: orthographical variant
above the cache: incorrect name (= as is)

#22 Updated by Wolf-Henning Kusber 7 months ago

WGB: besser „Orthographical correction of“
WHK: den im Screenshot oben vorgeschlagen Text „Orthographical variant“ würde ich WGBs Vorschlag gegenüber vorziehen.
Kann gerne noch mal diskutiert werden

#23 Updated by Wolf-Henning Kusber 7 months ago

related issue #8014

#24 Updated by Wolf-Henning Kusber 7 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 100

Implementation is clear, functional, and usable.

Note: "Orthographical variant" not shown.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)