Project

General

Profile

Actions

feature request #7717

closed

Implement "continued" in TimePeriod UI

Added by Andreas Müller over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Severity:
normal
Tags:

Description

The continued flag should be alternative to the end date. As described in #7644 either the flag is set or we have an end date. So setting the flag in the TimePeriod class actually removes the end date.

Therefore, when the flag is set it should not be possible to edit the end date.


Related issues

Follows (5 days) EDIT - feature request #7644: Add "continued" flag to (Verbatim)TimeperiodClosedAndreas Kohlbecker

Actions
Actions #1

Updated by Andreas Müller over 5 years ago

  • Due date set to 08/15/2018
  • Start date changed from 09/04/2018 to 08/15/2018
  • Follows feature request #7644: Add "continued" flag to (Verbatim)Timeperiod added
Actions #2

Updated by Andreas Müller over 5 years ago

  • Description updated (diff)
  • Due date deleted (08/15/2018)
  • Priority changed from New to Highest
  • Start date changed from 08/15/2018 to 09/04/2018
Actions #3

Updated by Andreas Müller over 5 years ago

for the expected behavior see also TimePeriodTest.testContinued and .testToStringTimePeriod

Actions #4

Updated by Katja Luther over 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #5

Updated by Katja Luther over 5 years ago

  • Status changed from Resolved to New
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 50 to 0

the continued flag is implemented in editor now. at the moment the end date is removed when the continued flag is set to avoid confusion when the end date is displayed in the ui but is not saved.

Actions #6

Updated by Katja Luther over 5 years ago

  • Status changed from New to Resolved
Actions #7

Updated by Andreas Müller over 5 years ago

I don't know if this is related, but when entering data into the parse field now, the cursor always jumps to the beginning. This is very critical.

Actions #8

Updated by Andreas Müller over 5 years ago

Also I would move the continued flag up, before "End" as it is something inbetween start and end. This may make the behavior a bit clearer.

Can we also grey out the labels of the "end line" this makes it clearer from the beginning that "end" is not available at current state (minor request).

Actions #9

Updated by Andreas Müller over 5 years ago

Best would be to not show the "end" line at all if continued == true

Actions #10

Updated by Andreas Müller over 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
Actions #11

Updated by Katja Luther over 5 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 0 to 50
Actions #12

Updated by Katja Luther over 5 years ago

  • % Done changed from 50 to 0

Andreas Müller wrote:

Best would be to not show the "end" line at all if continued == true

I think it is clearer to show the disabled line to show that it is possible to enter a end date.

Actions #13

Updated by Katja Luther over 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #14

Updated by Andreas Müller over 5 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther

It works well now and is also intuitive IMO.

Actions

Also available in: Atom PDF