Project

General

Profile

feature request #7717

Implement "continued" in TimePeriod UI

Added by Andreas Müller 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
09/04/2018
Due date:
% Done:

0%

Severity:
normal
Tags:

Description

The continued flag should be alternative to the end date. As described in #7644 either the flag is set or we have an end date. So setting the flag in the TimePeriod class actually removes the end date.

Therefore, when the flag is set it should not be possible to edit the end date.


Related issues

Follows (5 days) Edit - feature request #7644: Add "continued" flag to (Verbatim)Timeperiod Closed 08/09/2018

Associated revisions

Revision f36a68ee (diff)
Added by Katja Luther 3 months ago

fix #7717: add continued flag to timeperiod ui

Revision 957dce80 (diff)
Added by Katja Luther 3 months ago

ref #7717: parse field should not be updated if it is the event source

Revision a1fbc94a (diff)
Added by Katja Luther 3 months ago

fix #7717: color of end fields in partial element are grey if disabled

History

#1 Updated by Andreas Müller 3 months ago

  • Due date set to 08/15/2018
  • Start date changed from 09/04/2018 to 08/15/2018
  • Follows feature request #7644: Add "continued" flag to (Verbatim)Timeperiod added

#2 Updated by Andreas Müller 3 months ago

  • Description updated (diff)
  • Due date deleted (08/15/2018)
  • Priority changed from New to Highest
  • Start date changed from 08/15/2018 to 09/04/2018

#3 Updated by Andreas Müller 3 months ago

for the expected behavior see also TimePeriodTest.testContinued and .testToStringTimePeriod

#4 Updated by Katja Luther 3 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#5 Updated by Katja Luther 3 months ago

  • Status changed from Resolved to New
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 50 to 0

the continued flag is implemented in editor now. at the moment the end date is removed when the continued flag is set to avoid confusion when the end date is displayed in the ui but is not saved.

#6 Updated by Katja Luther 3 months ago

  • Status changed from New to Resolved

#7 Updated by Andreas Müller 3 months ago

I don't know if this is related, but when entering data into the parse field now, the cursor always jumps to the beginning. This is very critical.

#8 Updated by Andreas Müller 3 months ago

Also I would move the continued flag up, before "End" as it is something inbetween start and end. This may make the behavior a bit clearer.

Can we also grey out the labels of the "end line" this makes it clearer from the beginning that "end" is not available at current state (minor request).

#9 Updated by Andreas Müller 3 months ago

Best would be to not show the "end" line at all if continued == true

#10 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

#11 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 0 to 50

#12 Updated by Katja Luther 3 months ago

  • % Done changed from 50 to 0

Andreas Müller wrote:

Best would be to not show the "end" line at all if continued == true

I think it is clearer to show the disabled line to show that it is possible to enter a end date.

#13 Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller

#14 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther

It works well now and is also intuitive IMO.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)