Project

General

Profile

feature request #7644

Add "continued" flag to (Verbatim)Timeperiod

Added by Andreas Müller 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
08/09/2018
Due date:
% Done:

100%

Severity:
major
Tags:

Description

... to indicate that a reference (usually a database) is continously edited and has no end date (yet).

E.g. Berendsohn(2018+)

We may also want to revert changes in #7643 once this ticket is fixed and released and data adapted.


Related issues

Related to Edit - feature request #7643: cdmlight export: for bibliographic short citation use the freetext of the date as default Closed 08/09/2018
Precedes (5 days) Edit - feature request #7717: Implement "continued" in TimePeriod UI Closed 09/04/2018

Associated revisions

Revision 9e82319e (diff)
Added by Andreas Müller 4 months ago

ref #7644 implement "continued" in TimePeriod, still missing for most of the formats in parser

Revision 0d330678 (diff)
Added by Andreas Müller 4 months ago

ref #7644 some further fine tuning on setting CONTINUED/end date in TimePeriod and some cleanup

Revision 72b0e291 (diff)
Added by Andreas Müller 4 months ago

fix #7644 fix failing test in parser and add "continued" parsing to all relevant patterns

Revision f710aa8b (diff)
Added by Andreas Müller 3 months ago

ref #7644 handle continued in getYear()

Revision ca542a03 (diff)
Added by Andreas Müller 3 months ago

ref #7644 fix getYear() in test

History

#1 Updated by Andreas Müller 4 months ago

  • Related to feature request #7643: cdmlight export: for bibliographic short citation use the freetext of the date as default added

#2 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#3 Updated by Andreas Müller 4 months ago

  • % Done changed from 0 to 30

We may not need a model change for this.

Instead we use a defined constant end date 9999-12-30 witch stands for "continued".
This way we do not need a separate column.

Implemented so far. Still need to adapt parser (currently only parsing of dd.mm.yyyy is supported for testing).

#4 Updated by Andreas Müller 4 months ago

  • Category changed from cdm to cdmlib
  • Target version changed from CDM UML 5.2 to Release 5.3

#5 Updated by Andreas Müller 4 months ago

#6 Updated by Andreas Müller 4 months ago

  • Status changed from New to Resolved
  • % Done changed from 30 to 50

#7 Updated by Andreas Müller 4 months ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Can you please review? (Katja can you maybe also shortly review?)

#8 Updated by Katja Luther 4 months ago

if the continued flag is set and then setContinued(false) is called, this.end should be set to null

#9 Updated by Andreas Müller 4 months ago

Katja Luther wrote:

if the continued flag is set and then setContinued(false) is called, this.end should be set to null

As discussed by mail, this already has been solved in revision 72b0e291

#10 Updated by Andreas Kohlbecker 3 months ago

  • Target version changed from Release 5.3 to Release 5.4

#11 Updated by Andreas Müller 3 months ago

  • Target version changed from Release 5.4 to Release 5.3

Why has this been moved? It was for review.

#12 Updated by Andreas Kohlbecker 3 months ago

  • % Done changed from 50 to 70

The code changes look ok.

#13 Updated by Andreas Kohlbecker 3 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 70 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)