Project

General

Profile

feature request #7715

Description sources should be handled same as DescriptionElement

Added by Andreas Müller 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
09/03/2018
Due date:
% Done:

50%

Severity:
normal
Tags:

Description

Description sources are currently in supplemental data, DescriptionElement in Details view.

Both should be in Details view.


Related issues

Related to Edit - feature request #1847: Apply description sources (references) for a DescriptionBase to all included description elements Rejected 06/28/2010
Related to Edit - bug #7716: Apply description sources (references) for a DescriptionBase to all included description elements New 09/03/2018

Associated revisions

Revision 472f773b (diff)
Added by Patrick Plitzner 3 months ago

fix #7715 Show sources for descriptions in DetailsView

Revision d2c62a2b (diff)
Added by Katja Luther 3 months ago

fix #7715: set title to reference and remove selection dialog for type of original source

Revision b717449e (diff)
Added by Katja Luther 3 months ago

fix #7715: label for sources of descriptions and descriptionelements are changed to sources

Revision 7ec143e3 (diff)
Added by Patrick Plitzner about 2 months ago

ref #7715 re-enable source section in supplemental view for descriptions

History

#1 Updated by Andreas Müller 3 months ago

  • Related to feature request #1847: Apply description sources (references) for a DescriptionBase to all included description elements added

#2 Updated by Andreas Müller 3 months ago

  • Related to bug #7716: Apply description sources (references) for a DescriptionBase to all included description elements added

#3 Updated by Patrick Plitzner 3 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#4 Updated by Patrick Plitzner 3 months ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

#5 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 70

Generally it works, but there comes a selection dialog for choosing the source type. This needs to be removed as for now PrimaryTaxonomicSource should be the default type. Within additivity we may discuss if under certain circumstances this should not be the case.

Katja, could you do this as PP is on holidays?

#6 Updated by Andreas Müller 3 months ago

Generally we need to discuss if moving the sources from Supplemental Data to Details View means removing them at first place or cloning them. But this may be discussed together with general discussion on handling supplemental data in details view.

#7 Updated by Andreas Müller 3 months ago

The section is called "Description Sources" we should either relabel them "References" as in DescriptionElementDetailsView or relabel them "Sources" as in SupplementalDataView. If doing the later we should also relabel them in DescriptionElementDetailsView accordingly.

I prefer the later as it is more correct and more consistent throughout the application and according to the data model. Also "source" is less ambigous then "reference".

We should definitely remove "Description" from label as this becomes clear from the DetailsView label already and is ambigous because the term Description is ambigous.

#8 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 70 to 50

#9 Updated by Andreas Müller 3 months ago

  • Assignee changed from Katja Luther to Patrick Plitzner

#10 Updated by Andreas Müller 3 months ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

#11 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Andreas Müller wrote:

The section is called "Description Sources" we should either relabel them "References" as in DescriptionElementDetailsView or relabel them "Sources" as in SupplementalDataView. If doing the later we should also relabel them in DescriptionElementDetailsView accordingly.

I prefer the later as it is more correct and more consistent throughout the application and according to the data model. Also "source" is less ambigous then "reference".

Is there a reason for using "Reference" now, not "Source" as suggested. If yes can you please leave a note why you think this is preferable?

#12 Updated by Andreas Müller 3 months ago

Generally this ticket is ready and can be closed.

#13 Updated by Andreas Müller 3 months ago

  • % Done changed from 50 to 90

#14 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 50

#15 Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller

changed the label of descriptions and descriptionelements sources to sources

#16 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)