Project

General

Profile

Actions

feature request #7715

closed

Description sources should be handled same as DescriptionElement

Added by Andreas Müller over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Patrick Plitzner
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

50%

Estimated time:
Severity:
normal
Tags:

Description

Description sources are currently in supplemental data, DescriptionElement in Details view.

Both should be in Details view.


Related issues

Related to EDIT - feature request #1847: Apply description sources (references) for a DescriptionBase to all included description elementsRejectedAndreas Müller

Actions
Related to EDIT - bug #7716: Apply description sources (references) for a DescriptionBase to all included description elementsNewAndreas Müller

Actions
Actions #1

Updated by Andreas Müller over 4 years ago

  • Related to feature request #1847: Apply description sources (references) for a DescriptionBase to all included description elements added
Actions #2

Updated by Andreas Müller over 4 years ago

  • Related to bug #7716: Apply description sources (references) for a DescriptionBase to all included description elements added
Actions #3

Updated by Patrick Plitzner over 4 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #4

Updated by Patrick Plitzner over 4 years ago

  • Assignee changed from Patrick Plitzner to Andreas Müller
Actions #5

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 70

Generally it works, but there comes a selection dialog for choosing the source type. This needs to be removed as for now PrimaryTaxonomicSource should be the default type. Within additivity we may discuss if under certain circumstances this should not be the case.

Katja, could you do this as PP is on holidays?

Actions #6

Updated by Andreas Müller over 4 years ago

Generally we need to discuss if moving the sources from Supplemental Data to Details View means removing them at first place or cloning them. But this may be discussed together with general discussion on handling supplemental data in details view.

Actions #7

Updated by Andreas Müller over 4 years ago

The section is called "Description Sources" we should either relabel them "References" as in DescriptionElementDetailsView or relabel them "Sources" as in SupplementalDataView. If doing the later we should also relabel them in DescriptionElementDetailsView accordingly.

I prefer the later as it is more correct and more consistent throughout the application and according to the data model. Also "source" is less ambigous then "reference".

We should definitely remove "Description" from label as this becomes clear from the DetailsView label already and is ambigous because the term Description is ambigous.

Actions #8

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 70 to 50
Actions #9

Updated by Andreas Müller over 4 years ago

  • Assignee changed from Katja Luther to Patrick Plitzner
Actions #10

Updated by Andreas Müller over 4 years ago

  • Assignee changed from Patrick Plitzner to Andreas Müller
Actions #11

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Andreas Müller wrote:

The section is called "Description Sources" we should either relabel them "References" as in DescriptionElementDetailsView or relabel them "Sources" as in SupplementalDataView. If doing the later we should also relabel them in DescriptionElementDetailsView accordingly.

I prefer the later as it is more correct and more consistent throughout the application and according to the data model. Also "source" is less ambigous then "reference".

Is there a reason for using "Reference" now, not "Source" as suggested. If yes can you please leave a note why you think this is preferable?

Actions #12

Updated by Andreas Müller over 4 years ago

Generally this ticket is ready and can be closed.

Actions #13

Updated by Andreas Müller over 4 years ago

  • % Done changed from 50 to 90
Actions #14

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 50
Actions #15

Updated by Katja Luther over 4 years ago

  • Assignee changed from Katja Luther to Andreas Müller

changed the label of descriptions and descriptionelements sources to sources

Actions #16

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner
Actions

Also available in: Atom PDF