Project

General

Profile

Actions

feature request #10291

closed

Implement second publisher information for bibliographic reference formatting and other remaining issues

Added by Belen Escobari about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

Follow up from #10245

Also fix: "Formatting of References when publisher or placed published are missing". This had to be reverted in #10245

Also open: "According to the data model also journals and print series have a publisher. Can you please discuss with Norbert if this is correct? Are there cases when journals are cited with a publisher (place published). And do print series have a publisher/place published? Of course the single books within a print series do have a publisher but my question is about the print series itself."


Related issues

Related to EDIT - feature request #10245: #9626 Implement publisher information for bibliographic reference formattingClosedAndreas Müller

Actions
Related to EDIT - feature request #10288: Implement publisher and placePublished2 in TaxEditorClosedKatja Luther

Actions
Related to EDIT - feature request #10286: Add publisher2 and placePublished2 to ReferenceClosedAndreas Müller

Actions
Actions #1

Updated by Belen Escobari about 1 year ago

  • Related to feature request #10245: #9626 Implement publisher information for bibliographic reference formatting added
Actions #2

Updated by Andreas Müller about 1 year ago

  • Tags set to formatting
  • Subject changed from Implement second publisher information for bibliographic reference formatting to Implement second publisher information for bibliographic reference formatting and other remaining issues
  • Description updated (diff)
  • Priority changed from New to Highest
Actions #3

Updated by Belen Escobari about 1 year ago

  • Status changed from New to Feedback
  • Assignee changed from Belen Escobari to Andreas Müller

A second place published and a second publisher is now implemented in the references formatting as long as there is a first place published and a first publisher

Actions #4

Updated by Belen Escobari about 1 year ago

  • % Done changed from 0 to 50
Actions #5

Updated by Andreas Müller about 1 year ago

  • Status changed from Feedback to In Progress
  • Assignee changed from Andreas Müller to Belen Escobari

I will have a look. But please keep ticket assiged to you until all issues of the ticket are solved.

Actions #6

Updated by Andreas Müller about 1 year ago

Actions #7

Updated by Andreas Müller about 1 year ago

Actions #8

Updated by Belen Escobari about 1 year ago

Journals werden nicht mit Publisher zitiert, ich kenne auch keine Ausnahmen.

"Print series": das ist schon mal ein Definitionsproblem, also was genau ist damit gemeint? Eine monografische Reihe wie Englera oder Regnum Vegetabile?
Hier wird üblicherweise auch kein Publisher zitiert.

Dann gibt es Buchreihen:

ein Beispiel aus dem letzten Jahrebericht, mit 2 Zitiermöglichkeiten, hier beide angegeben:

Lack H.-W. 2021: Systematische Botanik an der Universität Breslau 1884–1925 – Engler, Prantl & Pax. – Pp. 247–264
in: Keil G. & Kiefer J. (ed.), Die deutsch-polnische Wissenschaftslandschaft Schlesien. – Düren: Shaker Verlag,
2021 (= Engelhardt D. v., Kästner I., Kiefer J. & Reich K. (ed.), Europäische Wissenschaftsbeziehungen 16).

NK

Actions #9

Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 5.44 to Release 5.37
Actions #10

Updated by Andreas Müller about 1 year ago

  • Status changed from In Progress to Feedback

Belen Escobari wrote in #note-3:

A second place published and a second publisher is now implemented in the references formatting as long as there is a first place published and a first publisher

Some cases for missing data are not yet handled correctly. I added some further test cases (but commented them to not disturb jenkins build on the server). Please uncomment them and try to fix.

Actions #11

Updated by Andreas Müller about 1 year ago

Belen Escobari wrote in #note-8:

Journals werden nicht mit Publisher zitiert, ich kenne auch keine Ausnahmen.

I removed publisher information from IJournal

Actions #12

Updated by Andreas Müller about 1 year ago

Andreas Müller wrote in #note-11:

Belen Escobari wrote in #note-8:

Journals werden nicht mit Publisher zitiert, ich kenne auch keine Ausnahmen.

I removed publisher information from IJournal

@Katja: can you remove publisher information from journals in TaxEditor?

Actions #13

Updated by Katja Luther about 1 year ago

Andreas Müller wrote in #note-12:

Andreas Müller wrote in #note-11:

Belen Escobari wrote in #note-8:

Journals werden nicht mit Publisher zitiert, ich kenne auch keine Ausnahmen.

I removed publisher information from IJournal

@Katja: can you remove publisher information from journals in TaxEditor?

done

Actions #14

Updated by Katja Luther about 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Belen Escobari to Andreas Müller

Andreas Müller wrote in #note-10:

Belen Escobari wrote in #note-3:

A second place published and a second publisher is now implemented in the references formatting as long as there is a first place published and a first publisher

Some cases for missing data are not yet handled correctly. I added some further test cases (but commented them to not disturb jenkins build on the server). Please uncomment them and try to fix.

fixed the formatting of publisher informations and uncommented the test.

Actions #15

Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Belen Escobari
  • % Done changed from 50 to 80

One more issue found. See commented test.

Actions #16

Updated by Belen Escobari about 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Belen Escobari to Andreas Müller

this should be fixed, please check

Actions #17

Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Belen Escobari
  • % Done changed from 80 to 100

Now it is correct. I simplified the code still a bit, but as all tests are still running I guess it works as before and we can close the ticket.

Actions

Also available in: Atom PDF