Project

General

Profile

Actions

feature request #8339

open

Completely remove the potentially redundant 'acceptedFor' parameter from synonym page

Added by Andreas Kohlbecker almost 5 years ago. Updated almost 3 years ago.

Status:
New
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Severity:
normal

Description

'acceptedFor' parameter which is used by the synonym page can potentially be replaced or removed.

this parameter is only being used to determine the synonym for which the synonym page is being displayed. This information can also be retrieved from the highlight parameter of from the URL fragment.

See also the drupal variable cdm_dataportal_display_is_accepted_for which must be set for the 'acceptedFor' parameter having an effect. This drupal variable is only being used in the following portals:


originally reported by a.mueller:

Hallo Andreas,

ich stolpere gerade über folgendes:

http://portal.cybertaxonomy.org/euromed/cdm_dataportal/search/results/taxon?ws=portal%2Ftaxon%2Ffind&query=Orchis+angustifolia+subf.+immaculata*&form_build_id=form-Cm_DsZc9EoQlnQrdGtqdve2LLBaY6Tt9reMXXxnDHi0&form_id=cdm_dataportal_search_taxon_form&search%5BdoTaxaByCommonNames%5D=1&search%5BdoMisappliedNames%5D=1&search%5BdoSynonyms%5D=1&search%5BdoTaxa%5D=1&search%5BpageNumber%5D=0&search%5BpageSize%5D=25

Wenn ich hier auf eines der Synonymsuchergebnisse klicke bekomme ich Links wie: http://portal.cybertaxonomy.org/euromed/cdm_dataportal/taxon/6387f09f-d688-4b63-b91e-04fc0aeb79aa/synonymy?highlite=2119777c-f0ed-4bf4-990b-cbee2dcd05f9&acceptedFor=2119777c-f0ed-4bf4-990b-cbee2dcd05f9#2119777c-f0ed-4bf4-990b-cbee2dcd05f9

Hier verstehe ich nicht ganz, wozu der ganze Teil ab dem „acceptedFor“ gebraucht wird. Die UUID 2119777c-f0ed-4bf4-990b-cbee2dcd05f9 wird irgendwie 3x angegeben. Ich kann mir irgendwie nicht vorstellen, dass das wirklich für irgendwas notwendig ist. Insbesondere nicht mehr, seitdem Synonyme immer exakt einem akzeptierten Taxon zugeordnet sind. Sind das noch relikte aus alter Zeit? Dann sollten wir versuchen, die zu säubern. Diese langen URLs sind ein bisschen unschön.

Viele Grüße,
Andreas M.



Related issues

Related to EDIT - bug #8340: is accepted for Footnotes missing and with wrong indexRejectedAndreas Kohlbecker

Actions
Actions #1

Updated by Andreas Kohlbecker almost 5 years ago

  • Related to bug #8340: is accepted for Footnotes missing and with wrong index added
Actions #2

Updated by Andreas Müller almost 5 years ago

OK, now I at least understand what it is used for. However, I doubt (but am not sure) that this is still needed. Maybe we can find out if the highlighting mechanism was later implemented and the "is accepted for" was only a first and fast implementation to show why a page was opened as link for a given synonym search result.
If so we should really remove it. If not we should ask palmweb if they still want it.

Anyway we should remove all footnotes from the accepted for name. It is only to explain the result. The data itself is shown in the synonymy which is enough.

Actions #3

Updated by Andreas Kohlbecker almost 5 years ago

  • Priority changed from New to Highest
  • Target version changed from Unassigned CDM tickets to Release 5.10
Actions #4

Updated by Andreas Müller over 4 years ago

  • Subject changed from consider removing the potentially redundant 'acceptedFor' parameter from synonym page to Consider removing the potentially redundant 'acceptedFor' parameter from synonym page
Actions #5

Updated by Andreas Kohlbecker over 4 years ago

Hallo Andreas,

das war mir völlig unbekannt, dass wir sowas überhaupt haben/hatten. Daher hatte ich das ganze auch bisher überhaupt nicht verstanden, was es überhaupt mit dem acceptedFor auf sich hat.

Für die Moose und die Flora Deutschland können wir es auf jeden Fall streichen, das kann nur ein c&p Fehler sein.

Für Palmweb wurde es vermutlich mal endwickelt, könnte ich mir vorstellen. Vielleicht zu Zeiten, als das Highliting noch nicht existierte.

Also eigentlich würde ich das auch ersatzlos streichen. Wenn wir ganz sicher gehen wollen, können wir natürlich auch nochmal Bill Baker fragen, ob er dazu ne Meinung hat. Aber ich denke der steckt da auch nicht mehr so drin. Die Portale hat ja tendenziell Soraya entwickelt.

Also von mir hättest du das ok, es einfach so zu streichen, da ich keinen Sinn drin sehe.

Viele Grüße,

Andreas M.

Actions #6

Updated by Andreas Kohlbecker over 4 years ago

Hallo Andreas,

danke für deine Einschätzung. Da du mich in meiner Auffassung bestätigst, werde ich das "is accepted for" Feature ersatzlos streichen.

Viele Grüße
Andreas

Actions #7

Updated by Andreas Kohlbecker over 4 years ago

  • Subject changed from Consider removing the potentially redundant 'acceptedFor' parameter from synonym page to Completely remove the potentially redundant 'acceptedFor' parameter from synonym page
Actions #8

Updated by Andreas Kohlbecker over 4 years ago

  • Target version changed from Release 5.10 to Release 5.11
Actions #9

Updated by Andreas Kohlbecker over 4 years ago

  • Target version changed from Release 5.11 to Release 5.12
Actions #10

Updated by Andreas Kohlbecker over 4 years ago

  • Target version changed from Release 5.12 to Release 5.13
Actions #11

Updated by Andreas Kohlbecker about 4 years ago

  • Target version changed from Release 5.13 to Release 5.14
Actions #12

Updated by Andreas Müller about 4 years ago

  • Target version changed from Release 5.14 to Release 5.15
Actions #13

Updated by Andreas Müller almost 4 years ago

  • Target version changed from Release 5.15 to Release 5.18
Actions #14

Updated by Andreas Kohlbecker over 3 years ago

  • Target version changed from Release 5.18 to Release 5.19
Actions #15

Updated by Andreas Kohlbecker about 3 years ago

  • Target version changed from Release 5.19 to Release 5.21
Actions #16

Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 5.21 to Release 5.22
Actions #17

Updated by Andreas Kohlbecker about 3 years ago

  • Target version changed from Release 5.22 to Release 5.25
Actions #18

Updated by Andreas Müller almost 3 years ago

  • Target version changed from Release 5.25 to Release 5.45
Actions

Also available in: Atom PDF