Project

General

Profile

bug #9491

Order of terms in not order relevant trees

Added by Katja Luther 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
03/01/2021
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

The order of not order relevant trees in term tree editors should be alphabetic.

Associated revisions

Revision a5cc95ce (diff)
Added by Katja Luther 8 months ago

children of termnodedto should be ordered alphabetically when not order relevant

Revision b858a126 (diff)
Added by Katja Luther 8 months ago

children of termnodedto should be ordered alphabetically when not order relevant - continue

Revision e9f80908 (diff)
Added by Katja Luther 8 months ago

children of termnodedto should be ordered alphabetically when not order relevant - continue

Revision 85f422a4 (diff)
Added by Katja Luther 8 months ago

ref #9491: do the ordering on editor side

Revision 0073b027 (diff)
Added by Katja Luther 8 months ago

ref #9491: revert changes in cdmlib

Revision 1a4389ec (diff)
Added by Katja Luther 8 months ago

ref #9491: do the ordering on editor side - code cleaning

Revision a501f1e0 (diff)
Added by Andreas Müller 8 months ago

ref #9491 fix NPE in comparator

Revision c3a27807 (diff)
Added by Katja Luther 8 months ago

label issues in term editors

History

#1 Updated by Katja Luther 8 months ago

  • % Done changed from 0 to 40

#2 Updated by Katja Luther 8 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Changed to client side ordering because the server does not know about the preference "Show Id in Vocabulary" for the term tree editor.
Please review

#3 Updated by Andreas Müller 8 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

There was still an NPE when editing the title of a tree. I fixed this with a501f1e0 .

It generally works. Only I do not understand why the comparator implements the label provider again. Shouldn't we reuse the label provider code to be on the save side?

#4 Updated by Katja Luther 7 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

There was still an NPE when editing the title of a tree. I fixed this with a501f1e0 .

It generally works. Only I do not understand why the comparator implements the label provider again. Shouldn't we reuse the label provider code to be on the save side?

The comparator is adapted and uses the labelprovider, please have a short look whether everything is ok, then we can close the ticket.

#5 Updated by Andreas Müller 7 months ago

Can we delete the commented text in CreateDefinedTermOperation?

#6 Updated by Andreas Müller 7 months ago

Can we rename FeatureTreeViewerComparator to TermTreeViewerComparator? "FeatureTree" is deprecated. Maybe we can run search and replace for "FeatureTree" for the complete code (but take care for possible exceptions).

#7 Updated by Andreas Müller 7 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 40 to 90

Functionality and new code looks looks ok beside this and ticket can be closed.

#8 Updated by Katja Luther 7 months ago

  • Status changed from Feedback to Closed

#9 Updated by Katja Luther 7 months ago

  • % Done changed from 90 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)