bug #9491: Order of terms in not order relevant trees - EDIT - EDIT Project Management

Actions

Copy link

bug #9491

closed

Order of terms in not order relevant trees

Added by Katja Luther about 3 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

New

Assignee:

Katja Luther

Category:

taxeditor

Target version:

Release 5.21

Start date:

Due date:

% Done:

100%

Estimated time:

Severity:

normal

Found in Version:

Description

The order of not order relevant trees in term tree editors should be alphabetic.

Actions

Copy link

Updated by Katja Luther about 3 years ago

% Done changed from 0 to 40

Actions

Copy link

Updated by Katja Luther about 3 years ago

Status changed from New to Resolved
Assignee changed from Katja Luther to Andreas Müller

Changed to client side ordering because the server does not know about the preference "Show Id in Vocabulary" for the term tree editor.
Please review

Actions

Copy link

Updated by Andreas Müller about 3 years ago

Status changed from Resolved to Feedback
Assignee changed from Andreas Müller to Katja Luther

There was still an NPE when editing the title of a tree. I fixed this with a501f1e0 .

It generally works. Only I do not understand why the comparator implements the label provider again. Shouldn't we reuse the label provider code to be on the save side?

Actions

Copy link

Updated by Katja Luther about 3 years ago

Status changed from Feedback to Resolved
Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

There was still an NPE when editing the title of a tree. I fixed this with a501f1e0 .

It generally works. Only I do not understand why the comparator implements the label provider again. Shouldn't we reuse the label provider code to be on the save side?

The comparator is adapted and uses the labelprovider, please have a short look whether everything is ok, then we can close the ticket.

Actions

Copy link

Updated by Andreas Müller about 3 years ago

Can we delete the commented text in CreateDefinedTermOperation?

Actions

Copy link

Updated by Andreas Müller about 3 years ago

Can we rename FeatureTreeViewerComparator to TermTreeViewerComparator? "FeatureTree" is deprecated. Maybe we can run search and replace for "FeatureTree" for the complete code (but take care for possible exceptions).

Actions

Copy link