bug #9491
closed
Order of terms in not order relevant trees
Added by Katja Luther about 3 years ago.
Updated about 3 years ago.
Description
The order of not order relevant trees in term tree editors should be alphabetic.
- % Done changed from 0 to 40
- Status changed from New to Resolved
- Assignee changed from Katja Luther to Andreas Müller
Changed to client side ordering because the server does not know about the preference "Show Id in Vocabulary" for the term tree editor.
Please review
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
There was still an NPE when editing the title of a tree. I fixed this with a501f1e0 .
It generally works. Only I do not understand why the comparator implements the label provider again. Shouldn't we reuse the label provider code to be on the save side?
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Andreas Müller
Andreas Müller wrote:
There was still an NPE when editing the title of a tree. I fixed this with a501f1e0 .
It generally works. Only I do not understand why the comparator implements the label provider again. Shouldn't we reuse the label provider code to be on the save side?
The comparator is adapted and uses the labelprovider, please have a short look whether everything is ok, then we can close the ticket.
Can we delete the commented text in CreateDefinedTermOperation?
Can we rename FeatureTreeViewerComparator to TermTreeViewerComparator? "FeatureTree" is deprecated. Maybe we can run search and replace for "FeatureTree" for the complete code (but take care for possible exceptions).
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
- % Done changed from 40 to 90
Functionality and new code looks looks ok beside this and ticket can be closed.
- Status changed from Feedback to Closed
- % Done changed from 90 to 100
Also available in: Atom
PDF