Project

General

Profile

bug #9199

Adapt TaxEditor to switch to originalSource for remaining single sourced objects

Added by Andreas Müller 6 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
07/02/2020
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

copied from #9116

It handles the same as #9116 but for the other SingleSourcedEntities mentioned in #6581

picture920-1.png View (1.52 KB) Andreas Müller, 12/01/2020 10:51 AM


Related issues

Related to Edit - feature request #6581: Make all microreferenced references OriginalSources Closed 04/24/2017
Related to Edit - feature request #9192: Layout issues for source in taxonnode details Closed 08/14/2020
Related to Edit - feature request #9298: Preference for IDinSource, IdNamespace and original information in nomenclatural reference details view New 11/13/2020
Follows Edit - feature request #9116: Adapt Editor to switch to originalSource for TaxonNode and improve layout of TaxonNode dialogue Closed 07/01/2020
Copied to Edit - feature request #9328: Adapt Editor to switch to originalSource for taxon secundum New 11/25/2020

Associated revisions

Revision 869cb64b (diff)
Added by Andreas Müller 6 months ago

ref ##9199, ref #6581, #9194 adapt TaxEditor to ReferencedEntityBase removal (has open issues)

Revision 82d37a4c (diff)
Added by Katja Luther 6 months ago

ref #9199: adapt editor to SingleSourcedEntityBase

Revision d74515be (diff)
Added by Katja Luther 6 months ago

ref #9199: continue adapt editor to singleSourcedEntities

Revision 8d33320b (diff)
Added by Katja Luther 6 months ago

ref #9199: continue adapt editor to singleSourcedEntities

Revision 7ca24c6e (diff)
Added by Katja Luther 6 months ago

ref #9199: TaxonNode should extend SingleSourcedEntityBase

Revision ce14d229 (diff)
Added by Katja Luther 6 months ago

ref #9199: TaxonNode is SingleSOurcedEntity

Revision 58e0cf09 (diff)
Added by Katja Luther 6 months ago

ref #9199: TaxonNode is SingleSOurcedEntity

Revision 7cf8a967 (diff)
Added by Andreas Müller 6 months ago

ref #9199 fix TaxonNode issues with new super class

Revision fcccac41 (diff)
Added by Andreas Müller 6 months ago

ref #9199 fix TaxonNode issues with new super class (cont.)

Revision 20a37084 (diff)
Added by Katja Luther 6 months ago

ref #9199: layout issues

Revision e154bb27 (diff)
Added by Andreas Müller 6 months ago

ref #9199, ref #9194 remove IReferencedEntity

Revision cd024235 (diff)
Added by Katja Luther 6 months ago

ref #9199: adapt nomenclatural status to original source and layout issues

Revision 13360a1e (diff)
Added by Katja Luther 6 months ago

ref #9199: adapt nom. ref, nom. status, typedes. elements to original source

Revision 0c28ee9b (diff)
Added by Katja Luther 6 months ago

ref #9199: adapt TypeDesignationBase to usage of source

Revision 8f36abc7 (diff)
Added by Katja Luther 4 months ago

ref #9199: fix problems with nomenclatural reference details

Revision 69bed327 (diff)
Added by Katja Luther 3 months ago

fix #9199: layout issues in nomenclatural source details and external links

Revision bd5b538f (diff)
Added by Katja Luther 3 months ago

ref #9199: fix NPE for newly created designation source

Revision 387aef2a (diff)
Added by Katja Luther 3 months ago

ref #9199: layout issues and code cleaning

Revision 5eabd2c1 (diff)
Added by Katja Luther 3 months ago

ref #9199: move original information behind name used in source

Revision af6adc60 (diff)
Added by Katja Luther 3 months ago

ref #9199: fix missing handling of name in source in nomenclatural source

Revision 3c793992 (diff)
Added by Katja Luther 3 months ago

ref #9199: fix missing handling of name in source in nomenclatural source

History

#1 Updated by Andreas Müller 6 months ago

  • Due date set to 07/02/2020
  • Start date changed from 08/19/2020 to 07/02/2020
  • Follows feature request #9116: Adapt Editor to switch to originalSource for TaxonNode and improve layout of TaxonNode dialogue added

#2 Updated by Andreas Müller 6 months ago

#3 Updated by Andreas Müller 6 months ago

#4 Updated by Andreas Müller 6 months ago

  • Target version changed from Release 5.19 to Release 5.18

#5 Updated by Andreas Müller 6 months ago

  • Due date deleted (07/02/2020)

#6 Updated by Katja Luther 6 months ago

  • Status changed from New to In Progress

adapted are the following elements:

  • Nomenclatural Status
  • Nomenclatural Reference
  • Taxonrelationships/NameRelationships
  • Typedesignations

missing:

  • secundum reference

#7 Updated by Katja Luther 3 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This is fixed for all sources listed above, for sec reference I create a new ticket or we create a new one when the secundum reference is moved to original source as well?

#8 Updated by Katja Luther 3 months ago

  • % Done changed from 0 to 50

#9 Updated by Andreas Müller 3 months ago

#10 Updated by Andreas Müller 3 months ago

  • Subject changed from Adapt Editor to switch to originalSource for remaining single sourced objects to Adapt TaxEditor to switch to originalSource for remaining single sourced objects

#11 Updated by Andreas Müller 3 months ago

  • Related to feature request #9298: Preference for IDinSource, IdNamespace and original information in nomenclatural reference details view added

#12 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Can we adapt single source layout according to nomenclatural source layout?

So we

  • move External Link up and - by default - show it not in the "more" section.
  • remove bold from External Link label
  • Relabel External Link => Link or Link(s)
  • do not use indentation for "more"
  • remove bold from "more" (not sure if really required, please check what looks better, if possible at all)

Only NameInSource should stay where it is by default. This needs to be decided from case to case.

#13 Updated by Andreas Müller 3 months ago

... for TaxonNodes.source we should keep indentation of "more" as it is followed by "Related persons"

#14 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I think this is fixed now. Please review.

#15 Updated by Andreas Müller 3 months ago

  • Assignee changed from Andreas Müller to Katja Luther

Yes, this looks much better. Only for nom. sources "more" is still bold. Can you adapt it there, too?

#16 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback

But it should be adapted for all single sources like for TaxonNode.source. So indentation is needed everywhere, except for nom. source where the Section only contains source information (there we should not have indentation for "Detail" if we don't have for other elements.

#17 Updated by Andreas Müller 3 months ago

Another layout issue somehow related: In external link, can we move the URI to the top and the type below URI? URI is the most important. Also there could be some little space between URI and Type and the space to "Description" could be reduced a bit.

#18 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved

#19 Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller

#20 Updated by Andreas Müller 3 months ago

Sometimes the nomenclatural source still shows "No external link" yet instead of no protologue yet.

#21 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The space between URI and type (in external links could be a bit smaller and therefore a bit more space between type and description). But this is a minor issue.

#22 Updated by Andreas Müller 3 months ago

NPE when editing a lectotype source

last remote method : http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/common.service
last remote request client time : 2020-12-01T10:53:59.93
last remote request response header time : Tue, 01 Dec 2020 10:53:59 GMT
client error time : 2020-12-01T10:54:04.024
login : admin
editor version : 5.18.0.202011302349
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.18.5.0.20201103
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.ui.section.reference.AdvancedSourceElement.handleEvent(AdvancedSourceElement.java:100)
    at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.propertyChange(AbstractCdmDetailElement.java:210)
    at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:255)
    at eu.etaxonomy.taxeditor.ui.element.TextWithLabelElement.modifyText(TextWithLabelElement.java:178)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:180)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)

#23 Updated by Andreas Müller 3 months ago

Another minor issue: could we move "Original Information" above ID Namespace and ID in Source. It is probably more important.

done

#24 Updated by Katja Luther 3 months ago

Andreas Müller wrote:

NPE when editing a lectotype source

last remote method : http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/common.service
last remote request client time : 2020-12-01T10:53:59.93
last remote request response header time : Tue, 01 Dec 2020 10:53:59 GMT
client error time : 2020-12-01T10:54:04.024
login : admin
editor version : 5.18.0.202011302349
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.18.5.0.20201103
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
  at eu.etaxonomy.taxeditor.ui.section.reference.AdvancedSourceElement.handleEvent(AdvancedSourceElement.java:100)
  at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.propertyChange(AbstractCdmDetailElement.java:210)
  at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:255)
  at eu.etaxonomy.taxeditor.ui.element.TextWithLabelElement.modifyText(TextWithLabelElement.java:178)
  at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:180)
  at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
  at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
  at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)

gefixt.

#25 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review.

#26 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Andreas Müller wrote:

Sometimes the nomenclatural source still shows "No external link" yet instead of no protologue yet.

this still happens

#27 Updated by Andreas Müller 3 months ago

Andreas Müller wrote:

Another minor issue: could we move "Original Information" above ID Namespace and ID in Source. It is probably more important.

done

It still shows up below ID Namesp and ID in Source for some reason. Did you forget to push?

#28 Updated by Andreas Müller 3 months ago

Also the NPE still exists, but with a different row number:

last remote method : http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/reference.service
last remote request client time : 2020-12-02T16:26:09.547
last remote request response header time : Wed, 02 Dec 2020 16:26:09 GMT
client error time : 2020-12-02T16:26:13.765
login : admin
editor version : 5.18.0.202012021500
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.18.5.0.20201103
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.ui.section.reference.AdvancedSourceElement.handleEvent(AdvancedSourceElement.java:89)
    at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.propertyChange(AbstractCdmDetailElement.java:210)
    at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:255)
    at eu.etaxonomy.taxeditor.ui.element.TextWithLabelElement.modifyText(TextWithLabelElement.java:178)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:180)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)

I entered ID Namespace here for a type desig which was completely empty except for the designation status

#29 Updated by Andreas Müller 3 months ago

... looks like the error appears at different places depending on the type field that you enter data in

#30 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

this should be solved with last commit.

#31 Updated by Andreas Müller 3 months ago

Andreas Müller wrote:

Andreas Müller wrote:

Another minor issue: could we move "Original Information" above ID Namespace and ID in Source. It is probably more important.

done

It still shows up below ID Namesp and ID in Source for some reason. Did you forget to push?

Now it appears also above Name in Source, but the order should be NameInSource, OriginalInformation, ID Namespace, ID in Source.

All other issues seem to be fixed. The new single sources look very nice now!!

#32 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

#33 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

Andreas Müller wrote:

Andreas Müller wrote:

Another minor issue: could we move "Original Information" above ID Namespace and ID in Source. It is probably more important.

done

It still shows up below ID Namesp and ID in Source for some reason. Did you forget to push?

Now it appears also above Name in Source, but the order should be NameInSource, OriginalInformation, ID Namespace, ID in Source.

All other issues seem to be fixed. The new single sources look very nice now!!

this is fixed.

#34 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 100

Works as expected. We can close this ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)