feature request #9116
closedAdapt Editor to switch to originalSource for TaxonNode and improve layout of TaxonNode dialogue
70%
Description
e.g TaxonName.nomenclaturalSource and TaxonName.source. For a complete list of all such places see #6581
Nomenclatural reference and placement reference are originalSources now. The detail elements should be adapted to these changes.
As a first step the reference and for the nomenclatural reference also the reference detail should always be visible and the other informations should be expandable.
A more suffisticated solution could be to have two views, a simple view with reference and reference detail as default and an advanced view with all fields. On the advanced view it should be possible to choose the fields which should be shown in the simple view. This information should be saved in local preferences.
Files
| picture319-1.png (5.42 KB) picture319-1.png | |||
| picture294-1.png (1.45 KB) picture294-1.png |
Related issues
Updated by Katja Luther over 3 years ago
- Related to feature request #9004: Make TaxonNode.referenceForParentChildRelation an OriginalSource and rename it to (placement)source added
Updated by Andreas Müller over 3 years ago
Note: At the moment nomenclatural reference is not really a source yet but nom ref and nom source exist in parallel. However the existing nom.source can be used for development reasons. But before commiting this we also need an updated script for the nom.ref.
The placement source is fully migrated already which means data is only stored in TaxonNode.source and TaxonNode.getReference() is only a wrapping method.
Updated by Andreas Müller over 3 years ago
- Related to feature request #6581: Make all microreferenced references OriginalSources added
Updated by Andreas Müller over 3 years ago
- Subject changed from Adapt Editor to switch to originalSource for Nomenclatural Reference and placement reference to Adapt Editor to switch to originalSource for all single sourced objects
- Description updated (diff)
Updated by Andreas Müller over 3 years ago
Note2: In the TaxEditor most elements implementing such single source refer to ReferencedEntityBase/IReferencedEntity. This base class will be removed in future as it should only be implemented by OriginalSourceBase then and therefore a base class is not needed anymore. Instead we will have SingleSourcedEntityBase which more or less replaces ReferencedEntityBase and will not inherit from ReferencedEntityBase but from AnnotatableEntity.
The same applies for ReferencedEntityDaoImpl.
Updated by Katja Luther about 3 years ago
- Assignee changed from Katja Luther to Andreas Müller
AM please have a look whether the taxon node details view is ok, in some places the internationalization is still missing.
Updated by Andreas Müller about 3 years ago
I will switch back to "In Progress" once I have reviewed this part.
Updated by Andreas Müller about 3 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
About the new original source section:
- The "detail" field is missing
- There is empty space between "Advanced" and "Id in Source"
- The source is of type DescriptionElementSource so it should also implement nameUsedInSource
- If possible "Advanced" should be indented to show that it belongs to "Placement source", otherwise one thinks that it is an own section
- "Advanced" is maybe not the correct label, it is more "Additional" information
About the new ordering:
- it looks much better now, it becomes much clearer which infomormation part belongs to taxon and which belongs to the node
- Related persond or teams should be moved to the end (as they are by far less used than the placement source I guess
- Secundum detail reference is missing
- There should be a bit more space above and below the separator
- The separator is not visible if the node is updated (not created), is this on purpose? It looks somehow better but with the other bold headers the separation is not that obvious. So either we should find a solution for not having the other headers in bold or we better use the separator
Updated by Katja Luther about 3 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Andreas Müller
The layout issues should be fixed and also the missing fields.
Updated by Andreas Müller about 3 years ago
- File picture319-1.png picture319-1.png added
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
- External links can not be added, a "+" button is missing
- There is empty space between "Advanced" and "Id in Source" => this is still an open issue
- "Details" for Placement source should be indented
- If possible "Advanced" should be indented ... => this is still an open issue
- Related persons or teams should be moved to the end => this is still an open issue
- There should be a bit more space above and below the separator => as there is no separator anymore this is now true for the label "Taxon node" itself
Updated by Andreas Müller about 3 years ago
last remote method : http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/taxonnode.service
last remote request client time : 2020-08-14T13:05:50.252
last remote request response header time : Fri, 14 Aug 2020 13:05:50 GMT
client error time : 2020-08-14T13:07:30.512
login : admin
editor version : 5.17.0.202008132255
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.15.2.0.20200611
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
at eu.etaxonomy.taxeditor.ui.section.classification.TaxonNodeDetailElement.handleEvent(TaxonNodeDetailElement.java:334)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.propertyChange(AbstractCdmDetailElement.java:210)
at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:255)
at eu.etaxonomy.taxeditor.ui.element.TextWithLabelElement.modifyText(TextWithLabelElement.java:178)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:180)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1103)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1084)
at org.eclipse.swt.widgets.Text.wmCommandChild(Text.java:3122)
at org.eclipse.swt.widgets.Control.WM_COMMAND(Control.java:4947)
at org.eclipse.swt.widgets.Control.windowProc(Control.java:4802)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:5123)
at org.eclipse.swt.internal.win32.OS.CallWindowProcW(Native Method)
at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:2446)
at org.eclipse.swt.widgets.Text.callWindowProc(Text.java:262)
at org.eclipse.swt.widgets.Control.windowProc(Control.java:4897)
at org.eclipse.swt.widgets.Text.windowProc(Text.java:2704)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:5110)
at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2552)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3822)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
at org.eclipse.jface.window.Window.open(Window.java:794)
at eu.etaxonomy.taxeditor.navigation.navigator.e4.handler.NewTaxonNodeHandlerE4.execute(NewTaxonNodeHandlerE4.java:58)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:282)
at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:264)
at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:488)
at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:433)
at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:454)
at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem$3.handleEvent(AbstractContributionItem.java:482)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
at eu.etaxonomy.taxeditor.Application.start(Application.java:20)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
Updated by Katja Luther about 3 years ago
Andreas Müller wrote:
- External links can not be added, a "+" button is missing
This is only as long as you did not enter a reference and therefore a descriptionElementSource is created.
Updated by Andreas Müller about 3 years ago
When selecting the placement source the "Additional information" section collapses. This should not happen.
Also when opening a taxon node that has additional source information by default the section should be expanded to show the information
Updated by Andreas Müller about 3 years ago
Katja Luther wrote:
This is only as long as you did not enter a reference and therefore a descriptionElementSource is created.
Hmm, I don't understand this. Why is it depended on entering a reference first?
Hmm, I tested and see now, that entering a detail first swollows this information and field is emptied again. There seems to be something incorrect the way data is created. Why can't you e.g. always create a source and simply remove it before saving if it is completely empty. There is even a method for doing this check: checkEmpty(...)
Updated by Katja Luther about 3 years ago
Andreas Müller wrote:
- External links can not be added, a "+" button is missing
this is fixed
- There is empty space between "Advanced" and "Id in Source" => this is still an open issue
this is not as easy as it seems, I already set margin on top and bottom to 0, I will create a new ticket for this issue => #9192
- "Details" for Placement source should be indented
On other places the details are like they are here, if we change it here, we should change it also for sec reference and nomcl. reference
- If possible "Advanced" should be indented ... => this is still an open issue
this is fixed
- Related persons or teams should be moved to the end => this is still an open issue
this is fixed.
- There should be a bit more space above and below the separator => as there is no separator anymore this is now true for the label "Taxon node" itself
this is fixed.
Updated by Katja Luther about 3 years ago
- Related to feature request #9192: Layout issues for source in taxonnode details added
Updated by Katja Luther about 3 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Andreas Müller
Updated by Andreas Müller about 3 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
Katja Luther wrote:
- "Details" for Placement source should be indented
On other places the details are like they are here, if we change it here, we should change it also for sec reference and nomcl. reference
Yes, we should do this also at the other places but we should start here (by the way nom. ref. and sec. ref. will be handled the same way as placement sec with the next release, so this will be done anyway, soon)
Updated by Andreas Müller about 3 years ago
- % Done changed from 30 to 70
Could we still rename "Additional information" to "More" and not make it bold (we could try with italics, this may make it more clear that it is not a NEW section but it just continous the above section.
In general the dialogue looks much better now, I think
Updated by Katja Luther about 3 years ago
Andreas Müller wrote:
Could we still rename "Additional information" to "More" and not make it bold (we could try with italics, this may make it more clear that it is not a NEW section but it just continous the above section.
In general the dialogue looks much better now, I think
The text is handled by ExpandableComposite a rcp class, I could not find a solution to change the font. The renaming I forgot to commit, sorry is done now.
The indent for the details is added.
Updated by Andreas Müller about 3 years ago
- Precedes bug #9199: Adapt TaxEditor to switch to originalSource for remaining single sourced objects added
Updated by Andreas Müller about 3 years ago
- Subject changed from Adapt Editor to switch to originalSource for all single sourced objects to Adapt Editor to switch to originalSource for TaxonNode and improve layout of TaxonNode dialogue
Updated by Andreas Müller about 3 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Andreas Müller
Katja Luther wrote:
Andreas Müller wrote:
Could we still rename "Additional information" to "More" and not make it bold (we could try with italics, this may make it more clear that it is not a NEW section but it just continous the above section.
In general the dialogue looks much better now, I think
The text is handled by ExpandableComposite a rcp class, I could not find a solution to change the font. The renaming I forgot to commit, sorry is done now.
The indent for the details is added.
So I think open issues are solved. I put ticket to resolved. OK? I add the "font" issue to #9192.
Updated by Andreas Müller about 3 years ago
The renaming for English was missing. I added this.
Updated by Andreas Müller about 3 years ago
- File picture294-1.png picture294-1.png added
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
The indentation does not seem to work yet:
Updated by Andreas Müller about 3 years ago
- Target version changed from Release 5.18 to Release 5.17
Updated by Katja Luther about 3 years ago
- Status changed from Feedback to Closed
The indent is available now, so I close this ticket.