EDIT

This is mostly fixed. 2 remaining issues:

• rename label "status" to "placement status" to clearly distinguish from taxon.doubtful status
• make "status notes" only available if status is not null

Andreas Müller wrote:

This is mostly fixed. 2 remaining issues:

• rename label "status" to "placement status" to clearly distinguish from taxon.doubtful status

done

• make "status notes" only available if status is not null

done

Now existing notes are not deleted if the status is set to null. This is the typical problem that you may not want to loose the information in case you return to the status.
Maybe we can delete the status notes when selecting null but keep in memory to put it back when the status is selected again. Only when saving the TaxonNode the status note will get fully lost.
Or maybe you have another idea.

now the notes are removed, but remembered till the wizard is closed and the taxon node saved. please review.

Now I got an NPE when switching from status to no status

last remote method : http://localhost:49511/remoting/term.service
last remote request client time : 2020-06-12T16:06:45.989
last remote request response header time : Fri, 12 Jun 2020 16:06:46 +0200
client error time : 2020-06-12T16:06:51.509
login : admin
editor version : 5.15.0.202006121153
server : localhost (localhost mgd.) / cdm-test2
schema version : 5.15.1.0.20200610
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.ui.element.MultilanguageTextElement.refresh(MultilanguageTextElement.java:220)
    at eu.etaxonomy.taxeditor.ui.section.classification.TaxonNodeDetailElement.handleEvent(TaxonNodeDetailElement.java:377)
    at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.propertyChange(AbstractCdmDetailElement.java:225)
    at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:256)
    at eu.etaxonomy.taxeditor.ui.combo.EnumComboElement.widgetSelected(EnumComboElement.java:314)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
    at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
    at org.eclipse.jface.window.Window.open(Window.java:794)
    at eu.etaxonomy.taxeditor.handler.defaultHandler.e4.DefaultOpenTaxonNodeWizardHandlerE4.open(DefaultOpenTaxonNodeWizardHandlerE4.java:44)
    at eu.etaxonomy.taxeditor.handler.defaultHandler.e4.DefaultOpenTaxonNodeWizardHandlerE4.open(DefaultOpenTaxonNodeWizardHandlerE4.java:1)
    at eu.etaxonomy.taxeditor.handler.defaultHandler.e4.DefaultOpenHandlerBaseE4.execute(DefaultOpenHandlerBaseE4.java:43)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

Applied in changeset taxeditor|eb5c6646d625eb63d4031b226ae2cd99fa7dda48.

Andreas Müller wrote:

Now I got an NPE when switching from status to no status

the NPE is fixed, please review.

Works as expected