Project

General

Profile

feature request #9033

Adapt TaxEditor to new TaxonNode.status

Added by Andreas Müller 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
05/07/2020
Due date:
% Done:

100%

Severity:
normal

Description

see alos #9005

The 3 checkboxes for unplaced, doubtful and excluded needed to be changed to a dropdown (or a radio button).

Also the label for the "excluded notes" needs be changed to "status notes".


Related issues

Follows Edit - feature request #9005: Make the TaxonNode flags alternatives and change excludednotes to status notes Closed 05/06/2020

Associated revisions

Revision c929d34b (diff)
Added by Katja Luther 4 months ago

ref #9033: adapt editor to taxonnode.status

Revision 6bc0bc7f (diff)
Added by Katja Luther 4 months ago

ref #9033: adapt labels

Revision b7797c35 (diff)
Added by Katja Luther 4 months ago

ref #9033: handling of status notes

Revision eb5c6646 (diff)
Added by Katja Luther 3 months ago

fix #9033: correct handling for notes when switching between status and no staus

History

#1 Updated by Andreas Müller 4 months ago

  • Due date set to 05/07/2020
  • Start date changed from 05/27/2020 to 05/07/2020
  • Follows feature request #9005: Make the TaxonNode flags alternatives and change excludednotes to status notes added

#2 Updated by Andreas Müller 4 months ago

  • Status changed from New to Feedback
  • Priority changed from New to Highest

This is mostly fixed. 2 remaining issues:

  • rename label "status" to "placement status" to clearly distinguish from taxon.doubtful status
  • make "status notes" only available if status is not null

#3 Updated by Andreas Müller 4 months ago

  • Due date deleted (05/07/2020)
  • % Done changed from 0 to 70

#4 Updated by Katja Luther 4 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

This is mostly fixed. 2 remaining issues:

  • rename label "status" to "placement status" to clearly distinguish from taxon.doubtful status

done

  • make "status notes" only available if status is not null

done

#5 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Now existing notes are not deleted if the status is set to null. This is the typical problem that you may not want to loose the information in case you return to the status.
Maybe we can delete the status notes when selecting null but keep in memory to put it back when the status is selected again. Only when saving the TaxonNode the status note will get fully lost.
Or maybe you have another idea.

#6 Updated by Katja Luther 4 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

now the notes are removed, but remembered till the wizard is closed and the taxon node saved. please review.

#7 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Now I got an NPE when switching from status to no status

last remote method : http://localhost:49511/remoting/term.service
last remote request client time : 2020-06-12T16:06:45.989
last remote request response header time : Fri, 12 Jun 2020 16:06:46 +0200
client error time : 2020-06-12T16:06:51.509
login : admin
editor version : 5.15.0.202006121153
server : localhost (localhost mgd.) / cdm-test2
schema version : 5.15.1.0.20200610
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.ui.element.MultilanguageTextElement.refresh(MultilanguageTextElement.java:220)
    at eu.etaxonomy.taxeditor.ui.section.classification.TaxonNodeDetailElement.handleEvent(TaxonNodeDetailElement.java:377)
    at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.propertyChange(AbstractCdmDetailElement.java:225)
    at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:256)
    at eu.etaxonomy.taxeditor.ui.combo.EnumComboElement.widgetSelected(EnumComboElement.java:314)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
    at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
    at org.eclipse.jface.window.Window.open(Window.java:794)
    at eu.etaxonomy.taxeditor.handler.defaultHandler.e4.DefaultOpenTaxonNodeWizardHandlerE4.open(DefaultOpenTaxonNodeWizardHandlerE4.java:44)
    at eu.etaxonomy.taxeditor.handler.defaultHandler.e4.DefaultOpenTaxonNodeWizardHandlerE4.open(DefaultOpenTaxonNodeWizardHandlerE4.java:1)
    at eu.etaxonomy.taxeditor.handler.defaultHandler.e4.DefaultOpenHandlerBaseE4.execute(DefaultOpenHandlerBaseE4.java:43)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

#8 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 70 to 50

#9 Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 50 to 70

Andreas Müller wrote:

Now I got an NPE when switching from status to no status

the NPE is fixed, please review.

#10 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 70 to 100

Works as expected

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)