Project

General

Profile

Actions

feature request #6595

closed

feature request #6565: [MASTER] Eclipse 4 Migration

Migrate name editor

Added by Patrick Plitzner over 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
New
Assignee:
Patrick Plitzner
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
major
Tags:

Files

synonymHasFocus.PNG (31.3 KB) synonymHasFocus.PNG Katja Luther, 10/25/2017 01:27 PM
synonymHighlighted.PNG (56.2 KB) synonymHighlighted.PNG Katja Luther, 10/25/2017 01:27 PM
picture804-1.png (4.15 KB) picture804-1.png Unnecessary change to menu item for accepted taxon Andreas Müller, 11/07/2017 10:49 AM

Related issues

Related to EDIT - bug #6550: ArrayIndexOutOfBoundsException when opening a taxon with double click from the navigatorClosedPatrick Plitzner

Actions
Copied to EDIT - bug #7064: NameEditor remaining issuesClosedPatrick Plitzner

Actions
Copied from EDIT - feature request #7071: Reenable restore functionalityNewKatja Luther

Actions
Actions #1

Updated by Andreas Müller over 5 years ago

  • Related to bug #6550: ArrayIndexOutOfBoundsException when opening a taxon with double click from the navigator added
Actions #2

Updated by Andreas Müller over 5 years ago

  • Target version changed from Unassigned CDM tickets to Release 4.8
Actions #3

Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 4.8 to Release 4.9
Actions #4

Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 4.9 to Release 4.10
Actions #5

Updated by Patrick Plitzner about 5 years ago

  • Status changed from New to In Progress
Actions #6

Updated by Patrick Plitzner about 5 years ago

  • Target version changed from Release 4.10 to Release 4.11
Actions #7

Updated by Patrick Plitzner about 5 years ago

  • % Done changed from 0 to 40
Actions #8

Updated by Patrick Plitzner about 5 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Patrick Plitzner to Katja Luther
  • % Done changed from 40 to 50
Actions #9

Updated by Katja Luther about 5 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Patrick Plitzner

seems to work

Actions #10

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Closed to Resolved
  • % Done changed from 50 to 80

Katja:

Es gibt noch zwei Sachen, die ich im Hinblick auf den Workshop kritisch finde:

Wenn ich einen neuen Namen erzeugt habe und eine Referenz in den NameEditor eingebe, dann funktioniert zwar der Parser richtig, aber der Details View wird nicht aktualisiert, so dass es so aussieht als hätte es nicht funktioniert.

Wenn Synonyme nicht im Name Editor nicht editierbar sind, dann kann ich sie auch nicht auswählen, dann kann ich im Name Editor auch keine Änderungen machen, so dass ich das Problem nicht beheben kann und ich kann sie dann auch nicht löschen.

Actions #11

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
Actions #12

Updated by Katja Luther about 5 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 80 to 50
Actions #13

Updated by Katja Luther about 5 years ago

  • % Done changed from 50 to 80

Wenn Synonyme nicht im Name Editor nicht editierbar sind, dann kann ich sie auch nicht
auswählen, dann kann ich im Name Editor auch keine Änderungen machen, so dass ich das
Problem nicht beheben kann und ich kann sie dann auch nicht löschen.

the textWidget needs to be enabled but not editable to be clickable.

Actions #14

Updated by Katja Luther about 5 years ago

  • Assignee changed from Patrick Plitzner to Andreas Müller
Actions #15

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 80 to 60
  • Severity changed from normal to major

The Name Editor can still be opened multiple times for the same taxon. At least this is the case when trying opening via search result view or referencing objects view. It seems to be not the case when opening via taxon navigator.
In general opening strategy should be independent from where the opening was triggered. If this is not yet the case we should try to make it independent and use 1 single access point.

Actions #16

Updated by Patrick Plitzner about 5 years ago

Andreas Müller wrote:

The Name Editor can still be opened multiple times for the same taxon. At least this is the case when trying opening via search result view or referencing objects view. It seems to be not the case when opening via taxon navigator.
In general opening strategy should be independent from where the opening was triggered. If this is not yet the case we should try to make it independent and use 1 single access point.

This has now also been fixed

Actions #17

Updated by Katja Luther about 5 years ago

  • Assignee changed from Katja Luther to Patrick Plitzner

when opening a taxon that has a synonym the synonym has the focus. But the accepted taxon should have the focus.

No it's more difficult: Opening a taxon in the name editor -> the synonym is highlighted but the selected item seems to be the accepted taxon (details and factual data are displayed) but when clicking on the tab to move it the synonym gets the focus (I did not click in the freetext field) and the details of the synonym are displayed. see attached images

Actions #19

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Katja Luther
  • % Done changed from 60 to 70
Actions #20

Updated by Katja Luther about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Katja Luther to Patrick Plitzner

the focus still moves to the synonym when moving the tab.

Actions #21

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Katja Luther
  • % Done changed from 70 to 80

Fixed the initial selection.

I think all the issues mentioned in the comments are done. Please close if correct

Actions #22

Updated by Katja Luther about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Katja Luther to Patrick Plitzner

I don't know if this is an old issue: but setting a synonym in a heterotypic (to the accepted taxon) homotypic group as basionym changes the symbol of the synonym from homotypic to heterotypic.

Actions #23

Updated by Katja Luther about 5 years ago

the focus stuff works fine now.

Actions #24

Updated by Katja Luther about 5 years ago

Katja Luther wrote:

I don't know if this is an old issue: but setting a synonym in a heterotypic (to the accepted taxon) homotypic group as basionym changes the symbol of the synonym from homotypic to heterotypic.

this is again an update problem because the basionym should be the first synonym in the list and then the icon is correct.
same problem when drag&drop a synoym in the homotypical group of an other synonym, the order should be recalculated.

Actions #25

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

Created a new ticket for the remaining issues -> #7058

Actions #26

Updated by Andreas Müller about 5 years ago

  • Status changed from Closed to Feedback

Have to reopen as it is not possible anymore to add a misapplication to an accepted taxon. The according submenu in the "New" context menu is disabled.

Another less critical issue: context menu of accepted taxon shows "change to" which has 3 disabled submenus. In e3 the "change to" menu item was invisible, which is more appropriate.

Finally, in e3 we had a "save" menu item which is missing in e4 version (not so critical, as save is possible at other places, however, some users might be used to)

Actions #28

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

Fixed misapplication handler and opened ticket for remaining issues. #7064

Please close after review

Actions #29

Updated by Patrick Plitzner about 5 years ago

  • Copied to bug #7064: NameEditor remaining issues added
Actions #30

Updated by Andreas Müller about 5 years ago

Misapplication issue seems to be fixed. Keep ticket open for general review of name editor.

Actions #31

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

Name editor tabs do still show taxon titleCache but should show name titleCache

Actions #32

Updated by Andreas Müller about 5 years ago

Restoring name editors tabs after restart (maybe also reconnect?) does not work anymore, but did in 4.10. (see similar issue in navigator ticket #6909)

Actions #33

Updated by Andreas Müller about 5 years ago

Move synonym (homot. group) to a new accepted taxon does not work correctly. The result is correct, but after the operation only the dirty flag is set. The homotypic group is still visible. It should be the other way round:

  • the synonym group should be removed
  • the dirty flag should NOT be set (because the operation is saved immediately and can't be reverted)
  • additionally the new taxon should be opened (showing the synonym group being moved)

Partly this already didn't work in v4.10: here the synonym group WAS removed but the dirty flag was still set. Also the new accepted taxon was not opened.

Actions #34

Updated by Andreas Müller about 5 years ago

Actions #35

Updated by Andreas Müller about 5 years ago

Actions #36

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 100 to 90

Handler was fixed.

Restoring was disabled on purpose (as described in #6909)

Actions #37

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

Patrick Plitzner wrote:

Handler was fixed.

In the old taxon, the synonym group is still visible (after reopen it is disappeared so it is only a refresh issue) but shouldn't. All the rest works.

Actions #38

Updated by Andreas Müller about 5 years ago

Actions #39

Updated by Katja Luther almost 5 years ago

Andreas Müller wrote:

Patrick Plitzner wrote:

Handler was fixed.

In the old taxon, the synonym group is still visible (after reopen it is disappeared so it is only a refresh issue) but shouldn't. All the rest works.

I can't reproduce this. The old taxon is closed and the new one is opened.

Actions #40

Updated by Katja Luther almost 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
Actions #41

Updated by Patrick Plitzner over 4 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • % Done changed from 90 to 100

The E4 migration has been done up to a sufficient state.
Remaining issues should be handled in separate tickets.

Actions

Also available in: Atom PDF