Project

General

Profile

Actions

feature request #7063

closed

Improve the area selection wizard for distribution editor

Added by Katja Luther almost 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
8:00 h
Severity:
normal
Tags:

Description

The wizard for selection of areas for the distribution editor should be improved.

  • while opening the wizard the vocabularies are not correctly marked if the whole vocabulary or only parts of it should be used in the distribution editor.
  • the wizard is quite slow (performance)

For the first issue we decided to implement the following:

  1. we keep selection via tree structure
  2. the checkbox uses triple state: a. checked, if, and only if, all subareas, and their subareas are fully included
    • undefined, if, some subareas are checked, but not all (including recursive subareas
    • not checked, if no of the subareas is checked or in "undefinded" state it self
  3. opening a node in the tree works via "triangle button"
  4. click actions: double functionality is needed
    • select/deselect all subareas
    • select the given area (not including the subareas)
    • problem: we want to avoid right click menus or other double functionality handling modes (e.g. single click/double click) as they are maybe not intuitive
    • solution: to select/deselect the single area (without subareas) we add it to itself as child node at first position, without children
  5. click action "select all subareas" will
    • open the for one more level
    • check the parent checkbox and all child checkboxes
    • check all grandchild checkboxes if expanded, however for all grand(grand) children the information needs to be stored that they are "checked"
    • opening also all grandchildren takes a lot of rendering time and is not necessary
  6. click "deselect all" will
    • unckeck all child and grandchild areas
    • not change the expansion state of the tree

For performance improvement need something like a UuidAndTitleCache for trees (including the parent information). Loading this should be faster then current implementation but can still load the full vocabulary at once if voc is not extremely large. But maybe this already exists e.g. from taxon navigator DTO.

Open issues:

  • triple state is not yet correctly propagated to vocabulary during initial load (checkbox always empty)
  • deselection only propagates to next parent, but not to grandparent (e.g. if parent switches from checked to undefined and grandparent is also checked, it also needs to switch to undefined)
  • clicking on a parent which is in "undefined" does not change its state but should (either going to checked or unchecked, because also all its children switch to this state

Related issues

Related to EDIT - bug #6297: [Overview] BGBM User group wishes 2017NewAndreas Müller

Actions
Related to EDIT - feature request #7793: Master ticket for E+M editor issuesClosedKatja Luther

Actions
Related to EDIT - feature request #7235: Make available area vocabularies a database preference for TaxEditor distribution editorClosedPatrick Plitzner

Actions
Related to EDIT - task #7854: Open issues in TaxDistributionEditor ClosedKatja Luther

Actions
Related to EDIT - feature request #7912: Enhance checkbox tree viewerClosedPatrick Plitzner

Actions
Copied from EDIT - bug #6159: improve distribution editor in TaxEditorClosedKatja Luther

Actions
Actions #1

Updated by Andreas Müller almost 5 years ago

  • Subject changed from improve the area selection wizard for sistribution editor to improve the area selection wizard for distribution editor
Actions #2

Updated by Katja Luther almost 5 years ago

The area selection wizard works better now then before. Some minor issues:

  • Handling of triple states: if only parts of a vocabulary are selected I would expect a triple state. As the vocabulary itself is not an area, it should only show the state of the selected areas within this vocabulary, with (1) selected = all areas selescted, (2) undefined = some areas selected, (3) unselected = no area selected. I managed to get such an "undefined" state once for the Waterbody vocabulary, but could not reproduce for any other. This is different for parent nodes which are areas themselves. They must not have a triple state because they might be shown or not shown in the editor.

  • The performance of e.g. clicking on TDWG vocabulary is very bad. Probably it is not a use case to select ALL TDWG areas. We may think for a better solution. Maybe it is enough to only select the next layer (e.g. TDWG level 1) and one has to select the next level manually, but this has also drawbacks, so we have to further think about a good solution

Actions #3

Updated by Andreas Müller almost 5 years ago

Actions #4

Updated by Andreas Müller almost 5 years ago

Actions #5

Updated by Andreas Müller almost 5 years ago

  • Copied from bug #6159: improve distribution editor in TaxEditor added
Actions #6

Updated by Andreas Müller almost 5 years ago

  • Target version changed from Release 4.12 to Release 4.13
Actions #7

Updated by Katja Luther almost 5 years ago

Katja Luther wrote:

The area selection wizard works better now then before. Some minor issues:

  • Handling of triple states: if only parts of a vocabulary are selected I would expect a triple state. As the vocabulary itself is not an area, it should only show the state of the selected areas within this vocabulary, with (1) selected = all areas selescted, (2) undefined = some areas selected, (3) unselected = no area selected. I managed to get such an "undefined" state once for the Waterbody vocabulary, but could not reproduce for any other. This is different for parent nodes which are areas themselves. They must not have a triple state because they might be shown or not shown in the editor.

this is partly implemented by checkmark if all areas of a vocabulary are selected and a grayed if only some areas are selected. It is not possible to select a parent node which is an area and deselect the children or select only some of the children (then the parent node is not displayed in distribution editor)

Actions #8

Updated by Katja Luther over 4 years ago

  • Status changed from New to In Progress

for better usabilty the terms are sorted now

Actions #9

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 4.13 to Release 4.14
Actions #10

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 4.14 to Release 5.0

the grayed check boxes for larger hierarchies needs to be improved

Actions #11

Updated by Andreas Müller over 4 years ago

  • Related to bug #6297: [Overview] BGBM User group wishes 2017 added
Actions #12

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 5.0 to Release 5.1
  • % Done changed from 0 to 40
Actions #13

Updated by Andreas Müller over 4 years ago

  • Estimated time set to 8:00 h
Actions #14

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 5.1 to Release 5.2
Actions #15

Updated by Andreas Müller about 4 years ago

  • Target version changed from Release 5.2 to Release 5.3
Actions #16

Updated by Katja Luther about 4 years ago

  • Target version changed from Release 5.3 to Release 5.4
Actions #17

Updated by Katja Luther about 4 years ago

now the admin can define the vocabulary and in the distribution editor itself the shown areas can be defined.

Actions #18

Updated by Andreas Müller almost 4 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

A lot of work on this has been done in #7793. I put to resolved to check if all issues reported here are resolved now.

Actions #19

Updated by Andreas Müller almost 4 years ago

Actions #20

Updated by Andreas Müller almost 4 years ago

  • Related to feature request #7235: Make available area vocabularies a database preference for TaxEditor distribution editor added
Actions #21

Updated by Andreas Müller almost 4 years ago

  • Related to task #7854: Open issues in TaxDistributionEditor added
Actions #22

Updated by Andreas Müller almost 4 years ago

Performance has been improved by preselecting vocabularies in DB prefs or local prefs.

Actions #23

Updated by Andreas Müller almost 4 years ago

  • Description updated (diff)
  • Status changed from Resolved to Feedback
Actions #24

Updated by Andreas Müller almost 4 years ago

I updated description to refelct our decisions how the selection tree should work

Actions #25

Updated by Andreas Müller almost 4 years ago

  • Description updated (diff)
Actions #26

Updated by Andreas Müller almost 4 years ago

  • Description updated (diff)
Actions #27

Updated by Andreas Müller almost 4 years ago

  • Description updated (diff)
Actions #28

Updated by Andreas Müller almost 4 years ago

  • Assignee changed from Andreas Müller to Katja Luther
Actions #29

Updated by Katja Luther almost 4 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I think this is solved with #7887.

Now the items in the tree have three states and it is possible to select and deselct all children of an item.

Actions #30

Updated by Andreas Müller over 3 years ago

  • Subject changed from improve the area selection wizard for distribution editor to Improve the area selection wizard for distribution editor
Actions #31

Updated by Andreas Müller over 3 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 40 to 100

Katja Luther wrote:

I think this is solved with #7887.

Now the items in the tree have three states and it is possible to select and deselct all children of an item.

I think it is #7912 (not 7887). However, the selection wizard works good now. Minor open issues will be handled in #7912. So we can close this ticket.

Actions #32

Updated by Andreas Müller over 3 years ago

Actions

Also available in: Atom PDF