Project

General

Profile

feature request #7071

feature request #7431: [MASTER] remaining E4 migration issues

Reenable restore functionality

Added by Andreas Müller about 2 years ago. Updated 6 days ago.

Status:
New
Priority:
Priority14
Assignee:
Category:
taxeditor
Start date:
10/06/2017
Due date:
% Done:

0%

Severity:
normal
Tags:

Description

With e4 we temporarily switched of the restore functionality in taxon navigator (before it could be be switched on via preferences). This should be switched on again after full migration.

Copy from #6909: "About restoring: Nothing is restored because we decided to start with a fresh workbench every startup. We can think about re-enabling this after full migration IF we want to. Restoring 10+ name editors was also a performance killer because it has to load the name editor AND expand the tree to the corresponding node."

For restoring name editor: it is true that it might be performance problem. But only restoring the name editors without linking to the navigator is usually not a big issue. So we might want to switch of the linking for this somehow. Also we should have restoring as a preference same as restoring the navigator. With a second preference we could then let the user decide if linking should be switched of for restoring name editors.

Idea:

  • After CdmStore has connected invoke "open Part" command on saved editors.
    • Maybe in class LifeCycleManager or CdmStore.
  • EditorInput/UUID can be saved in the local preferences

  • generic "open Part" command

    • ID: eu.etaxonomy.taxeditor.command.openPart
    • command parameter: eu.etaxonomy.taxeditor.workbench.commandparameter.partName
    • command value:

For taxon name editors look at EditorUtil.openNameEditor_internal()


Related issues

Related to Edit - task #6745: Investigate how e4 model changes affect the cached application model in existing Taxeditor installation New 06/21/2017
Related to Edit - feature request #7015: Migrate recent menu item New 10/13/2017
Related to Edit - bug #7064: NameEditor remaining issues Closed 11/07/2017
Related to Edit - feature request #7007: Migrate IMemento functionality Rejected 10/06/2017
Copied from Edit - feature request #6909: Migrate taxon navigator Closed 08/14/2017
Copied to Edit - feature request #6595: Migrate name editor Closed 04/27/2017

History

#1 Updated by Andreas Müller about 2 years ago

#2 Updated by Andreas Müller about 2 years ago

#3 Updated by Andreas Müller about 2 years ago

  • Target version changed from Release 4.12 to Release 4.13

#4 Updated by Andreas Müller almost 2 years ago

  • Target version changed from Release 4.13 to Release 4.14

#5 Updated by Patrick Plitzner almost 2 years ago

  • Tracker changed from bug to feature request

#6 Updated by Andreas Müller almost 2 years ago

  • Target version changed from Release 4.14 to Release 5.0

#7 Updated by Patrick Plitzner almost 2 years ago

  • Tags set to eclipse4

#8 Updated by Patrick Plitzner over 1 year ago

  • Target version deleted (Release 5.0)

removing milestone because master ticket is in current release

#9 Updated by Patrick Plitzner over 1 year ago

  • Status changed from New to Rejected

The E4 migration has been done up to a sufficient state.
This feature was not migrated.
This may be re-visited in #6745.

#10 Updated by Patrick Plitzner over 1 year ago

  • Related to task #6745: Investigate how e4 model changes affect the cached application model in existing Taxeditor installation added

#11 Updated by Andreas Müller over 1 year ago

  • Status changed from Rejected to Feedback
  • Target version set to Release 5.1

Can you leave a note why this is rejected and who decided? Are there technical problems related?

#12 Updated by Andreas Müller over 1 year ago

#13 Updated by Andreas Müller over 1 year ago

  • Related to bug #7064: NameEditor remaining issues added

#14 Updated by Andreas Müller over 1 year ago

  • Parent task changed from #6565 to #7431

#15 Updated by Andreas Müller over 1 year ago

#16 Updated by Andreas Müller over 1 year ago

  • % Done changed from 100 to 0

#17 Updated by Patrick Plitzner over 1 year ago

  • Target version changed from Release 5.1 to Release 5.2

Moving to the next release because it is not critical

#18 Updated by Andreas Müller over 1 year ago

As this is a master ticket only should we switch from Feedback to InProgress? Suits better IMO.

#19 Updated by Andreas Müller over 1 year ago

Upps, sorry, I see that this is not a master ticket. However, InProgress or New might still be the better status.

#20 Updated by Andreas Müller over 1 year ago

??

#21 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.2 to Release 5.3

#22 Updated by Patrick Plitzner over 1 year ago

  • Status changed from Feedback to New

#23 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.3 to Reviewed Next Major Release

#24 Updated by Patrick Plitzner 10 months ago

  • Priority changed from New to Priority14

#25 Updated by Andreas Müller 23 days ago

  • Tags changed from eclipse4 to eclipse4, pp_uebergabe
  • Assignee changed from Patrick Plitzner to Katja Luther

#26 Updated by Patrick Plitzner 6 days ago

  • Tags changed from eclipse4, pp_uebergabe to eclipse4

Idea:

  • After CdmStore has connected invoke "open Part" command on saved editors.
  • EditorInput/UUID can be saved in the local preferences

  • generic "open Part" command

    • ID: eu.etaxonomy.taxeditor.command.openPart
    • command parameter: eu.etaxonomy.taxeditor.workbench.commandparameter.partName
    • command value:

For taxon name editors look at EditorUtil.openNameEditor_internal()

#27 Updated by Patrick Plitzner 6 days ago

  • Description updated (diff)

#28 Updated by Patrick Plitzner 6 days ago

  • Description updated (diff)

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)