feature request #6909
closedfeature request #6565: [MASTER] Eclipse 4 Migration
Migrate taxon navigator
100%
Files
| picture532-1.png (463 Bytes) picture532-1.png | Symbols before | ||
| picture532-2.png (2.65 KB) picture532-2.png | Symbols missing |
Related issues
Updated by Patrick Plitzner about 5 years ago
- Status changed from New to In Progress
- Target version changed from Unassigned CDM tickets to Release 4.10
Updated by Andreas Müller about 5 years ago
- Target version changed from Release 4.10 to Release 4.11
Updated by Patrick Plitzner almost 5 years ago
- Status changed from In Progress to Resolved
- Assignee changed from Patrick Plitzner to Katja Luther
- % Done changed from 0 to 50
Updated by Katja Luther almost 5 years ago
in RemotingCdmHandlerE4.postOperation there is a NPE because onComplete of the operation returns null
Caused by: java.lang.NullPointerException
at eu.etaxonomy.taxeditor.operation.e4.RemotingCdmHandlerE4.postOperation(RemotingCdmHandlerE4.java:64)
at eu.etaxonomy.taxeditor.model.AbstractUtility.lambda$4(AbstractUtility.java:241)
at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:162)
at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:154)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
... 24 more
at eu.etaxonomy.taxeditor.model.MessagingUtils$1.run(MessagingUtils.java:286)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
at eu.etaxonomy.taxeditor.Application.start(Application.java:24)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
at org.eclipse.equinox.launcher.Main.main(Main.java:1492)
Updated by Katja Luther almost 5 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Katja Luther to Patrick Plitzner
Updated by Patrick Plitzner almost 5 years ago
- Assignee changed from Patrick Plitzner to Katja Luther
Katja Luther wrote:
in RemotingCdmHandlerE4.postOperation there is a NPE because onComplete of the operation returns null
Caused by: java.lang.NullPointerException at eu.etaxonomy.taxeditor.operation.e4.RemotingCdmHandlerE4.postOperation(RemotingCdmHandlerE4.java:64) at eu.etaxonomy.taxeditor.model.AbstractUtility.lambda$4(AbstractUtility.java:241) at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:162) at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:154) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182) ... 24 more at eu.etaxonomy.taxeditor.model.MessagingUtils$1.run(MessagingUtils.java:286) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148) at eu.etaxonomy.taxeditor.Application.start(Application.java:24) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610) at org.eclipse.equinox.launcher.Main.run(Main.java:1519) at org.eclipse.equinox.launcher.Main.main(Main.java:1492)
I cannot reproduce that behavior. What did you do?
Updated by Katja Luther almost 5 years ago
select "Set secundum for subtree" with right click on taxon node
Updated by Katja Luther almost 5 years ago
- Assignee changed from Katja Luther to Patrick Plitzner
Updated by Patrick Plitzner almost 5 years ago
- Assignee changed from Patrick Plitzner to Katja Luther
Katja Luther wrote:
select "Set secundum for subtree" with right click on taxon node
This is the exception I get. And it happens because the updateResult is returned before the operation is started. I think the error is in SetSecundumForSubtreeOperation.doUpdateExecute(). Could that be?
Caused by: java.lang.NullPointerException
at eu.etaxonomy.taxeditor.operation.RemotingCdmUpdateOperation.doExecute(RemotingCdmUpdateOperation.java:58)
at eu.etaxonomy.taxeditor.operation.RemotingCdmOperation.execute(RemotingCdmOperation.java:50)
Updated by Andreas Müller almost 5 years ago
- File picture532-1.png picture532-1.png added
- File picture532-2.png picture532-2.png added
- Severity changed from normal to critical
The complete symbol bar is missing (see attachement).
Therefore it is not possible anymore to switch off "Link with Editor". Also it is not possible anymore to Collapse and to Customize view. The first is very important, the second medium, the last minor (currently not in use).
Updated by Andreas Müller almost 5 years ago
The "Open in Referencing objects view" is missing in context menu.
"Open in Distribution Editor" is shown even if preference "Enable Distribution Editor" is not switched on, but shouldn't.
Updated by Patrick Plitzner almost 5 years ago
I added the "link" option to the context menu. That was the fastest way to do it. I tried adding it to the toolbar programatically but that caused problems with the workbench.xmi. Later we will define the toolbars in the application model.
Updated by Patrick Plitzner almost 5 years ago
The "Open in" options should now be correct. Now it also shows up in the referencing objects view but that should be a minor problem now
Updated by Katja Luther almost 5 years ago
- Assignee changed from Katja Luther to Patrick Plitzner
the button for the sync taxon -> navigator should show if it is enabled or not. But it works.
the open in options work now
Updated by Patrick Plitzner almost 5 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Patrick Plitzner to Katja Luther
- % Done changed from 50 to 70
All issues should be fixed now
Updated by Katja Luther almost 5 years ago
- Assignee changed from Katja Luther to Andreas Müller
It seems to be fixed completely, @AM maybe you want to have a final look.
Updated by Katja Luther almost 5 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Patrick Plitzner
It seems that there is a problem with the method LocalSelectionTransfer.getTransfer().getSelection(); which is used for getting the selected taxonNode for drag&drop. This seems to return always the first taxonnode in the navigator.
Updated by Katja Luther almost 5 years ago
Katja Luther wrote:
It seems that there is a problem with the method LocalSelectionTransfer.getTransfer().getSelection(); which is used for getting the selected taxonNode for drag&drop. This seems to return always the first taxonnode in the navigator.
this is handled in #7041.
Updated by Katja Luther almost 5 years ago
- Related to bug #7041: D&D for classifications should not be possible and corrupts data added
Updated by Patrick Plitzner almost 5 years ago
- Status changed from Feedback to Closed
- % Done changed from 70 to 100
Everything should be fixed or moved in to issues
Updated by Andreas Müller almost 5 years ago
- Status changed from Closed to Resolved
- Assignee changed from Patrick Plitzner to Andreas Müller
Updated by Andreas Müller almost 5 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Patrick Plitzner
The "Link" button still does not work always. If I switch it on I first have to reset the focus to the name editor. In e3 it automatically recognized which name editor had the focus before.
Updated by Andreas Müller almost 5 years ago
The "Customize View" does not exist anymore. But as filtering and showing synonyms did not seem to work in 4.10 neither we may live with this and wait until someone requires theses features.
Updated by Andreas Müller almost 5 years ago
Updated by Andreas Müller almost 5 years ago
The experimental featues "Create taxon hierarchy" and "Clone classification" are missing in e4 context menu for classifications. They were still available in 4.10.
Updated by Andreas Müller almost 5 years ago
All other functionality seems to work. So the open issues are #6909#note-22 and #6909#note-25
Updated by Andreas Müller almost 5 years ago
One more open issue: if restore is selected in preferences this does not work anymore. The navigator is always opened in collapsed state. This still worked in 4.10 (also restoring name editors does not work anymore but this will be mentioned in the name editor migration ticket)
Updated by Patrick Plitzner almost 5 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Patrick Plitzner to Andreas Müller
- % Done changed from 100 to 90
Fixed the two mentioned issues.
About restoring: Nothing is restored because we decided to start with a fresh workbench every startup. We can think about re-enabling this after full migration IF we want to. Restoring 10+ name editors was also a performance killer because it has to load the name editor AND expand the tree to the corresponding node.
Updated by Andreas Müller almost 5 years ago
- Copied to feature request #7071: Reenable restore functionality added
Updated by Andreas Müller almost 5 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Patrick Plitzner
The clone assistent throws an NPE. All the rest works.
login : admin
editor version : 4.11.0.201711080902
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 4.7.0.0.201710040000
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
org.eclipse.e4.core.di.InjectionException: org.eclipse.e4.core.di.InjectionException: java.lang.NullPointerException
at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:65)
at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:282)
at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:264)
at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:488)
at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:433)
at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:454)
at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem$3.handleEvent(AbstractContributionItem.java:482)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
at eu.etaxonomy.taxeditor.Application.start(Application.java:24)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
Caused by: org.eclipse.e4.core.di.InjectionException: java.lang.NullPointerException
at org.eclipse.e4.core.internal.di.ConstructorRequestor.execute(ConstructorRequestor.java:52)
at org.eclipse.e4.core.internal.di.InjectorImpl.internalMake(InjectorImpl.java:373)
at org.eclipse.e4.core.internal.di.InjectorImpl.make(InjectorImpl.java:294)
at org.eclipse.e4.core.contexts.ContextInjectionFactory.make(ContextInjectionFactory.java:162)
at eu.etaxonomy.taxeditor.navigation.navigator.e4.handler.CloneClassificationHandlerE4.execute(CloneClassificationHandlerE4.java:50)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
... 36 more
Caused by: java.lang.NullPointerException
at eu.etaxonomy.taxeditor.ui.section.classification.CloneClassificationWizard.<init>(CloneClassificationWizard.java:53)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at org.eclipse.e4.core.internal.di.ConstructorRequestor.execute(ConstructorRequestor.java:40)
... 45 more
Updated by Andreas Müller almost 5 years ago
It looks like the automated creation of a new classification if no classification exists yet does not work anymore. I tested on test/test1 (cdm_test1).
In general in this state it looks like it is not possible to create a new classification. Nothing works.
I havn't tested yet if this is a general issue also valid for DBs having a classification already.
Updated by Katja Luther almost 5 years ago
Andreas Müller wrote:
The clone assistent throws an NPE. All the rest works.
this works now, but the service throws an exception:
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
Failed to execute runnable (java.lang.NullPointerException)
login : admin
editor version : 4.13.0.qualifier
server : localhost (localhost-dev)
schema version : 4.7.0.0.201710040000
os : Windows 7 6.1 amd64
java : 1.8.0_121
at org.eclipse.swt.SWT.error(SWT.java:4533)
at org.eclipse.swt.SWT.error(SWT.java:4448)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
at eu.etaxonomy.taxeditor.Application.start(Application.java:24)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
at org.eclipse.equinox.launcher.Main.main(Main.java:1492)
Caused by : java.lang.NullPointerException
at eu.etaxonomy.cdm.api.service.ClassificationServiceImpl.addChildTaxa(ClassificationServiceImpl.java:159)
at eu.etaxonomy.cdm.api.service.ClassificationServiceImpl.addChildTaxa(ClassificationServiceImpl.java:180)
at eu.etaxonomy.cdm.api.service.ClassificationServiceImpl.addChildTaxa(ClassificationServiceImpl.java:180)
at eu.etaxonomy.cdm.api.service.ClassificationServiceImpl.addChildTaxa(ClassificationServiceImpl.java:180)
at eu.etaxonomy.cdm.api.service.ClassificationServiceImpl.cloneClassification(ClassificationServiceImpl.java:150)
....
Updated by Patrick Plitzner over 4 years ago
- Target version changed from Release 4.11 to Release 4.14
Updated by Patrick Plitzner over 4 years ago
- Assignee changed from Patrick Plitzner to Andreas Müller
Andreas, could you test again it the creation of the first classification still throws an exception? I just tried and it worked.
If this works then please close the ticket because this is the last remaining issue.
Updated by Patrick Plitzner over 4 years ago
I just had the problem that hitting "New->Classification" did nothing, not even an exception. I fixed the handler for this. This should work now.
Updated by Andreas Müller over 4 years ago
- Assignee changed from Andreas Müller to Patrick Plitzner
Creating a new classification works now. Also no exception is thrown anymore.
But in a completely empty database (with no classification) still no default classification is created. But this was the case in earlier versions.
I am not 100% sure if this is an issue that came with e4 or already with remoting.
Updated by Patrick Plitzner over 4 years ago
- Target version changed from Release 4.14 to Release 5.0
moving to current milestone
Updated by Patrick Plitzner over 4 years ago
- Status changed from Feedback to Closed
- % Done changed from 90 to 100
Andreas Müller wrote:
Creating a new classification works now. Also no exception is thrown anymore.
But in a completely empty database (with no classification) still no default classification is created. But this was the case in earlier versions.
I am not 100% sure if this is an issue that came with e4 or already with remoting.
This problem is not related to this issue, created a new one (#7306) and closing this.