Project

General

Profile

feature request #6554

The details views are newly created with every change of the focus

Added by Katja Luther almost 2 years ago. Updated about 1 month ago.

Status:
In Progress
Priority:
Highest
Category:
taxeditor
Start date:
04/03/2017
Due date:
% Done:

0%

Severity:
normal

Description

With every focus change the details view is created completely new. this leads to performance problems.

===

We should test if it is not possible to reuse certain precomputed details views or details view elements to improve performance


Related issues

Related to Edit - bug #6809: Name Editor throws double selection change events Closed 07/13/2017
Related to Edit - feature request #7040: [MASTER]Improve UI performance New 08/07/2018
Related to Edit - feature request #7838: Optimize details view creation for section expansion Closed 10/22/2018

Associated revisions

Revision 8da50b71 (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Avoid double destruction of details view sections

Revision 3b7513fa (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Avoid re-rendering of details view for same selection

Revision 9ef8582f (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Cache form section for taxon and derived unit details view

Revision 93246c1b (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Fix class cast exception

Revision 2e1e89cd (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Cache collection for entity collection sections

Revision 59916c08 (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Avoid double setInput() on managedForm

Revision 81215eb9 (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 set cached collection to null when entity is null

Revision 18b043ef (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Implement update() for DeterminationDetailElement

Revision 90524380 (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Evaluate expansion state at widget creation time

Conflicts:

eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/e4/details/DetailsViewerE4.java

Revision 1685391e (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Fix checkbox selection in update() method

Revision 25fe366b (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Implement update() for taxon details view sections

Revision 143dd6ba (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Rename ISelectable interface to avoid ambiguity for checkboxes

Revision 515cd3ec (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Cache NameDetailElement (experimental)

Revision ed60b90e (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Evaluate expansion state at widget creation time

Revision 69955d6c (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Revert caching of NameDetailElement

Revision ae2b6d7b (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Cache preferred terms in TermManager

Revision 9d0d72ef (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Cache preferred terms in TermManager

Revision 69957587 (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Evaluate expansion state for remaining elements

Revision ac4c5087 (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Pull up isCached() to abstract data viewer class

Revision bb6c8049 (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Evaluate expansion state for missing sections

Revision e12facbf (diff)
Added by Patrick Plitzner 6 months ago

ref #6554 Avoid unnecessary refreshs

Revision 15aa0a1c (diff)
Added by Patrick Plitzner 5 months ago

ref #6554 Fix initial expansion state

Revision 362c07ab (diff)
Added by Patrick Plitzner 5 months ago

ref #6554 Set initial expansion state

Revision cb7b8f2b (diff)
Added by Patrick Plitzner about 1 month ago

ref #6554 Reduce details view rendering

  • enhance check against previous selection
  • remove unused methods

History

#1 Updated by Andreas Müller almost 2 years ago

  • Tracker changed from bug to feature request
  • Subject changed from the details view are newly created with every change of the focus to The details views are newly created with every change of the focus
  • Description updated (diff)

#2 Updated by Patrick Plitzner over 1 year ago

  • Related to bug #6809: Name Editor throws double selection change events added

#3 Updated by Patrick Plitzner over 1 year ago

#4 Updated by Patrick Plitzner 6 months ago

The performance loss is separated in two areas:

  1. SWT/UI rendering
    • can be optimized by caching the UI widgets
  2. cdm service layer calls
    • can be optimized by reducing service calls
    • We should also watch out for preference queries that contain service calls like e.g. PreferencesUtil.getGlobalLanguage()

#5 Updated by Patrick Plitzner 6 months ago

  • Status changed from New to In Progress
  • Assignee changed from Katja Luther to Patrick Plitzner
  • Target version changed from Unassigned CDM tickets to Release 5.4

#6 Updated by Patrick Plitzner 6 months ago

Another bottleneck is

org.hibernate.collection.internal.PersistentSet.size()
org.hibernate.collection.internal.PersistentSet.iterator()

in some cases taking >90% of the rendering time of the supplemental data view

#7 Updated by Andreas Müller 6 months ago

Patrick Plitzner wrote:

Another bottleneck is

org.hibernate.collection.internal.PersistentSet.size()
org.hibernate.collection.internal.PersistentSet.iterator()

in some cases taking >90% of the rendering time of the supplemental data view

That is interesting. What exactly is it doing. Loading all data or only 1 request per Set to get the size?

I discussed this with Cherian already if we should have something like a count cache for persistend collections.

Or is it possible to combine the initialization or only the size-request for all supplemental data and not run it instance for instance?

#8 Updated by Andreas Müller 6 months ago

The count cache might be also something for the data portals

#9 Updated by Patrick Plitzner 5 months ago

#10 Updated by Patrick Plitzner 5 months ago

  • Target version changed from Release 5.4 to Release 5.5

#11 Updated by Patrick Plitzner about 2 months ago

  • Target version changed from Release 5.5 to Release 5.6

#12 Updated by Andreas Müller about 1 month ago

  • Target version changed from Release 5.6 to Reviewed Next Major Release

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)