Project

General

Profile

Actions

feature request #10057

closed

Add "accessed" field to OriginalSourceBase

Added by Andreas Müller about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Priority14
Category:
cdm
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

to allow reusability for references of type "WebPage".

Currently it is not possible to fully reuse them once the "accessed" field is used there.

It still needs discussion if the WebPage.accessed should be kept or removed instead. It might be necessary for formatting within a bibliography that does not show detail information or as default value. So if the discussion does not lead to another conclusion I suggest to keep it.
Handling should be similar to the handling of Book/BookSection.datePublished then.

In the TaxEditor the accessed field should only show up if the citation in OriginalSource is of type WebPage or Database. => TaxEditor implementation should be a separate ticket.


Files

clipboard-202205111331-1tf2u.png (52.8 KB) clipboard-202205111331-1tf2u.png Andreas Müller, 05/11/2022 01:31 PM

Related issues

Related to EDIT - bug #10056: Make Reference.Accessed deletable in TaxEditorClosedKatja Luther05/16/202205/20/2022

Actions
Related to EDIT - feature request #5258: Accessed field for WebPagesClosedAndreas Müller

Actions
Related to EDIT - bug #7074: Use TimePeriod for Media.mediaCreatedClosedAndreas Müller

Actions
Related to EDIT - bug #10126: Refresh original source element after changing from dynamic reference to not dynamic reference or other way roundNewKatja Luther

Actions
Related to EDIT - feature request #10145: Transform accessed field in Reference from DateTime to TimePeriodNewAndreas Müller

Actions
Actions #1

Updated by Andreas Müller about 2 years ago

  • Related to bug #10056: Make Reference.Accessed deletable in TaxEditor added
Actions #2

Updated by Andreas Müller about 2 years ago

Actions #3

Updated by Andreas Müller about 2 years ago

  • Related to bug #7074: Use TimePeriod for Media.mediaCreated added
Actions #4

Updated by Andreas Müller about 2 years ago

WGB:

mir ist gerade an Hand des folgenden Eintrags etwas aufgefallen:

Hier werden 36 Einträge referenziert – aber vermutlich nicht alle in einer Minute!
Ich habe bisher das Zugangsdatum immer in das Ref-Detail geschrieben – sonst müsste ich ja für jeden IPNI, Tropicos oder POWO-Eintrag eine neue Referenz eintragen. Außerdem haben wir in Caryophyllales_spp ein eigenes Format für das Datum (nn ### nnnn, ###= Monatsabk.).

AM:

Zu dem Rest: das stimmt, das „accessed“ Feld verhindert natürlich die Widerverwendung von Referenzen vom Typ Webpage.
Vielleicht macht es Sinn, der Klasse OriginalSource, in der ja auch das Detail gespeichert ist noch ein Feld „accessed“ hinzuzufügen. Ich denke, das macht auf jeden Fall Sinn.
Die Frage ist, ob wir zudem das Feld accessed in WebPage behalten. Das könnte in den Fällen Sinn machen, in denen die Referenz in einer Bibliographie ohne Details-Angabe auftaucht, wenn aber dennoch eine „accessed“ Information angezeigt werden soll. In der Regel sollte dieses accessed aber nicht ausgefüllt werden. Das Details accessed würde bei der Formatierung ggf. dann das WebPage accessed überschreiben.
Das wäre dann so ähnlich wie bei Book und BookSection, wo man auch für beides ein published Datum eingeben kann, letzteres aber ggf. den Vorrang hat bei der Auswertung.

Ich lege mal ein Ticket an: https://dev.e-taxonomy.eu/redmine/issues/10057
Und nehme gerne Kommentare entgegen, insbesondere auch zu der Frage, ob es Sinn macht, das alte WebPage.accessed Feld zu behalten.

Egal wie, sollten beide Felder vom Typ TimePeriod sein, also freilassen, welche Teile des Datums man eingibt und auch Zeitspannen zulassen.

WGB:

ja, accessed sollte wie das detail gehandhabt werden können, aber nur bei Webpages und Databases.
Ich plädiere dafür, dass dieser Eintrag bei Webpages statt des Details auftauchen sollte – zumindest optional (m.A.n. ist das Detail bei Webpages – wenn überhaupt – sehr selten nötig).
Ich weiß allerdings nicht so recht, ob ich da gerne den komplexen Datumsdialog hätte, der ja bei jeder Neueingabe nervt. Aber man kann ja auch schummeln und weiter das Details-Feld benutzen (wenn’s das gibt – s.o.).

Actions #5

Updated by Andreas Müller about 2 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 30

Model change done (not yet tested). Still needs cache strategy update and TaxEditor adaptation. Also maybe in Phycobank-Editor.

Actions #6

Updated by Andreas Müller about 2 years ago

  • Target version changed from CDM UML 5.45 to Release 5.32
Actions #7

Updated by Andreas Müller almost 2 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 30 to 70

This is implemented now in model and first implementations for OriginalSourceFormatter and TaxonBaseDefaultCacheStrategy are also implemented.

Also first implementation in TaxEditor implemented, see commit:29de040015b98 . However, the accessed field is only shown if the citation is of type dynamic (webpage, database or map). But it still needs a focus change to be shown/removed if the type changes (e.g. when set citation is set the first time). This still needs to be adapted.
@Katja: when reviewing, can you please do the adaptation or if more difficult create a ticket for this adaptation?

Actions #8

Updated by Andreas Müller almost 2 years ago

  • Priority changed from Highest to Priority14
Actions #9

Updated by Katja Luther almost 2 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 70 to 100

Andreas Müller wrote in #note-7:

This is implemented now in model and first implementations for OriginalSourceFormatter and TaxonBaseDefaultCacheStrategy are also implemented.

Also first implementation in TaxEditor implemented, see commit:29de040015b98 . However, the accessed field is only shown if the citation is of type dynamic (webpage, database or map). But it still needs a focus change to be shown/removed if the type changes (e.g. when set citation is set the first time). This still needs to be adapted.
@Katja: when reviewing, can you please do the adaptation or if more difficult create a ticket for this adaptation?

Unfortunately a simple refresh does not work, updating only the secundum source element, moves this part at the end of the taxon part and updating the taxon part adds an empty space between title and first element(titleCache) both not really nice, so I create a new ticket to solve this.

Actions #10

Updated by Katja Luther almost 2 years ago

  • Related to bug #10126: Refresh original source element after changing from dynamic reference to not dynamic reference or other way round added
Actions #11

Updated by Andreas Müller almost 2 years ago

Actions

Also available in: Atom PDF