Project

General

Profile

Actions
Copy link

bug #9766

closed

CDM vocabularies should not be editable

Added by Andreas Müller over 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Highest
Assignee:
Katja Luther
Category:
taxeditor
Target version:
Release 5.36
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:
Tags:
terms

Description

this is already implemented for languages in #9747. We should implement it for all CDM vocabularies.

Related issues

Related to EDIT - feature request #9747: Make languages editable in TaxEditorClosedKatja Luther

Actions
Related to EDIT - bug #10259: Terms of the default vocabularies should not be moved or deletedNewKatja Luther

Actions
Actions
Copy link
 #1

Updated by Andreas Müller over 2 years ago

Actions
Copy link
 #2

Updated by Andreas Müller over 2 years ago

AM:

Wir könnten auch je Klasse ein cdmVocabularyUuids() einführen, die dann alle bekannten CDM VOC uuids zurückgibt, mit der man dann checken kann, ob ein voc ein CDM Voc ist. Ich habe das für Language gerade mal angelegt. Aber vielleicht ist es besser, dass in die TermType Klasse zu verschieben und mit TermType als Parameter abzufragen. Dann hat man alles an einer Stelle und es ist leichter abfragbar.
Du kannst ja mal überlegen, was das sinnigste ist. Da es nicht ewig benutzt werden wird, ist es nicht ganz so wichtig. Aber gut, wenn es an einer Stelle steht, dann können wir es später im Bulk Löschen. Wir sollten es aber für alle editierbaren Terme implementieren.

Actions
Copy link
 #3

Updated by Katja Luther about 1 year ago

  • Related to bug #10259: Terms of the default vocabularies should not be moved or deleted added
Actions
Copy link
 #4

Updated by Katja Luther about 1 year ago

We could use the VocabularyEnum and add a method getVocabularyByUuid or a method to check whether a vocabulary is part of this enum.

Actions
Copy link
 #5

Updated by Katja Luther about 1 year ago

I implemented it with the VocabularyEnum and it seems to work. I would commit it and you can have a look whether it is ok.

Actions
Copy link
 #6

Updated by Andreas Müller about 1 year ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 60

I guess this is for review?

Actions
Copy link
 #7

Updated by Katja Luther about 1 year ago

  • Assignee changed from Katja Luther to Andreas Müller

Yes, please review.

Actions
Copy link
 #8

Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 5.45 to Release 5.44
Actions
Copy link
 #9

Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 5.44 to Release 5.36
Actions
Copy link
 #10

Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 60 to 70

Drag&drop from and to CDM vocabularies is still possible. Move to ... I could not check as there was an NPE in the parent search. I fixed and pushed it.

Actions
Copy link
 #11

Updated by Katja Luther about 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Missed to commit the changes and now also added that the standard vocabularies are not shown in the term choosing wizard. Please review.

Actions
Copy link
 #12

Updated by Andreas Müller about 1 year ago

Moving a term via context menu does not work anymore. I tried with multiple feature and state terms which do not belong to CDM default vocabularies.

I don't if this is related to the current fix. If not, please open a new ticket.

Actions
Copy link
 #13

Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
Actions
Copy link
 #14

Updated by Katja Luther about 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote in #note-12:

Moving a term via context menu does not work anymore. I tried with multiple feature and state terms which do not belong to CDM default vocabularies.

I don't if this is related to the current fix. If not, please open a new ticket.

This is fixed.

Actions
Copy link
 #15

Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Now it is (again?) possible to move a term from a non-CDM voc to a CDM-voc via d&d. I tried with "Delete2" from "Delete voc" into "Feature" on rem_conf_am.
This is dangerous because if it happens accidentely the user has no chance to move it back.

Actions
Copy link
 #16

Updated by Katja Luther about 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This is fixed, please review.

Actions
Copy link
 #17

Updated by Andreas Müller about 1 year ago

When trying to movie a feature via context menu to "test" I got 

java.lang.NullPointerException
    at eu.etaxonomy.cdm.persistence.dto.TermDto.localize(TermDto.java:127)
    at eu.etaxonomy.taxeditor.view.search.facet.term.TermSearchResult.initFacets(TermSearchResult.java:36)
    at eu.etaxonomy.taxeditor.view.search.facet.term.TermSearchResult.initFacets(TermSearchResult.java:1)
    at eu.etaxonomy.taxeditor.view.search.facet.SearchResult.<init>(SearchResult.java:28)
    at eu.etaxonomy.taxeditor.view.search.facet.term.TermSearchResult.<init>(TermSearchResult.j

Fixed by KL but check needed if there might be follow up exceptions.

Actions
Copy link
 #18

Updated by Andreas Müller about 1 year ago

  • Priority changed from New to Highest
Actions
Copy link
 #19

Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 70 to 100
Actions
Copy link

Also available in: Atom PDF