feature request #9747
closedMake languages editable in TaxEditor
100%
Description
Currently languages are not yet editable in TaxEditor.
For the CDM this is correct. But other languages should be editable.
We need an entry in the terms-vocabulary menu for this.
Files
Related issues
Updated by Katja Luther over 2 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 50
Applied in changeset taxeditor|53e555624aa688350d4c89e43e8a3f172e534022.
Updated by Katja Luther over 2 years ago
- Assignee changed from Katja Luther to Andreas Müller
- Severity changed from normal to blocker
To add the language editor can be done in 5 minutes, but to allow the editing for non cdm languages and do not allow for cdm languages is a little bit more difficult.
The actual implementation checks whether the vocabulary has titleCache "Languages (ISO 639-2)", maybe we should handle this more generic by a flag for cdm vocabularies.
Please review the actual implementation
Updated by Katja Luther over 2 years ago
Now the implementation uses the cdmVocabularyUuid method.
Updated by Andreas Müller over 2 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
The menu for vocabularies and term trees should use the same order. Please move the "language" menu item to the same position as in the term tree menu.
Updated by Andreas Müller over 2 years ago
- File picture451-1.png picture451-1.png added
Minor issue:
There is a separator below "New" but no other group or item:
Can we remove this.
Also for non-CDM vocabularies there are 2 separators between "New" and "Delete". One should be enough.
Updated by Andreas Müller over 2 years ago
Functionallity works and ticket can be closed.
However, the Language class has 1 more attribute iso639_1 which refers to the "ISO 639-1" id. Is it possible to add this field to the details view? Best position would be below ID in vocabulary.
Is this easy to implement or should we open a new ticket?
Updated by Andreas Müller over 2 years ago
According to commit 53e555624aa688 there is lots of commented code now in OpenDefinedTermEditorHandlerE4.java . Can this be removed or is it still needed?
Updated by Katja Luther over 2 years ago
- Assignee changed from Katja Luther to Andreas Müller
Andreas Müller wrote:
According to commit 53e555624aa688 there is lots of commented code now in OpenDefinedTermEditorHandlerE4.java . Can this be removed or is it still needed?
I already reverted the changes in this file, this will come with the changes of the character matrix and therefore the commented code will be removed.
Updated by Katja Luther over 2 years ago
- Status changed from Feedback to Resolved
Applied in changeset taxeditor|5cabd426f71e5cc0254e32e414ff7afc26b92ed5.
Updated by Katja Luther over 2 years ago
Andreas Müller wrote:
Functionallity works and ticket can be closed.
However, the Language class has 1 more attribute iso639_1 which refers to the "ISO 639-1" id. Is it possible to add this field to the details view? Best position would be below ID in vocabulary.
Is this easy to implement or should we open a new ticket?
This is fixed.
Updated by Katja Luther over 2 years ago
Andreas Müller wrote:
The menu for vocabularies and term trees should use the same order. Please move the "language" menu item to the same position as in the term tree menu.
this is fixed
Updated by Katja Luther over 2 years ago
The doubled separators are removed. Please review.
Updated by Andreas Müller over 2 years ago
- Related to bug #9766: CDM vocabularies should not be editable added
Updated by Andreas Müller over 2 years ago
- Status changed from Resolved to Closed
- Assignee changed from Andreas Müller to Katja Luther
- % Done changed from 50 to 100
This works as expected.
For the disabling of other CDM vocabularies I added a new ticket. If disabling was easy to implement we could maybe try to solve this also in 5.27.
Updated by Andreas Müller over 2 years ago
- Target version changed from Release 5.45 to Release 5.27