Project

General

Profile

feature request #9515

Add DescriptionType to TaxonDescription of TaxonAssociations in ABCD import

Added by Katja Luther 8 months ago. Updated 5 months ago.

Status:
Closed
Priority:
New
Assignee:
Category:
cdmadapter
Target version:
Start date:
03/05/2021
Due date:
% Done:

100%

Severity:
normal
Tags:

Description

copied from #9512:

Probably more such descriptions are created by the ABCD import. Katja, can you please check if ABCD already sets the status? If not create a ticket with additivity tag.
There are some other issues related to this status. I will create new tickets for them.

Open issues:

  • search for a description of type "TaxonAssociation" and use this description or create a new one

Related issues

Related to Edit - bug #9512: Descriptions being created for individual associations in matrix should have description status "Individual association" Closed 03/05/2021
Related to Edit - feature request #9519: Add posibilty to add IndividualAssociation descriptions in Facts View New 03/05/2021

Associated revisions

Revision 25935ad5 (diff)
Added by Katja Luther 7 months ago

fix #9515: adapt AbcdImport to Descriptiontype.IndividualAssociations

Revision b915dafb (diff)
Added by Andreas Müller 7 months ago

ref #9515 adding a break in the loop as we only search for the first description being a specimen holding description

Revision 31c1b80e (diff)
Added by Andreas Müller 7 months ago

ref #9515 rename state in SpecimenImportBase to individualsAssociationDescriptionPerTaxon and cleanup

Revision a9a9d9f0 (diff)
Added by Andreas Müller 7 months ago

cleanup and fix compile error related to ref #9515

Revision 7c3d49e6 (diff)
Added by Katja Luther 7 months ago

ref #9515: remove second call setIndividualsAssociationDescriptionPerTaxon

History

#1 Updated by Katja Luther 8 months ago

  • Related to bug #9512: Descriptions being created for individual associations in matrix should have description status "Individual association" added

#2 Updated by Andreas Müller 8 months ago

  • Tags set to additivity, fast
  • Target version changed from Unassigned CDM tickets to Release 5.22

#3 Updated by Andreas Müller 8 months ago

  • Related to feature request #9519: Add posibilty to add IndividualAssociation descriptions in Facts View added

#4 Updated by Andreas Müller 7 months ago

  • Subject changed from Add DescriptionType to TaxonDescription of TaxonAssociations to Add DescriptionType to TaxonDescription of TaxonAssociations in ABCD import

#5 Updated by Katja Luther 7 months ago

Now a description with type IndivialsAssociation is created or if already existing used to add the individual associations.

#6 Updated by Katja Luther 7 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#7 Updated by Katja Luther 7 months ago

  • Category changed from cdmadapter to taxeditor
  • Assignee changed from Katja Luther to Andreas Müller
  • Severity changed from normal to blocker

please review

#8 Updated by Andreas Müller 7 months ago

  • Category changed from taxeditor to cdmadapter
  • Severity changed from blocker to normal

#9 Updated by Andreas Müller 7 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Have you tested with a real import that it works?

#10 Updated by Andreas Müller 7 months ago

  • % Done changed from 50 to 70

I have renamed the method to set the description to the import state to get/setIndividualsAssociationDescriptionPerTaxon to make semantics clear. (push will come with the model update branch)

There is one thing I wonder about: in about line 1253 you call this method again. I it should be removed here and either added to the loop (before break) or generally be put before "//PREPARE REFERENCE QUESTIONS" and called only 1x (so being removed in the if-statement with "TaxonDescription.NewInstance(taxon, false);" (the later is preferred as it is simpler)

Can you adapt the code accordingly (once I have pushed my changes) and run a final import test on nightly. Then we can close this ticket.

#11 Updated by Katja Luther 7 months ago

  • Status changed from Feedback to Closed

adapted the code, tested and worked as expected.

#12 Updated by Katja Luther 7 months ago

  • % Done changed from 70 to 100

#13 Updated by Andreas Müller 5 months ago

  • Tags changed from additivity, fast to additivity

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)