Project

General

Profile

Actions

feature request #9025

closed

allow for creating a new schema in empty dbs via the remote login dialog

Added by Andreas Kohlbecker over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

this is a followup ticket to #9023.

The remote login dialog should set the "cdm.forceSchemaCreate" option for a db when the first startup has failed due to a CdmDatabaseException or SchemaExtractionException


Files

picture520-1.png (34.2 KB) picture520-1.png Andreas Kohlbecker, 06/09/2020 05:10 PM
picture520-2.png (48.2 KB) picture520-2.png Andreas Kohlbecker, 06/09/2020 05:10 PM

Related issues

Related to EDIT - bug #9058: Hibernate loggs error when creating schema on MySQL due to failing index creationClosedAndreas Müller

Actions
Related to EDIT - task #9119: Remove schema create and schema update functionality from datsource viewClosedKatja Luther

Actions
Has duplicate EDIT - bug #5601: Creation of local database structure via remotingDuplicateAndreas Müller

Actions
Actions #1

Updated by Andreas Kohlbecker over 2 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #2

Updated by Andreas Müller over 2 years ago

Should this be reviewed by someone?

Actions #3

Updated by Andreas Kohlbecker over 2 years ago

  • Assignee changed from Andreas Kohlbecker to Katja Luther

Andreas Müller wrote:

Should this be reviewed by someone?

I think this is not really needed, but having someone to throw a second pair of eyeballs on it can not be wrong:

@Katja: I guess you are the for sure the most experiences with Taxeditor code, can you please review?

Actions #4

Updated by Andreas Müller over 2 years ago

  • Assignee changed from Katja Luther to Andreas Müller

I am currently reviewing this issue (and implementing some further improvements)

Actions #5

Updated by Andreas Kohlbecker over 2 years ago

reviewing your changes I found the following issues:

1) In case of an empty DB the following notification is shown:

"Database schema is missing. Please create database schema. NOTE: This will delete all existing data!!"

The NOTE "This will delete all existing data!!" implies that there is existing data, which can be misleading. We should change this to "Any existing data in this database will be deleted if present."

2) Switching from localhost managed to another server does not reset the button color and label from "Create Schema" to "Connect" and is not re-enabled

3) when using the system properties -Dcdm.server.dev.port=8081 -Dcdm.server.dev.username=admin -Dcdm.server.dev.password=00000 and the specified server is not available and error dialog occurs - this is correct behavior. The dialog always recovered properly from this error which is no longer the case. The connect button is now stuck in the disabled state.

Actions #6

Updated by Andreas Kohlbecker over 2 years ago

another problem:

4) Taxeditor SNAPSHOT version: Open connect dialog, The dialog initially tries to connect the demo 1 server. This fails with:

after changing the cdm server the dialog fails to retrieve the instances:

This is the same with any server, pressing the refresh buttons does not help.

This is a SEVERE BUG as it currently blocks from connecting to servers if the dialog starts with the "wrong" sever.

Actions #7

Updated by Andreas Müller over 2 years ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Yes, the refactoring was not fully ready. Can you please try again if the above problems still appear?

Actions #8

Updated by Andreas Müller over 2 years ago

  • Related to bug #9058: Hibernate loggs error when creating schema on MySQL due to failing index creation added
Actions #9

Updated by Andreas Müller over 2 years ago

  • Has duplicate bug #5601: Creation of local database structure via remoting added
Actions #10

Updated by Andreas Kohlbecker over 2 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

The Points 1 - 4 from above are fixed.

Two remaining issues:

  • The connect button however looks a bit strange by now: Its border is black instead of the color which is defined by the desktop theme.
  • The "Create Schema" must not be triggered by hitting the enter key in the password or username fields
Actions #11

Updated by Andreas Müller over 2 years ago

Andreas Kohlbecker wrote:

The Points 1 - 4 from above are fixed.

Two remaining issues:

  • The connect button however looks a bit strange by now: Its border is black instead of the color which is defined by the desktop theme.
  • The "Create Schema" must not be triggered by hitting the enter key in the password or username fields

Katja, do you know how to set the default color? Is there a method?

Actions #12

Updated by Andreas Kohlbecker over 2 years ago

Andreas Müller wrote:

Andreas Kohlbecker wrote:

The Points 1 - 4 from above are fixed.

Two remaining issues:

  • The connect button however looks a bit strange by now: Its border is black instead of the color which is defined by the desktop theme.
  • The "Create Schema" must not be triggered by hitting the enter key in the password or username fields

Katja, do you know how to set the default color? Is there a method?

I guess setting null as color should reset to the default. I am just about testing this.

Actions #13

Updated by Andreas Kohlbecker over 2 years ago

The color issue is fixed, now. Please can someone check the look on windows?

Actions #14

Updated by Andreas Kohlbecker over 2 years ago

The "Create Schema" must not be triggered by hitting the enter key in the password or username fields

Is also fixed.

From my point of view this ticket can be closed.

Actions #15

Updated by Andreas Müller over 2 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
  • % Done changed from 50 to 100
Actions #16

Updated by Andreas Müller over 2 years ago

  • Related to task #9119: Remove schema create and schema update functionality from datsource view added
Actions

Also available in: Atom PDF