Project

General

Profile

feature request #9025

allow for creating a new schema in empty dbs via the remote login dialog

Added by Andreas Kohlbecker 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
05/20/2020
Due date:
% Done:

100%

Severity:
normal

Description

this is a followup ticket to #9023.

The remote login dialog should set the "cdm.forceSchemaCreate" option for a db when the first startup has failed due to a CdmDatabaseException or SchemaExtractionException

picture520-1.png View (34.2 KB) Andreas Kohlbecker, 06/09/2020 05:10 PM

picture520-2.png View (48.2 KB) Andreas Kohlbecker, 06/09/2020 05:10 PM


Related issues

Related to Edit - bug #9058: Hibernate loggs error when creating schema on MySQL due to failing index creation Closed 06/09/2020
Related to Edit - task #9119: Remove schema create and schema update functionality from datsource view Feedback 07/02/2020
Duplicated by Edit - bug #5601: Creation of local database structure via remoting Duplicate 07/06/2016

Associated revisions

Revision 1e4ec948 (diff)
Added by Andreas Kohlbecker 3 months ago

fix #9025 allow for creating a new schema in empty dbs via the remote login dialog

Revision 5a20c932 (diff)
Added by Andreas Müller 2 months ago

ref #9025 improve localhost mgd. handling for schema create and update and some general minor improvements and refactorings

Revision 07a97068 (diff)
Added by Andreas Müller 2 months ago

ref #9025 improve localhost mgd. handling (cont.)

Revision e1aeb4ac (diff)
Added by Andreas Müller 2 months ago

ref #9025 improve localhost mgd. handling (cont.)

Revision bb9cba6b (diff)
Added by Andreas Müller 2 months ago

ref #9025 improve localhost mgd. handling (cont.)

Revision ec99dd06 (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9025 fixing button color issue

Revision aa175a7a (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9025 password field does not trigger connect button when action is schmea create

History

#1 Updated by Andreas Kohlbecker 3 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#2 Updated by Andreas Müller 3 months ago

Should this be reviewed by someone?

#3 Updated by Andreas Kohlbecker 3 months ago

  • Assignee changed from Andreas Kohlbecker to Katja Luther

Andreas Müller wrote:

Should this be reviewed by someone?

I think this is not really needed, but having someone to throw a second pair of eyeballs on it can not be wrong:

@Katja: I guess you are the for sure the most experiences with Taxeditor code, can you please review?

#4 Updated by Andreas Müller 2 months ago

  • Assignee changed from Katja Luther to Andreas Müller

I am currently reviewing this issue (and implementing some further improvements)

#5 Updated by Andreas Kohlbecker 2 months ago

reviewing your changes I found the following issues:

1) In case of an empty DB the following notification is shown:

"Database schema is missing. Please create database schema. NOTE: This will delete all existing data!!"

The NOTE "This will delete all existing data!!" implies that there is existing data, which can be misleading. We should change this to "Any existing data in this database will be deleted if present."

2) Switching from localhost managed to another server does not reset the button color and label from "Create Schema" to "Connect" and is not re-enabled

3) when using the system properties -Dcdm.server.dev.port=8081 -Dcdm.server.dev.username=admin -Dcdm.server.dev.password=00000 and the specified server is not available and error dialog occurs - this is correct behavior. The dialog always recovered properly from this error which is no longer the case. The connect button is now stuck in the disabled state.

#6 Updated by Andreas Kohlbecker 2 months ago

another problem:

4) Taxeditor SNAPSHOT version: Open connect dialog, The dialog initially tries to connect the demo 1 server. This fails with:

after changing the cdm server the dialog fails to retrieve the instances:

This is the same with any server, pressing the refresh buttons does not help.

This is a SEVERE BUG as it currently blocks from connecting to servers if the dialog starts with the "wrong" sever.

#7 Updated by Andreas Müller 2 months ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Yes, the refactoring was not fully ready. Can you please try again if the above problems still appear?

#8 Updated by Andreas Müller 2 months ago

  • Related to bug #9058: Hibernate loggs error when creating schema on MySQL due to failing index creation added

#9 Updated by Andreas Müller 2 months ago

  • Duplicated by bug #5601: Creation of local database structure via remoting added

#10 Updated by Andreas Kohlbecker about 2 months ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

The Points 1 - 4 from above are fixed.

Two remaining issues:

  • The connect button however looks a bit strange by now: Its border is black instead of the color which is defined by the desktop theme.
  • The "Create Schema" must not be triggered by hitting the enter key in the password or username fields

#11 Updated by Andreas Müller about 2 months ago

Andreas Kohlbecker wrote:

The Points 1 - 4 from above are fixed.

Two remaining issues:

  • The connect button however looks a bit strange by now: Its border is black instead of the color which is defined by the desktop theme.
  • The "Create Schema" must not be triggered by hitting the enter key in the password or username fields

Katja, do you know how to set the default color? Is there a method?

#12 Updated by Andreas Kohlbecker about 2 months ago

Andreas Müller wrote:

Andreas Kohlbecker wrote:

The Points 1 - 4 from above are fixed.

Two remaining issues:

  • The connect button however looks a bit strange by now: Its border is black instead of the color which is defined by the desktop theme.
  • The "Create Schema" must not be triggered by hitting the enter key in the password or username fields

Katja, do you know how to set the default color? Is there a method?

I guess setting null as color should reset to the default. I am just about testing this.

#13 Updated by Andreas Kohlbecker about 2 months ago

The color issue is fixed, now. Please can someone check the look on windows?

#14 Updated by Andreas Kohlbecker about 2 months ago

The "Create Schema" must not be triggered by hitting the enter key in the password or username fields

Is also fixed.

From my point of view this ticket can be closed.

#15 Updated by Andreas Müller about 2 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
  • % Done changed from 50 to 100

#16 Updated by Andreas Müller about 1 month ago

  • Related to task #9119: Remove schema create and schema update functionality from datsource view added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)