Project

General

Profile

bug #8190

Default FeatureTree throws exception

Added by Patrick Plitzner 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
New
Category:
cdm
Target version:
Start date:
03/21/2019
Due date:
% Done:

100%

Severity:
critical
Found in Version:

Description

When there are Characters and Features in the data base and the default feature tree is created it will fetch all of those. This throws an exception when adding them to the tree in IHasTermType.checkTermTypes()

Currently, this makes the factual data view unusable if there are Characters in the DB.

Caused by: java.lang.IllegalArgumentException: Term types must match
    at eu.etaxonomy.cdm.model.term.IHasTermType.checkTermTypes(IHasTermType.java:30)
    at eu.etaxonomy.cdm.model.term.FeatureNode.checkTermType(FeatureNode.java:574)
    at eu.etaxonomy.cdm.model.term.FeatureNode.addChild(FeatureNode.java:320)
    at eu.etaxonomy.cdm.model.term.FeatureNode.addChild(FeatureNode.java:301)
    at eu.etaxonomy.cdm.model.term.FeatureTree.NewInstance_aroundBody8(FeatureTree.java:175)
    at eu.etaxonomy.cdm.model.term.FeatureTree.NewInstance(FeatureTree.java:1)
    at eu.etaxonomy.taxeditor.editor.definedterm.input.TermEditorInput.getDefaultFeatureTree(TermEditorInput.java:101)
    at eu.etaxonomy.taxeditor.editor.view.descriptive.e4.handler.DynamicFeatureMenuE4.getFeatureTree(DynamicFeatureMenuE4.java:140)
    at eu.etaxonomy.taxeditor.editor.view.descriptive.e4.handler.DynamicFeatureMenuE4.aboutToShow(DynamicFeatureMenuE4.java:64)

Associated revisions

Revision 1ebbb842 (diff)
Added by Patrick Plitzner 3 months ago

ref #8190 Allow sub term types for FeatureNode relations and trees

Revision b7d3a480 (diff)
Added by Patrick Plitzner 3 months ago

ref #8190 Fix potential NPE

Revision 341fa6e3 (diff)
Added by Patrick Plitzner 3 months ago

ref #8190 Fix termType in FeatureNode creation

Revision 2588dae5 (diff)
Added by Patrick Plitzner 2 months ago

ref #8190 Allow sub term types for FeatureNode relations and trees

Revision 429da4fe (diff)
Added by Patrick Plitzner 2 months ago

ref #8190 Fix potential NPE

Revision a310bd6a (diff)
Added by Patrick Plitzner 2 months ago

ref #8190 Fix termType in FeatureNode creation

History

#1 Updated by Patrick Plitzner 3 months ago

  • Status changed from New to In Progress
  • Assignee changed from Andreas Müller to Patrick Plitzner

#2 Updated by Patrick Plitzner 3 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 0 to 50

I extended the type check to also allow subtypes in the term tree

#3 Updated by Patrick Plitzner 3 months ago

  • Description updated (diff)

#5 Updated by Andreas Müller 2 months ago

  • Assignee changed from Andreas Müller to Katja Luther

please do first review on nightly

#6 Updated by Katja Luther 2 months ago

  • Assignee changed from Katja Luther to Andreas Müller

Seems to work.
I added some characters to rem_conf_am and got no exception when opening/working with factual data view.

#7 Updated by Andreas Müller 2 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • % Done changed from 50 to 100

For me it also seems to work

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)