Project

General

Profile

Actions

bug #8190

closed

Default FeatureTree throws exception

Added by Patrick Plitzner over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
New
Assignee:
Patrick Plitzner
Category:
cdm
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
critical
Found in Version:

Description

When there are Characters and Features in the data base and the default feature tree is created it will fetch all of those. This throws an exception when adding them to the tree in IHasTermType.checkTermTypes()

Currently, this makes the factual data view unusable if there are Characters in the DB.

Caused by: java.lang.IllegalArgumentException: Term types must match
    at eu.etaxonomy.cdm.model.term.IHasTermType.checkTermTypes(IHasTermType.java:30)
    at eu.etaxonomy.cdm.model.term.FeatureNode.checkTermType(FeatureNode.java:574)
    at eu.etaxonomy.cdm.model.term.FeatureNode.addChild(FeatureNode.java:320)
    at eu.etaxonomy.cdm.model.term.FeatureNode.addChild(FeatureNode.java:301)
    at eu.etaxonomy.cdm.model.term.FeatureTree.NewInstance_aroundBody8(FeatureTree.java:175)
    at eu.etaxonomy.cdm.model.term.FeatureTree.NewInstance(FeatureTree.java:1)
    at eu.etaxonomy.taxeditor.editor.definedterm.input.TermEditorInput.getDefaultFeatureTree(TermEditorInput.java:101)
    at eu.etaxonomy.taxeditor.editor.view.descriptive.e4.handler.DynamicFeatureMenuE4.getFeatureTree(DynamicFeatureMenuE4.java:140)
    at eu.etaxonomy.taxeditor.editor.view.descriptive.e4.handler.DynamicFeatureMenuE4.aboutToShow(DynamicFeatureMenuE4.java:64)
Actions #1

Updated by Patrick Plitzner over 5 years ago

  • Status changed from New to In Progress
  • Assignee changed from Andreas Müller to Patrick Plitzner
Actions #2

Updated by Patrick Plitzner over 5 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 0 to 50

I extended the type check to also allow subtypes in the term tree

Actions #3

Updated by Patrick Plitzner over 5 years ago

  • Description updated (diff)
Actions #5

Updated by Andreas Müller over 5 years ago

  • Assignee changed from Andreas Müller to Katja Luther

please do first review on nightly

Actions #6

Updated by Katja Luther over 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller

Seems to work.
I added some characters to rem_conf_am and got no exception when opening/working with factual data view.

Actions #7

Updated by Andreas Müller over 5 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • % Done changed from 50 to 100

For me it also seems to work

Actions

Also available in: Atom PDF