Project

General

Profile

Actions

bug #6432

closed

Apply CSS only to non-admin pages

Added by Saskia Gennrich almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
02/24/2017
Due date:
% Done:

0%

Estimated time:
Severity:
blocker
Found in Version:

Description

Some of the rules in cdm_dataportal.css are too wide. Especially HTML Description list tags (dl, dd, dt) mess with my admin theme (adminimal).

Proposed solution: Only add css to non-admin pages

I also use this issue to figure out how you would like me to submit changes.


Files

6432_css_only_admin.patch (1.4 KB) 6432_css_only_admin.patch Saskia Gennrich, 02/24/2017 03:52 PM
issue-6432-regression.png (134 KB) issue-6432-regression.png Andreas Kohlbecker, 03/02/2017 10:06 AM
Actions #1

Updated by Saskia Gennrich almost 5 years ago

So here's a patchfile you can apply to your local repository with

git apply -v 6432_css_only_admin.patch

Actions #3

Updated by Saskia Gennrich almost 5 years ago

  • Status changed from New to Feedback
Actions #4

Updated by Andreas Müller almost 5 years ago

  • Tags set to faunaEuropaea
Actions #5

Updated by Andreas Kohlbecker almost 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Saskia Gennrich to Andreas Kohlbecker
  • Target version changed from Unassigned CDM tickets to Release 4.6

The fix for this issue is now in the develop branch, so that it will be deployed to the test server. I now can test and review this commit there.

Actions #6

Updated by Andreas Kohlbecker almost 5 years ago

Hi Saskia,

your commit causes a problem in the admin settings area of portals using an other theme that the "CDM DataPortal base theme ". For example if you switch to the cichorieae theme the CDM-Debug-block table will overlay all settings pages:

Andreas

Actions #7

Updated by Saskia Gennrich almost 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Saskia Gennrich to Andreas Kohlbecker

Ich konnte das leider nicht reproduzieren.
Habe das CSS ein bisschen refactored. CSS für die Settings Tabelle wird auf allen admin pages geladen und das CSS für den debug block immer mit dem Block zusammen.

Actions #8

Updated by Andreas Kohlbecker almost 5 years ago

  • Assignee changed from Andreas Kohlbecker to Saskia Gennrich

Hast du das auch mit dem 'garland_cichorieae'-Theme getestet?

Actions #9

Updated by Saskia Gennrich almost 5 years ago

  • Assignee changed from Saskia Gennrich to Andreas Kohlbecker

Ja, aber das Problem ist ja nicht direkt mit dem Theme, sondern wo benötigt das cdm_dataportal welche CSS regeln.
Zum Beispiel sollten auf /admin/config/cdm_dataportal/settings/layout/taxon die hierarchy levels unter Distribution hierarchy style fäschlicherweise nicht mehr floaten.

Das sollte jetzt damit gelöst sein.

Actions #10

Updated by Andreas Kohlbecker almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF