Project

General

Profile

bug #6432

Apply CSS only to non-admin pages

Added by Saskia Gennrich almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
02/24/2017
Due date:
% Done:

0%

Severity:
blocker
Found in Version:

Description

Some of the rules in cdm_dataportal.css are too wide. Especially HTML Description list tags (dl, dd, dt) mess with my admin theme (adminimal).

Proposed solution: Only add css to non-admin pages

I also use this issue to figure out how you would like me to submit changes.

6432_css_only_admin.patch View (1.4 KB) Saskia Gennrich, 02/24/2017 03:52 PM

issue-6432-regression.png View (134 KB) Andreas Kohlbecker, 03/02/2017 10:06 AM

Associated revisions

Revision 8fc089e1 (diff)
Added by Saskia Gennrich almost 2 years ago

ref #6432 apply css only to non-admin pages

Revision 63f6d312 (diff)
Added by Saskia Gennrich almost 2 years ago

ref #6432 more fine tuned inclusion of css.

CSS rules for admin/config/cdm_dataportal/settings are included
on all settings rule.
CSS rules for the debug block are attached to the debug block.

History

#1 Updated by Saskia Gennrich almost 2 years ago

So here's a patchfile you can apply to your local repository with

git apply -v 6432_css_only_admin.patch

#3 Updated by Saskia Gennrich almost 2 years ago

  • Status changed from New to Feedback

#4 Updated by Andreas Müller almost 2 years ago

  • Tags set to faunaEuropaea

#5 Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Saskia Gennrich to Andreas Kohlbecker
  • Target version changed from Unassigned CDM tickets to Release 4.6

The fix for this issue is now in the develop branch, so that it will be deployed to the test server. I now can test and review this commit there.

#6 Updated by Andreas Kohlbecker almost 2 years ago

  • File issue-6432-regression.png View added
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Kohlbecker to Saskia Gennrich
  • Priority changed from New to Highest
  • Severity changed from minor to blocker

Hi Saskia,

your commit causes a problem in the admin settings area of portals using an other theme that the "CDM DataPortal base theme ". For example if you switch to the cichorieae theme the CDM-Debug-block table will overlay all settings pages:

Andreas

#7 Updated by Saskia Gennrich almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Saskia Gennrich to Andreas Kohlbecker

Ich konnte das leider nicht reproduzieren.
Habe das CSS ein bisschen refactored. CSS für die Settings Tabelle wird auf allen admin pages geladen und das CSS für den debug block immer mit dem Block zusammen.

#8 Updated by Andreas Kohlbecker almost 2 years ago

  • Assignee changed from Andreas Kohlbecker to Saskia Gennrich

Hast du das auch mit dem 'garland_cichorieae'-Theme getestet?

#9 Updated by Saskia Gennrich almost 2 years ago

  • Assignee changed from Saskia Gennrich to Andreas Kohlbecker

Ja, aber das Problem ist ja nicht direkt mit dem Theme, sondern wo benötigt das cdm_dataportal welche CSS regeln.
Zum Beispiel sollten auf /admin/config/cdm_dataportal/settings/layout/taxon die hierarchy levels unter Distribution hierarchy style fäschlicherweise nicht mehr floaten.

Das sollte jetzt damit gelöst sein.

#10 Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)