bug #6432
closedApply CSS only to non-admin pages
0%
Description
Some of the rules in cdm_dataportal.css are too wide. Especially HTML Description list tags (dl, dd, dt) mess with my admin theme (adminimal).
Proposed solution: Only add css to non-admin pages
I also use this issue to figure out how you would like me to submit changes.
Files
Updated by Saskia Gennrich about 7 years ago
So here's a patchfile you can apply to your local repository with
git apply -v 6432_css_only_admin.patch
Updated by Saskia Gennrich about 7 years ago
I also pushed my branch https://dev.e-taxonomy.eu/gitweb/cdm-dataportal.git/shortlog/refs/heads/6432_css_only_admin
Updated by Saskia Gennrich about 7 years ago
- Status changed from New to Feedback
Updated by Andreas Kohlbecker about 7 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Saskia Gennrich to Andreas Kohlbecker
- Target version changed from Unassigned CDM tickets to Release 4.6
The fix for this issue is now in the develop branch, so that it will be deployed to the test server. I now can test and review this commit there.
Updated by Andreas Kohlbecker about 7 years ago
- File issue-6432-regression.png issue-6432-regression.png added
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Kohlbecker to Saskia Gennrich
- Priority changed from New to Highest
- Severity changed from minor to blocker
Hi Saskia,
your commit causes a problem in the admin settings area of portals using an other theme that the "CDM DataPortal base theme ". For example if you switch to the cichorieae theme the CDM-Debug-block table will overlay all settings pages:
Andreas
Updated by Saskia Gennrich about 7 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Saskia Gennrich to Andreas Kohlbecker
Ich konnte das leider nicht reproduzieren.
Habe das CSS ein bisschen refactored. CSS für die Settings Tabelle wird auf allen admin pages geladen und das CSS für den debug block immer mit dem Block zusammen.
Updated by Andreas Kohlbecker about 7 years ago
- Assignee changed from Andreas Kohlbecker to Saskia Gennrich
Hast du das auch mit dem 'garland_cichorieae'-Theme getestet?
Updated by Saskia Gennrich about 7 years ago
- Assignee changed from Saskia Gennrich to Andreas Kohlbecker
Ja, aber das Problem ist ja nicht direkt mit dem Theme, sondern wo benötigt das cdm_dataportal welche CSS regeln.
Zum Beispiel sollten auf /admin/config/cdm_dataportal/settings/layout/taxon die hierarchy levels unter Distribution hierarchy style fäschlicherweise nicht mehr floaten.
Das sollte jetzt damit gelöst sein.
Updated by Andreas Kohlbecker about 7 years ago
- Status changed from Resolved to Closed