bug #6432
closed
Apply CSS only to non-admin pages
Added by Saskia Gennrich about 7 years ago.
Updated about 7 years ago.
Description
Some of the rules in cdm_dataportal.css are too wide. Especially HTML Description list tags (dl, dd, dt) mess with my admin theme (adminimal).
Proposed solution: Only add css to non-admin pages
I also use this issue to figure out how you would like me to submit changes.
Files
So here's a patchfile you can apply to your local repository with
git apply -v 6432_css_only_admin.patch
- Status changed from New to Feedback
- Tags set to faunaEuropaea
- Status changed from Feedback to Resolved
- Assignee changed from Saskia Gennrich to Andreas Kohlbecker
- Target version changed from Unassigned CDM tickets to Release 4.6
The fix for this issue is now in the develop branch, so that it will be deployed to the test server. I now can test and review this commit there.
Hi Saskia,
your commit causes a problem in the admin settings area of portals using an other theme that the "CDM DataPortal base theme ". For example if you switch to the cichorieae theme the CDM-Debug-block table will overlay all settings pages:
Andreas
- Status changed from Feedback to Resolved
- Assignee changed from Saskia Gennrich to Andreas Kohlbecker
Ich konnte das leider nicht reproduzieren.
Habe das CSS ein bisschen refactored. CSS für die Settings Tabelle wird auf allen admin pages geladen und das CSS für den debug block immer mit dem Block zusammen.
- Assignee changed from Andreas Kohlbecker to Saskia Gennrich
Hast du das auch mit dem 'garland_cichorieae'-Theme getestet?
- Assignee changed from Saskia Gennrich to Andreas Kohlbecker
Ja, aber das Problem ist ja nicht direkt mit dem Theme, sondern wo benötigt das cdm_dataportal welche CSS regeln.
Zum Beispiel sollten auf /admin/config/cdm_dataportal/settings/layout/taxon die hierarchy levels unter Distribution hierarchy style fäschlicherweise nicht mehr floaten.
Das sollte jetzt damit gelöst sein.
- Status changed from Resolved to Closed
Also available in: Atom
PDF