Project

General

Profile

Actions

feature request #6315

closed

Implement setSecundumForSubtree in TaxEditor

Added by Andreas Müller almost 6 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
5:00 h
Severity:
normal

Description

The functionality has been implemented in #3465

It needs to be called via taxon navigator right click menu. A configurator is required.


Files

picture977-1.png (10.2 KB) picture977-1.png Andreas Müller, 09/22/2017 06:12 PM

Related issues

Related to EDIT - bug #6359: Remaining issues secundum for subtreesClosedAndreas Müller

Actions
Related to EDIT - feature request #4155: Implement handler (IHandler) to trigger recursive setting of the publish bit on a taxon subtreeClosedKatja Luther

Actions
Follows EDIT - feature request #3465: Function to copy secundum reference of a given taxon node to all it's childrenClosedAndreas Müller

Actions
Copied to EDIT - bug #9390: Remaining issues for set secundum dialogIn ProgressKatja Luther

Actions
Actions #1

Updated by Andreas Müller almost 6 years ago

  • Due date set to 01/16/2014
  • Start date changed from 01/07/2017 to 01/16/2014
  • Follows feature request #3465: Function to copy secundum reference of a given taxon node to all it's children added
Actions #2

Updated by Andreas Müller almost 6 years ago

  • Due date changed from 01/12/2017 to 01/16/2017
Actions #3

Updated by Andreas Müller almost 6 years ago

  • Target version changed from Release 4.5 to Release 4.6
Actions #4

Updated by Andreas Müller almost 6 years ago

  • Related to bug #6359: Remaining issues secundum for subtrees added
Actions #5

Updated by Katja Luther almost 6 years ago

  • Due date changed from 01/16/2017 to 02/10/2017
  • Start date changed from 01/12/2017 to 02/09/2017
  • Estimated time set to 5:00 h
Actions #6

Updated by Katja Luther almost 6 years ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

implemented the menu item for the navigator. At the moment it is possible to remove the sec reference of the subtree if no reference is chosen.

Please review.

Actions #7

Updated by Andreas Müller almost 6 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Some layout and labeling issues:

  • The New secundum reference label is not translated
  • "anwenden auf akzeptierten Taxa" I would change to "akzeptierte Taxa" (otherwise change Synonyme to Synonymen)
  • Enable "bestehende Sec Ref bei akzeptierten Taxa überschreiben" only if "anwenden auf akzeptierte Taxa" is checked, also move it up directly below "anwenden auf akz..." and do some indentation
  • Same applies to "bestehende Sec Ref bei Synonymen überschreiben"
  • "auch geteilte Taxa mit einbeziehen": => "... mehrfach verwendete ..."
  • The background of the new reference should be white, not grey.
  • We should add a note saying that an empty reference will delete the secundum for all taxa/synonyms
Actions #8

Updated by Andreas Müller almost 6 years ago

  • If neither accepted taxa nor synonyms are checkedthe OK button should be disabled
  • "mehrfach verwendete" taxa should be enabled only if accepted taxa are checked, also move up below akzeptierte Taxa überschreiben and do indentation
Actions #9

Updated by Andreas Müller almost 6 years ago

Trying to create a new Reference in the reference selection box throws an NPE when clicking on ok:

login : admin
editor version : 4.6.0.201702161652
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 4.1.0.0.201607300000
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.ui.dialog.selection.AbstractFilteredCdmResourceSelectionDialog$3.widgetSelected(AbstractFilteredCdmResourceSelectionDialog.java:502)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:240)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)
    at org.eclipse.swt.widgets.Widget.sendSelectionEvent(Widget.java:1094)
    at org.eclipse.swt.widgets.Link.wmNotifyChild(Link.java:1071)
    at org.eclipse.swt.widgets.Control.wmNotify(Control.java:5534)
    at org.eclipse.swt.widgets.Composite.wmNotify(Composite.java:1896)
    at org.eclipse.swt.widgets.Control.WM_NOTIFY(Control.java:5086)
    at org.eclipse.swt.widgets.Control.windowProc(Control.java:4584)
    at org.eclipse.swt.widgets.Display.windowProc(Display.java:4985)
    at org.eclipse.swt.internal.win32.OS.CallWindowProcW(Native Method)
    at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:2425)
    at org.eclipse.swt.widgets.Link.callWindowProc(Link.java:172)
    at org.eclipse.swt.widgets.Widget.wmLButtonUp(Widget.java:2057)
    at org.eclipse.swt.widgets.Control.WM_LBUTTONUP(Control.java:4912)
    at org.eclipse.swt.widgets.Link.WM_LBUTTONUP(Link.java:909)
    at org.eclipse.swt.widgets.Control.windowProc(Control.java:4565)
    at org.eclipse.swt.widgets.Display.windowProc(Display.java:4985)
    at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
    at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2531)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3752)
    at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
    at org.eclipse.jface.window.Window.open(Window.java:801)
    at eu.etaxonomy.taxeditor.ui.dialog.selection.AbstractFilteredCdmResourceSelectionDialog.getSelectionFromDialog(AbstractFilteredCdmResourceSelectionDialog.java:146)
    at eu.etaxonomy.taxeditor.ui.dialog.selection.ReferenceSelectionDialog.select(ReferenceSelectionDialog.java:61)
    at eu.etaxonomy.taxeditor.ui.dialog.selection.SelectionDialogFactory.getSelectionFromDialog(SelectionDialogFactory.java:87)
    at eu.etaxonomy.taxeditor.ui.dialog.selection.SelectionDialogFactory.getSelectionFromDialog(SelectionDialogFactory.java:60)
    at eu.etaxonomy.taxeditor.ui.dialog.configurator.SetSecundumForSubtreeConfigurationDialog.handleEvent(SetSecundumForSubtreeConfigurationDialog.java:155)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
    at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
    at org.eclipse.jface.window.Window.open(Window.java:801)
    at org.eclipse.jface.dialogs.MessageDialog.open(MessageDialog.java:334)
    at eu.etaxonomy.taxeditor.ui.dialog.configurator.SetSecundumForSubtreeConfigurationDialog.openConfirmWithConfigurator(SetSecundumForSubtreeConfigurationDialog.java:112)
    at eu.etaxonomy.taxeditor.navigation.navigator.handler.SetSecReferenceForSubtreeHandler.allowOperations(SetSecReferenceForSubtreeHandler.java:88)
    at eu.etaxonomy.taxeditor.operation.RemotingCdmHandler.execute(RemotingCdmHandler.java:39)
    at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
    at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
    at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
    at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
    at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
    at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
    at org.eclipse.ui.menus.CommandContributionItem.handleWidgetSelection(CommandContributionItem.java:829)
    at org.eclipse.ui.menus.CommandContributionItem.access$19(CommandContributionItem.java:815)
    at org.eclipse.ui.menus.CommandContributionItem$5.handleEvent(CommandContributionItem.java:805)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
    at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701)
    at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665)
    at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499)
    at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
    at eu.etaxonomy.taxeditor.Application.start(Application.java:24)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
Actions #10

Updated by Andreas Müller almost 6 years ago

The progressbar does not seem to work. Is this because it is not yet correctly implemented in the underlying cdmlib method?

Actions #11

Updated by Andreas Müller almost 6 years ago

  • % Done changed from 0 to 70
Actions #12

Updated by Andreas Müller almost 6 years ago

Generally the functionality seems to work well.

Actions #13

Updated by Katja Luther almost 6 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 70 to 50
Actions #14

Updated by Katja Luther over 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller

please review

Actions #15

Updated by Andreas Müller over 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Some Remaining issues:

  • The functionality is still missing for whole classifications
  • Dialog window has no title, could be something like "Set secundum for subtree" + translation
  • The white area on the top currently holds information "if no reference is selected ...". This is a note that should be added below the reference selection field. In the white box we should have a description what is generally done here
  • Label "neue Secundum Referenz" should start with capital letter (please also check English version)
  • indentation is still missing for "bestehende Secundum ..." (2x)
  • also "bestehende Secundum ..." should be disabled not invisible if "anwenden auf ..." is unchecked (at least this is more what I would expect)
  • background of the new reference textbox is still grey but should be white (if possible) this is grey because the textfield is not editable.
  • "mehrfach verwendete" taxa should be moved up below "bestehende Secundum Referenzen bei akzeptierten Taxa überschreiben" AND have some indentation
Actions #16

Updated by Katja Luther over 5 years ago

  • Status changed from Feedback to Resolved
Actions #17

Updated by Andreas Müller over 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #18

Updated by Andreas Müller about 5 years ago

If the dialog box width is reduced (almost to minimum) the last 2 checkbox lines disappear. Increasing width does not make them reappear. See attachement.

If this is diffcult to fix wie should maybe work with larger minimum width. Also the minimum hight should always allow to show all options I think (but not sure).

Actions #19

Updated by Andreas Müller about 5 years ago

  • Due date deleted (02/10/2017)
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

There is also a lot of space between label "New secundum reference" and the text box for the secundum. Can we minimize this space or maybe put the textbox and the selection buttons in the next line to avoid problems with resizing.

Actions #20

Updated by Andreas Müller about 5 years ago

  • Related to feature request #4155: Implement handler (IHandler) to trigger recursive setting of the publish bit on a taxon subtree added
Actions #21

Updated by Andreas Müller almost 2 years ago

  • Copied to bug #9390: Remaining issues for set secundum dialog added
Actions #22

Updated by Andreas Müller almost 2 years ago

Andreas Müller wrote:

There is also a lot of space between label "New secundum reference" and the text box for the secundum. Can we minimize this space or maybe put the textbox and the selection buttons in the next line to avoid problems with resizing.

This seems to befixed. But there is another remaining issue => put to follow up ticket #9390

Actions #23

Updated by Andreas Müller almost 2 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 50 to 100
Actions

Also available in: Atom PDF