Project

General

Profile

bug #6359

Remaining issues secundum for subtrees

Added by Andreas Müller almost 5 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
01/20/2017
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

Open issue(s):

  • fill UpdateResult correctly => fixed, but preliminary changed due to #9627
  • add progress monitor
  • handle large subtrees in partitions
  • handle MAN and PPSyns (#9601)
  • handle errors
  • make cancelable

Also check these issues for setPublishForSubtree

picture038-1.png View (30 KB) Katja Luther, 05/17/2021 02:59 PM

picture624-1.png View (18.6 KB) Katja Luther, 05/17/2021 03:26 PM


Related issues

Related to Edit - feature request #6315: Implement setSecundumForSubtree in TaxEditor Closed 02/09/2017
Related to Edit - bug #9601: Set secundum for subTree does not work for misapplied names Closed 05/03/2021
Related to Edit - feature request #3740: Allow recursively setting the publish bit for TaxonBase Closed 09/27/2013
Related to Edit - bug #9390: Remaining issues for set secundum dialog In Progress 01/18/2021
Related to Edit - feature request #9622: Improve remoting progress monitor handling In Progress 05/13/2021
Related to Edit - bug #7577: Set Publish Flag for Subtree Dialog - Further Problems with Progressmonitor New 07/23/2018
Copied from Edit - feature request #3465: Function to copy secundum reference of a given taxon node to all it's children Closed 01/15/2014 01/11/2017
Copied to Edit - bug #9627: Handle updated objects correctly in monitored operations in taxeditor New 05/19/2021
Copied to Edit - task #9628: Improve update result handling for monitored operations New 05/19/2021

Associated revisions

Revision 06bf3273 (diff)
Added by Andreas Müller almost 5 years ago

fix #3465 Progressmonitor API and better UpdateResult handling for setSecundumForSubtree

Revision 1cc6cd7b (diff)
Added by Andreas Müller over 3 years ago

ref #6359, ref #3740 (setSubtree) add progress monitor progress computation, first version of partitioning

Revision f303cdad (diff)
Added by Andreas Müller over 3 years ago

ref #6359, ref #3740 (setSubtree) some further improvements, mostly for publish

Revision 40113a9f (diff)
Added by Andreas Müller 6 months ago

ref #6359 error handling for setSecundumForSubtree

Revision 3b1da35f (diff)
Added by Andreas Müller 6 months ago

ref #6359, ref #3740 error handling for setPublishForSubtree

Revision 3cba463f (diff)
Added by Andreas Müller 6 months ago

ref #9598 some parameter renaming and improve updated objects behavior

Revision cfa25f63 (diff)
Added by Andreas Müller 6 months ago

ref #6359 improve updated objects behavior

Revision e067bb50 (diff)
Added by Andreas Müller 6 months ago

ref #6359 improve partition handling

Revision 0bb7d42f (diff)
Added by Andreas Müller 6 months ago

ref #6359 fix update issue

Revision ec8277bd (diff)
Added by Andreas Müller 6 months ago

ref #6359 use subprogressmonitor

Revision 9336738a (diff)
Added by Andreas Müller 6 months ago

ref #6359 add session.clear()

Revision f752535b (diff)
Added by Andreas Müller 6 months ago

ref #6359 make setPublishForSubtree and setSecundumForSubtree cancelabel

Revision 06fb5f40 (diff)
Added by Andreas Müller 6 months ago

ref #6359 adapt setPublishForSubtree to improved progress monitoring

Revision af7821ec (diff)
Added by Andreas Müller 6 months ago

ref #6359 finetuning for updatedObjects in setSecundumForSubtree (distinguish taxon and originalsource)

Revision 220ce244 (diff)
Added by Andreas Müller 6 months ago

ref #6359 finetuning for updatedObjects in ITaxonNodeDao

Revision 63fb5a6d (diff)
Added by Andreas Müller 6 months ago

ref #6359 improve reporting for longrunning tasks with UpdateResult in TaxEditor

Revision ea3bd701 (diff)
Added by Andreas Müller 6 months ago

ref #6359 fix NPE when removing sec

Revision c9ccb1e7 (diff)
Added by Andreas Müller 6 months ago

ref #6359 improve progress monitoring for setSecundumForSubtree

Revision 1b643550 (diff)
Added by Andreas Müller 5 months ago

ref #9622 , ref #6359 handle progress monitor without setting taskName multiple times and some further fixes

Revision 809fcc17 (diff)
Added by Andreas Müller 5 months ago

ref #9622, ref #6359, #8871 adapt progress monitoring for description aggregation

Revision 0f6b5dda (diff)
Added by Andreas Müller 5 months ago

ref #6359, ref #9627 fix tests for setSecundumForSubtree workaround

History

#1 Updated by Andreas Müller almost 5 years ago

  • Target version changed from Unassigned CDM tickets to Release 4.6

#2 Updated by Andreas Müller almost 5 years ago

  • Copied from feature request #3465: Function to copy secundum reference of a given taxon node to all it's children added

#3 Updated by Andreas Müller almost 5 years ago

  • Related to bug #6215: NPE when opening preferences with no DB connection added

#4 Updated by Andreas Müller almost 5 years ago

  • Related to deleted (bug #6215: NPE when opening preferences with no DB connection)

#5 Updated by Andreas Müller almost 5 years ago

#6 Updated by Andreas Müller over 4 years ago

  • Description updated (diff)
  • Target version changed from Release 4.6 to Release 4.9

#7 Updated by Andreas Müller over 4 years ago

  • Target version changed from Release 4.9 to Release 4.10

#8 Updated by Andreas Müller about 4 years ago

  • Target version changed from Release 4.10 to Release 4.12

#9 Updated by Andreas Müller almost 4 years ago

  • Target version changed from Release 4.12 to Release 4.13

#10 Updated by Andreas Müller over 3 years ago

  • Target version changed from Release 4.13 to Release 4.14

#11 Updated by Andreas Müller over 3 years ago

  • Target version changed from Release 4.14 to Release 5.0

#12 Updated by Andreas Müller over 3 years ago

  • Target version changed from Release 5.0 to Release 5.1

#13 Updated by Andreas Müller over 3 years ago

  • Target version changed from Release 5.1 to Release 5.2

#14 Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 5.2 to Release 5.3

#15 Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 5.3 to Release 5.4

#16 Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 5.4 to Release 5.5

#17 Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.5 to Release 5.6

#18 Updated by Andreas Müller over 2 years ago

  • Priority changed from New to Highest
  • Target version changed from Release 5.6 to Reviewed Next Major Release

#19 Updated by Andreas Müller 6 months ago

  • Description updated (diff)

#20 Updated by Andreas Müller 6 months ago

  • Related to bug #9601: Set secundum for subTree does not work for misapplied names added

#21 Updated by Andreas Müller 6 months ago

  • Description updated (diff)

#22 Updated by Andreas Müller 6 months ago

#23 Updated by Andreas Müller 6 months ago

  • Description updated (diff)

#24 Updated by Andreas Müller 6 months ago

  • Description updated (diff)
  • % Done changed from 0 to 40

#25 Updated by Andreas Müller 6 months ago

  • Description updated (diff)

#26 Updated by Andreas Müller 6 months ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Target version changed from Reviewed Next Major Release to Release 5.25

#27 Updated by Andreas Müller 6 months ago

  • Description updated (diff)

#28 Updated by Andreas Müller 6 months ago

  • Status changed from In Progress to Resolved

#29 Updated by Andreas Müller 6 months ago

  • Related to bug #9390: Remaining issues for set secundum dialog added

#30 Updated by Andreas Müller 6 months ago

Katja, kannst du das Ticket grundsätzlich schon mal reviewen? Wir müssen noch eine Lösung finden für die Auswertung der updated objects. Kurzfristig müssen wir vermutlich die updated taxa wieder hinzufügen, auch wenn das nicht wirklich korrekt ist bis wir eine Lösung haben, die z.B. aus einer updated NamedSource berechnet, welche Editoren davon betroffen sind. Auch nicht so schön ist, dass im Result-Report der Begriff NamedSource für den User natürlich weniger Versändlich ist als z.B. Taxon Relation. D.h. wir müssen dringend klären, wozu die UpdatedObjects überhaupt gebraucht werden. Fürs CacheUpdating werden exakte Angaben benötigt, während für den Report eher grobe, Kontext bezogene Angaben reichen.

#31 Updated by Andreas Müller 6 months ago

  • Assignee changed from Andreas Müller to Katja Luther

#32 Updated by Katja Luther 6 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Katja Luther to Andreas Müller

review:

  • add progress monitor -> the submonitors not shown in the status of the editor -> maybe a new ticket?
  • handle large subtrees in partitions -> seems to work
  • handle MAN and PPSyns (#9601) this works as expected
  • handle errors -> they are handled in result, so I think this is correct.
  • make cancelable -> maybe we should show how many items already changed, especially because the status of the submonitors are not shown.

I think everything works, but we have to have a look at the progress monitor again.

#33 Updated by Andreas Müller 6 months ago

  • Assignee changed from Andreas Müller to Katja Luther

Katja Luther wrote:

review:

  • add progress monitor -> the submonitors not shown in the status of the editor -> maybe a new ticket?
  • handle large subtrees in partitions -> seems to work
  • handle MAN and PPSyns (#9601) this works as expected
  • handle errors -> they are handled in result, so I think this is correct.
  • make cancelable -> maybe we should show how many items already changed, especially because the status of the submonitors are not shown.

I think everything works, but we have to have a look at the progress monitor again.

What do you mean with "the submonitors are not shown"?
Do you mean percentage or subtask labels? For me the percentage appears almost always. I tested with rem_conf_am/Classification(Import)/Arenaria which has ~1400 taxa.

The change in code that makes the percentage visible (usually) was to create a total count of 100 already before the count methods were called and then use a subprogressmonitor to handle the exact counts. This makes the total count available much faster.
But I agree that this sometimes (very seldom for me) does not work if there is some delay on serverside. The reason for this IMO is the implementation in ProgressMonitorClientManager.pollMonitor() which after 10x polling assumes that there is no total count. But this is wrong behavior which I thing can be fixed by using submonitors instead. I will create a ticket for this.

Does ths percentage never appear for you? Did you test with a local server or on test server?

#34 Updated by Andreas Müller 6 months ago

Katja Luther wrote:

  • make cancelable -> maybe we should show how many items already changed, especially because the status of the submonitors are not shown.

The number of changed items is also shown in the report (even if progress monitor does not work). So I don't think it is worth implementing. By the way, it is also not so easy to implement because at least currently subtasks labels are not yet shown in the progress monitor so it is not possible to show a label that reports the current number.
Better lets try to spend time in the improved progress monitoring for long running tasks as explained above.

#35 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.23

#36 Updated by Katja Luther 5 months ago

I think the usage of submonitors needs to be adapted, I already did this for cache update, there the submonitor labels are shown correctly:

#37 Updated by Katja Luther 5 months ago

I tried to adapt the progress monitor handling like for the cache update and the output in editor looks like this:

Should I check it in?

#38 Updated by Andreas Müller 5 months ago

Katja Luther wrote:

I tried to adapt the progress monitor handling like for the cache update and the output in editor looks like this:

Should I check it in?

upps, I also worked on this already put did not yet push. Can you send the diff to see if we did similar things?

#39 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.23

#40 Updated by Katja Luther 5 months ago

  • Assignee changed from Katja Luther to Andreas Müller

So the progress monitor handling is fixed, we can close this ticket. A new ticket for user friendly result report and improved update result should be created.

#41 Updated by Andreas Müller 5 months ago

#42 Updated by Andreas Müller 5 months ago

  • Related to bug #7577: Set Publish Flag for Subtree Dialog - Further Problems with Progressmonitor added

#43 Updated by Andreas Müller 5 months ago

  • Description updated (diff)

#44 Updated by Andreas Müller 5 months ago

  • % Done changed from 40 to 80

Created a follow-up ticket #9627 for correct update result handling on editor side

#45 Updated by Andreas Müller 5 months ago

  • Copied to bug #9627: Handle updated objects correctly in monitored operations in taxeditor added

#46 Updated by Andreas Müller 5 months ago

  • Copied to task #9628: Improve update result handling for monitored operations added

#47 Updated by Andreas Müller 5 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

Also created a new ticket for better update result handling: #9628

So we can close this ticket now.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)