EDIT

review:

• add progress monitor -> the submonitors not shown in the status of the editor -> maybe a new ticket?
• handle large subtrees in partitions -> seems to work
• handle MAN and PPSyns (#9601) this works as expected
• handle errors -> they are handled in result, so I think this is correct.
• make cancelable -> maybe we should show how many items already changed, especially because the status of the submonitors are not shown.

I think everything works, but we have to have a look at the progress monitor again.

Katja Luther wrote:

review:

• add progress monitor -> the submonitors not shown in the status of the editor -> maybe a new ticket?
• handle large subtrees in partitions -> seems to work
• handle MAN and PPSyns (#9601) this works as expected
• handle errors -> they are handled in result, so I think this is correct.
• make cancelable -> maybe we should show how many items already changed, especially because the status of the submonitors are not shown.

I think everything works, but we have to have a look at the progress monitor again.

What do you mean with "the submonitors are not shown"?
Do you mean percentage or subtask labels? For me the percentage appears almost always. I tested with rem_conf_am/Classification(Import)/Arenaria which has ~1400 taxa.

The change in code that makes the percentage visible (usually) was to create a total count of 100 already before the count methods were called and then use a subprogressmonitor to handle the exact counts. This makes the total count available much faster.
But I agree that this sometimes (very seldom for me) does not work if there is some delay on serverside. The reason for this IMO is the implementation in ProgressMonitorClientManager.pollMonitor() which after 10x polling assumes that there is no total count. But this is wrong behavior which I thing can be fixed by using submonitors instead. I will create a ticket for this.

Does ths percentage never appear for you? Did you test with a local server or on test server?

I think the usage of submonitors needs to be adapted, I already did this for cache update, there the submonitor labels are shown correctly:

I tried to adapt the progress monitor handling like for the cache update and the output in editor looks like this:

Should I check it in?

So the progress monitor handling is fixed, we can close this ticket. A new ticket for user friendly result report and improved update result should be created.

Created a follow-up ticket #9627 for correct update result handling on editor side

Also created a new ticket for better update result handling: #9628

So we can close this ticket now.