Project

General

Profile

Actions

bug #6359

closed

Remaining issues secundum for subtrees

Added by Andreas Müller almost 6 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

Open issue(s):

  • fill UpdateResult correctly => fixed, but preliminary changed due to #9627
  • add progress monitor
  • handle large subtrees in partitions
  • handle MAN and PPSyns (#9601)
  • handle errors
  • make cancelable

Also check these issues for setPublishForSubtree


Files

picture038-1.png (30 KB) picture038-1.png Katja Luther, 05/17/2021 02:59 PM
picture624-1.png (18.6 KB) picture624-1.png Katja Luther, 05/17/2021 03:26 PM

Related issues

Related to EDIT - feature request #6315: Implement setSecundumForSubtree in TaxEditorClosedKatja Luther

Actions
Related to EDIT - bug #9601: Set secundum for subTree does not work for misapplied namesClosedAndreas Müller

Actions
Related to EDIT - feature request #3740: Allow recursively setting the publish bit for TaxonBaseClosedAndreas Müller

Actions
Related to EDIT - bug #9390: Remaining issues for set secundum dialogIn ProgressKatja Luther

Actions
Related to EDIT - feature request #9622: Improve remoting progress monitor handlingIn ProgressAndreas Müller

Actions
Related to EDIT - bug #7577: Set Publish Flag for Subtree Dialog - Further Problems with ProgressmonitorNewKatja Luther

Actions
Copied from EDIT - feature request #3465: Function to copy secundum reference of a given taxon node to all it's childrenClosedAndreas Müller

Actions
Copied to EDIT - bug #9627: Handle updated objects correctly in monitored operations in taxeditorNewAndreas Müller

Actions
Copied to EDIT - task #9628: Improve update result handling for monitored operationsNewKatja Luther

Actions
Actions #1

Updated by Andreas Müller almost 6 years ago

  • Target version changed from Unassigned CDM tickets to Release 4.6
Actions #2

Updated by Andreas Müller almost 6 years ago

  • Copied from feature request #3465: Function to copy secundum reference of a given taxon node to all it's children added
Actions #3

Updated by Andreas Müller almost 6 years ago

  • Related to bug #6215: NPE when opening preferences with no DB connection added
Actions #4

Updated by Andreas Müller almost 6 years ago

  • Related to deleted (bug #6215: NPE when opening preferences with no DB connection)
Actions #5

Updated by Andreas Müller almost 6 years ago

Actions #6

Updated by Andreas Müller over 5 years ago

  • Description updated (diff)
  • Target version changed from Release 4.6 to Release 4.9
Actions #7

Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 4.9 to Release 4.10
Actions #8

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 4.10 to Release 4.12
Actions #9

Updated by Andreas Müller almost 5 years ago

  • Target version changed from Release 4.12 to Release 4.13
Actions #10

Updated by Andreas Müller almost 5 years ago

  • Target version changed from Release 4.13 to Release 4.14
Actions #11

Updated by Andreas Müller almost 5 years ago

  • Target version changed from Release 4.14 to Release 5.0
Actions #12

Updated by Andreas Müller over 4 years ago

  • Target version changed from Release 5.0 to Release 5.1
Actions #13

Updated by Andreas Müller over 4 years ago

  • Target version changed from Release 5.1 to Release 5.2
Actions #14

Updated by Andreas Müller over 4 years ago

  • Target version changed from Release 5.2 to Release 5.3
Actions #15

Updated by Andreas Müller about 4 years ago

  • Target version changed from Release 5.3 to Release 5.4
Actions #16

Updated by Andreas Müller about 4 years ago

  • Target version changed from Release 5.4 to Release 5.5
Actions #17

Updated by Andreas Müller almost 4 years ago

  • Target version changed from Release 5.5 to Release 5.6
Actions #18

Updated by Andreas Müller almost 4 years ago

  • Priority changed from New to Highest
  • Target version changed from Release 5.6 to Reviewed Next Major Release
Actions #19

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
Actions #20

Updated by Andreas Müller over 1 year ago

  • Related to bug #9601: Set secundum for subTree does not work for misapplied names added
Actions #21

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
Actions #22

Updated by Andreas Müller over 1 year ago

Actions #23

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
Actions #24

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
  • % Done changed from 0 to 40
Actions #25

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
Actions #26

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Target version changed from Reviewed Next Major Release to Release 5.25
Actions #27

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
Actions #28

Updated by Andreas Müller over 1 year ago

  • Status changed from In Progress to Resolved
Actions #29

Updated by Andreas Müller over 1 year ago

  • Related to bug #9390: Remaining issues for set secundum dialog added
Actions #30

Updated by Andreas Müller over 1 year ago

Katja, kannst du das Ticket grundsätzlich schon mal reviewen? Wir müssen noch eine Lösung finden für die Auswertung der updated objects. Kurzfristig müssen wir vermutlich die updated taxa wieder hinzufügen, auch wenn das nicht wirklich korrekt ist bis wir eine Lösung haben, die z.B. aus einer updated NamedSource berechnet, welche Editoren davon betroffen sind. Auch nicht so schön ist, dass im Result-Report der Begriff NamedSource für den User natürlich weniger Versändlich ist als z.B. Taxon Relation. D.h. wir müssen dringend klären, wozu die UpdatedObjects überhaupt gebraucht werden. Fürs CacheUpdating werden exakte Angaben benötigt, während für den Report eher grobe, Kontext bezogene Angaben reichen.

Actions #31

Updated by Andreas Müller over 1 year ago

  • Assignee changed from Andreas Müller to Katja Luther
Actions #32

Updated by Katja Luther over 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Katja Luther to Andreas Müller

review:

  • add progress monitor -> the submonitors not shown in the status of the editor -> maybe a new ticket?
  • handle large subtrees in partitions -> seems to work
  • handle MAN and PPSyns (#9601) this works as expected
  • handle errors -> they are handled in result, so I think this is correct.
  • make cancelable -> maybe we should show how many items already changed, especially because the status of the submonitors are not shown.

I think everything works, but we have to have a look at the progress monitor again.

Actions #33

Updated by Andreas Müller over 1 year ago

  • Assignee changed from Andreas Müller to Katja Luther

Katja Luther wrote:

review:

  • add progress monitor -> the submonitors not shown in the status of the editor -> maybe a new ticket?
  • handle large subtrees in partitions -> seems to work
  • handle MAN and PPSyns (#9601) this works as expected
  • handle errors -> they are handled in result, so I think this is correct.
  • make cancelable -> maybe we should show how many items already changed, especially because the status of the submonitors are not shown.

I think everything works, but we have to have a look at the progress monitor again.

What do you mean with "the submonitors are not shown"?
Do you mean percentage or subtask labels? For me the percentage appears almost always. I tested with rem_conf_am/Classification(Import)/Arenaria which has ~1400 taxa.

The change in code that makes the percentage visible (usually) was to create a total count of 100 already before the count methods were called and then use a subprogressmonitor to handle the exact counts. This makes the total count available much faster.
But I agree that this sometimes (very seldom for me) does not work if there is some delay on serverside. The reason for this IMO is the implementation in ProgressMonitorClientManager.pollMonitor() which after 10x polling assumes that there is no total count. But this is wrong behavior which I thing can be fixed by using submonitors instead. I will create a ticket for this.

Does ths percentage never appear for you? Did you test with a local server or on test server?

Actions #34

Updated by Andreas Müller over 1 year ago

Katja Luther wrote:

  • make cancelable -> maybe we should show how many items already changed, especially because the status of the submonitors are not shown.

The number of changed items is also shown in the report (even if progress monitor does not work). So I don't think it is worth implementing. By the way, it is also not so easy to implement because at least currently subtasks labels are not yet shown in the progress monitor so it is not possible to show a label that reports the current number.
Better lets try to spend time in the improved progress monitoring for long running tasks as explained above.

Actions #35

Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.25 to Release 5.23
Actions #36

Updated by Katja Luther over 1 year ago

I think the usage of submonitors needs to be adapted, I already did this for cache update, there the submonitor labels are shown correctly:

Actions #37

Updated by Katja Luther over 1 year ago

I tried to adapt the progress monitor handling like for the cache update and the output in editor looks like this:

Should I check it in?

Actions #38

Updated by Andreas Müller over 1 year ago

Katja Luther wrote:

I tried to adapt the progress monitor handling like for the cache update and the output in editor looks like this:

Should I check it in?

upps, I also worked on this already put did not yet push. Can you send the diff to see if we did similar things?

Actions #39

Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.25 to Release 5.23
Actions #40

Updated by Katja Luther over 1 year ago

  • Assignee changed from Katja Luther to Andreas Müller

So the progress monitor handling is fixed, we can close this ticket. A new ticket for user friendly result report and improved update result should be created.

Actions #41

Updated by Andreas Müller over 1 year ago

Actions #42

Updated by Andreas Müller over 1 year ago

  • Related to bug #7577: Set Publish Flag for Subtree Dialog - Further Problems with Progressmonitor added
Actions #43

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
Actions #44

Updated by Andreas Müller over 1 year ago

  • % Done changed from 40 to 80

Created a follow-up ticket #9627 for correct update result handling on editor side

Actions #45

Updated by Andreas Müller over 1 year ago

  • Copied to bug #9627: Handle updated objects correctly in monitored operations in taxeditor added
Actions #46

Updated by Andreas Müller over 1 year ago

  • Copied to task #9628: Improve update result handling for monitored operations added
Actions #47

Updated by Andreas Müller over 1 year ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

Also created a new ticket for better update result handling: #9628

So we can close this ticket now.

Actions

Also available in: Atom PDF